- 04 Apr, 2019 40 commits
-
-
Kangjie Lu authored
devm_regmap_init_i2c may fail and return NULL. The fix returns the error when it fails. Signed-off-by:
Kangjie Lu <kjlu@umn.edu> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Marcelo Schmitt authored
Add an ABI documentation for the ad5933 driver. Signed-off-by:
Marcelo Schmitt <marcelo.schmitt1@gmail.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Marcelo Schmitt authored
Remove the previous comment about direct access via sysfs which would lead one think ad5933 driver has limitations it actually doesn't. Signed-off-by:
Marcelo Schmitt <marcelo.schmitt1@gmail.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Marcelo Schmitt authored
Add SPDX identifier of GPL-2.0 for the ad5933 driver. Signed-off-by:
Marcelo Schmitt <marcelo.schmitt1@gmail.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Marcelo Schmitt authored
Organize includes to list them in lexicographic order. Signed-off-by:
Marcelo Schmitt <marcelo.schmitt1@gmail.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Marcelo Schmitt authored
Make multi-line comments compliant with the preferred code style. Signed-off-by:
Marcelo Schmitt <marcelo.schmitt1@gmail.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Renato Lui Geh authored
Adds a device tree binding for the ad7780 driver. Signed-off-by:
Renato Lui Geh <renatogeh@gmail.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Renato Lui Geh authored
Move ad7780 ADC driver out of staging and into the mainline. The ad7780 is a sigma-delta analog to digital converter. This driver provides reading voltage values and status bits from both the ad778x and ad717x series. Its interface also allows writing on the FILTER and GAIN GPIO pins on the ad778x. Signed-off-by:
Renato Lui Geh <renatogeh@gmail.com> Signed-off-by:
Giuliano Belinassi <giuliano.belinassi@usp.br> Co-developed-by:
Giuliano Belinassi <giuliano.belinassi@usp.br> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Renato Lui Geh authored
This patch adds a new copyright holder to the ad7780 driver. Signed-off-by:
Renato Lui Geh <renatogeh@gmail.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Renato Lui Geh authored
Add SPDX identifier (GPL-2.0) to the AD7780 driver. Signed-off-by:
Renato Lui Geh <renatogeh@gmail.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Renato Lui Geh authored
To maintain consistency between ad7780_probe and ad7780_remove orders, regulator initialization has been moved to after GPIO initializations. Signed-off-by:
Renato Lui Geh <renatogeh@gmail.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Renato Lui Geh authored
The ad7780 supports both the ad778x and ad717x families. Each chip has a corresponding ID. This patch provides a mask for extracting ID values from the status bits and also macros for the correct values for the ad7170, ad7171, ad7780 and ad7781. Signed-off-by:
Renato Lui Geh <renatogeh@gmail.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Renato Lui Geh authored
The AD7780 driver contains status pattern bits designed for checking whether serial transfers have been correctly performed. Pattern macros were previously generated through bit fields. This patch sets good pattern values directly and masks through GENMASK. Signed-off-by:
Renato Lui Geh <renatogeh@gmail.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Renato Lui Geh authored
This patch adds the new feature of reading the filter odr value for ad778x chips. This value is stored in the chip's state struct whenever a read or write call is performed on the chip's driver. This feature requires sharing SAMP_FREQ. Since the ad717x does not have a filter option, the driver only shares the relevant info mask for the ad778x family. Signed-off-by:
Renato Lui Geh <renatogeh@gmail.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Renato Lui Geh authored
This patch adds a new functionality of reading gain values from the ad778x chips. This value is stored in the chip's state struct and is updated whenever a read or write call is performed on the driver. Signed-off-by:
Renato Lui Geh <renatogeh@gmail.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Renato Lui Geh authored
This patch simply adds a missing switch default case in read_raw. Signed-off-by:
Renato Lui Geh <renatogeh@gmail.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Renato Lui Geh authored
Previously, the AD7780 driver only supported gpio for the 'powerdown' pin. This commit adds suppport for the 'gain' and 'filter' pin. Signed-off-by:
Renato Lui Geh <renatogeh@gmail.com> Signed-off-by:
Giuliano Belinassi <giuliano.belinassi@usp.br> Co-developed-by:
Giuliano Belinassi <giuliano.belinassi@usp.br> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Gregory CLEMENT authored
As most of the other ADC the lpc32xx one use a vref-supply property: document it. Reviewed-by:
Rob Herring <robh@kernel.org> Signed-off-by:
Gregory CLEMENT <gregory.clement@bootlin.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Gregory CLEMENT authored
Until now this driver only exposed the raw value of the channels. With this patch, the scale value is also exposed. It depends of a regulator supply, and unlike most of the other driver, do not having this regulator won't prevent to use the driver. The reason for it is to allow to continue to use this driver with an old device tree. If there is no regulator supply then the scale won't be exposed. Signed-off-by:
Gregory CLEMENT <gregory.clement@bootlin.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Gregory CLEMENT authored
A few headers is useless: remove them. Signed-off-by:
Gregory CLEMENT <gregory.clement@bootlin.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Gregory CLEMENT authored
Sort the headers in alphabetic order in order to ease the maintenance for this part. Signed-off-by:
Gregory CLEMENT <gregory.clement@bootlin.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Mircea Caprioru authored
This patch will remove platform data members and replace them with device tree properties. These properties will be subject to further modifications and probably replaced with other functionalities at some point in time. Signed-off-by:
Mircea Caprioru <mircea.caprioru@analog.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Lorenzo Bianconi authored
Signed-off-by:
Lorenzo Bianconi <lorenzo@kernel.org> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Lorenzo Bianconi authored
Add support to STM LSM6DSOX 6-axis (acc + gyro) Mems sensor https://www.st.com/resource/en/datasheet/lsm6dsox.pdfSigned-off-by:
Lorenzo Bianconi <lorenzo@kernel.org> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Mircea Caprioru authored
This patch removes the goto out statement and uninformative print message. This improves readability. Signed-off-by:
Mircea Caprioru <mircea.caprioru@analog.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Mircea Caprioru authored
This patch replaces the platform data clock select member with DT clock binding. Through the DT the external clock binding is specified. If this is not provided then the device will use the internal clock source. With the external clock binding there is the option to use a clock or a crystal as the clock source. When an external crystal is used it is connected to MCLK1 and MCLK2 pins. If the external clock is used only MCLK2 pin will be connected. Signed-off-by:
Mircea Caprioru <mircea.caprioru@analog.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Mircea Caprioru authored
This patch fixes the odd indentation inside function ad7192_calibrate_all. Signed-off-by:
Mircea Caprioru <mircea.caprioru@analog.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Colin Ian King authored
A return statement is indented one level too deeply; clean this up by removing a tab. Signed-off-by:
Colin Ian King <colin.king@canonical.com> Acked-by:
Stefan Popa <stefan.popa@analog.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Enric Balletbo i Serra authored
Adopt the SPDX license identifier headers to ease license compliance management. Also fix MODULE_LICENSE for cros_ec_accel_legacy to match the SPDX and boiler plate license. Signed-off-by:
Enric Balletbo i Serra <enric.balletbo@collabora.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Gwendal Grignou authored
Document cros_ec_sensors_read_lpc, adding an additional note to explain that this is the safe function for reading the EC data. Signed-off-by:
Gwendal Grignou <gwendal@chromium.org> Signed-off-by:
Enric Balletbo i Serra <enric.balletbo@collabora.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Guenter Roeck authored
The cros_ec sensors drivers do not call any sysfs functions or use any sysfs defines, and thus do not need to include linux/sysfs.h. Also, some cros_ec drivers include linux/delay.h and is not used. Signed-off-by:
Guenter Roeck <groeck@chromium.org> [remove linux/delay.h] Signed-off-by:
Enric Balletbo i Serra <enric.balletbo@collabora.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Linus Walleij authored
The BMP280/BME280 calibration data should also go into the entropy pool, like we do for BMP180. This just adds the temperature and pressure calibration, the humidity calibration seems like too much annoying calls to add. Cc: Tomasz Duszynski <tduszyns@gmail.com> Cc: Stefan Tatschner <stefan.tatschner@gmail.com> Cc: Andreas Klinger <ak@it-klinger.de> Signed-off-by:
Linus Walleij <linus.walleij@linaro.org> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Stefan Popa authored
Add documentation for optional use of external clock. All devices supported by this driver can work with an external clock in sync mode. Another mode, called Pulse Per Second (PPS) is supported only by adis1649x devices. The mode is selected by using the "clock-names" property. The pin which is used as external clock input is selected by using a custom optional property called "adi,ext-clk-pin". If this field is left empty, DIO2 is assigned as default external clock input pin. Signed-off-by:
Stefan Popa <stefan.popa@analog.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Stefan Popa authored
Inertial sensor data collection and processing can be controlled by configuring one of the DIOx lines as an external clock input. This option is available for all devices supported by this driver. However, only adis1649x devices support different modes for the external clock. Sync mode is supported by all devices. In this mode, the output data rate is equal with the clock frequency divided by DEC_RATE + 1. This mode of calculation is similar with the case when the internal clock is used. Pulse Per Second (PPS) Mode, is only supported by adis1649x devices. In this mode, the output data rate is equal to the product of the external clock frequency and the scale factor in the SYNC_SCALE register. This patch uses the "clock-names" property to enable the external clock in one of the two supported modes: "sync" or "pps". This property is optional. If it is not specified, the internal clock is used. This patch also offers the option to select the DIOx line to be used as an external clock input via the custom "adi,ext-clk-pin" property. If this field is left empty, DIO2 is assigned as default external clock input pin. Each DIOx pin supports only one function at a time (data ready line selection or external clock input). Signed-off-by:
Stefan Popa <stefan.popa@analog.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Jonathan Cameron authored
indio_dev->mlock is intended to protect state transitions in the core. It's scope is tightly defined. For device specific uses such as those made here, we should define a local lock allowing the scope of the lock to be defined near to what it is protecting. These mlock changes can be non obvious, but given we don't do anything other than direct for DACs, these ones are easy to do. If anyone wants to help with this particular effort it would be most welcome! Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Enrico Weigelt, metux IT consult authored
Formatting of Kconfig files doesn't look so pretty, so just take damp cloth and clean it up. Signed-off-by:
Enrico Weigelt, metux IT consult <info@metux.net> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Nathan Chancellor authored
When building with -Wsometimes-uninitialized, Clang warns: drivers/iio/adc/stmpe-adc.c:204:13: warning: variable 'data' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] Clang can't tell that data will never be used uninitialized because the two if statements take care of all cases. Remove the first if statement and make it the else branch of the second one so that it is apparent to Clang that all cases are covered. Link: https://github.com/ClangBuiltLinux/linux/issues/387Suggested-by:
Nick Desaulniers <ndesaulniers@google.com> Signed-off-by:
Nathan Chancellor <natechancellor@gmail.com> Reviewed-by:
NIck Desaulniers <ndesaulniers@google.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Nathan Chancellor authored
When building with -Wsometimes-uninitialized, Clang warns: drivers/iio/common/ssp_sensors/ssp_iio.c:95:6: warning: variable 'calculated_time' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] While it isn't wrong, this will never be a problem because iio_push_to_buffers_with_timestamp only uses calculated_time on the same condition that it is assigned (when scan_timestamp is not zero). While iio_push_to_buffers_with_timestamp is marked as inline, Clang does inlining in the optimization stage, which happens after the semantic analysis phase (plus inline is merely a hint to the compiler). Fix this by just zero initializing calculated_time. Link: https://github.com/ClangBuiltLinux/linux/issues/394Signed-off-by:
Nathan Chancellor <natechancellor@gmail.com> Reviewed-by:
Nick Desaulniers <ndesaulniers@google.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Sven Van Asbroeck authored
This driver's probe() uses a mix of devm_ and non-devm_ functions. This means that the remove order will not be the exact opposite of the probe order. Remove order: 1. remove() executes: iio_device_unregister iio_triggered_buffer_cleanup iio_trigger_unregister (A) 2. core frees devm resources in reverse order: free_irq iio_trigger_free iio_device_free In (A) the trigger has been unregistered, but the irq handler is still registered and active, so the trigger may still be touched via interrupt -> as3935_event_work. This is a potential use-after-unregister. Given that the delayed work is never canceled explicitly, it may run even after iio_device_free. This is a potential use-after-free. Solution: convert all probe functions to their devm_ equivalents. Add a devm callback, called by the core on remove right after irq_free, which explicitly cancels the delayed work. This will guarantee that all resources are freed in the correct order. As an added bonus, some boilerplate code can be removed. Signed-off-by:
Sven Van Asbroeck <TheSven73@gmail.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-
Anderson Reis authored
Change dev_err message on line 215 in order to inform that tia-gain-ohm is not defined and an external resistor is not specified. Signed-off-by:
Anderson Reis <andersonreisrosa@gmail.com> Signed-off-by:
Lucas Oshiro <lucasseikioshiro@gmail.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com>
-