- 27 Oct, 2022 26 commits
-
-
Fangzhi Zuo authored
[Why] Invalidate unsupported 420 modes on HDMI TMDS. HDMI TMDS does not support ODM. Any modes that are horizontally wider than 4096, cannot be supported via TMDS. So they must be filtered out and should not pass validation. [How] Create fake plane for the new stream, and validate global state by going through dml validation routine. Tested-by:
Mark Broadworth <mark.broadworth@amd.com> Acked-by:
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> Signed-off-by:
Fangzhi Zuo <Jerry.Zuo@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Rodrigo Siqueira authored
The file dc.c has multiple comments that do not follow the kernel-doc or are made in a distracting way. This commit alleviates part of this issue by reorganizing some comments inside the dc file. Signed-off-by:
Hamza Mahfooz <hamza.mahfooz@amd.com> Signed-off-by:
-
Aric Cyr authored
DC version 3.2.209 brings along the following: * Improve color manipulation * Add corrections to DML and some flag configuration * Updates for DCN32x * Expand kernel-doc Tested-by:
Aric Cyr <Aric.Cyr@amd.com> Signed-off-by:
-
Yifan Zhang authored
This patch to fix the gdm3 start failure with virual display: /usr/libexec/gdm-x-session[1711]: (II) AMDGPU(0): Setting screen physical size to 270 x 203 /usr/libexec/gdm-x-session[1711]: (EE) AMDGPU(0): Failed to make import prime FD as pixmap: 22 /usr/libexec/gdm-x-session[1711]: (EE) AMDGPU(0): failed to set mode: Invalid argument /usr/libexec/gdm-x-session[1711]: (WW) AMDGPU(0): Failed to set mode on CRTC 0 /usr/libexec/gdm-x-session[1711]: (EE) AMDGPU(0): Failed to enable any CRTC gnome-shell[1840]: Running GNOME Shell (using mutter 42.2) as a X11 window and compositing manager /usr/libexec/gdm-x-session[1711]: (EE) AMDGPU(0): failed to set mode: Invalid argument vkms doesn't have modifiers support, set fb_modifiers_not_supported to bring the gdm back. Signed-off-by:
Yifan Zhang <yifan1.zhang@amd.com> Acked-by:
Guchun Chen <guchun.chen@amd.com> Reviewed-by:
Tim Huang <Tim.Huang@amd.com> Signed-off-by:
-
Rodrigo Siqueira authored
Add basic kernel-doc that describes some of the struct and functions that are part of the DC commit sequence.. Tested-by:
Aurabindo Pillai <Aurabindo.Pillai@amd.com> Acked-by:
-
Rodrigo Siqueira authored
Add kernel-doc to some important elements from DC struct that might help to understand DC sequence. Tested-by:
-
Rodrigo Siqueira authored
Add kernel-doc to some of the ODM-related functions. Tested-by:
-
Rodrigo Siqueira authored
Add a kernel-doc to the DE-Tile function hook. Tested-by:
-
Rodrigo Siqueira authored
This commit adds extra documentation for elements related to FAMs. Tested-by:
-
Ma Hanghong authored
[Why] For FreeSync HDR, native color space flag in AMD VSIF(BT.709) should be used when intepreting content and color space flag in VSC or AVI infoFrame should be ignored. However, it turned out some userspace application still use color flag in VSC or AVI infoFrame which is incorrect. [How] Transfer function is used when building the VSC and AVI infoFrame. Set colorimetry to BT.709 when all the following match: 1. Pixel format is YCbCr; 2. In FreeSync 2 HDR, color is COLOR_SPACE_2020_YCBCR; 3. Transfer function is TRANSFER_FUNC_GAMMA_22; Tested-by:
Krunoslav Kovac <Krunoslav.Kovac@amd.com> Acked-by:
Ma Hanghong <hanghong.ma@amd.com> Signed-off-by:
-
zhikzhai authored
[WHY] Now dynamic ODM will now be disabled when MPO is required safe transitions to avoid underflow, but we are triggering the way of minimal transition too often. Commit state of dc with no check will do pipeline setup which may re-initialize the component with no need such as audio. [HOW] Just do the minimal transition when all of pipes are in use, otherwise return true to skip. Tested-by:
Dillon Varone <Dillon.Varone@amd.com> Acked-by:
zhikzhai <zhikai.zhai@amd.com> Signed-off-by:
-
Haiyi Zhou authored
[WHY] Skipping vblank during global sync update request can result in underflow on certain displays. [HOW] Roll back to the previous behavior where DC waits for vblank during pipe programming. Fixes: 5d3e1442 ("drm/amd/display: do not wait for vblank during pipe programming") Tested-by:
Martin Leung <Martin.Leung@amd.com> Acked-by:
Haiyi Zhou <Haiyi.Zhou@amd.com> Signed-off-by:
-
Aric Cyr authored
Apply SDR visual confirm to RGB10 and FP16 formats as well when needed. Tested-by:
Jun Lei <Jun.Lei@amd.com> Acked-by:
-
Max Tseng authored
Missing send cursor_rect width & Height into DMUB. PSR-SU would use these information. But missing these assignment in last refactor commit Tested-by:
Anthony Koo <Anthony.Koo@amd.com> Acked-by:
Max Tseng <max.tseng@amd.com> Signed-off-by:
-
Alvin Lee authored
Missed enabling timing sync on DCN32 because DCN32 has a different DML param. Tested-by:
Alvin Lee <Alvin.Lee2@amd.com> Signed-off-by:
-
Bhawanpreet Lakha authored
[Why] On some linux based OS, the hotplug->HDCP start takes longer than 4seconds (by ~100ms) This is due to the HDCP delay (3 sec) so we only have 1 second to hotplug->stream enablement, which is not enough for certain OS configs. [How] Change the Delay to 0 seconds. From testing it seems like 0 Seconds can pass 1.x and 2.x compliances Tested-by:
Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com> Signed-off-by:
-
Alvin Lee authored
Optimization caused unexpected regression, so remove for now. Tested-by:
-
Dillon Varone authored
[Why] Cannot report 0 memclk levels even when SMU does not provide any. [How] When memclk levels reported by SMU is 0, set levels to 1. Tested-by:
-
Dillon Varone authored
Update DF related latencies based on new measurements. Tested-by:
-
Aric Cyr authored
DC version 3.2.208 brings along the following: * Add more kernel doc * Enable secure display on DCN21 * Limit dcn32 to 1950Mhz display clock * PSR code refactor * Rework audio stream sequence * Generic bug fixes Tested-by:
-
Anthony Koo authored
Add a simple documentation in the dmub_cmd. Tested-by:
-
Jun Lei authored
[why] Hardware team recommends we limit dispclock to 1950Mhz for all DCN3.2.x [how] Limit to 1950 when initializing clocks. Tested-by:
-
Alan Liu authored
[Why] reuse struct rect rather than adding a new struct. [How] - Userspace keeps inputting x_start, y_start, x_end, y_end - We translate data to x, y, width, height in code flow to store - translate back to x_start, y_start, x_end, y_end before programming HW Tested-by:
Wayne Lin <Wayne.Lin@amd.com> Acked-by:
Alan Liu <HaoPing.Liu@amd.com> Signed-off-by:
-
Alan Liu authored
[Why] Porting secure display feature from DCN10 to DCN21. Support single display for now and will extend to multiple displays. [How] - use workqueue to offload works for dmub or dmcu firmware - after receiving ROI update from userspace, set skip_frame_cnt to 1 - refactor amdgpu_dm_crtc_handle_crc_window_irq() - disable PSR before activating secure_display on a crtc - check if secure_display is activated before enabling psr - only work for single display for now. Tested-by:
-
Fangzhi Zuo authored
Ignore cable ID for DP2 receivers that does not support the feature. Tested-by:
Roman Li <Roman.Li@amd.com> Acked-by:
-
Leo Chen authored
dcn314 has 4 DSC - conflicted hardware document updated and confirmed. Tested-by:
Charlene Liu <Charlene.Liu@amd.com> Acked-by:
Leo Chen <sancchen@amd.com> Signed-off-by:
-
- 24 Oct, 2022 14 commits
-
-
Joaquín Ignacio Aramendía authored
This file was split in commit 5d945cbc ("drm/amd/display: Create a file dedicated to planes") and the logic in dm_plane_format_mod_supported() function got changed by a switch logic. That change broke drm_plane modifiers setting on series 5000 APUs (tested on OXP mini AMD 5800U and HP Dev One 5850U PRO) leading to Gamescope not working as reported on GitHub[1] To reproduce the issue, enter a TTY and run: $ gamescope -- vkcube With said commit applied it will abort. This one restores the old logic, fixing the issue that affects Gamescope. [1](https://github.com/Plagman/gamescope/issues/624) Cc: <stable@vger.kernel.org> # 6.0.x Signed-off-by:
Joaquín Ignacio Aramendía <samsagax@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Signed-off-by:
-
wangjianli authored
Delete the redundant word 'the'. Signed-off-by:
wangjianli <wangjianli@cdjrlc.com> Signed-off-by:
-
wangjianli authored
Delete the redundant word 'the'. Signed-off-by:
-
Lewis Huang authored
[Why] Read set_power_state dpcd after HPD cause USB4 CTS 4.2.1.1 [How] Read LTTPR caps first. If aux channel not ready, wake up aux channel. If wake up aux channel return pass, retrieve lttpr caps again. If wake up aux channel return false, register a detection retry timer. Tested-by:
Wenjing Liu <Wenjing.Liu@amd.com> Acked-by:
Lewis Huang <Lewis.Huang@amd.com> Signed-off-by:
-
Rodrigo Siqueira authored
As an attempt to offer more DCN debug tools for cases where the OPTC can hang, this commit introduces a trace event responsible for showing OPTC status when it requests lock and unlock. Tested-by:
-
Rodrigo Siqueira authored
The dc_dmub_srv file has a lot of documentation associated with SubVP that could be converted to a kernel-doc. This commit just changes the comment style to a kernel-doc. Tested-by:
-
Ian Chen authored
We split out PSR config from "global" to "per-panel" config settings. Tested-by:
Robin Chen <robin.chen@amd.com> Acked-by:
Ian Chen <ian.chen@amd.com> Signed-off-by:
-
Dmytro Laktyushkin authored
Fix incorrect pstate read order as well as min and max state logic. Tested-by:
Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com> Signed-off-by:
-
Wenjing Liu authored
VPG doesn't have the ability to mute audio output by sending all 0s in audio SDP. The existing implemention is disabling audio SDP instead. This is same as what dp_audio_enable does. Since it is no longer referenced by any callers, we decided to remove this interface for simplicity. Tested-by:
-
Wenjing Liu authored
Unify stream encoder audio setup interface. Tested-by:
-
Wenjing Liu authored
[why] 1. As recommended by hardware team, don't enable APG when stream is not enabled. 2. Move audio stream encoder programming into link_hwss. [how] 1. Merge dp_audio_enable into enable audio stream hw sequence. 2. Move stream encoder programming into link hwss level to unify stream encoder programming interface. Tested-by:
-
Rodrigo Siqueira authored
As part of the programming expectation for using DML functions, DC requires that any DML function invoked outside DML uses: DC_FP_START(); ... dml function ... DC_FP_END(); Additionally, all the DML functions that can be invoked outside the DML folder call the function dc_assert_fp_enabled(), which is responsible for triggering a warning in the case that the DML function was not guarded by the DC_FP_START/END. For this reason, call DC_FP_START/END inside DML is wrong, and this commit removes all of those references. Tested-by:
Nevenko Stupar <Nevenko.Stupar@amd.com> Reviewed-by:
-
Fangzhi Zuo authored
Add support to manually force link rate to UHBR135 (0x546) and UHBR20 (0x7d0). Tested-by:
-
Prike Liang authored
In the S2idle suspend/resume phase the gfxoff is keeping functional so some IP blocks will be likely to reinitialize at gfxoff entry and that will result in failing to program GC registers.Therefore, let disallow gfxoff until AMDGPU IPs reinitialized completely. Signed-off-by:
Prike Liang <Prike.Liang@amd.com> Acked-by:
-
