- 07 Mar, 2014 40 commits
-
-
Himangi Saraogi authored
This patch fixes the following Sparse warnings : drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:27:4: warning: symbol 'rsn_authen_cipher_suite' was not declared. Should it be static? drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:352:6: warning: symbol 'ext_ieee80211_send_beacon_wq' was not declared. Should it be static? Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Himangi Saraogi authored
This patch fixes sparse warnings like : (1) drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:331:31: warning: incorrect type in assignment (different base types) drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:331:31: expected unsigned short [unsigned] [usertype] frame_ctl drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:331:31: got restricted __le16 [usertype] <noident> (2) drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:1091:32: warning: incorrect type in assignment (different base types) drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:1091:32: expected restricted __le16 [usertype] duration_id drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:1091:32: got int Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Keerthimai Janarthanan authored
Unnecessary space between function pointer name. Signed-off-by: Keerthimai Janarthanan <keerthimaipb@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
This patch fixes the following sparse warning in rts51x.c drivers/staging/rts5139/rts51x.c:218:5: warning: symbol 'rts51x_pre_reset' was not declared. Should it be static? drivers/staging/rts5139/rts51x.c:229:5: warning: symbol 'rts51x_post_reset' was not declared. Should it be static? Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
This patch fixes the following Sparse warnings : formatter_inquiry_str should be static queuecommand_lck should be static Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Georgiana Rodica Chelu authored
This patch fixes the quoted string split across lines in staging/rts5139/ms.c Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Georgiana Rodica Chelu authored
Remove unnecessary parentheses from staging/rts5208/rtsx_scsi.c Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
This patch fixes following sparse warning in rts51x_fop.c Warning: incorrect type in assignment Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Himangi Saraogi authored
This patch fixes the following sparse warning : drivers/staging/serqt_usb2/serqt_usb2.c:727:40: warning: restricted __le16 degrades to integer Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Cc: stable <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Himangi Saraogi authored
This patch moves shared private data kzalloc to managed devm_kzalloc. There are no kfree statements associated with this data, so using devm adds the possibility of the data being freed, if the proble function fails (if that is possible) or if the remove function succeeds. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ebru Akagunduz authored
Fix checkpatch.pl issues with quoted string split across lines in nvec.c Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
This patch fixes following sparse warning in crystalhd_lnx.c WARNING: incorrect type in argument Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
This patch fixes following sparse warning in crystalhd_misc.c WARNING: incorrect type in argument Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ebru Akagunduz authored
Fix checkpatch.pl issues with "foo * bar" should be "foo *bar" in dgap.h Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ebru Akagunduz authored
Fix checkpatch.pl issues with open brace '{' following struct go on the same line in dgap.h Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ebru Akagunduz authored
This patch fixes the Sparse Warnings "symbol was not declared. Should it be static?" Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
This patch fixes following sparse warnings: drivers/staging/wlags49_h2/wl_wext.c:3357:28: warning: incorrect type in assignment (different address spaces) drivers/staging/wlags49_h2/wl_wext.c:3357:28: expected void [noderef] <asn:1>*[addressable] [assigned] pointer drivers/staging/wlags49_h2/wl_wext.c:3357:28: got void *<noident> drivers/staging/wlags49_h2/wl_wext.c:3422:47: warning: incorrect type in assignment (different address spaces) drivers/staging/wlags49_h2/wl_wext.c:3422:47: expected void [noderef] <asn:1>*[addressable] [assigned] pointer drivers/staging/wlags49_h2/wl_wext.c:3422:47: got char *[usertype] <noident> drivers/staging/wlags49_h2/wl_wext.c:3781:21: warning: symbol 'wl_priv_args' was not declared. Should it be static? Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
This patch fixes the following sparse warnings: drivers/staging/wlags49_h2/dhf.c:109:6: warning: symbol 'signature' was not declared. Should it be static? drivers/staging/wlags49_h2/dhf.c:126:25: warning: symbol 'mfi_sup' was not declared. Should it be static? drivers/staging/wlags49_h2/dhf.c:127:25: warning: symbol 'cfi_sup' was not declared. Should it be static? drivers/staging/wlags49_h2/dhf.c:142:17: warning: symbol 'ltv_info' was not declared. Should it be static? drivers/staging/wlags49_h2/dhf.c:173:1: warning: symbol 'check_comp_fw' was not declared. Should it be static? Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
This patch fixes following sparse warnings: drivers/staging/wlags49_h2/hcf.c:253:26: warning: symbol 'cfg_drv_identity' was not declared. Should it be static? drivers/staging/wlags49_h2/hcf.c:262:24: warning: symbol 'cfg_drv_sup_range' was not declared. Should it be static? drivers/staging/wlags49_h2/hcf.c:274:31: warning: symbol 'cfg_drv_act_ranges_pri' was not declared. Should it be static? drivers/staging/wlags49_h2/hcf.c:291:31: warning: symbol 'cfg_drv_act_ranges_sta' was not declared. Should it be static? drivers/staging/wlags49_h2/hcf.c:336:31: warning: symbol 'cfg_drv_act_ranges_hsi' was not declared. Should it be static? drivers/staging/wlags49_h2/hcf.c:373:24: warning: symbol 'cfg_drv_act_ranges_apf' was not declared. Should it be static? drivers/staging/wlags49_h2/hcf.c:3103:1: warning: symbol 'calc_mic' was not declared. Should it be static? drivers/staging/wlags49_h2/hcf.c:3419:1: warning: symbol 'check_mic' was not declared. Should it be static? Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
This patch removes the unused function "percent" from wl_util.c Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Himangi Saraogi authored
This patch fixes the checkpatch warnings: WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Himangi Saraogi authored
This patch fixes the following checkpatch errors: ERROR: space prohibited after that open parenthesis '(' ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Himangi Saraogi authored
This patch fixes the following warnings: WARNING: that open brace { should be on the previous line WARNING: suspect code indent for conditional statements (16, 16) Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Himangi Saraogi authored
This patch fixes the following issue detected by checkpatch.pl. WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h> Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Himangi Saraogi authored
Coding style requires that comments use the standard /* */ style instead of C99 style. The commented #include statements were also removed as they are not required. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
This patch fixes sparse warnings "Using plain integer as NULL pointer" in sta_h2.c Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
Staging: iio/accel: Fix Prefer netdev_warn(netdev, ...then dev_warn(dev, ... then pr_warn(... to printk(KERN_INFO ... in sca3000_ring.c This patch fixes the following checkpatch.pl warning in sca3000_ring.c WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
This patch fixes following checkpatch.pl warning WARNING: Prefer pr_warn(... to pr_warning(... Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning of "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)" in file rtw_cmd.c. Pahole shows that the addresses are 2-byte aligned. Signed-off-by: Elena Oat <oat.elena@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning of "suspect code indent for conditional statements" in file rtw_cmd.c. I have removed the conditional statements in two places altogether, as it didn't bring any value. Signed-off-by: Elena Oat <oat.elena@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning of "space prohibited before semicolon" in file rtw_cmd.c. Signed-off-by: Elena Oat <oat.elena@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning of "unnecessary parentheses" in file rtw_cmd.c. Signed-off-by: Elena Oat <oat.elena@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning of "please, no space before tabs" in file rtw_cmd.c. I have also removed couple of lines of code that was commented and probably left from the previous version. Signed-off-by: Elena Oat <oat.elena@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning of "please, no spaces at the start of a line" in file rtw_cmd.c. Signed-off-by: Elena Oat <oat.elena@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning of "braces {} are not necessary for single statement blocks" in file rtw_cmd.c. Signed-off-by: Elena Oat <oat.elena@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
This patch fixes the following sparse warnings: drivers/staging/rtl8188eu/core/rtw_wlan_util.c:1627:25: warning: cast to restricted __le16 by changing the annotations in the struct declaration. Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning produced by checkpatch of "printk should include KERN_ facility level". printk was replaced by netdev_info. While at it, I have also fixed the line over 80 characters warning. Signed-off-by: Elena Oat <oat.elena@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning produced by checkpatch "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)". The address that is copied is a field of nat25_network_db_entry structure. Definition for this struct is found in rtw_br_ext.h file. Pahole shows that the addresses are 2-byte aligned. Signed-off-by: Elena Oat <oat.elena@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning of "braces {} are not necessary for any arm of this statement" in file rtw_ioctl_set.c. The braces are removed in three places. Signed-off-by: Elena Oat <oat.elena@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ebru Akagunduz authored
Fix checkpatch.pl issues with kfree(NULL) is safe this check is probably not required in rtw_ap.c Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-