- 03 Sep, 2014 40 commits
-
-
Mauro Carvalho Chehab authored
Instead of allocating a var to store 0 and just return it, change the code to return 0 directly. Signed-off-by:Mauro Carvalho Chehab <m.chehab@samsung.com>
-
Mauro Carvalho Chehab authored
Instead of allocating a var to store 0 and just return it, change the code to return 0 directly. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of allocating a var to store 0 and just return it, change the code to return 0 directly. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of allocating a var to store 0 and just return it, change the code to return 0 directly. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of allocating a var to store 0 and just return it, change the code to return 0 directly. Signed-off-by: -
Mauro Carvalho Chehab authored
Make sure pm_runtime_* calls does not use unnecessary IS_ERR_VALUE(). Reported by scripts/coccinelle/api/pm_runtime.cocci script. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using if (foo == false), just use if (!foo). That allows a faster mental parsing when analyzing the code. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using if (foo == false), just use if (!foo). That allows a faster mental parsing when analyzing the code. Signed-off-by: -
Mauro Carvalho Chehab authored
instead of testing bools if they are false or true, just use if (!foo) or if (foo). That makes the code easier to read and shorter. Also, properly initialize booleans with true or false. Signed-off-by: -
Mauro Carvalho Chehab authored
lml33dpatch is boolean. So, the possible values are true or false. Instead of using if (lml33dpath), just use if (!lml33dpath). That allows a faster mental parsing when analyzing the code. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using if (on == true), just use if (on). That allows a faster mental parsing when analyzing the code. Signed-off-by: -
Mauro Carvalho Chehab authored
instead of testing if it is false or true, just use if (!foo) or if (foo). That makes the code easier to read and shorter. Also, properly initialize booleans with true or false. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using if (foo == false), just use if (!foo). That allows a faster mental parsing when analyzing the code. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using 0 or 1 for boolean, use the true/false defines. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using 0 or 1 for boolean, use the true/false defines. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using 0 or 1 for boolean, use the true/false defines. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using 0 or 1 for boolean, use the true/false defines. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using 0 or 1 for boolean, use the true/false defines. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using 0 or 1 for boolean, use the true/false defines. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using 0 or 1 for boolean, use the true/false defines. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using 0 or 1 for boolean, use the true/false defines. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using 0 or 1 for boolean, use the true/false defines. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using 0 or 1 for boolean, use the true/false defines. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using 0 or 1 for boolean, use the true/false defines. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using 0 or 1 for boolean, use the true/false defines. Also, instead of testing foo == false, just use the simplified notation if(!foo). Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using 0 or 1 for boolean, use the true/false defines. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using 0 or 1 for boolean, use the true/false defines. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using 0 or 1 for boolean, use the true/false defines. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using 0 or 1 for boolean, use the true/false defines. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using 0 or 1 for boolean, use the true/false defines. Signed-off-by: -
Mauro Carvalho Chehab authored
The error return code STV0900_NO_ERROR happens only once, at the end of the functions. So, just return it directly. This driver should actually be fixed to return standard Linux error codes, instead of its own macros, but this should be done on a separate patchset. Signed-off-by: -
Mauro Carvalho Chehab authored
We don't use semicolons after curly braces in the middle of the code. Signed-off-by: -
Mauro Carvalho Chehab authored
We don't use semicolons after curly braces in the middle of the code. Signed-off-by: -
Mauro Carvalho Chehab authored
We don't use semicolons after curly braces in the middle of the code. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of allocating and coping from __user, do it using one atomic call. That makes the code simpler. Found by coccinelle. Acked-by:
Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
Instead of calling kzalloc and then copying, use kmemdup(). That avoids zeroing the data structure before copying. Found by coccinelle. Acked-by:
Guennadi Liakhovetski <g.liakhovetski@gmx.de> Signed-off-by:
-
Mauro Carvalho Chehab authored
alloc_bufs_at_read is static. No need to initialize with zero, as the Kernel will cleanup the data memory already. Signed-off-by: -
Mauro Carvalho Chehab authored
As reported by smatch: drivers/media/dvb-core/dmxdev.c:1091 dvb_demux_poll() warn: variable dereferenced before check 'dmxdevfilter' (see line 1088) This was introduced by changeset d102cac8. We need to test before using it. Signed-off-by:
-
Hans Verkuil authored
drivers/media/tuners/mt2063.c:1238:56: warning: cast truncates bits from constant value (ffffff0f becomes f) drivers/media/tuners/mt2063.c:1313:62: warning: cast truncates bits from constant value (ffffff7f becomes 7f) drivers/media/tuners/mt2063.c:1321:62: warning: cast truncates bits from constant value (ffffff7f becomes 7f) Cast to u8 is unnecessary. Signed-off-by:
-
Hans Verkuil authored
A lot of these warnings are caused by the fact that we don't generally use __user in videodev2.h. Normally the video_usercopy function will copy anything pointed to by pointers into kernel space, so having __user in the struct will only cause lots of warnings in the drivers. But the flip side of that is that you need to add __force casts here. drivers/media/v4l2-core/v4l2-compat-ioctl32.c:337:26: warning: incorrect type in argument 1 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:337:30: warning: incorrect type in argument 2 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:338:31: warning: incorrect type in argument 1 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:338:49: warning: incorrect type in argument 2 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:343:21: warning: incorrect type in argument 1 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:346:21: warning: incorrect type in argument 1 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:349:35: warning: incorrect type in argument 1 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:349:46: warning: incorrect type in argument 2 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:352:35: warning: incorrect type in argument 1 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:352:54: warning: incorrect type in argument 2 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:363:26: warning: incorrect type in argument 1 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:363:32: warning: incorrect type in argument 2 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:364:31: warning: incorrect type in argument 1 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:364:51: warning: incorrect type in argument 2 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:371:35: warning: incorrect type in argument 1 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:371:56: warning: incorrect type in argument 2 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:376:35: warning: incorrect type in argument 1 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:376:48: warning: incorrect type in argument 2 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:430:30: warning: incorrect type in assignment (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:433:48: warning: incorrect type in argument 1 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:433:56: warning: incorrect type in argument 2 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:501:24: warning: incorrect type in assignment (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:507:48: warning: incorrect type in argument 1 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:507:56: warning: incorrect type in argument 2 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:565:18: warning: incorrect type in assignment (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:670:22: warning: incorrect type in assignment (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:680:29: warning: incorrect type in assignment (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:692:55: warning: incorrect type in initializer (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:773:18: warning: incorrect type in assignment (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:786:30: warning: incorrect type in argument 1 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:786:44: warning: incorrect type in argument 2 (different address spaces) drivers/media/v4l2-core/v4l2-compat-ioctl32.c:674:37: warning: dereference of noderef expression drivers/media/v4l2-core/v4l2-compat-ioctl32.c:718:37: warning: dereference of noderef expression Signed-off-by:
-
