Commits · 5e329145148d7e9fe5a07ecfc08682ef7334a4d1 · Kirill Smelkov / linux

06 Jan, 2024 1 commit
- bcachefs: Check journal entries for invalid keys in trans commit path · 5e329145
  Kent Overstreet authored Dec 21, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
  5e329145
01 Jan, 2024 39 commits

bcachefs: check_directory_structure() can now be run online · c98d132e

Kent Overstreet authored Dec 10, 2023

Now that we have dynamically resizable btree paths,
check_directory_structure() can check one path - inode up to the root -
in a single transaction.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

c98d132e

bcachefs: Fix reattach_inode() for snapshots · d296e7b1

Kent Overstreet authored Dec 15, 2023

reattach_inode() was broken w.r.t. snapshots - we'd lookup the subvolume
to look up lost+found, but if we're in an interior node snapshot that
didn't make any sense.

Instead, this adds a dirent path for creating in a specific snapshot,
skipping the subvolume; and we also make sure to create lost+found in
the root snapshot, to avoid conflicts with lost+found being created in
overlapping snapshots.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

d296e7b1

bcachefs: bch2_btree_trans_peek_slot_updates · c558c577

Kent Overstreet authored Dec 17, 2023

refactoring the BTREE_ITER_WITH_UPDATES code, prep for removing the flag
and making it always-on
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

c558c577

bcachefs: bch2_btree_trans_peek_prev_updates · 359e89ad

Kent Overstreet authored Dec 17, 2023

bch2_btree_iter_peek_prev() now supports BTREE_ITER_WITH_UPDATES
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

359e89ad

bcachefs: bch2_btree_trans_peek_updates · eb686359

Kent Overstreet authored Dec 17, 2023

refactoring the BTREE_ITER_WITH_UPDATES code, prep for removing the flag
and making it always-on
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

eb686359

bcachefs: growable btree_paths · 0c99e17d

Kent Overstreet authored Dec 10, 2023

XXX: we're allocating memory with btree locks held - bad

We need to plumb through an error path so we can do
allocate_dropping_locks() - but we're merging this now because it fixes
a transaction path overflow caused by indirect extent fragmentation, and
the resize path is rare.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

0c99e17d

bcachefs: Fix interior update path btree_path uses · ff70ad2c

Kent Overstreet authored Dec 15, 2023

Since the btree_paths array is now about to become growable, we have to
be careful not to refer to paths by pointer across contexts where they
may be reallocated.

This fixes the remaining btree_interior_update() paths - split and
merge.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

ff70ad2c

bcachefs: trans->nr_paths · 2c3b0fc3

Kent Overstreet authored Dec 10, 2023

Start to plumb through dynamically growable btree_paths; this patch
replaces most BTREE_ITER_MAX references with trans->nr_paths.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

2c3b0fc3

bcachefs: trans->updates will also be resizable · 5cc6daf7

Kent Overstreet authored Dec 12, 2023

the reflink triggers are also bumping up against the maximum number of
paths in a transaction - and generating proportional numbers of updates.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

5cc6daf7

bcachefs: optimize __bch2_trans_get(), kill DEBUG_TRANSACTIONS · 31403dca

Kent Overstreet authored Dec 11, 2023

 - Some tweaks to greatly reduce locking overhead for the list of btree
   transactions, so that it can always be enabled: leave btree_trans
   objects on the list when they're on the percpu single item freelist,
   and only check for duplicates in the same process when
   CONFIG_BCACHEFS_DEBUG is enabled

 - don't zero out the full btree_trans() unless we allocated it from
   the mempool
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

31403dca

bcachefs: rcu protect trans->paths · fea153a8

Kent Overstreet authored Dec 12, 2023

Upcoming patches are going to be changing trans->paths to a
reallocatable buffer. We need to guard against use after free when it's
used by other threads; this introduces RCU protection to those paths and
changes them to check for trans->paths == NULL
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

fea153a8

bcachefs: Clean up btree_trans · 6474b706
Kent Overstreet authored Dec 11, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
6474b706
bcachefs: kill btree_path.idx · 398c9834
Kent Overstreet authored Dec 11, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
398c9834
bcachefs: get_unlocked_mut_path() -> btree_path_idx_t · d7e14035
Kent Overstreet authored Dec 11, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
d7e14035
bcachefs: bch2_btree_iter_peek_prev() no longer uses path->idx · 542e6396
Kent Overstreet authored Dec 11, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
542e6396
bcachefs: bch2_path_get() no longer uses path->idx · 566eabd3
Kent Overstreet authored Dec 11, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
566eabd3
bcachefs: trans_for_each_path_with_node() no longer uses path->idx · b0b67378
Kent Overstreet authored Dec 10, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
b0b67378

bcachefs: trans_for_each_path() no longer uses path->idx · ccb7b08f

Kent Overstreet authored Dec 10, 2023

path->idx is now a code smell: we should be using path_idx_t, since it's
stable across btree path reallocation.

This is also a bit faster, using the same loop counter vs. fetching
path->idx from each path we iterate over.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

ccb7b08f

bcachefs: kill trans_for_each_path_from() · 4c5289e6
Kent Overstreet authored Dec 10, 2023
```
dead code
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
4c5289e6
bcachefs: bch2_btree_path_to_text() -> btree_path_idx_t · 311e446a
Kent Overstreet authored Dec 10, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
311e446a
bcachefs: struct trans_for_each_path_inorder_iter · 1f75ba4e
Kent Overstreet authored Dec 10, 2023
```
reducing our usage of path->idx
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
1f75ba4e
bcachefs: btree_insert_entry -> btree_path_idx_t · 7f9821a7
Kent Overstreet authored Dec 10, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
7f9821a7
bcachefs: btree_iter -> btree_path_idx_t · 07f383c7
Kent Overstreet authored Dec 04, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
07f383c7
bcachefs: btree_path_alloc() -> btree_path_idx_t · 788cc25d
Kent Overstreet authored Dec 08, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
788cc25d
bcachefs: bch2_btree_path_traverse() -> btree_path_idx_t · 96ed47d1
Kent Overstreet authored Dec 08, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
96ed47d1
bcachefs: bch2_btree_path_make_mut() -> btree_path_idx_t · f6363aca
Kent Overstreet authored Dec 08, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
f6363aca
bcachefs: bch2_btree_path_set_pos() -> btree_path_idx_t · 4617d946
Kent Overstreet authored Dec 08, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
4617d946
bcachefs; bch2_path_put() -> btree_path_idx_t · 74e600c1
Kent Overstreet authored Dec 10, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
74e600c1
bcachefs: bch2_path_get() -> btree_path_idx_t · 255ebbbf
Kent Overstreet authored Dec 08, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
255ebbbf
bcachefs: minor bch2_btree_path_set_pos() optimization · 5ce8b92d
Kent Overstreet authored Dec 08, 2023
```
bpos_eq() is cheaper than bpos_cmp()
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
5ce8b92d
bcachefs: Kill GFP_NOFAIL usage in readahead path · 4753bdeb
Kent Overstreet authored Dec 20, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
4753bdeb

bcachefs: Convert split_devs() to darray · 806ebf2a

Kent Overstreet authored Dec 22, 2023

Bit of cleanup & modernization: also moving this code to util.c, it'll
be used by userspace as well.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

806ebf2a

bcachefs: skip journal more often in key cache reclaim · 0c0ba8e9
Kent Overstreet authored Dec 19, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
0c0ba8e9
bcachefs: for_each_keylist_key() declares loop iter · 1a2a9f9f
Kent Overstreet authored Dec 21, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
1a2a9f9f
bcachefs: bkey_for_each_ptr() now declares loop iter · 0beebd92
Kent Overstreet authored Dec 21, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
0beebd92
bcachefs: kill __bch2_btree_iter_peek_upto_and_restart() · 0bc64d7e
Kent Overstreet authored Dec 17, 2023
```
dead code
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
0bc64d7e
bcachefs: fsck -> bch2_trans_run() · 4eb3877e
Kent Overstreet authored Dec 17, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
4eb3877e
bcachefs: vstruct_for_each() now declares loop iter · cea07a7b
Kent Overstreet authored Dec 17, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
cea07a7b
bcachefs: for_each_member_device_rcu() now declares loop iter · 41b84fb4
Kent Overstreet authored Dec 17, 2023
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
41b84fb4