- 07 Jan, 2013 40 commits
-
-
Ian Abbott authored
Initialize the special interrupt subdevice as a digital input subdevice even if the interrupt handler cannot be registered. It's `insn_bits` handler will still read the interrupt status register. This hardware status bits in this register might be valid even if they haven't been enabled in the interrupt control register, but this needs to be checked. In any case, initializing the subdevice as a digital input subdevice is harmless. Signed-off-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ian Abbott authored
When setting up asynchronous commands for the special interrupt subdevice, use the channel list to decide which interrupt sources to enable. Set the maximum length of the channel list to be the same as the number of channels (2). Normally, the channel list would include channel 0, channel 1 or both. When reading the scan data in the interrupt routine, the readings from each channel in the channel list will be packed into a single unsigned short data value. Make each bit in this value correspond to an index in the channel list. Since all the channels in the channel list are read at the same time, insist that the scan end argument is the length of the channel list and that the conversion source is `TRIG_NOW`. Allocate some private data for the special interrupt subdevice to hold a spin-lock, the channels to be enabled and an indication of whether the command is still active. Stop the command if a buffer overflow occurs. Signed-off-by:
-
Ian Abbott authored
The interrupt handler disables all interrupt sources when a valid interrupt occurs. Just disable the triggered interrupt source so we can still get interrupts for the other interrupt source. Also add a comment indicating why the triggered interrupt source is disabled. The interrupt sources are level-sensitive and indicate hardware errors that are likely to be persistent, so if we reenabled them they would just keep triggering repeatedly. Signed-off-by:
-
Ian Abbott authored
The `insn_bits` handler for the special digital input subdevice used for interrupts currently uses `s->state` for the data value, which is set to the value of the APCI2032_INT_STATUS_REG register when a valid interrupt occurs. Just read the live register contents in the `insn_bits` handler instead of relying on the interrupt service routine to read it for us. The register contains a couple of hardware error status bits. They might also be valid even when the corresponding bits have not been enabled in the APCI_INT_CTRL_REG register in which case this would be useful for checking for hardware errors without using interrupts, but this needs to be checked. Signed-off-by:
-
Ian Abbott authored
If the call to `comedi_buf_put()` fails in the interrupt routine, set the `COMEDI_CB_OVERFLOW` event flag. Note that the `COMEDI_CB_ERROR` flag will have also been set by `comedi_buf_put()` in this case. Signed-off-by:
-
Ian Abbott authored
The subdevice type and flags are initialized incorrectly for the interrupt subdevice - the SDF_CMD_READ value belongs in the subdevice flags. Fix it. Also set the number of channels to 2 since there are 2 interrupt sources each with its own status bit. Signed-off-by:
-
Ian Abbott authored
Put the hardware into a safe state before enabling the interrupt. In the interrupt routine, check the device has been fully configured by checking `dev->attached`. In particular, `dev->read_subdev` could be NULL early on and although the hardware's status register should indicate no interrupt has occurred (since it's been put into a safe state), it's better not to rely on it. Signed-off-by:
-
Samuel Thibault authored
Turn static some symbols which do not actually need to be externally-visible Signed-off-by:
Samuel Thibault <samuel.thibault@ens-lyon.org> Signed-off-by:
-
Samuel Thibault authored
This prefixes all externally-visible symbols of speakup with "spk_". Signed-off-by:
-
Mark Einon authored
Use register name defines instead of magic numbers where a bit of clarity would be useful. Also a small typo fix and some register prefixes added, for further clarity. Signed-off-by:
Mark Einon <mark.einon@gmail.com> Signed-off-by:
-
Mark Einon authored
Several magic numbers were used to represent rxdma csr register bitmasks. Replace them with descriptive defines. Signed-off-by:
-
Cong Ding authored
we should check the return value of calling function fir16_create(): a NULL value means the memory allocation fails. this patch also cleans up the error handling in function function oslec_create() Signed-off-by:
Cong Ding <dinggnu@gmail.com> Signed-off-by:
-
Cyril Roelandt authored
In uf_send_pkt_to_encrypt(), the memory area zeroed by this call to memset() is overwritten by a call to memcpy() a few instructions later, so it is not needed. Signed-off-by:
Cyril Roelandt <tipecaml@gmail.com> Signed-off-by:
-
Cong Ding authored
the variable j isn't used in the loop Signed-off-by:
-
Dan Carpenter authored
line6_send_sysex_message_async() isn't called from anywhere. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
Stefan Hajnoczi <stefanha@gmail.com> Reviewed-by:
Johannes Thumshirn <morbidrsa@googlemail.com> Signed-off-by:
-
Laurent Navet authored
staging: line6: driver.c The semantic patch that makes this output is available in scripts/coccinelle/api/memdup.cocci. Signed-off-by:
Laurent Navet <laurent.navet@gmail.com> Signed-off-by:
-
Laurent Navet authored
fix those checkpatch issues drivers/staging/line6/pcm.c:84: WARNING: simple_strtoul is obsolete, use kstrtoul instead call to obsolete simple_strtoul() replaced by kstrtoint() drivers/staging/line6/pcm.c:423: ERROR: switch and case should be at the same indent realigns comments Signed-off-by:
-
Kurt Kanzenbach authored
Fixed a coding style issue. Fixed positions of braces regarding to linux coding style. Signed-off-by:
Kurt Kanzenbach <shifty91@gmail.com> Acked-by:
-
Kurt Kanzenbach authored
Fixed a coding style issue. Removed trailing whitespaces in code. Signed-off-by:
-
Kurt Kanzenbach authored
Fixed a coding style issue. Replaced all c99 comments by c89 ones and deleted commented out code. Signed-off-by:
-
Sebastian Hahn authored
Fix the checkpatch error "do not initialize statics to 0 or NULL" Signed-off-by:
Sebastian Hahn <snsehahn@cip.cs.fau.de> Signed-off-by:
-
Sebastian Hahn authored
Fix the checkpatch error "switch and case should be at the same indent" Signed-off-by:
-
Sebastian Hahn authored
Fix a couple of instances where checkpatch complained about initializing globals with 0. Signed-off-by:
-
Sebastian Hahn authored
Converted staging/rtl8187se to use tabs instead of spaces for indentation to fix the checkpatch error "code indent should use tabs where possible". Signed-off-by:
-
Jennifer Naumann authored
This fixes the checkpatch error "open brace '{' following struct go on the same line" in staging/rtl8192u Signed-off-by:Jennifer Naumann <Jennifer.Naumann@informatik.stud.uni-erlangen.de> Signed-off-by:
-
Sebastian Hahn authored
Run cleanfile on all files inside drivers/staging/rtl819u Signed-off-by:
-
YAMANE Toshiaki authored
The following errors fixed. - ERROR: "foo * bar" should be "foo *bar" - ERROR: "(foo*)" should be "(foo *)" Signed-off-by:
YAMANE Toshiaki <yamanetoshi@gmail.com> Signed-off-by:
-
YAMANE Toshiaki authored
The following errors and warnings fixed. - WARNING: braces {} are not necessary for single statement blocks - ERROR: that open brace { should be on the previous line - ERROR: space required before the open parenthesis '(' - ERROR: space prohibited after that open parenthesis '(' Signed-off-by: -
YAMANE Toshiaki authored
The following errors fixed. - ERROR: spaces required around that '=' (ctx:VxV) - ERROR: spaces required around that '<=' (ctx:VxV) - ERROR: space required after that ',' (ctx:VxV) Signed-off-by:
-
YAMANE Toshiaki authored
The following warnings fixed. -WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ... -WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... Signed-off-by:
-
YAMANE Toshiaki authored
The following errors fixed. -ERROR: spaces required around that '<' (ctx:VxV) -ERROR: spaces required around that '?' (ctx:VxV) -ERROR: spaces required around that ':' (ctx:VxV) -ERROR: spaces required around that '>' (ctx:VxV) Signed-off-by:
-
YAMANE Toshiaki authored
The following errors fixed. -ERROR: that open brace { should be on the previous line -ERROR: space required before the open parenthesis '(' -ERROR: else should follow close brace '}' -ERROR: space required before the open brace '{' Signed-off-by: -
YAMANE Toshiaki authored
The following errors and warnings fixed. - ERROR: code indent should use tabs where possible - WARNING: please, no spaces at the start of a line - WARNING: please, no space before tabs Signed-off-by:
-
Ilija Hadzic authored
If mkdir() of VHCI_STATE_PATH fails because the directory already exists, that's not an error. This patch fixes annoying "record connection" errors that would typically come up on attach. Signed-off-by:
Ilija Hadzic <ihadzic@research.bell-labs.com> Acked-by:
David Chang <dchang@suse.com> Signed-off-by:
-
Ilija Hadzic authored
This comes handy when hacking with different cross compilers, some of which may or may not have _FORTIFY_SOURCE turned on by default. This patch allows us to turn _FORTIFY_SOURCE on by specifying --with-fortify option at configuration time (or to turn it off by specifying --without-fortify). If nothing is specified, default compiler behavior is assumed. Signed-off-by:
-
Ilija Hadzic authored
USBIP daemon relies on functions available in glib2 library to spawn handler code for incoming connection. This makes the whole program dependent on glib2 library, which is a GNOME library that on systems that don't have GNOME results in pulling more dependency, only to be able to run a relatively trivial socket-based program. While this may not seem to be a problem on full-blown desktops that already have the necessary libraries, it is a big issue on small embedded systems (think USB hub with an Ethernet port) that only have bare essentials in their file systems. This patch eliminates glib2 dependency by reworking the code to use lower level system calls to dispatch connection handler. Instead of using glib2-style event loop and dispatching mechanism, just do a ppoll(2) system call in our own loop and call accept(2) followed by fork(2) on the socket that has incoming connection. Stevens' books taught us that more than twenty years ago. No need for anything smarter in a simple server, such as usbipd. Signed-off-by:
-
Ilija Hadzic authored
There are a bunch of automatically generated files that git should not care about. Signed-off-by:
-
Ilija Hadzic authored
File doc/usbip_bind_driver.8 does not exist any more but it is listed in dist_man_MANS. This breaks the build of the userspace. Remove the file from the list. Signed-off-by:
-
Kurt Kanzenbach authored
strict_strtoul is obsolete and should be replaced with kstrto* function as reported by checkpatch.pl. pInfo->CardNumber is a u8. This is why kstrtou8 should be used here. Signed-off-by:
-
Ondrej Zary authored
After unifying struct ft1000_info, struct ft1000_device is now wrong name. Rename it to ft1000_usb to match its semantics. Signed-off-by:
Ondrej Zary <linux@rainbow-software.org> Reviewed-by:
Marek Belisko <marek.belisko@open-nandra.com> Signed-off-by:
-
