Commits · 6038178ebe29e6b5e4d519a5ac56653d156c90f9 · Kirill Smelkov / linux

08 Nov, 2012 40 commits

drbd: Change how the "handshake" packets are called · 6038178e

Andreas Gruenbacher authored Mar 28, 2011

Packets of type P_HAND_SHAKE define which protocol versions and features
a node supports.  For clarity, call those packets P_CONNECTION_FEATURES
instead.

(This does not determine the features that a specific drbd device
supports, such as drbd protocol A, B, C.)
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

6038178e

drbd: Change how the initial packets are called · e5d6f33a

Andreas Gruenbacher authored Mar 28, 2011

The first packets exchanged when a connection is established are
referred to as P_HAND_SHAKE_S and P_HAND_SHAKE_M in the code, followed
by P_HAND_SHAKE packets. To avoid confusion between these two unrelated
things, call the initial packets P_INITIAL_DATA and P_INITIAL_META.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

e5d6f33a

drbd: _conn_send_cmd(), _drbd_send_cmd(): Pass a struct drbd_socket instead of a plain socket · 7c96715a
Andreas Gruenbacher authored Mar 22, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
7c96715a
drbd: drbd_connect(): Initialize struct drbd_socket before sending anything · 2bf89621
Andreas Gruenbacher authored Mar 28, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
2bf89621
drbd: Map from (connection, volume number) to device in the asender handlers · 1952e916
Andreas Gruenbacher authored Mar 25, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
1952e916
drbd: Pass struct packet_info down to the asender receive functions · e05e1e59
Andreas Gruenbacher authored Mar 25, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
e05e1e59

drbd: Do not segfault if a sync dependency reaches a diskless device · 438c8374

Philipp Reisner authored Mar 28, 2011

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

438c8374

drbd: Allow to disconnect if one volume is diskless · 778bcf2e

Philipp Reisner authored Mar 28, 2011

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

778bcf2e

drbd: Print common state changes of all volumes as connection state changes · 435693e8
Philipp Reisner authored Mar 25, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
435693e8

drbd: Fixed logging of old connection state · 88ef594e

Philipp Reisner authored Mar 25, 2011

During a disconnect the oc variable in _conn_request_state()
could become outdated. Determin the common old state after
sleeping.
While at it, I implemented that for all parts of the state
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

88ef594e

drbd: Use the idr_for_each_entry() iterator instead of idr_for_each() · bd0c824a
Philipp Reisner authored Mar 25, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
bd0c824a

drbd: Map from (connection, volume number) to device in the receive handlers · 4a76b161

Andreas Gruenbacher authored Mar 25, 2011

The receive handlers do not all handle unknown volume numbers the same
way.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

4a76b161

drbd: Pass struct packet_info down to the receive functions · e2857216

Andreas Gruenbacher authored Mar 25, 2011

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

e2857216

drbd: Remove useless error messages · 49ba9b1b

Andreas Gruenbacher authored Mar 25, 2011

These messages can only trigger in case there is a pretty obvious
internal programming error.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

49ba9b1b

drbd: A small cleanup in drbdd() · deebe195

Andreas Gruenbacher authored Mar 25, 2011

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

deebe195

drbd: _drbd_send_bitmap(): Use the pre-allocated send buffer · 79ed9bd0

Andreas Gruenbacher authored Mar 24, 2011

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

79ed9bd0

drbd: Preallocate one page per drbd_socket as a send buffer · 5a87d920

Andreas Gruenbacher authored Mar 24, 2011

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

5a87d920

drbd: receive_bitmap(): Use the pre-allocated receive buffer · fc56815c

Andreas Gruenbacher authored Mar 24, 2011

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

fc56815c

drbd: Preallocate one page per drbd_socket as a receive buffer · e6ef8a5c

Andreas Gruenbacher authored Mar 24, 2011

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

e6ef8a5c

drbd: Converted drbd_try_outdate_peer() from mdev to tconn · cb703454

Philipp Reisner authored Mar 24, 2011

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

cb703454

drbd: Rename the DCBP_* functions to dcbp_* and move them to where they are used · a02d1240
Andreas Gruenbacher authored Mar 22, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
a02d1240

drbd: Make _drbd_send_bitmap() static · 058820cd

Andreas Gruenbacher authored Mar 22, 2011

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

058820cd

drbd: Move drbd_send_ping() and drbd_send_ping_ack() to drbd_main.c · e307f352
Andreas Gruenbacher authored Mar 22, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
e307f352

drbd: Always use the same protocol version for the same peer · 0916e0e3

Andreas Gruenbacher authored Mar 21, 2011

There is no need to send protocol 80 headers to peers that understand
protocol 95 headers. Make sure that we don't send protocol 95 headers
until we have agreed upon a protocol version with our peer, though.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

0916e0e3

drbd: drbd_connected(): Return an error code upon failure. · 0829f5ed

Andreas Gruenbacher authored Mar 24, 2011

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

0829f5ed

drbd: Introduce and use drbd_recv_all_warn() · a5c31904

Andreas Gruenbacher authored Mar 24, 2011

The pattern of receiving a fixed number of bytes and warning if a short
packet is received and the receiver has not actively been interruped is
repeated many times; clean that up.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

a5c31904

drbd: Get rid of typedef drbd_work_cb · 309a8348

Andreas Gruenbacher authored Dec 21, 2010

This type is not used anywhere else.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

309a8348

drbd: Rename various functions from *_oos_* to *_out_of_sync_* for clarity · 8f7bed77
Andreas Gruenbacher authored Dec 19, 2010
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
8f7bed77

drbd: drbd_may_do_local_read(): Use bool/true/false · 0da34df0

Andreas Gruenbacher authored Dec 19, 2010

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

0da34df0

drbd: Remove unnecessary assertion · 1097e9a8

Andreas Gruenbacher authored Dec 17, 2010

This is also checked further below in the same function.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

1097e9a8

drbd: Remove duplicate initialization · 69f5ec72

Andreas Gruenbacher authored Dec 13, 2010

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

69f5ec72

drbd: drbd_md_sync_page_io(): Return 0 upon success and an error code otherwise · 3fbf4d21
Andreas Gruenbacher authored Dec 13, 2010
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
3fbf4d21
drbd: _drbd_md_sync_page_io(): Return 0 upon success and an error code otherwise · ac29f403
Andreas Gruenbacher authored Dec 13, 2010
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
ac29f403
drbd: drbd_bm_read() never returns a positive value through drbd_bitmap_io() · 22ab6a30
Andreas Gruenbacher authored Dec 13, 2010
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
22ab6a30
drbd: Make all command handlers return 0 upon success and an error code otherwise · 82bc0194
Andreas Gruenbacher authored Mar 17, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
82bc0194

drbd: Add drbd_recv_all(): Receive an entire buffer · c6967746

Andreas Gruenbacher authored Mar 17, 2011

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

c6967746

drbd: send_bitmap_rle_or_plain(): Error handling cleanup · a982dd57

Andreas Gruenbacher authored Dec 10, 2010

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

a982dd57

drbd: recv_resync_read(): Return 0 upon success and an error code otherwise · e1c1b0fc
Andreas Gruenbacher authored Mar 16, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
e1c1b0fc
drbd: recv_dless_read(): Return 0 upon success and an error code otherwise · 28284cef
Andreas Gruenbacher authored Mar 16, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
28284cef
drbd: drbd_drain_block(): Return 0 upon success and an error code otherwise · fc5be839
Andreas Gruenbacher authored Mar 16, 2011
```
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
```
fc5be839