- 19 Mar, 2012 4 commits
-
-
J. Bruce Fields authored
These changes fix readdir loops on ext4 filesystems with dir_index turned on. I'm pulling them from Ted's tree as I'd like to give them some extra nfsd testing, and expect to be applying (potentially conflicting) patches to the same code before the next merge window. From the nfs-ext4-premerge branch of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4Signed-off-by:
J. Bruce Fields <bfields@redhat.com>
-
Bernd Schubert authored
Use 32-bit or 64-bit llseek() hashes for directory offsets depending on the NFS version. NFSv2 gets 32-bit hashes only. NOTE: This patch got rather complex as Christoph asked to set the filp->f_mode flag in the open call or immediatly after dentry_open() in nfsd_open() to avoid races. Personally I still do not see a reason for that and in my opinion FMODE_32BITHASH/FMODE_64BITHASH flags could be set nfsd_readdir(), as it follows directly after nfsd_open() without a chance of races. Signed-off-by:
Bernd Schubert <bernd.schubert@itwm.fraunhofer.de> Signed-off-by:
"Theodore Ts'o" <tytso@mit.edu> Acked-by: J. Bruce Fields<bfields@redhat.com>
-
Bernd Schubert authored
Just rename this variable, as the next patch will add a flag and 'access' as variable name would not be correct any more. Signed-off-by:
-
Fan Yong authored
Traditionally ext2/3/4 has returned a 32-bit hash value from llseek() to appease NFSv2, which can only handle a 32-bit cookie for seekdir() and telldir(). However, this causes problems if there are 32-bit hash collisions, since the NFSv2 server can get stuck resending the same entries from the directory repeatedly. Allow ext4 to return a full 64-bit hash (both major and minor) for telldir to decrease the chance of hash collisions. This still needs integration on the NFS side. Patch-updated-by:
Fan Yong <yong.fan@whamcloud.com> Signed-off-by:
Andreas Dilger <adilger@whamcloud.com> Signed-off-by:
-
- 14 Mar, 2012 1 commit
-
-
Bernd Schubert authored
Those flags are supposed to be set by NFS readdir() to tell ext3/ext4 to 32bit (NFSv2) or 64bit hash values (offsets) in seekdir(). Signed-off-by:
-
- 09 Mar, 2012 1 commit
-
-
J. Bruce Fields authored
Make sure this is set whenever there is no callback channel. If a client does not set up a callback channel at all, then it will get this flag set from the very start. That's OK, it can just ignore the flag if it doesn't care. If a client does care, I think it's better to inform it of the problem as early as possible. Reported-by:
Rick Macklem <rmacklem@uoguelph.ca> Signed-off-by:
-
- 06 Mar, 2012 10 commits
-
-
J. Bruce Fields authored
I get 320 bytes for struct svc_fh on x86_64, really a little large to be putting on the stack; kmalloc() instead. Signed-off-by: -
J. Bruce Fields authored
Compound processing stops on error, so the current filehandle won't be used on error. Thus the order here doesn't really matter. It'll be more convenient to do it later, though. Signed-off-by: -
Benny Halevy authored
The session client is manipulated under the client_lock hence both free_session and nfsd4_del_conns must be called under this lock. This patch adds a BUG_ON that checks this condition in the respective functions and implements the missing locks. nfsd4_{get,put}_session helpers were moved to the C file that uses them so to prevent use from external files and an unlocked version of nfsd4_put_session is provided for external use from nfs4xdr.c Signed-off-by:Benny Halevy <bhalevy@tonian.com> Signed-off-by:
-
Benny Halevy authored
Handle the case where the nfsv4.1 client asked to uprade or downgrade its delegations and server returns no delegation. In this case, op_delegate_type is set to NFS4_OPEN_DELEGATE_NONE_EXT and op_why_no_deleg is set respectively to WND4_NOT_SUPP_{UP,DOWN}GRADE Signed-off-by: -
Benny Halevy authored
When a 4.1 client asks for a delegation and the server returns none op_delegate_type is set to NFS4_OPEN_DELEGATE_NONE_EXT and op_why_no_deleg is set to either WND4_CONTENTION or WND4_RESOURCE. Or, if the client sent a NFS4_SHARE_WANT_CANCEL (which it is not supposed to ever do until our server supports delegations signaling), op_why_no_deleg is set to WND4_CANCELLED. Note that for WND4_CONTENTION and WND4_RESOURCE, the xdr layer is hard coded at this time to encode boolean FALSE for ond_server_will_push_deleg / ond_server_will_signal_avail. Signed-off-by:
-
Dan Carpenter authored
Sparse complains that the definition function definition and the implementation aren't anotated the same way. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Acked-by:
Tom Tucker <tom@opengridcomputing.com> Signed-off-by:
-
J. Bruce Fields authored
Another leak on error Signed-off-by: -
Jeff Layton authored
The current code never calls nfsd4_shutdown_recdir if nfs4_state_start returns an error. Also, it's better to go ahead and consolidate these functions since one is just a trivial wrapper around the other. Signed-off-by:
Jeff Layton <jlayton@redhat.com> Signed-off-by:
-
J. Bruce Fields authored
To escape having your stable storage record purged at the end of the grace period, it's not sufficient to simply have performed a setclientid_confirm; you also need to meet the same requirements as someone creating a new record: either you should have done an open or open reclaim (in the 4.0 case) or a reclaim_complete (in the 4.1 case). Signed-off-by: -
J. Bruce Fields authored
We set cl_firststate when we first decide that a client will be permitted to reclaim state on next boot. This happens: - for new 4.0 clients, when they confirm their first open - for returning 4.0 clients, when they reclaim their first open - for 4.1+ clients, when they perform reclaim_complete We also use cl_firststate to decide whether a reclaim_complete has already been performed, in the 4.1+ case. We were setting it on 4.1 open reclaims, which caused spurious COMPLETE_ALREADY errors on RECLAIM_COMPLETE from an nfs4.1 client with anything to reclaim. Reported-by:
-
- 17 Feb, 2012 6 commits
-
-
Benny Halevy authored
Respect client request for not getting a delegation in NFSv4.1 Appropriately return delegation "type" NFS4_OPEN_DELEGATE_NONE_EXT and WND4_NOT_WANTED reason. [nfsd41: add missing break when encoding op_why_no_deleg] Signed-off-by:
-
Bryan Schumaker authored
When I initially wrote it, I didn't understand how lists worked so I wrote something that didn't use them. I think making a list of stateids to test is a more straightforward implementation, especially compared to especially compared to decoding stateids while simultaneously encoding a reply to the client. Signed-off-by:
Bryan Schumaker <bjschuma@netapp.com> Signed-off-by:
-
NeilBrown authored
If you try to set grace_period or timeout via a module parameter to lockd, and do this on a big-endian machine where sizeof(int) != sizeof(unsigned long) it won't work. This number given will be effectively shifted right by the difference in those two sizes. So cast kp->arg properly to get correct result. Cc: stable@kernel.org Signed-off-by:
NeilBrown <neilb@suse.de> Signed-off-by:
-
Tom Tucker authored
The svcrdma transport was un-marshalling requests in-place. This resulted in sparse warnings due to __beXX data containing both NBO and HBO data. The code has been restructured to do byte-swapping as the header is parsed instead of when the header is validated immediately after receipt. Also moved extern declarations for the workqueue and memory pools to the private header file. Signed-off-by:
Tom Tucker <tom@ogc.us> Signed-off-by:
-
Benny Halevy authored
Signed-off-by:
-
Benny Halevy authored
Currently, it will not correctly ignore any nfsv4.1 signal flags if the client sends them. Signed-off-by:
-
- 15 Feb, 2012 10 commits
-
-
Tigran Mkrtchyan authored
Signed-off-by:
Tigran Mkrtchyan <kofemann@gmail.com> Signed-off-by:
-
Tigran Mkrtchyan authored
Signed-off-by:
-
Tigran Mkrtchyan authored
Signed-off-by:
-
Tigran Mkrtchyan authored
Signed-off-by:
-
Tigran Mkrtchyan authored
Signed-off-by:
-
Tigran Mkrtchyan authored
Signed-off-by:
-
Tigran Mkrtchyan authored
Signed-off-by:
-
Tigran Mkrtchyan authored
Signed-off-by:
-
Tigran Mkrtchyan authored
Signed-off-by:
-
Tigran Mkrtchyan authored
Signed-off-by:
-
- 14 Feb, 2012 2 commits
-
-
J. Bruce Fields authored
This fixes an oops when a buggy client tries to use an initial seqid of 0 on a new slot, which we may misinterpret as a replay. Signed-off-by: -
J. Bruce Fields authored
Combine two booleans into a single flag field, move the smaller fields to the end. (In practice this doesn't make the struct any smaller. But we'll be adding another flag here soon.) Remove some debugging code that doesn't look useful, while we're in the neighborhood. Signed-off-by:
-
- 13 Feb, 2012 1 commit
-
-
J. Bruce Fields authored
From RFC 5661 2.10.6.1: "If the previous sequence ID was 0xFFFFFFFF, then the next request for the slot MUST have the sequence ID set to zero." While we're there, delete some redundant comments. Signed-off-by:
-
- 03 Feb, 2012 5 commits
-
-
J. Bruce Fields authored
The rpc buffers will be allocated out of low memory, so we should really only be taking that into account. Signed-off-by: -
J. Bruce Fields authored
Move calculation of the default into a helper function. Get rid of an unused variable "err" while we're there. Thanks to Mi Jinlong for catching an arithmetic error in a previous version. Cc: Mi Jinlong <mijinlong@cn.fujitsu.com> Signed-off-by: -
Stanislav Kinsbursky authored
This is a cleanup patch. Service temporary sockets can be TCP or RDMA only. But XPT_CHNGBUF service socket flag is checked only for UDP sockets on receive. Thus (if I don't miss something non-obvious) this bit raising for temporary sockets can be removed. Signed-off-by:
Stanislav Kinsbursky <skinsbursky@parallels.com> Signed-off-by:
-
Dan Carpenter authored
We check for zero length strings in the caller now, so these aren't needed. Signed-off-by:
-
Dan Carpenter authored
There is no point in passing a zero length string here and quite a few of that cache_parse() implementations will Oops if count is zero. Signed-off-by:
-
