Skip to content

L
linux
Switch branch/tag
  1. 02 Jul, 2004 14 commits
    • Mika Kukkonen's avatar
      [PATCH] sparse: fix sparse in drivers/pnp/pnpbios/* · 62d10271
      Mika Kukkonen authored 
        CHECK   drivers/pnp/pnpbios/core.c
include/linux/pnpbios.h:144:5: warning: undefined preprocessor identifier 'needed'
  CC      drivers/pnp/pnpbios/core.o
  CHECK   drivers/pnp/pnpbios/bioscalls.c
include/linux/pnpbios.h:144:5: warning: undefined preprocessor identifier 'needed'
drivers/pnp/pnpbios/bioscalls.c:346:5: warning: undefined preprocessor identifier 'needed'
drivers/pnp/pnpbios/bioscalls.c:361:5: warning: undefined preprocessor identifier 'needed'
drivers/pnp/pnpbios/bioscalls.c:388:5: warning: undefined preprocessor identifier 'needed'
drivers/pnp/pnpbios/bioscalls.c:427:5: warning: undefined preprocessor identifier 'needed'
drivers/pnp/pnpbios/bioscalls.c:509:5: warning: undefined preprocessor identifier 'needed'
  CC      drivers/pnp/pnpbios/bioscalls.o
  CHECK   drivers/pnp/pnpbios/rsparser.c
include/linux/pnpbios.h:144:5: warning: undefined preprocessor identifier 'needed'
  CC      drivers/pnp/pnpbios/rsparser.o
  CHECK   drivers/pnp/pnpbios/proc.c
include/linux/pnpbios.h:144:5: warning: undefined preprocessor identifier 'needed'

The fix is trivial, sparse wants the preprocessor symbol to be defined
before use.  There was a similar fix accepted by Linus couple weeks ago.
Patch attached.
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      62d10271
    • Mika Kukkonen's avatar
      [PATCH] sparse: fix sparse warnings in kernel/power/* · 482ce192
      Mika Kukkonen authored 
        CHECK   kernel/power/swsusp.c
kernel/power/swsusp.c:320:15: warning: expected lvalue for member dereference
kernel/power/swsusp.c:337:15: warning: expected lvalue for member dereference
kernel/power/swsusp.c:359:14: warning: expected lvalue for member dereference
kernel/power/swsusp.c:925:12: warning: assignment expression in conditional
[...]
  CHECK   kernel/power/pmdisk.c
kernel/power/pmdisk.c:795:12: warning: assignment expression in conditional

Trivial sparse fixes for two files under kernel/power. Patch attached.
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      482ce192
    • Mika Kukkonen's avatar
      [PATCH] sparse: define max kernel symbol length and clean up errors in kernel/kallsyms.c · 77e5ab66
      Mika Kukkonen authored 
        CHECK   kernel/kallsyms.c
kernel/kallsyms.c:136:7: warning: bad constant expression
kernel/kallsyms.c:136:7: warning: bad constant expression
kernel/kallsyms.c:136:7: warning: bad constant expression
kernel/kallsyms.c:143:22: warning: bad constant expression
kernel/kallsyms.c:143:22: warning: bad constant expression
kernel/kallsyms.c:143:22: warning: bad constant expression

Now the cause of sparse warnings is that it does not handle runtime array
dimensioning (which I take it is a sparse problem), but in this particular
case it _might_ make sense to change the runtime allocation to compile
time, as the upper size of the array is known, because the code in
kernel/kallsyms.c clearly uses 127 (or 128) as "magic constant" for kernel
symbol (array) length, and in the other hand in include/linux/module.h
there is: #define MODULE_NAME_LEN (64 - sizeof(unsigned long))

The only concern is that the array become quite big (the original comment
of it being "pretty small" no longer applies ...).  One way to help that
would be to use buffer[] also in place of namebuf[], but that would be
little tricky as the format string should be before the symbol name ... 
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      77e5ab66
    • George Anzinger's avatar
      [PATCH] Bugfix for CLOCK_REALTIME absolute timer · 7fe672b1
      George Anzinger authored 
      As required by the standard, this patch adds to POSIX ABSOLUTE timers the
functionality of adjusting the timer when the clock is set so that it still
expires at the specified time (provided that time has not passed, in which
case the timer expires immeadiatly).

The standard is, IMNSOHO, a bit vague on just how repeating timers are to
be handled so I made some choices:

1) If an absolute timer is to expire every N intervals, we assume that
   the expiries should happen at those specified times after clock setting.
    I.e.  we adjust the repeat timer as well as the initial timer.  (The
   other option would be to treat the repeating timers as relative and not
   to adjust them.)

2) If a clock set moves the the clock prior to the initial expiry time
   AND that time has already passed and been signaled, the current repeat
   timer is adjusted, i.e.  we DO NOT go back to the initial time and
   repeat that.  (The other option is to treat this case as a new request
   with the initial timer parameters (which by this time we have lost).)

3) If time is advanced such that it appears that several expiries have
   been missed, the overrun count will reflect the misses.  (The other
   option is to not reflect this in the overrun.) At the same time, nothing
   is done to acknowledge, to the user, that we are repeating expiries when
   the clock is retarded.
Signed-off-by: default avatarGeorge Anzinger <george@mvista.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      7fe672b1
    • Arjan van de Ven's avatar
      [PATCH] produce a warning on unchecked inode_setattr use · 84db6603
      Arjan van de Ven authored 
      The patch below uses the new-in-gcc-3.4 option to generate a warning on
unchecked results of marked functions, and applies this to the
inode_setattr function (which based on recent bk commits HAS to be checked
for it's return value for correct operation).  A warning looks like this:

fs/ext2/inode.c:1279: warning: ignoring return value of 'inode_setattr', declared with attribute warn_unused_result
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      84db6603
    • Pavel Machek's avatar
      [PATCH] swsusp: preparation for smp support & fix device suspending · 19995e25
      Pavel Machek authored 
      It fixes levels for calling driver model, puts devices into sleep before
powering down (so that emergency parking does not happen), and actually
introduces SMP support, but its disabled for now.  Plus noone should try to
freeze_processes() when thats not implemented, we now BUG()s -- we do not
want Heisenbugs.
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      19995e25
    • Matt Porter's avatar
      [PATCH] ppc32: Fix dual UICs in 4xx PIC support · 939206e7
      Matt Porter authored 
      Fixes a case where we were not correctly acking the base cascade controller
on PPC4xx.  Patch from Pavel Bartusek <pba@sysgo.com>
Signed-off-by: default avatarMatt Porter <mporter@kernel.crashing.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      939206e7
    • Matt Porter's avatar
      [PATCH] ppc32: PPC4xx preempt fix · 2197b58c
      Matt Porter authored 
      PPC4xx preempt fixes. Based on previous Classic PPC patch.
Signed-off-by: default avatarTom Rini <trini@kernel.crashing.org>
Signed-off-by: default avatarMatt Porter <mporter@kernel.crashing.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      2197b58c
    • Matt Porter's avatar
      [PATCH] ppc32: PPC44x defconfig update and fixes · bd77c334
      Matt Porter authored 
      Update PPC44x defconfigs and some fixes.
Signed-off-by: default avatarMatt Porter <mporter@kernel.crashing.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      bd77c334
    • Tom Rini's avatar
      [PATCH] ppc32: OCP for MP10x · 0c54689b
      Tom Rini authored 
      Attached is the latest version of Adrian Cox's OCP patch for
MPC107/8240/8245.  This unifies some openpic setup code, and ensures that
the OCP devices are only added to the bus on chip variants which have them.

All interested parties seem happy, and this patch is necessary to provide a
unified I2C driver for 85xx and 107/824x.
Signed-off-by: default avatarAdrian Cox <adrian@humboldt.co.uk>
Signed-off-by: default avatarTom Rini <trini@kernel.crashing.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      0c54689b
    • Paul Mackerras's avatar
      [PATCH] ppc64: Janitor rtas_call() return variables · 0fd58fb3
      Paul Mackerras authored 
      Recently I changed the return value of rtas_call() from an unsigned long to
an int.  That patch missed a few places where we declare a variable to
store the result from rtas_call().  This new patch changes those places to
use an int variable instead of a long or unsigned long variable.  Linas
Vepstas pointed this out.
Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      0fd58fb3
    • Paul Mackerras's avatar
      [PATCH] ppc64: janitor log_rtas_error() call arguments · e1148e37
      Paul Mackerras authored 
      This patch from Linas Vepstas (rediffed by me) fixes the confusing argument
aliasing of the log_rtas_error() subroutine.

This patch makes no functional changes, it just cleans up some strange
usage.

The rtas_args used to communicate with firmware are always taken from the
paca struct, so as to keep the args at a fixed, low-memory location.  But
the log_rtas_error() routine also took an rtas_args pointer, which it
assumed was aliased to the paca struct.  This aliasing is both
un-neccessary, and confusing; this patch eliminates this confusion.
Signed-off-by: default avatarLinas Vepstas <linas@linas.org>
Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      e1148e37
    • David Gibson's avatar
      [PATCH] ppc64: PACA cleanup · 16b004a7
      David Gibson authored 
      Cleanup the PPC64 PACA structure.  It was previously a big mess of
unecessary fields, overengineered cache layout and uninformative comments. 
This is essentially a rewrite of include/asm-pp64/paca.h with associated
changes elsewhere.  The patch:

- Removes unused PACA fields

- Removes uneeded #includes

- Uses gcc attributes instead of explicit padding to get the desired
  cacheline layout, also rethinks the layout and comments accordingly.

- Better comments where asm or firmware dependencies apply non-obvious
  layout constraints.

- Splits up the pointless STAB structure, letting us move its elements
  independently.

- Uses offsetof instead of hardcoded offset in spinlocks.

- Eradicates xStudlyCaps identifiers

- Replaces PACA guard page with an explicitly defined emergency stack
  (removing more than NR_CPUS pages from the initialized data segment).

Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      16b004a7
    • David Gibson's avatar
      [PATCH] ppc64: remove RTAS arguments from PACA · 78c39c9f
      David Gibson authored 
      This patch removes the RTAS arguments structure on ppc64 from the PACA. 
The args have to be in the RMO, but since we have a global spinlock for
RTAS anyway, there's no reason to have a separate copy of the args per-CPU.
 This patch replaces the PACA field with a single instance in the global
rtas structure.

The one exception is for the rtas_stop_self() call, which can't take the
lock, because it never returns.  But it has a fixed set of arguments, so we
can use another global instance which is initialized at boot.

This lets us remove rtas.h from paca.h, which substantially reduces overall
#include hairiness (because paca.h is now, as it wants to be, a nice
low-level structure-defining header which relies on very little and can
safely be included almost anywhere).  Although it does add some noise to
the patch, because a bunch of places relied on the indirect inclusion of
rtas.h, or even more indirect inclusions (see the hunks applying to eeh.h
and current.h!).

Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      78c39c9f
  3. 01 Jul, 2004 12 commits
  5. 30 Jun, 2004 14 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7