This is a minor update to the patch I sent out about a week ago.
The key change is to use the I/O watchdog while doing ISO streaming.
Bernd Porr reports that a VT8235 system needs that; it seems like
IDE activity can interfere with the delivery of USB IRQs.


EHCI periodic scheduling updates.

 - Initial version of full speed ISO transaction support.  This
   should handle OUT transactions, such as those for usb speakers.
   For now, it's controlled using an EXPERIMENTAL config option:

   * I've run into interesting differences in how different USB 2.0
     hub silicon (the transaction translators) handle some older
     audio devices.  Needs more investigation.

   * Interrupt transfer scheduling doesn't yet cope well with schedules
     where every slot already has activity.  For now, don't plug in
     devices like hubs, mice, or keyboards while EHCI is streaming.

 - Protect freelist for highspeed ITDs, using spinlock.  Could be
   an issue for some drivers.

 - Kick in the I/O watchdog timer (5 msec) for periodic transfers.
   In this case, IDE activity on a VT8235 lost the IRQs which should
   have kept the ISO stream active.  Queues shorter than 5 msec are
   not going to work on all USB hosts.

 - Simplified the ISO scheduler:  doesn't attempt to re-schedule
   after lossage, or to short-circuit scanning.  (Rescheduling will
   probably come back later ... for now, the "hard" error here is
   highlighting problems that need attention.)

Adds two new gadget-side utility functions, to support a declarative
style of managing usb configuration descriptors.  The functions fill
buffers from null-terminated vectors of usb descriptors, which are
simple to build or update.

The "ethernet" gadget driver currently has the most interesting config
descriptors.  This uses those functions to replace some complex code with
simpler static declarations; result, it's cleaner.  (And it'll be easier
to add RNDIS configurations later, too.)

Memory savings (or cost, depending on config) was less than 50 bytes;
nothing worth worrying about.

New Zaurus ID, from Sven Trampel <Sven.Trampel@surf-club.de>

On Fri, 27 Feb 2004, Lenar Lõhmus wrote:

> Hi,
>
> Got this:
>
> usb 3-1: new full speed USB device using address 3
> usb-storage: This device (0686,400b,0001 S 06 P 50) has an unneeded SubClass entry in unusual_devs.h
> Please send a copy of this message to <linux-usb-devel@lists.sourceforge.net>

Well, Martin Pool notwithstanding (see

http://marc.theaimsgroup.com/?l=linux-usb-devel&m=107642806303815&w=2

), it sure looks like this doesn't need an unusual_devs.h entry.

Greg, please apply this patch.

I tried using the kl5kusb105 driver for a 3Com PalmConnect USB device I
had lying around.

It oopses during device detection. There is a nested loop using the same
loop counter as the outer loop - causing the code after the nested loop
is first executed to have an invalid counter. The counter is then used
as an array index, causing a NULL deref.

Fix attached.

Nothing in life is assured...

This patch tightens up the conditions under which an auto-sense will be
cleared.  It also fixes the comment associated with the code.

This one-liner removes an unneeded macro.

This patch changes some error checking so that some bogus devices (like the
Fuji Finepix 1400) will work.

This is basically relaxing a test on a field that the spec says "should
always be zero"

Our friends at sony are at it again.  The DSC-T1 needs a new entry.  Note
that it's the same VID & PID as the last entry, but different version.

This patch is from Stephen Hemminger.  I modified it slightly to place the
new elements at the end of the complete_list instead of at the front.

On Tue, 24 Feb 2004, Stephen Hemminger wrote:

> Since the remove_list and complete_list now use the same element for
> linking, it is possible to use the list_splice inline to avoid
> having to loop over all the urb's

On Mon, 23 Feb 2004, Stephen Hemminger wrote:
> Bulk and interrupt urb's share common irq processing, why does the
> code try to obfuscate it?

Quite right; this is needless complexity.  (But note you left in a couple
of lines that should have been deleted.)

This patch changes the result code returned by the UHCI driver for a
certain class of errors.  Under a number of circumstances a USB device is
obliged to send a response packet within a fairly short turn-around time,
typically 1 - 10 microseconds depending on the bus speed.  Failure to do
so is a protocol error and should be reported as such, not as a timeout,
which is really a higher-level concept.  I believe the EHCI driver already
does this.

I trust nobody will object to the update this patch adds to
Documentation/usb/error-codes.txt, making this more explicit.

In a vaguely related change, the patch corrects the terminology in a few
comments.  The parts of a control transfer are called "stages", not
"phases".

On Mon, 23 Feb 2004, Chip Salzenberg wrote:

> It works ... perfectly!  I can now suspend and resume my A30 with
> impunity, and the USB keyboard works fine after each resume.
>
> Thanks much, Alan.
>
> (Now if I could just get the alsa guys to fix snd-intel8x0...)

This patch re-initializes the UHCI Interrupt Enable register following a
PM resume.  Apparently some systems clear the register during suspend,
which causes obvious problems later on.

On Mon, 23 Feb 2004, Stephen Hemminger wrote:

> Great, the kernel with this patch ran successfully all weekend.  Looks like no
> more races in the unlink path.

Wonderful.  Thanks a lot for all your SMP testing, it's been a big help.


This patch corrects an error in the dequeueing code for UHCI.  Improper
locking caused it to hang in the oddball case where an URB was unlinked
even before it had been queued.

On Tue, 24 Feb 2004, Matthew Dharm wrote:

> We should also put a comment into the unusual_devs.h file to make sure
> nobody tries to remove the protocol override in the future.

How about this?

On Thu, 19 Feb 2004, Evan Felix wrote:

> I plugged a Cyclades AlterPath BIO USb device into my linux 2.6.2 laptop
> and it asked me to send you this:
>
>
> hub 1-1.2:1.0: new USB device on port 3, assigned address 6
> hub 1-1.2.3:1.0: USB hub found
> hub 1-1.2.3:1.0: 4 ports detected
> hub 1-1.2.3:1.0: new USB device on port 1, assigned address 7
> hub 1-1.2.3:1.0: new USB device on port 2, assigned address 8
> Initializing USB Mass Storage driver...
> usb-storage: This device (05dc,0001,0001 S 06 P 50) has an unneeded
> SubClass entry in unusual_devs.h
>    Please send a copy of this message to
> <linux-usb-devel@lists.sourceforge.net>
> scsi0 : SCSI emulation for USB Mass Storage devices
>   Vendor: Lexar     Model: Jumpshot USB CF   Rev: 0001
>   Type:   Direct-Access                      ANSI SCSI revision: 02

Thank you for sending this.  Greg, here's the patch.

This patch is the first of several planned fixes for the cyclades
multiserial cards driver.

Its mostly a sync with in-house driver:

- Prevent users from opening non-existing Z ports
- Implement special XON/XOFF character handling in Z cards
- Prevent data-loss on Z cards
- Throttling fix for Z card
- Only throttle if CTS/RTS are set
- Fix accounting of received data

Kudos to Cyclades R&D

From: William Lee Irwin III <wli@holomorphy.com>

PRD_ENTRIES is specified to be precisely 256; on platforms where
PAGE_SIZE varies from 4KB the calculation in the current expression
defining it is inaccurate, which may cause crashes. This patch changes
it to the constant literal 256.

From: Andrew Morton <akpm@osdl.org>

Use sector_t for the block number.

Noticed by Marcel Cotta <mc123@mail.ru>.

ide_init() always initializes system_bus_speed variable
so system_bus_clock() should never call ide_system_bus_speed()
and no driver is calling ide_system_bus_speed() directly.

Bug was that if no IDE kernel parameter was given during boot
system_bus_speed will be zeroed in init_ide_data().

This patch should fix the problem
(as a bonus -> no need to zero these variables they are static).

From: Vojtech Pavlik <vojtech@suse.cz>

Add UDMA6 support to ALi PCI IDE driver.
Forward port from 2.4 and a patch from ALi.

Was in -mm for a long time...

Fix from jgarzik's sata_sil.c libata driver.

This was in -mm for a long time...

This switches alpha to use drivers/Kconfig instead of including most of
files included by drivers/Kconfig, thus enabling previously omitted i2c
(already used in some drivers available on alpha) and telephony drivers.

Because drivers/message/fusion/Kconfig was included only conditionally
("if PCI"), this patch also changes CONFIG_FUSION to depend on PCI.

(these changes were consulted with Christoph Hellwig in "i2c on alpha
- used but not available in 2.6.3" thread on LKML)

into ppc970.osdl.org:/home/torvalds/v2.5/linux

into ppc970.osdl.org:/home/torvalds/v2.5/linux

arm-26, ppc, sparc, sparc64 and sh have per-arch definitions of
__cacheline_aligned that are identical to default.  And yes, removal is
safe - all users of __cacheline_aligned actually pull linux/cache.h in.

We put ____cacheline_aligned things in their own section, simply
because we waste less space that way.  Otherwise we end up padding
innocent variables to the next cacheline to get the required
alignment.

There's no reason not to do this in modules, too.

	Removes gratitious ifdefs - get_nodes() is only called from __init
and by itself, check_space() is only called by get_nodes(), so they can
be made unconditionally __init.

into ppc970.osdl.org:/home/torvalds/v2.5/linux

Use KERN_DEBUG in all debugging printk() output.

This patch originally from the kernel janitors.

Fix interrupt handler return types to be irqreturn_t.

Remove non-existent config option from defconfig.

I goofed in my last patch to this code..
It reported 1 less CPU than it should have. Doh.