- 22 May, 2019 4 commits
-
-
Puranjay Mohan authored
Change (x == NULL) to !x and (x != NULL) to x, to fix following checkpatch.pl warnings: CHECK: Comparison to NULL could be written "!x". Signed-off-by:
Puranjay Mohan <puranjay12@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Puranjay Mohan authored
Change comparison to zero to !x. Replace (x == 0) to !x. Signed-off-by:
-
Puranjay Mohan authored
Use "%s", __func__ in place of strings which contain function names. Signed-off-by:
-
Puranjay Mohan authored
Remove functions which just print the name of function and return 0, These functions fake the network core to say that they support these options. Signed-off-by:
-
- 21 May, 2019 20 commits
-
-
Jeremy Sowden authored
The show functions of two attributes output nothing and they are unused. Removed them. Signed-off-by:
Jeremy Sowden <jeremy@azazel.net> Reported-by:
Matt Sickler <matt.sickler@daktronics.com> Signed-off-by:
-
Jeremy Sowden authored
staging: kpc2000: added separate show functions for kpc_uio_class device attributes, defined them as read-only and declared them static. Defined separate simple show functions for each attribute instead of having a one big one containing a chain of conditionals. Replaced scnprintf calls with sprintf since all the outputs are short bounded strings or single integers. All of the device attributes are read-only, so used DEVICE_ATTR_RO to define them. The definitions are only used to populate the kpc_uio_class_attrs attribute array, so declared them as static. Fixes the following sparse warnings: drivers/staging/kpc2000/kpc2000/cell_probe.c:220:1: warning: symbol 'dev_attr_offset' was not declared. Should it be static? drivers/staging/kpc2000/kpc2000/cell_probe.c:221:1: warning: symbol 'dev_attr_size' was not declared. Should it be static? drivers/staging/kpc2000/kpc2000/cell_probe.c:222:1: warning: symbol 'dev_attr_type' was not declared. Should it be static? drivers/staging/kpc2000/kpc2000/cell_probe.c:223:1: warning: symbol 'dev_attr_s2c_dma' was not declared. Should it be static? drivers/staging/kpc2000/kpc2000/cell_probe.c:224:1: warning: symbol 'dev_attr_c2s_dma' was not declared. Should it be static? drivers/staging/kpc2000/kpc2000/cell_probe.c:225:1: warning: symbol 'dev_attr_irq_count' was not declared. Should it be static? drivers/staging/kpc2000/kpc2000/cell_probe.c:226:1: warning: symbol 'dev_attr_irq_base_num' was not declared. Should it be static? drivers/staging/kpc2000/kpc2000/cell_probe.c:227:1: warning: symbol 'dev_attr_core_num' was not declared. Should it be static? Signed-off-by:
-
Nishka Dasgupta authored
Remove local variable psdio which is declared but not used (or returned) in its function. Issue found with Coccinelle. Signed-off-by:
Nishka Dasgupta <nishka.dasgupta@yahoo.com> Signed-off-by:
-
Quentin Deslandes authored
Check for error during device initialization callback and return a meaningful error code or zero on success. Signed-off-by:
Quentin Deslandes <quentin.deslandes@itdev.co.uk> Signed-off-by:
-
Quentin Deslandes authored
Avoid discarding function's return code during register initialization. Handle it instead and return 0 on success or a negative errno value on error. Signed-off-by:
-
Quentin Deslandes authored
Check on called function's returned value for error and return 0 on success or a negative errno value on error instead of a boolean value. Signed-off-by:
-
Quentin Deslandes authored
Avoid discarding return value of functions called during firmware management process. Handle such return value and return 0 on success or a negative errno value on error. Signed-off-by:
-
Quentin Deslandes authored
Change some of the driver's functions in order to handle error codes instead of discarding them. These function now returns 0 on success and a negative errno value on error. Signed-off-by:
-
Quentin Deslandes authored
Avoid discarding called function's returned value. Store it instead in order to act accordingly. Update error path to return 0 on success and a negative errno value on error. Signed-off-by:
-
Quentin Deslandes authored
vnt_free_tx_bufs() relies on priv->tx_context elements to be NULL if they are not initialized (as vnt_free_rx_bufs() does). Add a check to these elements in order to avoid NULL pointer dereference. Signed-off-by:
-
Puranjay Mohan authored
Fix following checkpatch.pl warning by adding braces around if statement: CHECK: braces {} should be used on all arms of this statement Signed-off-by: -
Puranjay Mohan authored
Remove else after break statements to fix following checkpatch.pl warnings: WARNING: else is not generally useful after a break or return. Signed-off-by:
-
Yannick Loeck authored
Fixes the misspelling of packet in <MASK_PACKETCONFIG1_PAKET_FORMAT_VARIABLE> Signed-off-by:
Yannick Loeck <yannick.loeck@gmail.com> Signed-off-by:
-
Greg Kroah-Hartman authored
As this is only called twice, just call writel() like a normal driver should :) At the same time, clean up the formatting for the irq handler, as there is no need to have that be incorrect, it just hurts the eyes... Cc: Matt Sickler <Matt.Sickler@daktronics.com> Signed-off-by: -
Greg Kroah-Hartman authored
The functions GetBackEndStatus() and BackEndControlSetClear() are never used by any code, so just remove them. Cc: Matt Sickler <Matt.Sickler@daktronics.com> Signed-off-by: -
Greg Kroah-Hartman authored
There is no need for a subdirectory for just a single .c file. So move it out of kpc_i2c/ and rename it to the module name that we want the file to build to, saving one more linking stage. Cc: Matt Sickler <Matt.Sickler@daktronics.com> Signed-off-by: -
Greg Kroah-Hartman authored
There is no need for a subdirectory for just a single .c file. So move it out of kpc_spi/ and rename it to the module name that we want the file to build to, saving one more linking stage. Cc: Matt Sickler <Matt.Sickler@daktronics.com> Signed-off-by: -
Greg Kroah-Hartman authored
The structures defined in spi_parts.h belong in the .c file that uses it. So move it directly into spi_driver.c to make things simpler to manage. Cc: Matt Sickler <Matt.Sickler@daktronics.com> Signed-off-by: -
Greg Kroah-Hartman authored
Use tabs in pcie.h, like is mandated. Cc: Matt Sickler <Matt.Sickler@daktronics.com> Signed-off-by: -
Greg Kroah-Hartman authored
The fileops.c file does not need to be stand-alone, so move it into the core.c file. This lets us make some functions static, reducing the global namespace of the driver. Cc: Matt Sickler <Matt.Sickler@daktronics.com> Signed-off-by:
-
- 20 May, 2019 16 commits
-
-
Puranjay Mohan authored
Fix following checkpatch.pl warning by removing unnecessary braces: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: -
Moses Christopher authored
- Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts" Signed-off-by:Moses Christopher <moseschristopherb@gmail.com> Signed-off-by:
-
Moses Christopher authored
- Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts" Signed-off-by: -
Moses Christopher authored
- Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts" Signed-off-by: -
Moses Christopher authored
- Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts" Signed-off-by: -
Moses Christopher authored
- Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts Signed-off-by: -
Moses Christopher authored
- Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts" Signed-off-by: -
Geordan Neukum authored
Throughout i2c_driver.c, there are numerous deviations from the two standards of: - placing a '*' at the beginning of every line containing a block comment. - placing the closing comment marker '*/' on a new line. Instead, use a block comment style that is more consistent with the prescribed guidelines. Signed-off-by:
Geordan Neukum <gneukum1@gmail.com> Signed-off-by:
-
Geordan Neukum authored
Throughout i2c_driver.c, there are instances where the log strings contain the function's name hardcoded into the string. Instead, use the printk conversion specifier '%s' with the __func__ preprocessor identifier to more maintainably print the function's name. Signed-off-by:
-
Geordan Neukum authored
The probe() function performs a kzalloc to dynamically allocate memory at runtime. If the allocation succeeds, yet invoking the function i2c_add_adapter fails, the dynamically allocated memory is never freed. Change the allocation to use the managed allocation API instead and remove the manual freeing of the memory in the remove() function. Signed-off-by:
-
Geordan Neukum authored
The copyright header in i2c_driver.c is difficult to read and not chronologically ordered. Reformat and reorganize the copyright header to be similar to other drivers in the i2c subsystem. Signed-off-by:
-
Geordan Neukum authored
i2c_driver.c uses a mixture of space and tab indentations which conflicts with the kernel coding style guide. Reindent i2c_driver.c. Signed-off-by:
-
Greg Kroah-Hartman authored
We do not need an inline function to "hide" the lock, so just replace the few calls to these functions with the "real" mutex_lock/unlock() calls. Cc: Matt Sickler <Matt.Sickler@daktronics.com> Signed-off-by: -
Greg Kroah-Hartman authored
The kp200_module.c does not need to be stand-alone, so move it into the core.c file. This lets us make some functions static, reducing the global namespace of the driver. Cc: Matt Sickler <Matt.Sickler@daktronics.com> Signed-off-by: -
Greg Kroah-Hartman authored
Use tabs in uapi.h, like is mandated. Cc: Matt Sickler <Matt.Sickler@daktronics.com> Signed-off-by: -
Oscar Gomez Fuente authored
These changes solve a warning realated to an incorrect type inilizer in the function fieldbus_poll. Signed-off-by:
Oscar Gomez Fuente <oscargomezf@gmail.com> Signed-off-by:
-
