1. 19 Mar, 2015 3 commits
  2. 18 Mar, 2015 11 commits
  3. 17 Mar, 2015 2 commits
  4. 16 Mar, 2015 2 commits
  5. 13 Mar, 2015 8 commits
    • Ingo Molnar's avatar
      Merge tag 'perf-core-for-mingo' of... · 107eb964
      Ingo Molnar authored
      Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core
      
      Pull perf/core improvements and fixes from Arnaldo Carvalho de Melo:
      
      User visible changes:
      
        - Fix UI bug after zoom into thread/dso/symbol and another, after fold/unfold,
          in the TUI hists browser (He Kuang)
      
        - Fixes for 'perf probe' to better handle aliased symbols, for instance in glibc (Masami Hiramatsu, Namhyung Kim)
      
        - 'perf kmem' improvements and fixes: (Namhyung Kim)
          - Fix segfault when invalid sort key is given
          - Allow -v option
          - Fix alignment of slab result table
      
        - 'perf stat' improvements and fixes: (Andi Kleen)
          - Output running time and run/enabled ratio in CSV mode
          - Fix IPC and other formulas with -A
          - Always correctly indent ratio column
      
        - Add tracepoint events fields CTF conversion support to 'perf data' (Sebastian Andrzej Siewior)
      
      Infrastructure changes:
      
        - Output feature detection's gcc output to a file, to help in debugging (Arnaldo Carvalho de Melo)
      
        - Fix 'perf probe' compiles due to declarations using perf_probe_point (David Ahern)
      
        - Fix possible double free on error in 'perf probe' (He Kuang)
      
        - Remove superfluous thread->comm_set setting (Jiri Olsa)
      
        - Fix libbabeltrace detection (Jiri Olsa)
      
        - More work on separating ordered_events code out of perf_session (Arnaldo Carvalho de Melo)
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      107eb964
    • Sebastian Andrzej Siewior's avatar
      perf data: Add tracepoint events fields CTF conversion support · 69364727
      Sebastian Andrzej Siewior authored
      Adding support to convert tracepoint event fields into CTF
      event fields.
      
      We parse each tracepoint event for CTF conversion and add
      tracepoint fields as regular CTF event fields, so they
      appear in babeltrace output like:
      
        $ babeltrace ./ctf-data/
        ...
        [09:02:00.950703057] (+?.?????????) sched:sched_stat_runtime: { }, { perf_ip = ... SNIP ... common_type = 298, common_flags = 1, \
        common_preempt_count = 0, common_pid = 31813, comm = "perf", pid = 31813, runtime = 458800, vruntime = 52059858071 }
        ...
      Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
      Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jeremie Galarneau <jgalar@efficios.com>
      Cc: Namhyung Kim <namhyung@gmail.com>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Tom Zanussi <tzanussi@gmail.com>
      Cc: Wang Nan <wangnan0@huawei.com>
      Link: http://lkml.kernel.org/r/1424470628-5969-6-git-send-email-jolsa@kernel.orgSigned-off-by: default avatarJiri Olsa <jolsa@kernel.org>
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      69364727
    • Namhyung Kim's avatar
      perf kmem: Fix alignment of slab result table · 65f46e02
      Namhyung Kim authored
      Its table was a bit misaligned.  Fix it.
      
      Before:
      
        # perf kmem stat --caller -l 10
        ------------------------------------------------------------------------------------------------------
         Callsite                           | Total_alloc/Per | Total_req/Per   | Hit      | Ping-pong | Frag
        ------------------------------------------------------------------------------------------------------
         radeon_cs_parser_init.part.1+11a   |      2080/260   |      1504/188   |        8 |        0 | 27.692%
         radeon_cs_parser_init.part.1+e1    |       384/96    |       288/72    |        4 |        0 | 25.000%
         radeon_cs_parser_init.part.1+93    |       128/32    |        96/24    |        4 |        0 | 25.000%
         load_elf_binary+a39                |       512/512   |       392/392   |        1 |        0 | 23.438%
         __alloc_skb+89                     |      6144/877   |      4800/685   |        7 |        6 | 21.875%
         radeon_fence_emit+5c               |      1152/192   |       912/152   |        6 |        0 | 20.833%
         radeon_cs_parser_relocs+ad         |      8192/2048  |      6624/1656  |        4 |        0 | 19.141%
         radeon_sa_bo_new+78                |      1280/64    |      1120/56    |       20 |        0 | 12.500%
         load_elf_binary+2c4                |        32/32    |        28/28    |        1 |        0 | 12.500%
         anon_vma_prepare+101               |       576/72    |       512/64    |        8 |        0 | 11.111%
         ...                                | ...             | ...             | ...    | ...      | ...
        ------------------------------------------------------------------------------------------------------
      
      After:
      
        ---------------------------------------------------------------------------------------------------------
         Callsite                           | Total_alloc/Per | Total_req/Per   | Hit      | Ping-pong | Frag
        ---------------------------------------------------------------------------------------------------------
         radeon_cs_parser_init.part.1+11a   |      2080/260   |      1504/188   |        8 |         0 | 27.692%
         radeon_cs_parser_init.part.1+e1    |       384/96    |       288/72    |        4 |         0 | 25.000%
         radeon_cs_parser_init.part.1+93    |       128/32    |        96/24    |        4 |         0 | 25.000%
         load_elf_binary+a39                |       512/512   |       392/392   |        1 |         0 | 23.438%
         __alloc_skb+89                     |      6144/877   |      4800/685   |        7 |         6 | 21.875%
         radeon_fence_emit+5c               |      1152/192   |       912/152   |        6 |         0 | 20.833%
         radeon_cs_parser_relocs+ad         |      8192/2048  |      6624/1656  |        4 |         0 | 19.141%
         radeon_sa_bo_new+78                |      1280/64    |      1120/56    |       20 |         0 | 12.500%
         load_elf_binary+2c4                |        32/32    |        28/28    |        1 |         0 | 12.500%
         anon_vma_prepare+101               |       576/72    |       512/64    |        8 |         0 | 11.111%
         ...                                | ...             | ...             | ...      | ...       | ...
        ---------------------------------------------------------------------------------------------------------
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Joonsoo Kim <js1304@gmail.com>
      Cc: Minchan Kim <minchan@kernel.org>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Link: http://lkml.kernel.org/r/1426145571-3065-4-git-send-email-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      65f46e02
    • Namhyung Kim's avatar
      perf kmem: Allow -v option · bd72a33e
      Namhyung Kim authored
      Current perf kmem fails when -v option is used.  As it's very useful for
      debugging, let's allow it.
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Joonsoo Kim <js1304@gmail.com>
      Cc: Minchan Kim <minchan@kernel.org>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Link: http://lkml.kernel.org/r/1426145571-3065-3-git-send-email-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      bd72a33e
    • Namhyung Kim's avatar
      perf kmem: Fix segfault when invalid sort key is given · 405f8755
      Namhyung Kim authored
      When it tries to free 'str', it was already updated by strsep() - so it
      needs to save the original pointer.
      
        # perf kmem stat -s xxx,hit
          Error: Unknown --sort key: 'xxx'
        *** Error in `perf': free(): invalid pointer: 0x0000000000e9e7b6 ***
        ======= Backtrace: =========
        /usr/lib/libc.so.6(+0x7198e)[0x7fc7e6e0d98e]
        /usr/lib/libc.so.6(+0x76dee)[0x7fc7e6e12dee]
        /usr/lib/libc.so.6(+0x775cb)[0x7fc7e6e135cb]
        ./perf[0x44a1b5]
        ./perf[0x490b20]
        ./perf(parse_options_step+0x173)[0x491773]
        ./perf(parse_options_subcommand+0xa7)[0x491fb7]
        ./perf(cmd_kmem+0x2bc)[0x44ae4c]
        ./perf[0x47aa13]
        ./perf(main+0x60a)[0x427a9a]
        /usr/lib/libc.so.6(__libc_start_main+0xf0)[0x7fc7e6dbc800]
        ./perf(_start+0x29)[0x427bb9]
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Joonsoo Kim <js1304@gmail.com>
      Cc: Minchan Kim <minchan@kernel.org>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Link: http://lkml.kernel.org/r/1426145571-3065-2-git-send-email-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      405f8755
    • Andi Kleen's avatar
      perf stat: Always correctly indent ratio column · 79103528
      Andi Kleen authored
      When cycles or instructions do not print anything, as in being,
      --per-socket or --per-core modi, the ratio column was not correctly
      indented for them. This lead to some ratios not lining up with the
      others. Always indent correctly when nothing is printed.
      Signed-off-by: default avatarAndi Kleen <ak@linux.intel.com>
      Link: http://lkml.kernel.org/r/1426087682-22765-3-git-send-email-andi@firstfloor.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      79103528
    • Andi Kleen's avatar
      perf stat: Fix IPC and other formulas with -A · 56f0fd45
      Andi Kleen authored
      perf stat didn't compute the IPC and other formulas for individual CPUs
      with -A. Fix this for the easy -A case. As before, --per-core and
      --per-socket do not handle it, they simply print nothing.
      Signed-off-by: default avatarAndi Kleen <ak@linux.intel.com>
      Link: http://lkml.kernel.org/r/1426087682-22765-2-git-send-email-andi@firstfloor.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      56f0fd45
    • Andi Kleen's avatar
      perf stat: Output running time and run/enabled ratio in CSV mode · d73515c0
      Andi Kleen authored
      The information how much a counter ran in 'perf stat' can be quite
      interesting for other tools to judge how trustworthy a measurement is.
      
      Currently it is only output in non CSV mode.
      
      This patches make perf stat always output the running time and the
      enabled/running ratio in CSV mode.
      
      This adds two new fields at the end for each line. I assume that
      existing tools ignore new fields at the end, so it's on by default.
      
      Only CSV mode is affected, no difference otherwise.
      
      v2: Add extra print_running function
      v3: Avoid printing nan
      v4: Remove some elses and add brackets.
      v5: Move non CSV case into print_running
      Signed-off-by: default avatarAndi Kleen <ak@linux.intel.com>
      Reviewed-by: default avatarJiri Olsa <jolsa@redhat.com>
      Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Link: http://lkml.kernel.org/r/1426083387-17006-1-git-send-email-andi@firstfloor.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      d73515c0
  6. 12 Mar, 2015 14 commits
    • He Kuang's avatar
      perf hists browser: Fix UI bug after fold/unfold · 4fabf3d1
      He Kuang authored
      In perf hists browser, the fold/unfold stat of each hist entry is
      recorded but hb->nr_callchain_rows loses its value after zoom out and
      zoom in back. This causes a wrong row cursor range that restrict user to
      move down anymore.
      
      This bug can be reproduced as follows:
      
        $ perf record -g -e syscalls:* ls
        $ perf report
      
          Available samples
        ================================================================
          2 syscalls:sys_enter_mprotect <= [enter one of the entries]
          2 syscalls:sys_exit_mprotect
          13 syscalls:sys_enter_brk
          ...
      
      In the hists brower, unfold some of the items, now the cursor can reach
      to any rows:
      
          Children      Self  Command  Shared Object          Symbol
        ================================================================
        -  100.00%   100.00%  ls       libuClibc-0.9.33.2.so  [.] lstat64
        - lstat64
             16.67% 0x6469702e64
             8.33% 0x646970
             8.33% 0x617461
             8.33% 0x65
        -   16.67%     0.00%  ls       [unknown]              [.]0x6469702e64
           0x6469702e64 <= [cursor can reach to bottom line, everything is ok]
      
      Now, zoom back to "Available samples" and enter again:
      
          Children      Self  Command  Shared Object          Symbol
        ================================================================
        -  100.00%   100.00%  ls       libuClibc-0.9.33.2.so  [.] lstat64
        - lstat64
             16.67% 0x6469702e64
             8.33% 0x646970
             8.33% 0x617461 <= [cursor may stop here, can't move down anymore]
             8.33% 0x65
        -   16.67%     0.00%  ls       [unknown]              [.]0x6469702e64
           0x6469702e64
      
      This patch recalculates hb->nr_callchain_rows to fix the bug.
      Signed-off-by: default avatarHe Kuang <hekuang@huawei.com>
      Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Wang Nan <wangnan0@huawei.com>
      Link: http://lkml.kernel.org/r/1426144909-18951-1-git-send-email-hekuang@huawei.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      4fabf3d1
    • David Ahern's avatar
      perf probe: Fix compiles due to declarations using perf_probe_point · 6d4a4896
      David Ahern authored
      perf fails to build with gcc "(GCC) 4.4.7 20120313 (Red Hat
      4.4.7-4.0.9)" (a.k.a., RHEL6 / CentOS 6 / OL 6):
      
        cc1: warnings being treated as errors
        util/probe-event.c: In function ‘get_alternative_line_range’:
        util/probe-event.c:359: error: missing initializer
        util/probe-event.c:359: error: (near initialization for ‘pp.file’)
        util/probe-event.c:359: error: missing initializer
        util/probe-event.c:359: error: (near initialization for ‘result.function’)
      
      Fix by bringing in initializers to declaration.
      Signed-off-by: default avatarDavid Ahern <david.ahern@oracle.com>
      Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
      Link: http://lkml.kernel.org/r/1426084580-60780-1-git-send-email-david.ahern@oracle.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      6d4a4896
    • He Kuang's avatar
      perf hists browser: Fix UI bug after zoom into thread/dso/symbol · a8cd1f43
      He Kuang authored
      When zoom into thread/dso/symbol, the fold/unfold stat is cleared in
      hists__filter_by_thread/dso/symbol(), but h->nr_rows is not cleared. So
      if we toggle fold stat on the unfold entires, nr_entries got a wrong
      value.
      
      This bug can be reproduced as follows:
      
      $ perf record -g -e syscalls:sys_enter_open ls
      $ perf report
      
          Children      Self  Command  Shared Object            Symbol
        ================================================================
        +   50.00%     0.00%  ls       ld64.so  [.]  _dl_get_ready_to_run
        -   50.00%     0.00%  ls       ld64.so  [.]  _dl_load_shared_library
            _dl_load_shared_library <= [Zoom into thread/dso]
            _dl_get_ready_to_run
            _start
        ...
      
      In the new thread hists, all entries reset to fold, if we unfold the
      same entry as we previously unfolded, nr_entries got wrong value, and we
      can't move down cursor to bottom row.
      
                                                               Thread: ls
          Children      Self  Command  Shared Object            Symbol
        ================================================================
        +   50.00%     0.00%  ls       ld64.so  [.]  _dl_get_ready_to_run
        -   50.00%     0.00%  ls       ld64.so  [.]  _dl_load_shared_library
            _dl_load_shared_library
            _dl_get_ready_to_run <= [cursor may stop here, can't move down]
            _start
        ...
      
      This patch clear h->nr_rows to fix this bug.
      Signed-off-by: default avatarHe Kuang <hekuang@huawei.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Wang Nan <wangnan0@huawei.com>
      Link: http://lkml.kernel.org/r/1426077363-855-2-git-send-email-hekuang@huawei.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      a8cd1f43
    • He Kuang's avatar
      perf probe: Fix possible double free on error · a78604de
      He Kuang authored
      A double free occurred when get source file path failed. If lr->path
      failed to assign a new value, it will be freed as the old path and then
      be freed again during line_range__clear(), and causes this:
      
        $ perf probe -L do_execve -k vmlinux
        *** Error in `/usr/bin/perf': double free or corruption (fasttop):
            0x0000000000a9ac50 ***
        ======= Backtrace: =========
        ../lib64/libc.so.6(+0x6eeef)[0x7ffff5e44eef]
        ../lib64/libc.so.6(+0x78cae)[0x7ffff5e4ecae]
        ../lib64/libc.so.6(+0x79987)[0x7ffff5e4f987]
        ../bin/perf[0x4ab41f]
        ...
      
      This patch fix this problem.
      Signed-off-by: default avatarHe Kuang <hekuang@huawei.com>
      Acked-by: default avatarMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Wang Nan <wangnan0@huawei.com>
      Link: http://lkml.kernel.org/r/1425463302-1687-1-git-send-email-hekuang@huawei.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      a78604de
    • Arnaldo Carvalho de Melo's avatar
      perf tools: Output feature detection's gcc output to a file · 443a7054
      Arnaldo Carvalho de Melo authored
      So that we can debug feature detection problems.
      
      It will appear on $(OUTPUT)feature-checks/.make-libbabeltrace.output,
      using the libbabeltrace feature test.
      
      Whole process:
      
        [acme@ssdandy linux]$ make -C tools/perf install-bin
        make: Entering directory `/home/acme/git/linux/tools/perf'
          BUILD:   Doing 'make -j8' parallel build
        config/Makefile:425: No libunwind found. Please install libunwind-dev[el] >= 1.1 and/or set LIBUNWIND_DIR
        config/Makefile:709: No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev
      
        Auto-detecting system features:
        ...                         dwarf: [ on  ]
        ...                         glibc: [ on  ]
        ...                          gtk2: [ on  ]
        ...                      libaudit: [ on  ]
        ...                        libbfd: [ on  ]
        ...                        libelf: [ on  ]
        ...                       libnuma: [ on  ]
        ...                       libperl: [ on  ]
        ...                     libpython: [ on  ]
        ...                      libslang: [ on  ]
        ...                     libunwind: [ OFF ]
        ...            libdw-dwarf-unwind: [ on  ]
        ...                 libbabeltrace: [ OFF ]
        <SNIP>
        [acme@ssdandy linux]$ find tools/perf -name ".make-*.output" | grep lib | tail -5
        tools/perf/config/feature-checks/.make-libdw-dwarf-unwind.output
        tools/perf/config/feature-checks/.make-libbabeltrace.output
        tools/perf/config/feature-checks/.make-zlib.output
        tools/perf/config/feature-checks/.make-liberty.output
        tools/perf/config/feature-checks/.make-liberty-z.output
        [acme@ssdandy linux]$
        [acme@ssdandy linux]$ cat tools/perf/config/feature-checks/.make-libbabeltrace.output
        make[1]: Entering directory `/home/acme/git/linux/tools/perf/config/feature-checks'
        gcc -MD  -Wall -Werror -o test-libbabeltrace.bin test-libbabeltrace.c -Wl,-z,noexecstack  -lbabeltrace-ctf # -lbabeltrace provided by
        test-libbabeltrace.c:2:42: fatal error: babeltrace/ctf-writer/writer.h: No such file or directory
          #include <babeltrace/ctf-writer/writer.h>
                                                ^
        compilation terminated.
        make[1]: *** [test-libbabeltrace.bin] Error 1
        make[1]: Leaving directory `/home/acme/git/linux/tools/perf/config/feature-checks'
        [acme@ssdandy linux]$
      
      So the libbabeltrace feature will not be builtin, but if we do what is required for it
      to be built, namely point where we have it installed:
      
        [acme@ssdandy linux]$ time make -C tools/perf LIBBABELTRACE_DIR=/opt/libbabeltrace install-bin
        make: Entering directory `/home/acme/git/linux/tools/perf'
          BUILD:   Doing 'make -j8' parallel build
        config/Makefile:425: No libunwind found. Please install libunwind-dev[el] >= 1.1 and/or set LIBUNWIND_DIR
      
        Auto-detecting system features:
        ...                         dwarf: [ on  ]
        ...                         glibc: [ on  ]
        ...                          gtk2: [ on  ]
        ...                      libaudit: [ on  ]
        ...                        libbfd: [ on  ]
        ...                        libelf: [ on  ]
        ...                       libnuma: [ on  ]
        ...                       libperl: [ on  ]
        ...                     libpython: [ on  ]
        ...                      libslang: [ on  ]
        ...                     libunwind: [ OFF ]
        ...            libdw-dwarf-unwind: [ on  ]
        ...                 libbabeltrace: [ on  ]
        ...                          zlib: [ on  ]
        ...     DWARF post unwind library: libdw
        <SNIP>
        [acme@ssdandy linux]$ find tools/perf -name ".make-libbabel*.output" | grep lib | tail -5
        tools/perf/config/feature-checks/.make-libbabeltrace.output
        [acme@ssdandy linux]$ cat tools/perf/config/feature-checks/.make-libbabeltrace.output
        make[1]: Entering directory `/home/acme/git/linux/tools/perf/config/feature-checks'
        gcc -MD -I/opt/libbabeltrace/include -Wall -Werror -o test-libbabeltrace.bin test-libbabeltrace.c -Wl,-z,noexecstack -L/opt/libbabeltrace/lib -lbabeltrace-ctf # -lbabeltrace provided by
        make[1]: Leaving directory `/home/acme/git/linux/tools/perf/config/feature-checks'
        [acme@ssdandy linux]$
      Acked-by: default avatarJiri Olsa <jolsa@kernel.org>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jeremie Galarneau <jgalar@efficios.com>
      Cc: Namhyung Kim <namhyung@gmail.com>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
      Cc: Tom Zanussi <tzanussi@gmail.com>
      Cc: Wang Nan <wangnan0@huawei.com>
      Link: http://lkml.kernel.org/n/tip-h53xwueqwdeeiqcv9f50nqqb@git.kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      443a7054
    • Jiri Olsa's avatar
      perf build: Fix libbabeltrace detection · 19a9df35
      Jiri Olsa authored
      Following patch added -Werror for feature builds:
      
        b49f1a4b perf tools: Improve feature test debuggability
      
      and exposed a problem in the libbabeltrace feature build, because it was
      including wrong header and gcc couldn't find the used symbol definition.
      
      Adding proper header and keeping the old one as it is needed also
      (libbabeltrace quirk).
      Reported-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jeremie Galarneau <jgalar@efficios.com>
      Cc: Namhyung Kim <namhyung@gmail.com>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
      Cc: Tom Zanussi <tzanussi@gmail.com>
      Cc: Wang Nan <wangnan0@huawei.com>
      Link: http://lkml.kernel.org/r/20150310120035.GA4333@krava.redhat.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      19a9df35
    • Namhyung Kim's avatar
      perf probe: Allow weak symbols to be probed · e578da3b
      Namhyung Kim authored
      It currently prevents adding probes in weak symbols.  But there're cases
      that given name is an only weak symbol so that we cannot add probe.
      
        $ perf probe -x /usr/lib/libc.so.6 -a calloc
        Failed to find symbol calloc in /usr/lib/libc-2.21.so
          Error: Failed to add events.
      
        $ nm /usr/lib/libc.so.6 | grep calloc
        000000000007b1f0 t __calloc
        000000000007b1f0 T __libc_calloc
        000000000007b1f0 W calloc
      
      This change will result in duplicate probes when strong and weak symbols
      co-exist in a binary.  But I think it's not a big problem since probes
      at the weak symbol will never be hit anyway.
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Naohiro Aota <naota@elisp.net>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: http://lkml.kernel.org/r/20150306073129.6904.41078.stgit@localhost.localdomainSigned-off-by: default avatarMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      e578da3b
    • Namhyung Kim's avatar
      perf symbols: Allow symbol alias when loading map for symbol name · 680d926a
      Namhyung Kim authored
      When perf probe tries to add a probe in a binary using symbol name, it
      sometimes failed since some symbols were discard during loading dso.
      
      When it resolves an address to symbol, it'd be better to have just one
      symbol at given address.  But for finding address from symbol, it'd be
      better to keep all names (including aliases).
      
      So allow tools to state that they want to allow aliases via
      symbol_conf.allow_aliases.
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Acked-by: default avatarMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Naohiro Aota <naota@elisp.net>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: http://lkml.kernel.org/r/20150306073127.6904.3232.stgit@localhost.localdomain
      [ Original patch passwd allow_alias to many functions, use symbol_conf.allow_aliases instead ]
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      680d926a
    • Masami Hiramatsu's avatar
      Revert "perf probe: Fix to fall back to find probe point in symbols" · 0687eba7
      Masami Hiramatsu authored
      This reverts commit 906451b9 ("perf probe: Fix to fall back to find probe point in symbols").
      
      Since 'perf probe' now retries with the address of given symbol searched from
      map before this path, this fall back routine isn't needed anymore.
      Signed-off-by: default avatarMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Naohiro Aota <naota@elisp.net>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: http://lkml.kernel.org/r/20150306073124.6904.1751.stgit@localhost.localdomainSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      0687eba7
    • Masami Hiramatsu's avatar
      perf probe: Fix --line to handle aliased symbols in glibc · 811dd2ae
      Masami Hiramatsu authored
      Fix perf probe --line to handle aliased symbols correctly in glibc.
      
      This makes line_range search failing back to address-based alternative
      search as same as --add and --vars.
      
      Without this patch;
        -----
        # ./perf probe -x /usr/lib64/libc-2.17.so -L malloc
        Specified source line is not found.
          Error: Failed to show lines.
        -----
      
      With this patch;
        -----
        # ./perf probe -x /usr/lib64/libc-2.17.so -L malloc
        <__libc_malloc@/usr/src/debug/glibc-2.17-c758a686/malloc/malloc.c:0>
              0  __libc_malloc(size_t bytes)
              1  {
                   mstate ar_ptr;
                   void *victim;
      
                   __malloc_ptr_t (*hook) (size_t, const __malloc_ptr_t)
              6      = force_reg (__malloc_hook);
              7    if (__builtin_expect (hook != NULL, 0))
              8      return (*hook)(bytes, RETURN_ADDRESS (0));
      
             10    arena_lookup(ar_ptr);
      
             12    arena_lock(ar_ptr, bytes);
        -----
      
      Note that this actually shows __libc_malloc, since it is the real
      instance of malloc. User can use both __libc_malloc and malloc for
      --line.
      Signed-off-by: default avatarMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
      Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Naohiro Aota <naota@elisp.net>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: http://lkml.kernel.org/r/20150306073122.6904.18540.stgit@localhost.localdomainSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      811dd2ae
    • Masami Hiramatsu's avatar
      perf probe: Fix to handle aliased symbols in glibc · 9b118aca
      Masami Hiramatsu authored
      Fix perf probe to handle aliased symbols correctly in glibc.  In the
      glibc, several symbols are defined as an alias of __libc_XXX, e.g.
      malloc is an alias of __libc_malloc.
      
      In such cases, dwarf has no subroutine instances of the alias functions
      (e.g. no "malloc" instance), but the map has that symbol and its
      address.
      
      Thus, if we search the alieased symbol in debuginfo, we always fail to
      find it, but it is in the map.
      
      To solve this problem, this fails back to address-based alternative
      search, which searches the symbol in the map, translates its address to
      alternative (correct) function name by using debuginfo, and retry to
      find the alternative function point from debuginfo.
      
      This adds fail-back process to --vars, --lines and --add options. So,
      now you can use those on malloc@libc :)
      
      Without this patch;
        -----
        # ./perf probe -x /usr/lib64/libc-2.17.so -V malloc
        Failed to find the address of malloc
          Error: Failed to show vars.
        # ./perf probe -x /usr/lib64/libc-2.17.so -a "malloc bytes"
        Probe point 'malloc' not found in debuginfo.
          Error: Failed to add events.
        -----
      
      With this patch;
        -----
        # ./perf probe -x /usr/lib64/libc-2.17.so -V malloc
        Available variables at malloc
                @<__libc_malloc+0>
                        size_t  bytes
        # ./perf probe -x /usr/lib64/libc-2.17.so -a "malloc bytes"
        Added new event:
          probe_libc:malloc    (on malloc in /usr/lib64/libc-2.17.so with bytes)
      
        You can now use it in all perf tools, such as:
      
                perf record -e probe_libc:malloc -aR sleep 1
        -----
      Reported-by: default avatarArnaldo Carvalho de Melo <acme@kernel.org>
      Signed-off-by: default avatarMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Naohiro Aota <naota@elisp.net>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: http://lkml.kernel.org/r/20150306073120.6904.13779.stgit@localhost.localdomainSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      9b118aca
    • Arnaldo Carvalho de Melo's avatar
      perf ordered_events: Adopt queue() method · 4a6b362f
      Arnaldo Carvalho de Melo authored
      From perf_session, will be used in 'trace'.
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Borislav Petkov <bp@suse.de>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Don Zickus <dzickus@redhat.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-mfihndzaumx44h6y37ng2irb@git.kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      4a6b362f
    • Jiri Olsa's avatar
      perf tools: Remove superfluous thread->comm_set setting · 01fbc1fe
      Jiri Olsa authored
      It is set by calling thread__set_comm right before the removed line.
      Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/r/1425396581-17716-2-git-send-email-jolsa@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      01fbc1fe
    • Arnaldo Carvalho de Melo's avatar
      perf tools: tool->finished_round() doesn't need perf_session · d704ebda
      Arnaldo Carvalho de Melo authored
      It is all about flushing the ordered queue or piping it thru, no need
      for a perf_session pointer.
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Borislav Petkov <bp@suse.de>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Don Zickus <dzickus@redhat.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-g47fx3ys0t9271cp0dcabjc7@git.kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      d704ebda