- 08 Jun, 2014 5 commits
-
-
Nick Dyer authored
The patch e57a66aa: "Input: atmel_mxt_ts - read and report bootloader version" from May 18, 2014, leads to the following static checker warning: drivers/input/touchscreen/atmel_mxt_ts.c:437 mxt_get_bootloader_version() warn: signedness bug returning '(-5)' drivers/input/touchscreen/atmel_mxt_ts.c 429 static u8 mxt_get_bootloader_version(struct mxt_data *data, u8 val) 430 { 431 struct device *dev = &data->client->dev; 432 u8 buf[3]; 433 434 if (val & MXT_BOOT_EXTENDED_ID) { 435 if (mxt_bootloader_read(data, &buf[0], 3) != 0) { 436 dev_err(dev, "%s: i2c failure\n", __func__); 437 return -EIO; ^^^^ This gets truncated into a number from 0-255 and anyway the caller doesn't check for errors. (reported by Dan Carpenter) Signed-off-by:
Nick Dyer <nick.dyer@itdev.co.uk> Signed-off-by:
Dmitry Torokhov <dmitry.torokhov@gmail.com>
-
Sachin Kamat authored
Let's start checking return value of regulator_enable and pwm_enable to avoid errors. Fixes the following warning: drivers/input/misc/max8997_haptic.c:185:19: warning: ignoring return value of ‘regulator_enable’, declared with attribute warn_unused_result [-Wunused-result] Signed-off-by:
Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by:
-
Hans de Goede authored
The touchpad on the GIGABYTE U2442 not only stops communicating when we try to set bit 3 (enable real hardware resolution) of reg_10, but on some BIOS versions also when we set bit 1 (enable two finger mode auto correct). I've asked the original reporter of: https://bugzilla.kernel.org/show_bug.cgi?id=61151 To check that not setting bit 1 does not lead to any adverse effects on his model / BIOS revision, and it does not, so this commit fixes the touchpad not working on these versions by simply never setting bit 1 for laptop models with the no_hw_res quirk. Reported-and-tested-by:
James Lademann <jwlademann@gmail.com> Tested-by:
Philipp Wolfer <ph.wolfer@gmail.com> Cc: stable@vger.kernel.org Signed-off-by:
Hans de Goede <hdegoede@redhat.com> Signed-off-by:
-
Hans de Goede authored
At least the Dell Vostro 5470 elantech *clickpad* reports right button clicks when clicked in the right bottom area: https://bugzilla.redhat.com/show_bug.cgi?id=1103528 This is different from how (elantech) clickpads normally operate, normally no matter where the user clicks on the pad the pad always reports a left button event, since there is only 1 hardware button beneath the path. It looks like Dell has put 2 buttons under the pad, one under each bottom corner, causing this. Since this however still clearly is a real clickpad hardware-wise, we still want to report it as such to userspace, so that things like finger movement in the bottom area can be properly ignored as it should be on clickpads. So deal with this weirdness by simply mapping a right click to a left click on elantech clickpads. As an added advantage this is something which we can simply do on all elantech clickpads, so no need to add special quirks for this weird model. Reported-and-tested-by:
Elder Marco <eldermarco@gmail.com> Cc: stable@vger.kernel.org Signed-off-by:
-
Robert Woerle authored
The driver sends 3 bytes instead of 2 when accessing a register on the M09 firmware, so writing to gain seems to overflow into the offset register. Signed-off-by:
Robert Woerle <robert@linuxdevelopment.de> Acked-By:
Simon Budig <simon.budig@kernelconcepts.de> Signed-off-by:
-
- 29 May, 2014 20 commits
-
-
Joachim Eastwood authored
This is unused since all users (OMAP4/5) are DT only. Signed-off-by:
Joachim Eastwood <manabian@gmail.com> Signed-off-by:
-
Joachim Eastwood authored
This has been unused since omap4 board files went away. Signed-off-by:
Tony Lindgren <tony@atomide.com> Signed-off-by:
-
Himangi Saraogi authored
Let's switch the driver to use managed resources, this will simplify error handling and driver unbinding logic. Signed-off-by:
Himangi Saraogi <himangi774@gmail.com> Acked-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Himangi Saraogi authored
Let's switch the driver to use managed resources, this will simplify error handling and driver unbinding logic. Signed-off-by:
-
Himangi Saraogi authored
Let's switch the driver to use managed resources, this will simplify error handling and driver unbinding logic. Signed-off-by:
-
Himangi Saraogi authored
Let's switch the driver to use managed resources, this will simplify error handling and driver unbinding logic. Signed-off-by:
-
Himangi Saraogi authored
Let's switch the driver to use managed resources, this will simplify error handling and driver unbinding logic. Signed-off-by:
-
Ping Cheng authored
New Cintiq tablets have a 200 tablet counts outside of screen area. Add x/y_min for ABS_X/Y to pass this information to userland. Signed-off-by:
Ping Cheng <pingc@wacom.com> Reviewed-by:
Jason Gerecke <killertofu@gmail.com> Tested-by:
-
Ping Cheng authored
Signed-off-by:
-
Sebastian Reichel authored
This adds support for the tsc2005 touchscreen to the Nokia N900 DTS file. Signed-off-by:
Sebastian Reichel <sre@kernel.org> Acked-by:
-
Sebastian Reichel authored
This adds DT support to the tsc2005 touchscreen driver. It also adds regulator support to the driver if booted via DT. Reviewed-by:
Pavel Machek <pavel@ucw.cz> Acked-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
-
Sebastian Reichel authored
Add common DT binding documentation for touchscreen devices and implement input_parse_touchscreen_of_params, which parses the common properties and configures the input device accordingly. The method currently does not interpret the axis inversion properties, since there is no matching flag in the generic linux input device. Reviewed-by:
-
Himangi Saraogi authored
Let's switch the driver to use managed resources, this will simplify error handling and driver unbinding logic. Signed-off-by:
-
Himangi Saraogi authored
Let's switch the driver to use managed resources, this will simplify error handling and driver unbinding logic. Signed-off-by:
-
Himangi Saraogi authored
Let's switch the driver to use managed resources, this will simplify error handling and allows us to get rid of da9034_touch_remove(). Signed-off-by:
-
Beomho Seo authored
Let's switch the driver to use managed resources, this will simplify error handling and driver unbinding logic. Signed-off-by:
Beomho Seo <beomho.seo@samsung.com> Signed-off-by:
-
Beomho Seo authored
This patch fix a typo error in MELFAS MCS-5000 controller driver. Signed-off-by:
-
Beomho Seo authored
This patch fix a typo error in mms114 touchscreen driver. Signed-off-by:
-
Beomho Seo authored
This patch fix a typo error in MELFAS 5000/5080 controller driver. Signed-off-by:
-
Sachin Kamat authored
input.h was included twice. Signed-off-by:
-
- 27 May, 2014 4 commits
-
-
Nick Dyer authored
Signed-off-by:
Benson Leung <bleung@chromium.org> Acked-by:
Yufeng Shen <miletus@chromium.org> Signed-off-by:
-
Nick Dyer authored
This avoids confusion with the newer T100 touchscreen object. Signed-off-by:
-
Nick Dyer authored
Signed-off-by:
-
Nick Dyer authored
By reading the touchscreen configuration from the settings that the maXTouch chip is actually using, we can remove some platform data. The matrix size is not used for anything, and results in some rather confusing code to re-read it because it may change when configuration is downloaded, so don't print it out. Signed-off-by:
-
- 19 May, 2014 11 commits
-
-
Nick Dyer authored
Atmel supplies firmware files in ASCII HEX format (.enc) which must be converted before they can be loaded by kernel driver. Try to detect the error and print a friendly error message rather than feeding junk to the bootloader. Signed-off-by:
-
Nick Dyer authored
By implementing a frame counter, print out fewer debug messages (the firmware may contain hundreds of frames). Signed-off-by:
-
Nick Dyer authored
Signed-off-by:
-
Nick Dyer authored
Signed-off-by:
-
Nick Dyer authored
Move bootloaders reads/writes into separate functions. Instead of switching client->addr, define new field bootloader_addr in mxt_data. Implement lookup calculation for bootloader addresses. Signed-off-by:
-
Nick Dyer authored
The configuration is stored in NVRAM on the maXTouch chip. When the device is reset it reports a CRC of the stored configuration values. Therefore it isn't necessary to send the configuration on each probe - we can check the CRC matches and avoid a timeconsuming backup/reset cycle. Signed-off-by:
-
Nick Dyer authored
- Add error messages for probe errors - Report type in invalid object type - Tweak some other debug output messages Signed-off-by:
-
Iiro Valkonen authored
The delay before the chip can be accessed after reset varies between different chips in maXTouch family. Waiting for an interrupt and a T6 status message with the RESET bit set is a better behaviour. Signed-off-by:
-
Benson Leung authored
Rather than msleep for MXT_RESET_TIME and MXT_FWRESET_TIME during the transition to bootloader mode and the transition back from app, wait for the CHG assert to indicate that the transition is done. This change replaces the msleep with a wait for completion that the mxt_interrupt handler signals. Also add CHG poll after last firmware frame - some bootloader versions will assert the interrupt line after the final frame, in testing this meant that the driver attempts to read the info block too early whilst the chip is still resetting. This improves firmware update time as we no longer wait longer than necessary for each reset. Signed-off-by:
Daniel Kurtz <djkurtz@chromium.org> Signed-off-by:
-
Benson Leung authored
The driver should not immediately read bootloader status when in Application Update Mode. The CHG line will assert when the device has made a state transition and is ready to report a new status via i2c. This change adds a wait for completion in mxt_check_bootloader, and changes the mxt_interrupt handler to signal the completion. Signed-off-by:
-
Nick Dyer authored
Signed-off-by:
-
