- 16 Oct, 2019 4 commits
-
-
Anson Huang authored
i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller inside, the system controller is in charge of controlling power, clock and scu key etc.. Adds i.MX system controller key driver support, Linux kernel has to communicate with system controller via MU (message unit) IPC to get scu key's status. Signed-off-by:
Anson Huang <Anson.Huang@nxp.com> Reviewed-by:
Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/1570412509-7893-2-git-send-email-Anson.Huang@nxp.comSigned-off-by:
Dmitry Torokhov <dmitry.torokhov@gmail.com>
-
Michal Vokáč authored
In case the interrupt line is not available, polling can be used to read out the state of the keys. Period of the polling needs to be configured by the poll-interval DT property. Signed-off-by:
Michal Vokáč <michal.vokac@ysoft.com> Reviewed-by:
-
Michal Vokáč authored
Convert the mpr121 binding to DT schema format using json-schema. Signed-off-by:
-
Michal Vokáč authored
Create schema for the common input properties and merge all properties from the Documentation/devicetree/bindings/input/keys.txt binding into this common schema. Signed-off-by:
-
- 09 Oct, 2019 6 commits
-
-
Dmitry Torokhov authored
Previous change moved platform data definition into the driver, making it unusable for users. Given that we want to move away from custom platform data structures, and always use device properties (DT, ACPI or static) to configure devices, let's complete the removal. Tested-by:
Fabio Estevam <festevam@gmail.com> Tested-by:
Roger Quadros <rogerq@ti.com> Signed-off-by:
-
Fabio Estevam authored
In the case of defer probe we should not print an error message. This also aligns with how defer probe is handled in the other GPIOs used by this driver. Signed-off-by:
-
Fabio Estevam authored
The pixcir datasheet lists the registers addresses in decimal and so are PIXCIR_REG_POWER_MODE and PIXCIR_REG_INT_MODE defined in decimal. Change the error messages to print the register addresses in decimal instead of hexadecimal for better readability. Signed-off-by:
-
Fabio Estevam authored
Keep the header files in alphabetical order to keep it more organized. Signed-off-by:
-
Fabio Estevam authored
All the defined symbols from linux/platform_data/pixcir_i2c_ts.h are only used by the pixcir_i2c_ts driver, so move all the definitions locally and get rid of the pixcir_i2c_ts.h file. Signed-off-by:
-
Fabio Estevam authored
The touchscreen device is a GPIO consumer, not a GPIO controller, so there is no need to include <linux/gpio.h>. Remove the unneeded header file. Signed-off-by:
-
- 04 Oct, 2019 2 commits
-
-
Dmitry Torokhov authored
Now that instances of input_dev support polling mode natively, we no longer need to create input_polled_dev instance. Acked-by:
Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> Signed-off-by:
-
Dmitry Torokhov authored
Some drivers need to be able to know the current polling interval for devices working in polling mode, let's allow them fetching it. Acked-By:
Benjamin Tissoires <benjamin.tissoires@redhat.com> Tested-by:
-
- 02 Oct, 2019 1 commit
-
-
Evan Green authored
Across suspend and resume, we are seeing error messages like the following: atmel_mxt_ts i2c-PRP0001:00: __mxt_read_reg: i2c transfer failed (-121) atmel_mxt_ts i2c-PRP0001:00: Failed to read T44 and T5 (-121) This occurs because the driver leaves its IRQ enabled. Upon resume, there is an IRQ pending, but the interrupt is serviced before both the driver and the underlying I2C bus have been resumed. This causes EREMOTEIO errors. Disable the IRQ in suspend, and re-enable it on resume. If there are cases where the driver enters suspend with interrupts disabled, that's a bug we should fix separately. Signed-off-by:
Evan Green <evgreen@chromium.org> Signed-off-by:
-
- 06 Sep, 2019 2 commits
-
-
Colin Ian King authored
Don't populate the array seq on the stack but instead make it static const. Makes the object code smaller by 30 bytes. Before: text data bss dec hex filename 22284 3184 0 25468 637c drivers/input/joystick/sidewinder.o After: text data bss dec hex filename 22158 3280 0 25438 635e drivers/input/joystick/sidewinder.o (gcc version 9.2.1, amd64) Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Dmitry Torokhov authored
We need to reset input device's timestamp on input_sync(), otherwise drivers not using input_set_timestamp() will end up with a stale timestamp after their clients consume first input event. Fixes: 3b51c44b ("Input: allow drivers specify timestamp for input events") Reported-by:
John Stultz <john.stultz@linaro.org> Signed-off-by:
-
- 02 Sep, 2019 11 commits
-
-
Dmitry Torokhov authored
This switches the driver over to the standard touchscreen properties for coordinate transformation, while keeping old bindings working as well. Tested-by:
Linus Walleij <linus.walleij@linaro.org> Signed-off-by:
-
Dmitry Torokhov authored
MT-B protocol is more efficient and everyone expects it. We use in-kernel tracking to identify contacts. Tested-by:
-
Dmitry Torokhov authored
If the touchscreen is configured as wakeup source we should not be cutting off power to it. Also, now that the driver relies on I2C client to supply IRQ, we do not need to explicitly enable and disable IRQ for wakeup: if device is created as wakeup source, I2C core will mark interrupt as wakeup one. Tested-by:
-
Dmitry Torokhov authored
Instead of trying to map INT GPIO to interrupt, let's use one supplied by I2C client. If there is none - bail. This will also allow us to treat INT GPIO as optional, as per the binding. Tested-by:
-
Dmitry Torokhov authored
There are no current users of the platform data in the tree, and any new users should either use device tree, or static device properties to describe the device. This change drop the platform data definition and handling and moves the driver over to generic device properties API. We also drop support for the external clock. If it is needed we will have to extend the bindings to supply the clock reference and handle it properly in the driver. Also, wakeup setting should be coming from I2C client. Tested-by:
-
Dmitry Torokhov authored
This allows trimming error unwinding and device removal handling. Tested-by:
-
Dmitry Torokhov authored
The comments for individual functions in the driver do not provide any additional information beyond what function names indicate. Tested-by:
-
Dmitry Torokhov authored
Instead if #ifdef-ing out suspend and resume methods, let's mark them as __maybe_unused to get better compile time coverage. Tested-by:
-
Dmitry Torokhov authored
"bu21013_data" and "struct bu21013_ts_data" are a tad long, let's call them "ts" and "struct bu21013_ts". Also rename retval to error in bu21013_init_chip() and adjust formatting; i2c_smbus_write_byte_data() returns negative on error and 0 on success, so we simply test if whether erro is 0 or not. Tested-by:
-
Linus Walleij authored
This driver can use GPIO descriptors rather than GPIO numbers without any problems, convert it. Name the field variables after the actual pins on the chip rather than the "reset" and "touch" names from the devicetree bindings that are vaguely inaccurate. No in-tree users pass GPIO numbers in platform data so drop this. Descriptor tables can be used to get these GPIOs from a board file if need be. Signed-off-by:
-
Dmitry Torokhov authored
In preparation to update to bu21013_tp driver properly annotate GPIOs property (the INT GPIOs are active low, not open drain), and also define interrupt lines so we do not have to have special conversion in the driver. Tested-by:
-
- 29 Aug, 2019 1 commit
-
-
Stephen Boyd authored
We don't know when the device will be added with device_add() in serio_add_port() because serio_add_port() is called from a workqueue that this driver schedules by calling serio_register_port(). The best we can know is that the device will definitely not have been added yet when the start callback is called on the serio device. While it hasn't been shown to be a problem, proactively move the wakeup enabling calls to the start hook so that we don't race with the workqueue calling device_add(). This will avoid racy situations where code tries to add wakeup sysfs attributes for this device from dpm_sysfs_add() but the path in device_set_wakeup_capable() has already done so. Signed-off-by:
Stephen Boyd <swboyd@chromium.org> Signed-off-by:
-
- 20 Aug, 2019 4 commits
-
-
Enrico Weigelt authored
The registration of gpio-keys device can be written much shorter by using the platform_device_register_resndata() helper. Signed-off-by:
Enrico Weigelt <info@metux.net> Signed-off-by:
-
Hui Wang authored
Recently we had a building error if we enable the MOUSE_PS2_ALPS while disable the MOUSE_PS2_TRACKPOINT, and was fixed by 49e6979e ("Input: psmouse - fix build error of multiple definition"). We could improve that fix by dropping all unneeded functions and CONFIG_MOUSE_ guards from the header, it is safe to do that since those functions are not directly called by psmouse-base.c anymore. Signed-off-by:
Hui Wang <hui.wang@canonical.com> Signed-off-by:
-
Dmitry Torokhov authored
Separating "normal" and "polled" input devices was a mistake, as often we want to allow the very same device work on both interrupt-driven and polled mode, depending on the board on which the device is used. This introduces new APIs: - input_setup_polling - input_set_poll_interval - input_set_min_poll_interval - input_set_max_poll_interval These new APIs allow switching an input device into polled mode with sysfs attributes matching drivers using input_polled_dev APIs that will be eventually removed. Tested-by:
-
Jason Gerecke authored
GCC warns that the output of our call to 'snprintf' in 'w8001_connect' may be truncated since both 'serio->phys' and 'w8001->phys' are 32 bytes in length. Increase the amount of space allocated for the latter to compensate. Signed-off-by:
Jason Gerecke <jason.gerecke@wacom.com> Signed-off-by:
-
- 16 Aug, 2019 1 commit
-
-
Fei Shao authored
In the previous patch we didn't mask out event_type in case statement, so switches are always picked instead of buttons, which results in ChromeOS devices misbehaving when power button is pressed. This patch adds back the missing mask. Fixes: d096aa3e ("Input: cros_ec_keyb: mask out extra flags in event_type") Signed-off-by:
Fei Shao <fshao@chromium.org> Reviewed-by:
Nicolas Boichat <drinkcat@chromium.org> Signed-off-by:
-
- 14 Aug, 2019 1 commit
-
-
Stephen Boyd authored
We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // <smpl> @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // </smpl> While we're here, remove braces on if statements that only have one statement (manually). Signed-off-by:
-
- 12 Aug, 2019 7 commits
-
-
Greg Kroah-Hartman authored
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
-
Greg Kroah-Hartman authored
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Signed-off-by:
-
Andy Shevchenko authored
Use use device_property_count_u32() directly, that makes code neater. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by:
-
Andy Shevchenko authored
Use use device_property_count_u32() directly, that makes code neater. Signed-off-by:
-
Andy Shevchenko authored
Use use device_property_count_u32() directly, that makes code neater. Signed-off-by:
-
Andy Shevchenko authored
Use use device_property_count_u32() directly, that makes code neater. Signed-off-by:
-
Greg Kroah-Hartman authored
Drivers now have the option to have the driver core create and remove any needed sysfs attribute files. So take advantage of that and do not register "by hand" a sysfs group of attributes. Signed-off-by:
-
