- 25 Nov, 2014 3 commits
-
-
Tomas Henzl authored
The patch moves an error code assigment to a 'default' case in the previous switch statement. Signed-off-by:
Tomas Henzl <thenzl@redhat.com> Acked-by:
Bradley Grove <bgrove@attotech.com> Signed-off-by:
Christoph Hellwig <hch@lst.de>
-
Tomas Henzl authored
Is seems strange to manipulate nvram_semaphore when in this place, this patch fixes it. Signed-off-by:
-
Tomas Henzl authored
This patch fixes an error path and rearranges error handling. Signed-off-by:
-
- 24 Nov, 2014 26 commits
-
-
Hannes Reinecke authored
The am53c974 is a re-implementation of the tmscsim driver, and provides the same functionality. So remove the tmscsim driver and make am53c974 an alias to tmscsim. Acked-by:
Guennadi Liakhovetski <g.liakhovetski@gmx.de> Signed-off-by:
Hannes Reinecke <hare@suse.de> Signed-off-by:
-
Hannes Reinecke authored
CONFIG2_FENAB ('feature enable') changed definition between chip revisions, from 'Latch SCSI Phase' to 'Latch SCSI Phase, display chip ID upon reset, and enable 24 bit addresses'. So only enable it for am53c974 where we know what it's doing. Acked-by:David S. Miller <davem@davemloft.net> Reviewed-by:
Paolo Bonzini <pbonzini@redhat.com> Signed-off-by:
-
Paolo Bonzini authored
On PCscsi, the FENAB configuration also enables 24-bit DMA transfer lengths (and provides the chip id in TCHI after reset). We want to be able to enable this parameter from the DMA driver. Check if the caller of scsi_esp_register provided a value for esp->config2. If this is the case, assume this is not an ESP100, skip the detection phase and leave esp->config2 untouched. It will be used in esp_reset_esp. Reviewed-by:
-
Hannes Reinecke authored
The am53c974 returns the same ID as the FAS236, but implements things slightly differently. So detect the am53c974 by checking for ESP_CONFIG4 register. Reviewed-by:
-
Hannes Reinecke authored
The am53c974 has an design issue where a single byte might be left in the SCSI FIFO after a DMA transfer. As the handling code is currently untested add a WARN_ON() statement here. Reviewed-by:
-
Hannes Reinecke authored
This patch adds a new implementation for the Tekram DC-390T / AMD AM53c974 SCSI controller, based on the generic esp_scsi infrastructure. Reviewed-by:
-
Hannes Reinecke authored
Using DMA for command submission has the drawback that it might generate additional DMA completion interrupts after the command has been submitted to the device. Additionally the am53c974 has a design flaw causing it to generate spurious interrupts even though DMA completion interrupts are not enabled. This can be avoided by using the FIFO for command submission. Reviewed-by:
-
Hannes Reinecke authored
A read to ESP_INTRPT will clear ESP_STATUS and ESP_SSTEP. So read all status registers in one go to avoid losing information. Reviewed-by:
-
Hannes Reinecke authored
Add new debug definitions for event and command logging. Reviewed-by:
-
Hannes Reinecke authored
Use dev_printk functions for correct device annotations. Reviewed-by:
-
Hannes Reinecke authored
Add a field 'num_tags' to the esp structure to allow drivers to overwrite the number of avialable tags if required. Default is ESP_DEFAULT_TAGS. Reviewed-by:
-
Hannes Reinecke authored
Reviewed-by:
-
Christoph Hellwig authored
Remove overly verbose debugging output that pokes into mid-layer internal structures that looks like copy & paste from the mpt2/3 drivers. Signed-off-by:
Mike Christie <michaelc@cs.wisc.edu> Reviewed-by:
-
Christoph Hellwig authored
Merge two functions, and remove overly verbose debugging output that pokes into mid-layer internal structures. Signed-off-by:
-
Christoph Hellwig authored
Merge two functions, and remove overly verbose debugging output that pokes into mid-layer internal structures. Signed-off-by:
-
Christoph Hellwig authored
Drop the now unused reason argument from the ->change_queue_depth method. Also add a return value to scsi_adjust_queue_depth, and rename it to scsi_change_queue_depth now that it can be used as the default ->change_queue_depth implementation. Signed-off-by:
-
Christoph Hellwig authored
We won't ever queue more commands than the host allows. Instead of letting drivers either reject or ignore this case handle it in common code. Note that various driver use internal constant or variables that are assigned to both shost->can_queue and checked in ->change_queue_depth - I did remove those checks as well. Signed-off-by:
-
Christoph Hellwig authored
All drivers use the implementation for ramping the queue up and down, so instead of overloading the change_queue_depth method call the implementation diretly if the driver opts into it by setting the track_queue_depth flag in the host template. Note that a few drivers validated the new queue depth in their change_queue_depth method, but as we never go over the queue depth set during slave_configure or the sysfs file this isn't nessecary and can safely be removed. Signed-off-by:
Venkatesh Srinivas <venkateshs@google.com>
-
Christoph Hellwig authored
James Smart said the userspace to consume these events never emerged. Given that these get in the way of the following patches remove support for them. Signed-off-by:
James Smart <james.smart@emulex.com>
-
Sumit.Saxena@avagotech.com authored
Do not process any SCSI and IOCTL command further (return them with appropriate return values to callers), while driver removal is in progress or PCI shutdown is invoked. Signed-off-by:
Sumit Saxena <sumit.saxena@avagotech.com> Signed-off-by:
Kashyap Desai <kashyap.desai@avagotech.com> Reviewed-by:
-
Sumit.Saxena@avagotech.com authored
This patch addresses few endianness related bug fixes. Signed-off-by:
-
Sumit.Saxena@avagotech.com authored
Corrected wait_event() call which was waiting for wrong completion status (0xFF). Signed-off-by:
-
Sumit.Saxena@avagotech.com authored
In OCR(Online Controller Reset) path, driver sets adapter state to MEGASAS_HBA_OPERATIONAL before getting new RAID map. There will be a small window where IO will come from OS with old RAID map. This patch will update adapter state to MEGASAS_HBA_OPERATIONAL, only after driver has new RAID map to avoid any IOs getting build using old RAID map. Signed-off-by:
-
Sumit.Saxena@avagotech.com authored
In OCR (Online Controller Reset) path, driver sets adapter state to MEGASAS_HBA_OPERATIONAL before getting new RAID map. There will be a small window where IO will come from OS with old RAID map. This patch will update adapter state to MEGASAS_HBA_OPERATIONAL, only after driver has new RAID map to avoid any IOs getting build using old RAID map. Signed-off-by:
-
Sumit.Saxena@avagotech.com authored
Update MAINTAINERS list and copyright information for megaraid_sas driver. Signed-off-by:
-
Sumit.Saxena@avagotech.com authored
Update driver version and remove some meta data (release date and extended version) about megaraid_sas driver. Signed-off-by:
-
- 20 Nov, 2014 11 commits
-
-
Martin Peschke authored
This patch improves the Fibre Channel port scan behaviour of the zfcp lldd. Without it the zfcp device driver may churn up the storage area network by excessive scanning and scan bursts, particularly in big virtual server environments, potentially resulting in interference of virtual servers and reduced availability of storage connectivity. The two main issues as to the zfcp device drivers automatic port scan in virtual server environments are frequency and simultaneity. On the one hand, there is no point in allowing lots of ports scans in a row. It makes sense, though, to make sure that a scan is conducted eventually if there has been any indication for potential SAN changes. On the other hand, lots of virtual servers receiving the same indication for a SAN change had better not attempt to conduct a scan instantly, that is, at the same time. Hence this patch has a two-fold approach for better port scanning: the introduction of a rate limit to amend frequency issues, and the introduction of a short random backoff to amend simultaneity issues. Both approaches boil down to deferred port scans, with delays comprising parts for both approaches. The new port scan behaviour is summarised best by: NEW: NEW: no_auto_port_rescan random rate flush backoff limit =wait adapter resume/thaw yes yes no yes* adapter online (user) no yes no yes* port rescan (user) no no no yes adapter recovery (user) yes yes yes no adapter recovery (other) yes yes yes no incoming ELS yes yes yes no incoming ELS lost yes yes yes no Implementation is straight-forward by converting an existing worker to a delayed worker. But care is needed whenever that worker is going to be flushed (in order to make sure work has been completed), since a flush operation cancels the timer set up for deferred execution (see * above). There is a small race window whenever a port scan work starts running up to the point in time of storing the time stamp for that port scan. The impact is negligible. Closing that gap isn't trivial, though, and would the destroy the beauty of a simple work-to-delayed-work conversion. Signed-off-by:Martin Peschke <mpeschke@linux.vnet.ibm.com> Signed-off-by:
Steffen Maier <maier@linux.vnet.ibm.com> Reviewed-by:
-
Steffen Maier authored
Through sysfs attributes, zfcp unit objects provide a trigger for manual LUN recovery and export information for problem determination. With commit f8210e34 "[SCSI] zfcp: Allow midlayer to scan for LUNs when running in NPIV mode" and when attaching SCSI devices through this new optional method, no more zfcp unit objects are allocated for such SCSI devices. Hence, the above-mentioned trigger and information were missing. The information and context is located in SCSI transport device data since b62a8d9b "[SCSI] zfcp: Use SCSI device data zfcp_scsi_dev instead of zfcp_unit" 57c23773 "[SCSI] zfcp: Add zfcp private struct as SCSI device driver data" Hence, introduce the trigger and the information unconditionally for all SCSI devices attached through zfcp. We prefix the attribute names with 'zfcp_' to prevent collisions and to avoid mix-ups such as with the common 'state' attribute. Since some of the new attribute views do not need zfcp_port in the ZFCP_DEFINE_SCSI_ATTR helper macro, remove zfcp_port to avoid compiler warnings on unused variable. It's easy to open code the conversion from zfcp_scsi_dev to zfcp_port for the two already existing attributes hba_id and wwpn. Signed-off-by:
-
Fabian Frederick authored
This patch also removes unnecessary printk(KERN_INFO Signed-off-by:
Fabian Frederick <fabf@skynet.be> Acked-by:
Anil Gurumurthy <anil.gurumurthy@qlogic.com> Signed-off-by:
-
Martin Peschke authored
This patch removes some leftovers for commit 663e0890 "[SCSI] zfcp: remove access control tables interface". The "access denied" case for ports is gone, as well. The corresponding flag was cleared, but never set. So clean it up. Sysfs flag is kept, though, for backward-compatibility. Now it returns always 0. Signed-off-by:
-
Ming Lei authored
Since virtio_scsi has supported multi virtqueue already, it is natural to map the virtque to hw-queue of blk-mq. Signed-off-by:
Ming Lei <ming.lei@canonical.com> Reviewed-by:
-
Stephen M. Cameron authored
It is already using atomic test_and_set_bit to do the allocation. There is some microscopic chance of starvation, but it is so microscopic that it should never happen in reality. Signed-off-by:
Don Brace <don.brace@pmcs.com> Reviewed-by:
Webb Scales <webbnh@hp.com> Signed-off-by:
-
Robert Elliott authored
If the kernel is booted with the reset_device parameter, which is done for kdump, then the driver needs to call pci_set_master after pci_enable_device to reenable bus mastering (since the preceding pci_disable_device call disables bus mastering). Also, place that after pci_request_regions both in the kdump code and the normal pci_init code. Remove the comment summarizing what pci_set_master does, with the incomplete commentary on the impact of pci_disable_device. Signed-off-by:
Robert Elliott <elliott@hp.com> Signed-off-by:
-
Nicholas Bellinger authored
There isn't anything in hpsa that requires the host lock to be held during queuecommand. Signed-off-by:
Nicholas Bellinger <nab@linux-iscsi.org> Reviewed-by:
Stephen M. Cameron <stephenmcameron@gmail.com> Signed-off-by:
-
Stephen M. Cameron authored
We were printing a lot of useless information before ultimately just passing things up to the SCSI mid layer. Just let the midlayer handle it without LLD chatter. Signed-off-by:
Joe Handzik <joseph.t.handzik@hp.com> Reviewed-by:
Scott Teel <scott.teel@hp.com> Signed-off-by:
-
Stephen M. Cameron authored
Use atomics for commands_outstanding instead of protecting with spin locks. Signed-off-by:
-
Stephen M. Cameron authored
Using bit fields for hardware command fields isn't portable and relies on assumptions about how the compiler lays out the bits. We can fix this in the driver's internal command structure, but the ioctl interface we can't change because it is part of the userland ABI. Signed-off-by:
Webb Scales <webb.scales@hp.com> Signed-off-by:
-
