- 10 Apr, 2023 14 commits
-
-
Yunfei Dong authored
While the decoder can produce frames in both MM21 and MT21C formats, only MM21 is currently supported by userspace tools (like gstreamer and libyuv). In order to ensure userspace keeps working after the SCP firmware is updated to support both MM21 and MT21C formats, force the MM21 format for the capture queue. This is meant as a stopgap solution while dynamic format switching between MM21 and MT21C isn't implemented in the driver. Fixes: 7501edef ("media: mediatek: vcodec: Different codec using different capture format") Signed-off-by:
Yunfei Dong <yunfei.dong@mediatek.com> Reviewed-by:
Nicolas F. R. A. Prado <nfraprado@collabora.com> Tested-by:
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by:
Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by:
Mauro Carvalho Chehab <mchehab@kernel.org>
-
Yunfei Dong authored
Given that only the MM21 capture format is supported by userspace tools (like gstreamer and libyuv), make it the default capture format. This allows us to force the MM21 format even when a MM21 and MT21C capable firmware is available (which is needed while dynamic format switching isn't implemented in the driver), without causing the following regressions on v4l2-compliance: fail: v4l2-test-formats.cpp(478): pixelformat 3132544d (MT21) for buftype 9 not reported by ENUM_FMT test VIDIOC_G_FMT: FAIL fail: v4l2-test-formats.cpp(478): pixelformat 3132544d (MT21) for buftype 9 not reported by ENUM_FMT test VIDIOC_TRY_FMT: FAIL fail: v4l2-test-formats.cpp(478): pixelformat 3132544d (MT21) for buftype 9 not reported by ENUM_FMT test VIDIOC_S_FMT: FAIL Fixes: 7501edef ("media: mediatek: vcodec: Different codec using different capture format") Signed-off-by: -
Pin-yen Lin authored
After commit b018be06 ("media: mediatek: vcodec: Read max resolution from dec_capability"), the stateful video decoder driver never really sets its output frame size to 4K. Parse the decoder capability reported by the firmware, and update the output frame size in mtk_init_vdec_params to enable 4K frame size when available. Fixes: b018be06 ("media: mediatek: vcodec: Read max resolution from dec_capability") Signed-off-by:
Pin-yen Lin <treapking@chromium.org> Reviewed-by:
-
Yunfei Dong authored
Need to add racing control register base in device node for mt8195 support inner racing mode. Changing the max reg value from 1 to 2. Adding the description for VDEC_SYS and VDEC_MISC. Signed-off-by:
Allen-KH Cheng <allen-kh.cheng@mediatek.com> Acked-by:
Rob Herring <robh@kernel.org> Reviewed-by:
Chen-Yu Tsai <wenst@chromium.org> Tested-by:
-
Yunfei Dong authored
mt8195 and mt8192 have different clock numbers, separate 'clock-names' according to compatible name. Signed-off-by:
-
Allen-KH Cheng authored
Because the decoder nodes already make use of the iommus property to configure the IOMMU for address translations, having a dma-ranges property makes no sense. In fact, after commit f1ad5338 ("of: Fix "dma-ranges" handling for bus controllers"), having a dma-ranges property causes IOMMU faults. Remove the dma-ranges property and update the example. Signed-off-by:
-
Allen-KH Cheng authored
In order to make the names of the child nodes more generic, we rename "vcodec-lat" and "vcodec-core" to "video-codec" for decoder in patternProperties and example. Signed-off-by:
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by:
-
kyrie wu authored
Add a atomic_t variable for initialization of hw dev. Signed-off-by:
kyrie wu <kyrie.wu@mediatek.com> Signed-off-by:
irui wang <irui.wang@mediatek.com> Signed-off-by:
-
kyrie wu authored
Refactor some variables to reduce redundancy and optimize the initialization process. Signed-off-by:
-
kyrie wu authored
remove is_jpgenc_multihw, is_jpgdec_multihw, and unnecessary initialization. Signed-off-by:
-
kyrie wu authored
exclude is_jpgenc_multihw or is_jpgdec_multihw for judgment, and re-initialize jpeg worker. Signed-off-by:
-
kyrie wu authored
1. Move removing buffer after sw setting and before hw setting in enc&dec worker to prevents the operation of removing the buffer twice if the sw setting fails. 2. Remove the redundant operation of queue work in the jpegenc irq handler because the jpegenc worker has called v4l2_m2m_job_finish to do it. Fixes: 5fb1c236 ("mtk-jpegenc: add jpeg encode worker interface") Fixes: dedc2150 ("media: mtk-jpegdec: add jpeg decode worker interface") Signed-off-by:
-
kyrie wu authored
add single core initial function to init reg_base, irq and clk. Signed-off-by:
-
kyrie wu authored
some chips have multi-hw, but others have only one, modify the condition of multi-hw judgement Fixes: 934e8bcc ("mtk-jpegenc: support jpegenc multi-hardware") Signed-off-by:
-
- 20 Mar, 2023 26 commits
-
-
Sakari Ailus authored
VIDEO_V4L2_SUBDEV_API is required for v4l2_subdev_get_pad_*() functions. Select it. Fixes: ("media: i2c: ov2685: Add .get_selection() support") Signed-off-by:Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by:
-
Neil Armstrong authored
Convert the Amlogic Meson IR remote control receiver bindings to dt-schema. Take in account the used variant with amlogic,meson-gx-ir. Reviewed-by:
Martin Blumenstingl <martin.blumenstingl@googlemail.com> Reviewed-by:
Neil Armstrong <neil.armstrong@linaro.org> Signed-off-by:
-
Shravan Chippa authored
Add new supported link frequency in dt example. Acked-by:
Sakari Ailus <sakari.ailus@iki.fi> Signed-off-by:
Shravan Chippa <shravan.chippa@microchip.com> Signed-off-by:
-
Shravan Chippa authored
Some platforms may not be capable of supporting the bandwidth required for 12 bit or 3840x2160@60 resolutions. Add support for dynamically selecting 10 bit and 1920x1080@30 resolutions while leaving the existing configuration as default. Reviewed-by:
Jacopo Mondi <jacopo.mondi@ideasonboard.com> CC: Conor Dooley <conor.dooley@microchip.com> Signed-off-by:
Prakash Battu <Prakash.Battu@microchip.com> Signed-off-by:
-
Shravan Chippa authored
There are some missing reset reg_mode values for the 3840x2160@60 resolution. The camera sensor still works in 3840x2160@60 resolution mode because of the register reset values. This is an issue when we change the modes dynamically. As an example, when we change the mode from 1920x1080@30 resolution to 3840x2160@60 resoultion then the mode values will be written to the registers from the array mode_3840x2160_regs[] which gives the wrong output which is incorrect resolution. So add the missing reset values to the mode_3840x2160_regs[]. Reviewed-by:
-
Shravan Chippa authored
For every mode we will get new set of values for hbalnk so use __v4l2_ctrl_modify_range() to support multi modes for hblank. The hblank value is readonly in the driver. because of this the function returns error if we try to change. so added dumy return case in imx334_set_ctrl function. Reviewed-by:
Jacopo Mondi <jacopo@jmondi.org> Signed-off-by:
-
Miaoqian Lin authored
We should call v4l2_ctrl_request_hdl_put() instead of v4l2_ctrl_request_put_hdl(). Fix the typo. Signed-off-by:
Miaoqian Lin <linmq006@gmail.com> Reviewed-by:
Nicolas Dufresne <nicolas.dufresne@collabora.com> Signed-off-by:
-
Krzysztof Kozlowski authored
Venus Linux driver loads firmware based on firmware-name property and some DTS already have it: msm8996-oneplus3.dtb: video-codec@c00000: Unevaluated properties are not allowed ('firmware-name', 'interconnect-names', 'interconnects' were unexpected) Signed-off-by: -
Krzysztof Kozlowski authored
Venus on Qualcomm SM8250 uses Operating Performance Points (both in DTS and driver): sm8250-hdk.dtb: video-codec@aa00000: 'operating-points-v2', 'opp-table' do not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by:
-
Krzysztof Kozlowski authored
Venus on Qualcomm SDM845 uses Operating Performance Points (in Linux driver). Signed-off-by:
-
Krzysztof Kozlowski authored
Venus on Qualcomm SC7280 uses Operating Performance Points (both in DTS and driver): sc7280-crd-r3.dtb: video-codec@aa00000: Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected) Signed-off-by: -
Krzysztof Kozlowski authored
Venus on Qualcomm SC7180 uses Operating Performance Points (both in DTS and driver): sc7180-idp.dtb: video-codec@aa00000: Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected) Signed-off-by: -
Krzysztof Kozlowski authored
Venus on Qualcomm MSM8996 defines interconnects: apq8096-db820c.dtb: video-codec@c00000: Unevaluated properties are not allowed ('interconnect-names', 'interconnects' were unexpected) Signed-off-by: -
Krzysztof Kozlowski authored
All Qualcomm SoC Venus bindings share a lot of properties, so split common part to re-usable schema to reduce the duplication and promote unified style. Signed-off-by:
-
Krzysztof Kozlowski authored
Cleanup the Qualcomm SoC Venus bindings: - Drop unneeded blank lines and quotes, - Fix indentation in example to 4-space (to match DT schema bindings style), - Add SoC name in each title. Signed-off-by:
-
Laurent Pinchart authored
The control handler is leaked in some probe-time error paths, as well as in the remove path. Fix it. Fixes: 66d8c9d2 ("media: i2c: Add MAX9286 driver") Signed-off-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by:
Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by:
-
Robert Mader authored
Analogous to e.g. the imx219. This enables propagating V4L2_CID_CAMERA_ORIENTATION and V4L2_CID_CAMERA_SENSOR_ROTATION values. The motivation is to allow libcamera detect these values from the device tree and propagate them further to e.g. Pipewire. While at it, reserve space for 3 additional controls even if v4l2_ctrl_new_fwnode_properties() can only register 2 of them, to fix the existing implementation which reserve space for 8 controls but actually registers 9. [Sakari Ailus: Rewrapped the commit message and removed changelog] Signed-off-by:
Robert Mader <robert.mader@collabora.com> Reviewed-by:
-
Bingbu Cao authored
It is not expected that trying to set the sensor to streaming mode when trying to set initial sensor configuration. Signed-off-by:
Bingbu Cao <bingbu.cao@intel.com> Signed-off-by:
-
Arec Kao authored
Tell ACPI device PM code that the driver supports the device being in non-zero ACPI D state when the driver's probe function is entered. Also do identification on the first access of the device, whether in probe or when starting streaming. Signed-off-by:
Arec Kao <arec.kao@intel.com> Signed-off-by:
-
Luca Weiss authored
Add support for the .get_selection() pad operation to the ov2685 sensor driver. Report the native sensor size (pixel array), the crop bounds (readable pixel array area) and the current and default analog crop rectangles. Reviewed-by:
Luca Weiss <luca@z3ntu.xyz> Signed-off-by:
-
Luca Weiss authored
Add V4L2_CID_CAMERA_ORIENTATION and V4L2_CID_CAMERA_SENSOR_ROTATION controls to the ov2685 driver by attempting to parse them from firmware. Signed-off-by:
-
Luca Weiss authored
If the sensor doens't power up correctly, for example due to incorrect devicetree description, the power up i2c writes will fail. Add an error print for this situation. Reviewed-by:
-
Laurent Pinchart authored
The imx296 driver uses the subdev active state, there's no need to implement the .get_fmt() operation manually. Use the v4l2_subdev_get_fmt() helper instead. Signed-off-by:
-
Jacopo Mondi authored
The ov5670 driver tries to get a reference to the xvclk provider by using the common cock framework and deflects to parsing the "clock-frequency" property in case the clock provider is not specified in the firmware interface, detected by checking if ov5670->xvclk == PTR_ERR(-ENOENT). However, as reported by the Smatch static checker, if CONFIG_HAVE_CLK is not enabled, devm_clk_get() returns 0 which when passed to PTR_ERR() means success causing the driver to fail without propagating any error code up. Explicitly handle the case where ov5670->xvclk it set to NULL, forcing the code to parse the "clock-frequency" property in case CONFIG_HAVE_CLK is not enabled, as suggested by Dan Carpenter. Reported-by:
Dan Carpenter <error27@gmail.com> Suggested-by:
-
Krzysztof Kozlowski authored
The st,stm32-cec.yaml was moved to media/cec directory, however the "remove" part disappeared during applying. Link: https://lore.kernel.org/all/20221208103115.25512-3-krzysztof.kozlowski@linaro.org/ Fixes: 8f437662 ("media: dt-bindings: st,stm32-cec: move to cec subfolder") Signed-off-by:
-
Luca Weiss authored
Currently the driver always configures the sensor for dual-lane MIPI output, but it also supports single-lane output. Add support for that by checking the data-lanes fwnode property how many lanes are used and configure the necessary registers based on that. To achieve this we move setting register 0x3018 out of the general reg sequence so we set it to the correct value. The pixel_rate value also needs to be adjusted. [Sakari Ailus: Use div_s64 to divide a 64-bit number] Signed-off-by:
-
