- 11 Sep, 2012 40 commits
-
-
Samuel Iglesias Gonsálvez authored
As the IRQ was requested by the driver, it should free it also. Signed-off-by:
Samuel Iglesias Gonsálvez <siglesias@igalia.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Samuel Iglesias Gonsálvez authored
The ipoctal devices can be uninstalled from the ipack_driver_unregister() call as the device model calles the bus's .remove() function for each device registered by the driver and it will execute the .remove() function of the ipoctal driver. Signed-off-by:
-
Samuel Iglesias Gonsálvez authored
Using the call to the ipack_device_unregister() function to avoid the strange way it was doing, as the device model will take care of calling the bus's .remove function when a device is being unregistered. Signed-off-by:
-
Samuel Iglesias Gonsálvez authored
As indicated in the documentation of pci_dev_get. Signed-off-by:
-
Samuel Iglesias Gonsálvez authored
Move iounmap and pci_release_region to tpci200_unregister(), as it is the place where the clean-up of the device is done. Also, renamed iounmap() to pci_iounmap() as the mapped region was requested from PCI bus. Signed-off-by:
-
Jens Taprogge authored
We check the CRC and store the result of the check in struct ipac_device. A warning is emitted if the check fails. However we leave it to the IPack module device to refuse to initialize due to a bad CRC. I have seen otherwise good modules with bad CRCs. Signed-off-by:
Jens Taprogge <jens.taprogge@taprogge.org> Signed-off-by:
-
Jens Taprogge authored
Resetting the previous timeout we avoid to read the timeout status register and see timeout errors that don't correspond to the present state of the device. Signed-off-by:
-
Jens Taprogge authored
Reading the ID space at 8 MHz is always supported. Most carriers will boot up in 8MHz mode. Still, play it safe and ensure we are operating at 8Mhz. Signed-off-by:
-
Samuel Iglesias Gonsálvez authored
As the linked list was removed before, delete the useless struct list_head Signed-off-by:
-
Jens Taprogge authored
After a successful match is found the driver field in struct device is set by the core device code. We can use this field. Signed-off-by:
-
Jens Taprogge authored
Signed-off-by:
-
Jens Taprogge authored
Signed-off-by:
-
Jens Taprogge authored
Provide get_clockrate, set_clockrate, get_error, get_timeout and reset_timeout callbacks. Signed-off-by:
-
Jens Taprogge authored
We provide callbacks to: - set/get the clockrate a module is accessed at, - get the error state of a slot, - get/reset the timeout state of a slot. Signed-off-by:
-
Jens Taprogge authored
This saves us from a little pointer arithmetic and cleans up the code a bit. Signed-off-by:
-
Eduardo Valentin authored
While registering the thermal zone, it is required to have the cooling devices already setup, so that the .bind callback can succeed. Due to that, the driver code needs to be reorganized so that we first setup the cooling devices then the zones. This way we cope with the right thermal framework initialization sequence. This patch changes the order of the thermal zone initialization, so that we create it only when the cooling devices are available. It also adds some defensive checks for the config data, so that the callbacks are ready for calls when the data is still not initialized. Signed-off-by:
Eduardo Valentin <eduardo.valentin@ti.com> Signed-off-by:
-
Eduardo Valentin authored
While registering the omap thermal zones we need to properly specify TC1 and TC2, as long as the proper passive polling period and monitor period. This patch fixes the parameters passed while registering the thermal zone. Signed-off-by:
-
Eduardo Valentin authored
Simple checkpatch.pl clean ups. Signed-off-by:
-
J Keerthy authored
Removes checkpatch warnings on omap-bandgap.c. Signed-off-by:
J Keerthy <j-keerthy@ti.com> Signed-off-by:
-
Güngör Erseymen authored
Fix coding style issues by removing unnecessary braces. Signed-off-by:
Güngör Erseymen <gelurine@gmail.com> Signed-off-by:
-
H Hartley Sweeten authored
Remove some obvious comments. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
H Hartley Sweeten authored
The comedi core always calls the 'do_cmdtest' function before it calls the 'do_cmd' function. The 'do_cmdtest' for this driver calls i8253_cascade_ns_to_timer_2div() to validate the cmd->convert_arg. This call sets the dev_private 'div1' and 'div2' values needed to program the 8254 timer. There is no need to call the i8253 function a second time in the do_cmd function. Signed-off-by:
-
H Hartley Sweeten authored
Use the helper function cfc_check_trigger_is_unique. Signed-off-by:
-
H Hartley Sweeten authored
"Step 2" of each do_cmdtest checks that the trigger sources are unique by doing something like this for each trigger: if (cmd->start_src != TRIG_TIMER && cmd->start_src != TRIG_FOLLOW && cmd->start_src != TRIG_EXT) err++; /* Test the remaining triggers similarly */ if (err) return 2; Introduce a helper function in comedi_fc to handle this boilerplate. The drivers can then just do: err |= cfc_check_trigger_is_unique(cmd->start_src); /* Test the remaining triggers similarly */ if (err) return 2; Signed-off-by:
-
H Hartley Sweeten authored
If a single source trigger passes "step 1" of the do_cmdtest function they are already unique. There is no need to recheck them. Signed-off-by:
-
H Hartley Sweeten authored
Remove the pci9111_check_trigger_src macro and use the helper function cfc_check_trigger_src instead. Signed-off-by:
-
H Hartley Sweeten authored
All of the comedi drivers that support the 'cmd' callback also require a 'do_cmdtest' callback. The do_cmdtest validates the comedi_cmd before it is executed. "Step 1" of each do_cmdtest does a trivial validation of the trigger sources by doing something like this for each trigger: int err = 0; unsigned int tmp; tmp = cmd->start_src; src &= TRIG_NOW; if (!src || tmp != src) err++; /* Test the remaining triggers similarly */ if (err) return 1; Introduce a helper function in comedi_fc to handle this boilerplate. The drivers can then just do: err |= cfc_check_trigger_src(&cmd->start_src, TRIG_NOW); /* Test the remaining triggers similarly */ if (err) return 1; Signed-off-by:
-
Macpaul Lin authored
Remove camel-case variables in gdm_qos.h and gdm_qos.c Signed-off-by:
Macpaul Lin <macpaul@gmail.com> Cc: Paul Stewart <pstew@chromium.org> Cc: Ben Chan <benchan@chromium.org> Cc: Sage Ahn <syahn@gctsemi.com> Signed-off-by:
-
Tony Lindgren authored
Let's define some things locally to avoid breaking build when irqs.h is removed. This is needed for the ARM common zImage support. Cc: Omar Ramirez Luna <omar.ramirez@ti.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
Tony Lindgren <tony@atomide.com> Signed-off-by:
-
Justin P. Mattock authored
Signed-off-by:
Justin P. Mattock <justinmattock@gmail.com> Signed-off-by:
-
H Hartley Sweeten authored
The 'is_valid' variable in the private data is only used in the detach of the board to determine if the pci9111_reset() function can be called. That function only requires a valid dev->iobase to work. Use that for the check instead and remove the unneeded variable from the private data. Signed-off-by:
-
H Hartley Sweeten authored
For aesthetic reasons, rename the symbols. Remove the unnecessary () around the symbols in the calls to i8253_cascade_ns_to_timer_2div(). Signed-off-by:
-
H Hartley Sweeten authored
For aesthetic reasons, rename the symbol and fix the whitespace. Signed-off-by:
-
H Hartley Sweeten authored
Finish renaming the defines for the register map. Move the bit defines so that they are associated with the register. Remove the unneeded '0' bit defines. Signed-off-by:
-
H Hartley Sweeten authored
This macro relies on a local variable having a specific name. It's used multiple places so change it into a function. Signed-off-by:
-
H Hartley Sweeten authored
These macros rely on a local variable having a specific name. Signed-off-by:
-
H Hartley Sweeten authored
These macros rely on a local variable having a specific name. Signed-off-by:
-
H Hartley Sweeten authored
This macro relies on a local variable having a specific name. Signed-off-by:
-
H Hartley Sweeten dev authored
This macro relies on a local variable having a specific name. Signed-off-by:
-
H Hartley Sweeten authored
These macros rely on a local variable having a specific name. Signed-off-by:
-
