1. 13 Aug, 2008 3 commits
    • Andrew Morton's avatar
      net/tipc/subscr.c: don't use ___constant_swab32 · 6ced0b3f
      Andrew Morton authored
      It's an internal implementation detail which we _should_ be free to change. 
      So we did, and it promptly broke.
      
      The compiler shold be able to work out when to use the __constant version
      anyway.
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6ced0b3f
    • David S. Miller's avatar
      pkt_sched: Add queue stopped test back to qdisc_run(). · 83f36f3f
      David S. Miller authored
      Based upon a bug report by Andrew Gallatin on netdev
      with subject "CPU utilization increased in 2.6.27rc"
      
      In commit 37437bb2
      ("pkt_sched: Schedule qdiscs instead of netdev_queue.")
      the test of the queue being stopped was erroneously
      removed from qdisc_run().
      
      When the TX queue of the device fills up, this omission
      causes lots of extraneous useless work to be queued up
      to softirq context, where we'll just return immediately
      because the device is still stuffed up.
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      83f36f3f
    • Brian Haley's avatar
      ipv6: Fix OOPS, ip -f inet6 route get fec0::1, linux-2.6.26, ip6_route_output, rt6_fill_node+0x175 · 5e0115e5
      Brian Haley authored
      Alexey Dobriyan wrote:
      > On Thu, Aug 07, 2008 at 07:00:56PM +0200, John Gumb wrote:
      >> Scenario: no ipv6 default route set.
      > 
      >> # ip -f inet6 route get fec0::1
      >>
      >> BUG: unable to handle kernel NULL pointer dereference at 00000000
      >> IP: [<c0369b85>] rt6_fill_node+0x175/0x3b0
      >> EIP is at rt6_fill_node+0x175/0x3b0
      > 
      > 0xffffffff80424dd3 is in rt6_fill_node (net/ipv6/route.c:2191).
      > 2186                    } else
      > 2187    #endif
      > 2188                            NLA_PUT_U32(skb, RTA_IIF, iif);
      > 2189            } else if (dst) {
      > 2190                    struct in6_addr saddr_buf;
      > 2191      ====>         if (ipv6_dev_get_saddr(ip6_dst_idev(&rt->u.dst)->dev,
      >					       ^^^^^^^^^^^^^^^^^^^^^^^^
      >											NULL
      > 
      > 2192                                           dst, 0, &saddr_buf) == 0)
      > 2193                            NLA_PUT(skb, RTA_PREFSRC, 16, &saddr_buf);
      > 2194            }
      
      The commit that changed this can't be reverted easily, but the patch
      below works for me.
      
      Fix NULL de-reference in rt6_fill_node() when there's no IPv6 input
      device present in the dst entry.
      Signed-off-by: default avatarBrian Haley <brian.haley@hp.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5e0115e5
  2. 12 Aug, 2008 3 commits
  3. 11 Aug, 2008 11 commits
  4. 09 Aug, 2008 2 commits
  5. 08 Aug, 2008 6 commits
  6. 07 Aug, 2008 15 commits