- 16 Jan, 2017 13 commits
-
-
Arnd Bergmann authored
gcc-7 detects that wlanhdr_to_ethhdr() in two drivers calls memcpy() with a destination argument that an earlier function call may have set to NULL: staging/rtl8188eu/core/rtw_recv.c: In function 'wlanhdr_to_ethhdr': staging/rtl8188eu/core/rtw_recv.c:1318:2: warning: argument 1 null where non-null expected [-Wnonnull] staging/rtl8712/rtl871x_recv.c: In function 'r8712_wlanhdr_to_ethhdr': staging/rtl8712/rtl871x_recv.c:649:2: warning: argument 1 null where non-null expected [-Wnonnull] I'm fixing this by adding a NULL pointer check and returning failure from the function, which is hopefully already handled properly. This seems to date back to when the drivers were originally added, so backporting the fix to stable seems appropriate. There are other related realtek drivers in the kernel, but none of them contain a function with a similar name or produce this warning. Cc: stable@vger.kernel.org Fixes: 1cc18a22 ("staging: r8188eu: Add files for new driver - part 5") Fixes: 2865d42c ("staging: r8712u: Add the new driver to the mainline kernel") Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Javier Rodriguez authored
Remove one unnecessary white line. Signed-off-by:
Javier Rodriguez <jrodbar@yahoo.es> Signed-off-by:
-
Javier Rodriguez authored
Correct code style error. Add a character in every line of the comment block. Signed-off-by:
-
Derek Robson authored
Change file permissions to octal style. Found using checkpatch. Signed-off-by:
Derek Robson <robsonde@gmail.com> Signed-off-by:
-
David Wittman authored
This change fixes a checkpatch error for "that open brace { should be on the previous line" as well as a related spacing warning. Signed-off-by:David Wittman <dwittman@gmail.com> Signed-off-by:
-
Omri Arad authored
'cb' and 'sgb' were assigned __le values but were not marked as such, this fixes the following sparse warnings: drivers/staging/rts5208/rtsx_transport.c:220:34: warning: incorrect type in assignment (different base types) drivers/staging/rts5208/rtsx_transport.c:220:34: expected unsigned int [unsigned] [usertype] <noident> drivers/staging/rts5208/rtsx_transport.c:220:34: got restricted __le32 [usertype] <noident> drivers/staging/rts5208/rtsx_transport.c:319:44: warning: incorrect type in assignment (different base types) drivers/staging/rts5208/rtsx_transport.c:319:44: expected unsigned long long [unsigned] [long] [long long] [usertype] <noident> drivers/staging/rts5208/rtsx_transport.c:319:44: got restricted __le64 [usertype] <noident> drivers/staging/rts5208/rtsx_transport.c:319:44: warning: incorrect type in assignment (different base types) drivers/staging/rts5208/rtsx_transport.c:319:44: expected unsigned long long [unsigned] [long] [long long] [usertype] <noident> drivers/staging/rts5208/rtsx_transport.c:319:44: got restricted __le64 [usertype] <noident> Signed-off-by:
Omri Arad <omriarad3@gmail.com> Signed-off-by:
-
Philip Thiemann authored
Removed checkpatch.pl warning 'line over 80 characters' by inserting a linebreak in the comment line 50. Signed-off-by:
Philip Thiemann <philip.thiemann@fau.de> Signed-off-by:
Fabian Arnold <fabian.arnold@fau.de> Signed-off-by:
-
Eric Salem authored
Fixed mismatch between types used in sizeof operator. Signed-off-by:
Eric Salem <ericsalem@gmail.com> Signed-off-by:
-
Roman Sommer authored
Fix checkpatch warnings for parameter type unsigned in greybus. Note that this patch does not fix all checkpatch warnings for the affected files. Signed-off-by:
Christian Bewermeyer <christian.bewermeyer@fau.de> Signed-off-by:
Roman Sommer <roman.sommer@fau.de> Reviewed-by:
Johan Hovold <johan@kernel.org> Signed-off-by:
-
Abdul Rauf authored
Fix the following warnings: braces {} are not necessary for any arm of this statement Signed-off-by:Abdul Rauf <abdulraufmujahid@gmail.com> Acked-by:
Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by:
-
Abdul Rauf authored
Fix the following Errors: Bad function definition - void abort() should probably be void abort(void) Signed-off-by:
-
Derek Robson authored
Changed permissions to be in octal style. Found by checkpatch. Signed-off-by:
-
Dan Carpenter authored
"svcpt->scp_hist_seq" is a u64 so static checkers complain that 1U should be 1ULL. I looked at REQS_SEQ_SHIFT() a little and it seems to be capped by the number of CPUs online and the amount of memory, but I think it could go above 32 possibly. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
- 10 Jan, 2017 27 commits
-
-
Scott Matheina authored
Fixed the following checkpatch warnings by deleting blank lines Blank lines aren't necessary before a close brace '}' Blank lines aren't necessary after an open brace '{' Please don't use multiple blank lines Signed-off-by:Scott Matheina <scott@matheina.com> Signed-off-by:
-
Scott Matheina authored
Fixed Alignment should match open parenthesis from checkpatch Signed-off-by:
-
Scott Matheina authored
Fixed Alignment should match open parenthesis checkpatch CHECK Signed-off-by:
-
Scott Matheina authored
Fixed Alignment should match open parenthesis checkpatch CHECK Signed-off-by:
-
Stefan Wahren authored
This fixes the space coding styles issues complained by checkpatch. Signed-off-by:
Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by:
-
Stefan Wahren authored
This should fix the indentation issues found by checkpatch. Signed-off-by:
-
Stefan Wahren authored
There is no need for a vchiq_2835.h with its 2 local defines. Signed-off-by:
-
Stefan Wahren authored
This patch tries to make the kernel thread names of vchiq a little bit more self explaining and look closer to the existing ones: slot handler: VCHIQ-%d -> vchiq-slot/%d recycle thread: VCHIQr-%d -> vchiq-recy/%d sync thread: VCHIQs-%d -> vhciq-sync/%d keep-alive thread: VCHIQka-%d -> vchiq-keep/%d Signed-off-by:
-
Stefan Wahren authored
This patch fixes issues reported by checkpatch.pl about preferred kernel types. Signed-off-by:
-
Stefan Wahren authored
The quota_spinlock is only local. So make it static. Signed-off-by:
-
Stefan Wahren authored
This variable is assigned a value, but never used. So remove it. Signed-off-by:
-
Stefan Wahren authored
The functions vchiq_dump_shared_state() and vchiq_is_connected() are only used locally. So make them static. Signed-off-by:
-
Stefan Wahren authored
This function is never used, so we could remove it. Signed-off-by:
-
Yamanappagouda Patil authored
Fixed checkpatch.pl warnings in rtl8188eu module core folder files. Signed-off-by:
Yamanappagouda Patil <goudapatilk@gmail.com> Signed-off-by:
-
Scott Matheina authored
Fixes checkpatch warning - Please don't use multiple blank lines Signed-off-by:
-
Scott Matheina authored
Fixes absence of braces on last arm of statement, identified by checkpatch Signed-off-by:
-
Scott Matheina authored
Fixes checkpatch.pl warning - Blank lines aren't necessary before a close brace '}' & Please don't use multiple blank lines Signed-off-by:
-
Scott Matheina authored
Fixes Alignment should match open parenthesis in checkpatch Signed-off-by:
-
Emmanuil Chatzipetru authored
This issue is caught by checkpatch.pl and is related to the following warning: - CHECK: Please don't use multiple blank lines Signed-off-by:
Emmanuil Chatzipetru <chatzi.emanuel@gmail.com> Signed-off-by:
-
Emmanuil Chatzipetru authored
This issue is caught by checkpatch.pl and is related to the following warning: - CHECK: spaces preferred around that '/' (ctx:VxV) Signed-off-by:
-
Emmanuil Chatzipetru authored
dcon_was_irq(); should return a boolean value if PMIO_Rx50[6] is either set or unset, which is evaluated in the first return statement. Therefore, the following return statement is redundant and thus, removed. Signed-off-by:
-
Emmanuil Chatzipetru authored
This issue is caught by checkpatch.pl and is related to the following warning: - CHECK: Alignment should match open parenthesis Signed-off-by:
-
Abdul Rauf authored
Fix the following warnings: line over 80 characters Signed-off-by:
-
Abdul Rauf authored
Fix the following checks: Please don't use multiple blank lines Signed-off-by:
-
Cheah Kok Cheong authored
Unused after commit 6e302939 ("staging: comedi: comedi_fops: coding style fixes") - Fixed coding style in comedi_fops.c Symbolic to octal permission. Anyway it's included in module.h Signed-off-by:
Cheah Kok Cheong <thrust73@gmail.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Cheah Kok Cheong authored
Unused after commit d1843132 ("staging: comedi: deprecate loading firmware with comedi_config"). Signed-off-by:
-
Cheah Kok Cheong authored
After commit 0fd972a7 ("module: relocate module_init from init.h to module.h"), including module.h will do and init.h is also thrown in. Signed-off-by:
-
