When looking for or validating a user device, only use devices
that are currently active.
Reviewed-by: Mitko Haralanov <mitko.haralanov@intel.com>
Signed-off-by: Dean Luick <dean.luick@intel.com>
Signed-off-by: Jubin John <jubin.john@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

During driver load the thermal sensor needs to be reset prior
to initialization of the sensor. This prevents a possible sensor lock
up which can cause the wrong temperature value to be reported.
This fix leads to remove disabling thermal polling from
reset_asic_csrs() function.

Reviewed by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Reviewed by: Easwar Hariharan <easwar.hariharan@intel.com>
Signed-off-by: Jareer Abdel-Qader <jareer.h.abdel-qader@intel.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Jubin John <jubin.john@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

B0 dual port parts require the SBus firmware to always be
downloaded.

Remove reset of the SBus Master spico.  It is not necessary
since the SBus firmware download already does that.
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Dean Luick <dean.luick@intel.com>
Signed-off-by: Jubin John <jubin.john@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Some BIOS implementations turn off extended tags in DevCtl (a RW
field) even though it was originally set and is advertised in DevCap
Fix is to set it in the driver
Reviewed-by: Dean Luick <dean.luick@intel.com>
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Signed-off-by: Vennila Megavannan <vennila.megavannan@intel.com>
Signed-off-by: Jubin John <jubin.john@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

The FLR on driver load asserts the QSFP reset pin and the driver does
not deassert it after. This patch allows the external QSFP cable to exit
reset by writing 1 to all the QSFP pins.
Reviewed-by: Dean Luick <dean.luick@intel.com>
Signed-off-by: Easwar Hariharan <easwar.hariharan@intel.com>
Signed-off-by: Jubin John <jubin.john@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Replacing dd_dev_info() for hfi1_cdbg() to avoid generating syslog
output for every context that is open by PSM.
Reviewed-by: Mitko Haralanov <mitko.haralanov@intel.com>
Signed-off-by: Sebastian Sanchez <sebastian.sanchez@intel.com>
Signed-off-by: Jubin John <jubin.john@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames DIM_EnqueueBuffer to dim_enqueue_buffer to avoid
camelcase found by checkpatch.

CHECK: Avoid CamelCase: <DIM_EnqueueBuffer>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:877:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames DIM_GetChannelState to dim_get_channel_state to avoid
camelcase found by checkpatch.

CHECK: Avoid CamelCase: <DIM_GetChannelState>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:865:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

The second argument name of DIM_GetChannelState declaration changes from
dim_ch_state_ptr to state_ptr. The DIM_GetChannelState declaration and
definition has same argument name as state_ptr.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames DIM_ServiceChannel to dim_service_channel to avoid
camelcase found by checkpatch.

CHECK: Avoid CamelCase: <DIM_ServiceChannel>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:857:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames DIM_ServiceIrq to dim_service_irq to avoid camelcase
found by checkpatch.

CHECK: Avoid CamelCase: <DIM_ServiceIrq>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:819:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames DIM_DestroyChannel to dim_destroy_channel to avoid
camelcase found by checkpatch.

CHECK: Avoid CamelCase: <DIM_DestroyChannel>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:806:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames DIM_InitSync to dim_init_sync to avoid camelcase
found by checkpatch.

CHECK: Avoid CamelCase: <DIM_InitSync>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:781:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames DIM_InitIsoc to dim_init_isoc to avoid camelcase
found by checkpatch.

CHECK: Avoid CamelCase: <DIM_InitIsoc>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:756:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames DIM_InitAsync to dim_init_async to avoid camelcase
found by checkpatch.

CHECK: Avoid CamelCase: <DIM_InitAsync>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:749:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames DIM_InitControl to dim_init_control to avoid
camelcase found by checkpatch.

CHECK: Avoid CamelCase: <DIM_InitControl>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:742:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames DIM_NormSyncBufferSize to dim_norm_sync_buffer_size
to avoid camelcase found by checkpatch.

CHECK: Avoid CamelCase: <DIM_NormSyncBufferSize>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:734:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames DIM_NormIsocBufferSize to dim_norm_isoc_buffer_size
to avoid camelcase found by checkpatch.

CHECK: Avoid CamelCase: <DIM_NormIsocBufferSize>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:720:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames DIM_NormCtrlAsyncBufferSize to
dim_norm_ctrl_async_buffer_size to avoid camelcase found by checkpatch

CHECK: Avoid CamelCase: <DIM_NormCtrlAsyncBufferSize>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:709:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames DIMCB_IoRead to dimcb_io_read to avoid camelcase
found by checkpatch.

CHECK: Avoid CamelCase: <DIMCB_IoRead>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:157:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames DIMCB_IoWrite to dimcb_io_write to avoid camelcase
found by checkpatch.

CHECK: Avoid CamelCase: <DIMCB_IoWrite>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:154:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames DIMCB_OnError to dimcb_on_error to avoid camelcase
found by checkpatch.

CHECK: Avoid CamelCase: <DIMCB_OnError>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:77:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames DIM_GetLockState to dim_get_lock_state to avoid
camelcase found by checkpatch.

CHECK: Avoid CamelCase: <DIM_GetLockState>
FILE: drivers/staging/most/hdm-dim2/dim2_hdm.c:131:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames DIM_DetachBuffers to dim_detach_buffers to avoid
camelcase found by checkpatch.

CHECK: Avoid CamelCase: <DIM_DetachBuffers>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:886:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames DIM_Shutdown to dim_shutdown to avoid camelcase
found by checkpatch.

CHECK: Avoid CamelCase: <DIM_Shutdown>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:676:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames DIM_Startup to dim_startup to avoid camelcase
found by checkpatch.

CHECK: Avoid CamelCase: <DIM_Startup>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:653:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch adds space around '<<' found by checkpatch.

CHECK: spaces preferred around that '<<' (ctx:VxV)
FILE: drivers/staging/most/hdm-dim2/dim2_reg.h:69:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes blank line after an open brace found by checkpatch.
CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes multiple blank lines found by checkpatch.
CHECK: Please don't use multiple blank lines
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

malloc error handling moved into one place.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

goto is not needed here.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

IS_* and GET_CVID_* macros have not been used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

IS_* macros (except one) occur only once.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

The range of elements to fill with zeros is determined by using a roundup macro
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This name is better suited for this variable.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This name is better suited for this variable.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This name is better suited for this variable.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

checkpatch fix:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

It is superfluous.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>