- 03 Jul, 2020 11 commits
-
-
Jérôme Pouiller authored
The device is able to send multiple Tx confirmations in the one reply. In this case, there is only one vif identifier for all the confirmations. Unfortunately, to generate this kind of messages the device squashes all the confirmations whatever their vif ID and use the vif ID of the first confirmation. So, the driver cannot rely on the vif ID mentioned in the header. Fortunately, using the packet_id, the driver can retrieve the Tx request and the associated vif. Signed-off-by:
Jérôme Pouiller <jerome.pouiller@silabs.com> Link: https://lore.kernel.org/r/20200701150707.222985-4-Jerome.Pouiller@silabs.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Jérôme Pouiller authored
When the driver has sent a frame on a virtual interface (vif), it expects to receive the confirmation on the same vif. This patch add a check for that. Signed-off-by:
-
Jérôme Pouiller authored
The device handles 4 queues (one per AC) for each virtual interface (and maximum 4 virtual interfaces). Until now the driver unified the queue of all interfaces and handled only 4 queues for whole device. This architecture did not allow to balance the traffic between the vif. So, this patch relocate the queues into the vif and change the API accordingly. Signed-off-by:
-
Suraj Upadhyay authored
Remove extra indentations from if-statement. Signed-off-by:
Suraj Upadhyay <usuraj35@gmail.com> Link: https://lore.kernel.org/r/20200702084022.GA1586@blackclownSigned-off-by:
-
Mauro Dreissig authored
Those #define's are not used anywhere, get rid of them. Signed-off-by:
Mauro Dreissig <mukadr@gmail.com> Link: https://lore.kernel.org/r/20200701214420.5566-3-mukadr@gmail.comSigned-off-by:
-
Mauro Dreissig authored
Use the existing offsetof() macro instead of duplicating code. Signed-off-by:
-
Michael Straube authored
Many defined constants in wifi.h are unused and/or available from <linux/ieee80211.h>, some with slightly different names. Use the common ones, rename where necessary and remove unused. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20200701164213.4205-1-straube.linux@gmail.comSigned-off-by:
-
Simon Fong authored
Fixed 5 WARNINGs of Block comments use * on subsequent lines. Signed-off-by:
Simon Fong <simon.fodin@gmail.com> Link: https://lore.kernel.org/r/239f5c7f4761dd2ef0df8ee6966fca8ed2a13a9c.1593703689.git.simon.fodin@gmail.comSigned-off-by:
-
Simon Fong authored
Fixed a CHECK of Lines should not end with a '('. Signed-off-by: -
Michael Straube authored
Many defined constants in wifi.h are unused and/or available from <linux/ieee80211.h>, some with slightly different names. Use the common ones, rename where necessary and remove unused. Signed-off-by:
-
Michael Straube authored
Remove unused parameter 'padapter' from rtw_os_xmit_resource_alloc(). Signed-off-by:
-
- 02 Jul, 2020 2 commits
-
-
Greg Kroah-Hartman authored
The movement of wilc1000 out of staging left an obsolete TODO file. Remove that as it's no longer needed. Cc: Kalle Valo <kvalo@codeaurora.org> Cc: <Ajay.Kathat@microchip.com> Cc: <Venkateswara.Kaja@microchip.com> Cc: <Sripad.Balwadgi@microchip.com> Cc: <Nicolas.Ferre@microchip.com> Cc: <johannes@sipsolutions.net> Signed-off-by: -
Greg Kroah-Hartman authored
Merge branch 'wilc1000-move-out-of-staging' of git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next into staging-next This is the movement of the wilc1000 driver out of staging, pulled in here so that we do not end up doing duplicate work. Signed-off-by:
-
- 01 Jul, 2020 27 commits
-
-
Puranjay Mohan authored
Use %s and __func__ in place of function names. This solves following checkpatch.pl warning WARNING: Prefer using '"%s...", __func__' to using 'rtw_do_join', this function's name, in a string Signed-off-by:
Puranjay Mohan <puranjay12@gmail.com> Link: https://lore.kernel.org/r/20200701145457.9562-1-puranjay12@gmail.comSigned-off-by:
-
Simon Fong authored
Fixed a WARNING of Block comments use * on subsequent lines. Signed-off-by:
-
Nicolas Saenz Julienne authored
To make the separation clear between vchiq's header files and vchiq.h, which is to be used by services and is the 'public' API, move it into a dedicated includes directory. Signed-off-by:
Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Link: https://lore.kernel.org/r/20200629150945.10720-48-nsaenzjulienne@suse.deSigned-off-by:
-
Nicolas Saenz Julienne authored
Those are only used in the core vchiq code, while present in vchiq's 'public' API header. Move them into the right place. Signed-off-by:
-
Nicolas Saenz Julienne authored
This used to be vchiq_if.h but vchiq.h is more concise for an include file that will hopefully be in the future in the includes directory. Signed-off-by:
-
Nicolas Saenz Julienne authored
The barrier is only used by core code. So keep the barrier definition in the core header. Signed-off-by:
-
Nicolas Saenz Julienne authored
All the functions that vchi currently provides are a 1:1 mapping to its vchiq counterparts. Get rid of vchi altogether and use vchiq's on all services. In the process also get rid of the vchi directory, as the only remaining file was a TODO file, which now lives in the parent directory. Signed-off-by:
-
Nicolas Saenz Julienne authored
We can't really merge it with vchiq_queue_message() as it has internal users that will not benefit from the retry mechanism vchiq_queue_kernel_message() uses. So, for the sake of getting rid of vchi, move it into vchiq. Signed-off-by:
-
Nicolas Saenz Julienne authored
Its vchiq counterpart, vchiq_bulk_transmit() is only used by vchi. We can then merge both functions by moving vchi_bulk_queue_transmit()'s retry mechanism into vchiq_bulk_transmit() and let services call the later. Signed-off-by:
-
Nicolas Saenz Julienne authored
Its vchiq counterpart, vchiq_bulk_receive() is only used by vchi. We can then merge both functions by moving vchi_bulk_queue_receive()'s retry mechanism into vchiq_bulk_receive() and let services call the later. Signed-off-by:
-
Nicolas Saenz Julienne authored
vchiq_if.h is used by service consumers and only the exported API should be present. Move the rest of definitions, which were not exported by the way, to vchiq_core.h where they belong. Signed-off-by:
-
Nicolas Saenz Julienne authored
The function is being exported although there is no use for it outside of vchiq's core code. Keep it local then. Signed-off-by:
-
Nicolas Saenz Julienne authored
Those functions don't actually exist, nor have any use, nor the macros. Signed-off-by:
-
Nicolas Saenz Julienne authored
This file is internal to vchiq. Signed-off-by:
-
Nicolas Saenz Julienne authored
It's already forward declared in vchiq_if.h. So no need to insist Signed-off-by:
-
Nicolas Saenz Julienne authored
There is already enough duplication with regard to fourcc generation in the kernel. Let's at least use the same macro all over the vchiq ecosystem. Signed-off-by:
-
Nicolas Saenz Julienne authored
The services have access to struct vchiq_header's internals, so we can let them get the data pointer. This pretty much makes both functions exactly the same, which will allow us to make a switch to vchiq_msg_hold() further down the road. Signed-off-by:
-
Nicolas Saenz Julienne authored
vchi created an opaque structure to be held by services while they process callback messages. The contents of this opaque structure are the service handle, which all services already maintain, and a pointer to vchiq's message structure, struct vchiq_header. Let's get rid of this opaque structure and directly pass struct vchiq_header, which is what ultimately vchiq consumes when handling callback messages. Signed-off-by:
-
Nicolas Saenz Julienne authored
The structure only contains a single parameter, which is the underlying vchiq handle. Get rid of the struct and directly pass the handle around. Signed-off-by:
-
Nicolas Saenz Julienne authored
For initialization, vchi has its own params structure, which is then translated to vchiq's params structure. They are essentially the same, so lets directly use vchiq's. Signed-off-by:
-
Nicolas Saenz Julienne authored
Linux coding style says to avoid typdefs. Signed-off-by:
-
Nicolas Saenz Julienne authored
As vchiq_shim's callback does nothing aside from pushing messages into the service's queue, let's bypass it and jump directly to the service's callbacks, letting them choose whether to use the message queue. It turns out most services don't need to use the message queue, which makes for simpler code in the end. Signed-off-by:
-
Nicolas Saenz Julienne authored
vchiq consumer drivers may need to use this function in order to get the benefits of vchiq's per service message queueing mechanism. Signed-off-by:
-
Nicolas Saenz Julienne authored
This is for service's callbacks to get their private data. Signed-off-by:
-
Nicolas Saenz Julienne authored
This will make further changes easier. The struct will ultimately disappear. Signed-off-by:
-
Nicolas Saenz Julienne authored
The header file only provides other includes. Move the relevant includes to their respective C files and delete it for good. Signed-off-by:
-
Nicolas Saenz Julienne authored
This has historically been handled by vchi, but there is no reason why this couldn't be handled directly in vchiq. The patch tries to avoid altering any behavior, with the exception of the msg_queue size, which is now fixed to VCHIQ_MAX_SLOTS (it was set to VCHIQ_MAX_SLOTS / 2). This is done to match vchiq's user_service message queue, which could be merged with this one in the future. Signed-off-by:
-
