1. 10 Nov, 2018 12 commits
    • David S. Miller's avatar
      Merge branch 'hns3-add-code-optimization-for-VF-reset-and-some-new-reset-feature' · 70e79832
      David S. Miller authored
      Huazhong Tan says:
      
      ====================
      hns3: add code optimization for VF reset and some new reset feature
      
      Currently hardware supports below reset:
      1. VF reset: triggered by sending cmd to IMP(Integrated Management
         Processor). Only reset specific VF function and do not affect
         other PF or VF.
      2. PF reset: triggered by sending cmd to IMP. Only reset specific PF
         and it's VF.
      3. PF FLR: triggered by PCIe subsystem. Only reset specific PF and
         it's VF.
      4. VF FLR: triggered by PCIe subsystem. Only reset specific VF function
         and do not affect other PF or VF.
      5. Core reset: triggered by writing to register. Reset most hardware
         unit, such as SSU, which affects all the PF and VF.
      6. Global reset: triggered by writing to register. Reset all hardware
         unit, which affects all the PF and VF.
      7. IMP reset: triggered by IMU(Intelligent Management Unit) when
         IMP is not longer feeding IMU's watchdog. IMU will reload the IMP
         firmware and IMP will perform global reset after firmware reloading,
         which affects all the PF and VF.
      
      Current driver only support PF/VF reset, incomplete core and global
      reset(lacking the vf reset handling). So this patchset adds complete
      reset support in hns3 driver.
      
      Also, this patchset contains some optimization related to reset.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      70e79832
    • Huazhong Tan's avatar
      net: hns3: add PCIe FLR support for VF · 6ff3cf07
      Huazhong Tan authored
      This patch implements the .reset_prepare and .reset_done
      ops from pci framework to support the VF FLR.
      
      This patch uses hclgevf_set_def_reset_request() and
      hclgevf_reset_event() to handle FLR, so when
      hdev->default_reset_request is non zero, it means there is
      some reset requseted by hclgevf_set_def_reset_request() need
      to be processed. Also get the hdev from the ae_dev because
      hclgevf_reset_event is called with handle being NULL.
      Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6ff3cf07
    • Huazhong Tan's avatar
      net: hns3: do VF's pci re-initialization while PF doing FLR · 862d969a
      Huazhong Tan authored
      While doing PF FLR, VF's PCIe configuration space will be cleared, so
      the pci and vector of VF should be re-initialized in the VF's reset
      process while PF doing FLR.
      
      Also, this patch fixes some memory not freed problem when pci
      re-initialization is done during reset process.
      Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      862d969a
    • Huazhong Tan's avatar
      net: hns3: add PCIe FLR support for PF · 6b9a97ee
      Huazhong Tan authored
      This patch implements the .reset_prepare and .reset_done
      ops from pci framework to support the PF FLR.
      Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6b9a97ee
    • Huazhong Tan's avatar
      net: hns3: implement the IMP reset processing for PF · 6dd22bbc
      Huazhong Tan authored
      The current code only print the prompt message after receiving
      the IMP reset interrupt and does not perform the corresponding driver
      reset operation. This patch implements the missing IMP reset handling
      in the driver.
      1. The driver sets the HCLGE_STATE_CMD_DISABLE to stop sending command
         after receiving the IMP reset interrupt.
      2. The driver needs to notify the hardware to reload the IMP firmware.
      3. The IMP firmware reloading makes the reset time of hardware longer,
         so it is necessary to extend the driver's waiting time to wait for
         the hardware reset to complete.
      4. In hclge_check_event_cause, IMP reset event should have higher
         priority than other events.
      
      Also, after clearing HCLGE_STATE_CMD_DISABLE in the hclge_cmd_init(),
      it needs to check whether there is a pending reset, if so, just set
      the HCLGE_STATE_CMD_DISABLE back and return.
      Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6dd22bbc
    • Huazhong Tan's avatar
      net: hns3: stop napi polling when HNS3_NIC_STATE_DOWN is set · ff0699e0
      Huazhong Tan authored
      When calling napi_disable during reset down process, if NAPIF_STATE_MISSED
      is set, napi_complete will call __napi_schedule to do the polling again.
      So this patch uses HNS3_NIC_STATE_DOWN to ensure the polling is not
      scheduled again.
      
      Also, when napi_complete returns true, it means polling is scheduled
      again, it is not neccssary to enable the interrupt.
      Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ff0699e0
    • Huazhong Tan's avatar
      net: hns3: add error handler for hclgevf_reset() · 6a5f6fa3
      Huazhong Tan authored
      Since hclgevf_reset() may fail for some reasons, so it needs an error
      handler to deal with it. When VF reset failed, VF can only be restored
      by a higher level reset asserted by PF. So, it needs to reinitialize
      its command queue, then it can respond to higher level reset.
      
      Also, this patch adds error logging in the hclgevf_notify_client().
      Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6a5f6fa3
    • Huazhong Tan's avatar
      net: hns3: stop handling command queue while resetting VF · ef5f8e50
      Huazhong Tan authored
      According to hardware's description, after the reset occurs, the driver
      needs to re-initialize the command queue before sending and receiving
      any commands. Therefore, the VF's driver needs to identify the command
      queue needs to re-initialize with HCLGEVF_STATE_CMD_DISABLE, and does
      not allow sending or receiving commands before the re-initialization.
      Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ef5f8e50
    • Huazhong Tan's avatar
      net: hns3: add reset handling for VF when doing Core/Global/IMP reset · b90fcc5b
      Huazhong Tan authored
      When a Core/Global/IMP reset occurs, the hardware sets the reset status
      register of all PF/VF and reports a reset interrupt to all PF/VF and
      firmware.
      
      When receiving the reset interrupt:
      1. The firmware will wait for 100 ms before resetting the hardware and
         clear the reset status register of all PF when hardware reset is done.
      2. The PF/VF driver needs to down the netdev within 100 ms and then wait
         for hardware reset to finish.
      3. After firmware clearing the reset status register of all PF, the PF
         driver reinitializes the hardware and clear the reset status register
         of it's VF.
      4. After PF driver clearing the reset status register of VF, the VF driver
         reinitializes the hardware.
      
      This patch mainly add handling for the step 4.
      Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b90fcc5b
    • Huazhong Tan's avatar
      net: hns3: add reset handling for VF when doing PF reset · aa5c4f17
      Huazhong Tan authored
      When PF performs a function reset, the hardware will reset both PF
      and all the VF belong to this PF. Hence, both PF's driver and VF's
      driver need to perform corresponding reset operations.
      
      Before PF driver asserting function reset to hardware, it firstly
      set up VF's hardware reset status, and inform the VF driver with
      HNAE3_VF_PF_FUNC_RESET, then VF driver sets this reset type to
      reset_pending and shechule reset task to stop IO and waits for the
      hardware reset status to clear. When PF driver has reinitialized the
      hardware and is ready to process mailbox from VF, PF driver clears
      VF's hardware reset status for VF to continue its reset process.
      
      Also, this patch uses readl_poll_timeout to simplify the hardware reset
      status waitting.
      Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
      Signed-off-by: default avatarYunsheng Lin <linyunsheng@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      aa5c4f17
    • Huazhong Tan's avatar
      net: hns3: adjust VF's reset process · dea846e8
      Huazhong Tan authored
      Currently when VF need to reset itself, it will send a cmd to PF,
      after receiving the VF reset requset, PF sends a cmd to inform
      VF to enter the reset process and send a cmd to firmware to do the
      actual reset for the VF, it is possible that firmware has resetted
      the VF, but VF has not entered the reset process, which may cause
      IO not stopped problem when firmware is resetting VF.
      
      This patch fixes it by adjusting the VF reset process, when VF
      need to reset itself, it will enter the reset process first, and
      it will tell the PF to send cmd to firmware to reset itself.
      
      Add member reset_pending to struct hclgevf_dev, which indicates that
      there is reset event need to be processed by the VF's reset task, and
      the VF's reset task chooses the highest-level one and clears other
      low-level one when it processes reset_pending.
      
      hclge_inform_reset_assert_to_vf function is unused now, but it will
      be used to support the PF reset with VF working, so declare it in
      the header file.
      Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
      Signed-off-by: default avatarYunsheng Lin <linyunsheng@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      dea846e8
    • Huazhong Tan's avatar
      net: hns3: add reset_hdev to reinit the hdev in VF's reset process · 9c6f7085
      Huazhong Tan authored
      When doing reset, the reset handling function only need to
      reinitialize hardware, it makes sense to add a function to
      do that job. Also the error handling of hclgevf_init_hdev is
      different when it is used in reset process.
      
      This patch adds reset_hdev to reinitialize hardware when resetting.
      Also, this patch removes the hclgevf_dev_ongoing_full_reset because
      it is unused now.
      Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
      Signed-off-by: default avatarYunsheng Lin <linyunsheng@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9c6f7085
  2. 09 Nov, 2018 28 commits