1. 22 Apr, 2021 2 commits
    • Arnd Bergmann's avatar
      net: enetc: fix link error again · 74c97ea3
      Arnd Bergmann authored
      A link time bug that I had fixed before has come back now that
      another sub-module was added to the enetc driver:
      
      ERROR: modpost: "enetc_ierb_register_pf" [drivers/net/ethernet/freescale/enetc/fsl-enetc.ko] undefined!
      
      The problem is that the enetc Makefile is not actually used for
      the ierb module if that is the only built-in driver in there
      and everything else is a loadable module.
      
      Fix it by always entering the directory this time, regardless
      of which symbols are configured. This should reliably fix the
      problem and prevent it from coming back another time.
      
      Fixes: 112463dd ("net: dsa: felix: fix link error")
      Fixes: e7d48e5f ("net: enetc: add a mini driver for the Integrated Endpoint Register Block")
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Acked-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      74c97ea3
    • Arnd Bergmann's avatar
      net: mana: fix PCI_HYPERV dependency · 45b102dd
      Arnd Bergmann authored
      The MANA driver causes a build failure in some configurations when
      it selects an unavailable symbol:
      
      WARNING: unmet direct dependencies detected for PCI_HYPERV
        Depends on [n]: PCI [=y] && X86_64 [=y] && HYPERV [=n] && PCI_MSI [=y] && PCI_MSI_IRQ_DOMAIN [=y] && SYSFS [=y]
        Selected by [y]:
        - MICROSOFT_MANA [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICROSOFT [=y] && PCI_MSI [=y] && X86_64 [=y]
      drivers/pci/controller/pci-hyperv.c: In function 'hv_irq_unmask':
      drivers/pci/controller/pci-hyperv.c:1217:9: error: implicit declaration of function 'hv_set_msi_entry_from_desc' [-Werror=implicit-function-declaration]
       1217 |         hv_set_msi_entry_from_desc(&params->int_entry.msi_entry, msi_desc);
            |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
      
      A PCI driver should never depend on a particular host bridge
      implementation in the first place, but if we have this dependency
      it's better to express it as a 'depends on' rather than 'select'.
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Reviewed-by: default avatarDexuan Cui <decui@microsoft.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      45b102dd
  2. 21 Apr, 2021 18 commits
  3. 20 Apr, 2021 20 commits