Commits · 774f13ac2b567207f04eb34d25188f5daec57f9e · Kirill Smelkov / linux

14 Feb, 2023 39 commits

dm: declare variables static when sensible · 774f13ac

Heinz Mauelshagen authored Feb 07, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

774f13ac

dm: fix suspect indent whitespace · 23fda2ef

Heinz Mauelshagen authored Feb 07, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

23fda2ef

dm ioctl: prefer strscpy() instead of strlcpy() · 22a8b849

Heinz Mauelshagen authored Feb 07, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

22a8b849

dm: avoid void function return statements · b39b7324

Heinz Mauelshagen authored Feb 07, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

b39b7324

dm integrity: change macros min/max() -> min_t/max_t where appropriate · ba287d7c
Heinz Mauelshagen authored Feb 07, 2023
```
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
```
ba287d7c

dm: fix use of sizeof() macro · 8d1058fb

Heinz Mauelshagen authored Feb 07, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

8d1058fb

dm: avoid 'do {} while(0)' loop in single statement macros · 6cc435fa
Heinz Mauelshagen authored Feb 07, 2023
```
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
```
6cc435fa

dm log: avoid multiple line dereference · dcdd4679

Heinz Mauelshagen authored Feb 07, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

dcdd4679

dm log: avoid trailing semicolon in macro · fb99e87b

Heinz Mauelshagen authored Feb 07, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

fb99e87b

dm ioctl: have constant on the right side of the test · 5cae0aa7
Heinz Mauelshagen authored Feb 07, 2023
```
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
```
5cae0aa7

dm: don't indent labels · a6ba79c0

Heinz Mauelshagen authored Feb 07, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

a6ba79c0

dm: avoid inline filenames · 9bfeac5d

Heinz Mauelshagen authored Feb 07, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

9bfeac5d

dm: add missing blank line after declarations/fix those · b30f1607
Heinz Mauelshagen authored Feb 07, 2023
```
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
```
b30f1607

dm: avoid useless 'else' after 'break' or return' · 1c3fe2fa

Heinz Mauelshagen authored Feb 07, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

1c3fe2fa

dm: favour __packed versus "__attribute__ ((packed))" · ae99111e
Heinz Mauelshagen authored Feb 07, 2023
```
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
```
ae99111e
dm: favour __aligned(N) versus "__attribute__ (aligned(N))" · f8922a48
Heinz Mauelshagen authored Feb 07, 2023
```
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
```
f8922a48

dm: avoid using symbolic permissions · 6a808034

Heinz Mauelshagen authored Feb 06, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

6a808034

dm: prefer '"%s...", __func__' · 1c131886

Heinz Mauelshagen authored Feb 06, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

1c131886

dm: adjust EXPORT_SYMBOL() to follow functions immediately · aa07f9d8
Heinz Mauelshagen authored Feb 03, 2023
```
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
```
aa07f9d8

dm: avoid split of quoted strings where possible · 2e84fecf

Heinz Mauelshagen authored Feb 03, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

2e84fecf

dm: remove unnecessary braces from single statement blocks · 2d0f25cb
Heinz Mauelshagen authored Feb 02, 2023
```
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
```
2d0f25cb

dm: add missing empty lines · 0ef0b471

Heinz Mauelshagen authored Feb 01, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

0ef0b471

dm: add argument identifier names · 02f10ba1

Heinz Mauelshagen authored Feb 01, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

02f10ba1

dm: avoid spaces before function arguments or in favour of tabs · 8ca817c4
Heinz Mauelshagen authored Feb 01, 2023
```
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
```
8ca817c4

dm block-manager: avoid not required parentheses · beecc843

Heinz Mauelshagen authored Feb 01, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

beecc843

dm crypt: correct 'foo*' to 'foo *' · ced6e475

Heinz Mauelshagen authored Jan 31, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

ced6e475

dm: fix trailing statements · 03b18887

Heinz Mauelshagen authored Jan 30, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

03b18887

dm: fix undue/missing spaces · 43be9c74

Heinz Mauelshagen authored Jan 30, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

43be9c74

dm: correct block comments format. · a4a82ce3

Heinz Mauelshagen authored Jan 26, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

a4a82ce3

dm: address indent/space issues · 255e2646

Heinz Mauelshagen authored Jan 25, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

255e2646

dm: address space issues relative to switch/while/for/... · 96422281
Heinz Mauelshagen authored Jan 25, 2023
```
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
```
96422281

dm: avoid initializing static variables · 2f06cd12

Heinz Mauelshagen authored Jan 30, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

2f06cd12

dm: enclose complex macros into parentheses where possible · 44bc08ed
Heinz Mauelshagen authored Feb 01, 2023
```
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
```
44bc08ed

dm: avoid assignment in if conditions · d715fa23

Heinz Mauelshagen authored Feb 01, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

d715fa23

dm: change "unsigned" to "unsigned int" · 86a3238c

Heinz Mauelshagen authored Jan 25, 2023

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

86a3238c

dm: use fsleep() instead of msleep() for deterministic sleep duration · 238d991f
Heinz Mauelshagen authored Jan 25, 2023
```
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
```
238d991f
dm: prefer kmap_local_page() instead of deprecated kmap_atomic() · 0d78954a
Heinz Mauelshagen authored Feb 07, 2023
```
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
```
0d78954a

dm: add missing SPDX-License-Indentifiers · 3bd94003

Heinz Mauelshagen authored Jan 25, 2023

'GPL-2.0-only' is used instead of 'GPL-2.0' because SPDX has
deprecated its use.
Suggested-by: John Wiele <jwiele@redhat.com>
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

3bd94003

dm: send just one event on resize, not two · 7533afa1

Mikulas Patocka authored Feb 07, 2023

Device mapper sends an uevent when the device is suspended, using the
function set_capacity_and_notify. However, this causes a race condition
with udev.

Udev skips scanning dm devices that are suspended. If we send an uevent
while we are suspended, udev will be racing with device mapper resume
code. If the device mapper resume code wins the race, udev will process
the uevent after the device is resumed and it will properly scan the
device.

However, if udev wins the race, it will receive the uevent, find out that
the dm device is suspended and skip scanning the device. This causes bugs
such as systemd unmounting the device - see
https://bugzilla.redhat.com/show_bug.cgi?id=2158628

This commit fixes this race.

We replace the function set_capacity_and_notify with set_capacity, so that
the uevent is not sent at this point. In do_resume, we detect if the
capacity has changed and we pass a boolean variable need_resize_uevent to
dm_kobject_uevent. dm_kobject_uevent adds "RESIZE=1" to the uevent if
need_resize_uevent is set.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Tested-by: Peter Rajnoha <prajnoha@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

7533afa1

12 Feb, 2023 1 commit

dm table: check that a dm device doesn't reference itself · d1c0e158

Benjamin Marzinski authored Jan 31, 2023

If a DM device's table references itself, it will crash the kernel with an
infinite recursion. Check for a self-reference in dm_get_device(). This
is a quick check, but it won't catch more complicated circular references.
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

d1c0e158