1. 06 Mar, 2021 40 commits
    • Arnaldo Carvalho de Melo's avatar
      perf map: Tighten snprintf() string precision to pass gcc check on some 32-bit arches · 77d02bd0
      Arnaldo Carvalho de Melo authored
      Noticed on a debian:experimental mips and mipsel cross build build
      environment:
      
        perfbuilder@ec265a086e9b:~$ mips-linux-gnu-gcc --version | head -1
        mips-linux-gnu-gcc (Debian 10.2.1-3) 10.2.1 20201224
        perfbuilder@ec265a086e9b:~$
      
          CC       /tmp/build/perf/util/map.o
        util/map.c: In function 'map__new':
        util/map.c:109:5: error: '%s' directive output may be truncated writing between 1 and 2147483645 bytes into a region of size 4096 [-Werror=format-truncation=]
          109 |    "%s/platforms/%s/arch-%s/usr/lib/%s",
              |     ^~
        In file included from /usr/mips-linux-gnu/include/stdio.h:867,
                         from util/symbol.h:11,
                         from util/map.c:2:
        /usr/mips-linux-gnu/include/bits/stdio2.h:67:10: note: '__builtin___snprintf_chk' output 32 or more bytes (assuming 4294967321) into a destination of size 4096
           67 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
              |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           68 |        __bos (__s), __fmt, __va_arg_pack ());
              |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        cc1: all warnings being treated as errors
      
      Since we have the lenghts for what lands in that place, use it to give
      the compiler more info and make it happy.
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      77d02bd0
    • Ravi Bangoria's avatar
      perf report: Fix -F for branch & mem modes · 6740a4e7
      Ravi Bangoria authored
      perf report fails to add valid additional fields with -F when
      used with branch or mem modes. Fix it.
      
      Before patch:
      
        $ perf record -b
        $ perf report -b -F +srcline_from --stdio
        Error:
        Invalid --fields key: `srcline_from'
      
      After patch:
      
        $ perf report -b -F +srcline_from --stdio
        # Samples: 8K of event 'cycles'
        # Event count (approx.): 8784
        ...
      
      Committer notes:
      
      There was an inversion: when looking at branch stack dimensions (keys)
      it was checking if the sort mode was 'mem', not 'branch'.
      
      Fixes: aa6b3c99 ("perf report: Make -F more strict like -s")
      Reported-by: default avatarAthira Jajeev <atrajeev@linux.vnet.ibm.com>
      Signed-off-by: default avatarRavi Bangoria <ravi.bangoria@linux.ibm.com>
      Reviewed-by: default avatarAthira Jajeev <atrajeev@linux.vnet.ibm.com>
      Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Tested-by: default avatarAthira Jajeev <atrajeev@linux.vnet.ibm.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Kan Liang <kan.liang@linux.intel.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Link: http://lore.kernel.org/lkml/20210304062958.85465-1-ravi.bangoria@linux.ibm.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      6740a4e7
    • Arnaldo Carvalho de Melo's avatar
      perf tests x86: Move insn.h include to make sure it finds stddef.h · c1f272df
      Arnaldo Carvalho de Melo authored
      In some versions of alpine Linux the perf build is broken since commit
      1d509f2a ("x86/insn: Support big endian cross-compiles"):
      
        In file included from /usr/include/linux/byteorder/little_endian.h:13,
                         from /usr/include/asm/byteorder.h:5,
                         from arch/x86/util/../../../../arch/x86/include/asm/insn.h:10,
                         from arch/x86/util/archinsn.c:2:
        /usr/include/linux/swab.h:161:8: error: unknown type name '__always_inline'
         static __always_inline __u16 __swab16p(const __u16 *p)
      
      So move the inclusion of arch/x86/include/asm/insn.h to later in the
      places where linux/stddef.h (that conditionally defines
      __always_inline) to workaround this problem on Alpine Linux 3.9 to 3.11,
      3.12 onwards works.
      
      Cc: Josh Poimboeuf <jpoimboe@redhat.com>
      Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      c1f272df
    • Kan Liang's avatar
      perf test: Support the ins_lat check in the X86 specific test · 7d9d4c6e
      Kan Liang authored
      The ins_lat of PERF_SAMPLE_WEIGHT_STRUCT stands for the instruction
      latency, which is only available for X86. Add a X86 specific test for
      the ins_lat and PERF_SAMPLE_WEIGHT_STRUCT type.
      
      The test__x86_sample_parsing() uses the same way as the
      test__sample_parsing() to verify a sample type. Since the ins_lat and
      PERF_SAMPLE_WEIGHT_STRUCT are the only X86 specific sample type for now,
      the test__x86_sample_parsing() only verify the PERF_SAMPLE_WEIGHT_STRUCT
      type. Other sample types are still verified in the generic test.
      
        $ perf test 77 -v
        77: x86 Sample parsing                                              :
        --- start ---
        test child forked, pid 102370
        test child finished with 0
        ---- end ----
        x86 Sample parsing: Ok
      Signed-off-by: default avatarKan Liang <kan.liang@linux.intel.com>
      Cc: Athira Jajeev <atrajeev@linux.vnet.ibm.com>
      Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
      Cc: Sumanth Korikkar <sumanthk@linux.ibm.com>
      Cc: Sven Schnelle <svens@linux.ibm.com>
      Cc: Thomas Richter <tmricht@linux.ibm.com>
      Cc: Vasily Gorbik <gor@linux.ibm.com>
      Link: http://lore.kernel.org/lkml/1614787285-104151-2-git-send-email-kan.liang@linux.intel.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      7d9d4c6e
    • Kan Liang's avatar
      perf test: Fix sample-parsing failure on non-x86 platforms · a8146d66
      Kan Liang authored
      Executing 'perf test 27' fails on s390:
      
        [root@t35lp46 perf]# ./perf test -Fv 27
        27: Sample parsing
        --- start ---
        ---- end ----
        Sample parsing: FAILED!
        [root@t35lp46 perf]#
      
      The commit fbefe9c2 ("perf tools: Support arch specific
      PERF_SAMPLE_WEIGHT_STRUCT processing") changes the ins_lat to a
      model-specific variable only for X86, but perf test still verify the
      variable in the generic test.
      
      Remove the ins_lat check in the generic test. The following patch will
      add it in the X86 specific test.
      
      Fixes: fbefe9c2 ("perf tools: Support arch specific PERF_SAMPLE_WEIGHT_STRUCT processing")
      Reported-by: default avatarThomas Richter <tmricht@linux.ibm.com>
      Signed-off-by: default avatarKan Liang <kan.liang@linux.intel.com>
      Tested-by: default avatarThomas Richter <tmricht@linux.ibm.com>
      Cc: Athira Jajeev <atrajeev@linux.vnet.ibm.com>
      Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
      Cc: Sumanth Korikkar <sumanthk@linux.ibm.com>
      Cc: Sven Schnelle <svens@linux.ibm.com>
      Cc: Vasily Gorbik <gor@linux.ibm.com>
      Link: http://lore.kernel.org/lkml/1614787285-104151-1-git-send-email-kan.liang@linux.intel.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      a8146d66
    • Nicholas Fraser's avatar
      perf archive: Fix filtering of empty build-ids · ec4d0a76
      Nicholas Fraser authored
      A non-existent build-id used to be treated as all-zero SHA-1 hash.
      Build-ids are now variable width. A non-existent build-id is an empty
      string and "perf buildid-list" pads this with spaces. This is true even
      when using old perf.data files recorded from older versions of perf;
      "perf buildid-list" never reports an all-zero hash anymore.
      
      This fixes "perf-archive" to skip missing build-ids by skipping lines
      that start with a padding space rather than with zeroes.
      Signed-off-by: default avatarNicholas Fraser <nfraser@codeweavers.com>
      Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Huw Davies <huw@codeweavers.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Ulrich Czekalla <uczekalla@codeweavers.com>
      Link: https://lore.kernel.org/r/442bffc7-ac5c-0975-b876-a549efce2413@codeweavers.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      ec4d0a76
    • Namhyung Kim's avatar
      perf daemon: Fix compile error with Asan · bd57a9f3
      Namhyung Kim authored
      I'm seeing a build failure when build with address sanitizer.  It seems
      we could write to the name[100] if the var is longer.
      
        $ make EXTRA_CFLAGS=-fsanitize=address
        ...
          CC       builtin-daemon.o
        In function ‘get_session_name’,
          inlined from ‘session_config’ at builtin-daemon.c:164:6,
          inlined from ‘server_config’ at builtin-daemon.c:223:10:
        builtin-daemon.c:155:11: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
          155 |  *session = 0;
              |  ~~~~~~~~~^~~
        builtin-daemon.c: In function ‘server_config’:
        builtin-daemon.c:162:7: note: at offset 100 to object ‘name’ with size 100 declared here
          162 |  char name[100];
              |       ^~~~
      
      Fixes: c0666261 ("perf daemon: Add config file support")
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: https://lore.kernel.org/r/20210224071438.686677-1-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      bd57a9f3
    • Namhyung Kim's avatar
      perf stat: Fix use-after-free when -r option is used · 513068f2
      Namhyung Kim authored
      I got a segfault when using -r option with event groups.  The option
      makes it run the workload multiple times and it will reuse the evlist
      and evsel for each run.
      
      While most of resources are allocated and freed properly, the id hash
      in the evlist was not and it resulted in the bug.  You can see it with
      the address sanitizer like below:
      
        $ perf stat -r 100 -e '{cycles,instructions}' true
        =================================================================
        ==693052==ERROR: AddressSanitizer: heap-use-after-free on
            address 0x6080000003d0 at pc 0x558c57732835 bp 0x7fff1526adb0 sp 0x7fff1526ada8
        WRITE of size 8 at 0x6080000003d0 thread T0
          #0 0x558c57732834 in hlist_add_head /home/namhyung/project/linux/tools/include/linux/list.h:644
          #1 0x558c57732834 in perf_evlist__id_hash /home/namhyung/project/linux/tools/lib/perf/evlist.c:237
          #2 0x558c57732834 in perf_evlist__id_add /home/namhyung/project/linux/tools/lib/perf/evlist.c:244
          #3 0x558c57732834 in perf_evlist__id_add_fd /home/namhyung/project/linux/tools/lib/perf/evlist.c:285
          #4 0x558c5747733e in store_evsel_ids util/evsel.c:2765
          #5 0x558c5747733e in evsel__store_ids util/evsel.c:2782
          #6 0x558c5730b717 in __run_perf_stat /home/namhyung/project/linux/tools/perf/builtin-stat.c:895
          #7 0x558c5730b717 in run_perf_stat /home/namhyung/project/linux/tools/perf/builtin-stat.c:1014
          #8 0x558c5730b717 in cmd_stat /home/namhyung/project/linux/tools/perf/builtin-stat.c:2446
          #9 0x558c57427c24 in run_builtin /home/namhyung/project/linux/tools/perf/perf.c:313
          #10 0x558c572b1a48 in handle_internal_command /home/namhyung/project/linux/tools/perf/perf.c:365
          #11 0x558c572b1a48 in run_argv /home/namhyung/project/linux/tools/perf/perf.c:409
          #12 0x558c572b1a48 in main /home/namhyung/project/linux/tools/perf/perf.c:539
          #13 0x7fcadb9f7d09 in __libc_start_main ../csu/libc-start.c:308
          #14 0x558c572b60f9 in _start (/home/namhyung/project/linux/tools/perf/perf+0x45d0f9)
      
      Actually the nodes in the hash table are struct perf_stream_id and
      they were freed in the previous run.  Fix it by resetting the hash.
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: https://lore.kernel.org/r/20210225035148.778569-2-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      513068f2
    • Namhyung Kim's avatar
      libperf: Add perf_evlist__reset_id_hash() · e2a99c9a
      Namhyung Kim authored
      Add the perf_evlist__reset_id_hash() function as an internal function so
      that it can be called by perf to reset the hash table.  This is
      necessary for 'perf stat' to run the workload multiple times.
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: https://lore.kernel.org/r/20210225035148.778569-1-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      e2a99c9a
    • Jin Yao's avatar
      perf stat: Fix wrong skipping for per-die aggregation · 034f7ee1
      Jin Yao authored
      Uncore becomes die-scope on Xeon Cascade Lake-AP and perf has supported
      --per-die aggregation yet.
      
      One issue is found in check_per_pkg() for uncore events running on AP
      system. On cascade Lake-AP, we have:
      
      S0-D0
      S0-D1
      S1-D0
      S1-D1
      
      But in check_per_pkg(), S0-D1 and S1-D1 are skipped because the mask
      bits for S0 and S1 have been set for S0-D0 and S1-D0. It doesn't check
      die_id. So the counting for S0-D1 and S1-D1 are set to zero.  That's not
      correct.
      
        root@lkp-csl-2ap4 ~# ./perf stat -a -I 1000 -e llc_misses.mem_read --per-die -- sleep 5
           1.001460963 S0-D0           1            1317376 Bytes llc_misses.mem_read
           1.001460963 S0-D1           1             998016 Bytes llc_misses.mem_read
           1.001460963 S1-D0           1             970496 Bytes llc_misses.mem_read
           1.001460963 S1-D1           1            1291264 Bytes llc_misses.mem_read
           2.003488021 S0-D0           1            1082048 Bytes llc_misses.mem_read
           2.003488021 S0-D1           1            1919040 Bytes llc_misses.mem_read
           2.003488021 S1-D0           1             890752 Bytes llc_misses.mem_read
           2.003488021 S1-D1           1            2380800 Bytes llc_misses.mem_read
           3.005613270 S0-D0           1            1126080 Bytes llc_misses.mem_read
           3.005613270 S0-D1           1            2898176 Bytes llc_misses.mem_read
           3.005613270 S1-D0           1             870912 Bytes llc_misses.mem_read
           3.005613270 S1-D1           1            3388608 Bytes llc_misses.mem_read
           4.007627598 S0-D0           1            1124608 Bytes llc_misses.mem_read
           4.007627598 S0-D1           1            3884416 Bytes llc_misses.mem_read
           4.007627598 S1-D0           1             921088 Bytes llc_misses.mem_read
           4.007627598 S1-D1           1            4451840 Bytes llc_misses.mem_read
           5.001479927 S0-D0           1             963328 Bytes llc_misses.mem_read
           5.001479927 S0-D1           1            4831936 Bytes llc_misses.mem_read
           5.001479927 S1-D0           1             895104 Bytes llc_misses.mem_read
           5.001479927 S1-D1           1            5496640 Bytes llc_misses.mem_read
      
      From above output, we can see S0-D1 and S1-D1 don't report the interval
      values, they are continued to grow. That's because check_per_pkg()
      wrongly decides to use zero counts for S0-D1 and S1-D1.
      
      So in check_per_pkg(), we should use hashmap(socket,die) to decide if
      the cpu counts needs to skip. Only considering socket is not enough.
      
      Now with this patch,
      
        root@lkp-csl-2ap4 ~# ./perf stat -a -I 1000 -e llc_misses.mem_read --per-die -- sleep 5
           1.001586691 S0-D0           1            1229440 Bytes llc_misses.mem_read
           1.001586691 S0-D1           1             976832 Bytes llc_misses.mem_read
           1.001586691 S1-D0           1             938304 Bytes llc_misses.mem_read
           1.001586691 S1-D1           1            1227328 Bytes llc_misses.mem_read
           2.003776312 S0-D0           1            1586752 Bytes llc_misses.mem_read
           2.003776312 S0-D1           1             875392 Bytes llc_misses.mem_read
           2.003776312 S1-D0           1             855616 Bytes llc_misses.mem_read
           2.003776312 S1-D1           1             949376 Bytes llc_misses.mem_read
           3.006512788 S0-D0           1            1338880 Bytes llc_misses.mem_read
           3.006512788 S0-D1           1             920064 Bytes llc_misses.mem_read
           3.006512788 S1-D0           1             877184 Bytes llc_misses.mem_read
           3.006512788 S1-D1           1            1020736 Bytes llc_misses.mem_read
           4.008895291 S0-D0           1             926592 Bytes llc_misses.mem_read
           4.008895291 S0-D1           1             906368 Bytes llc_misses.mem_read
           4.008895291 S1-D0           1             892224 Bytes llc_misses.mem_read
           4.008895291 S1-D1           1             987712 Bytes llc_misses.mem_read
           5.001590993 S0-D0           1             962624 Bytes llc_misses.mem_read
           5.001590993 S0-D1           1             912512 Bytes llc_misses.mem_read
           5.001590993 S1-D0           1             891200 Bytes llc_misses.mem_read
           5.001590993 S1-D1           1             978432 Bytes llc_misses.mem_read
      
      On no-die system, die_id is 0, actually it's hashmap(socket,0), original behavior
      is not changed.
      Reported-by: default avatarYing Huang <ying.huang@intel.com>
      Signed-off-by: default avatarJin Yao <yao.jin@linux.intel.com>
      Acked-by: default avatarJiri Olsa <jolsa@kernel.org>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Andi Kleen <ak@linux.intel.com>
      Cc: Jin Yao <yao.jin@intel.com>
      Cc: Kan Liang <kan.liang@linux.intel.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Ying Huang <ying.huang@intel.com>
      Link: http://lore.kernel.org/lkml/20210128013417.25597-1-yao.jin@linux.intel.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      034f7ee1
    • Arnaldo Carvalho de Melo's avatar
      tools headers UAPI: Sync KVM's kvm.h and vmx.h headers with the kernel sources · 33dc525f
      Arnaldo Carvalho de Melo authored
      To pick the changes in:
      
        fe6b6bc8 ("KVM: VMX: Enable bus lock VM exit")
      
      That makes 'perf kvm-stat' aware of this new BUS_LOCK exit reason, thus
      addressing the following perf build warning:
      
        Warning: Kernel ABI header at 'tools/arch/x86/include/uapi/asm/vmx.h' differs from latest version at 'arch/x86/include/uapi/asm/vmx.h'
        diff -u tools/arch/x86/include/uapi/asm/vmx.h arch/x86/include/uapi/asm/vmx.h
      
      Cc: Chenyi Qiang <chenyi.qiang@intel.com>
      Cc: Paolo Bonzini <pbonzini@redhat.com>
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      33dc525f
    • Arnaldo Carvalho de Melo's avatar
      tools headers cpufeatures: Sync with the kernel sources · 1a9bcadd
      Arnaldo Carvalho de Melo authored
      To pick the changes from:
      
        3b9c723e ("KVM: SVM: Add support for SVM instruction address check change")
        b85a0425 ("Enumerate AVX Vector Neural Network instructions")
        fb35d30f ("x86/cpufeatures: Assign dedicated feature word for CPUID_0x8000001F[EAX]")
      
      This only causes these perf files to be rebuilt:
      
        CC       /tmp/build/perf/bench/mem-memcpy-x86-64-asm.o
        CC       /tmp/build/perf/bench/mem-memset-x86-64-asm.o
      
      And addresses this perf build warning:
      
        Warning: Kernel ABI header at 'tools/arch/x86/include/asm/cpufeatures.h' differs from latest version at 'arch/x86/include/asm/cpufeatures.h'
        diff -u tools/arch/x86/include/asm/cpufeatures.h arch/x86/include/asm/cpufeatures.h
      
      Cc: Borislav Petkov <bp@suse.de>
      Cc: Kyung Min Park <kyung.min.park@intel.com>
      Cc: Paolo Bonzini <pbonzini@redhat.com>
      Cc: Sean Christopherson <seanjc@google.com>
      Cc: Wei Huang <wei.huang2@amd.com>
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      1a9bcadd
    • Arnaldo Carvalho de Melo's avatar
      tools headers UAPI: Update tools' copy of linux/coresight-pmu.h · 6c0afc57
      Arnaldo Carvalho de Melo authored
      To get the changes in these commits:
      
        88f11864 ("coresight: etm-perf: Support PID tracing for kernel at EL2")
        53abf3fe ("coresight: etm-perf: Clarify comment on perf options")
      
      This will possibly be used in patches lined up for v5.13.
      
      And silence this perf build warning:
      
        Warning: Kernel ABI header at 'tools/include/linux/coresight-pmu.h' differs from latest version at 'include/linux/coresight-pmu.h'
        diff -u tools/include/linux/coresight-pmu.h include/linux/coresight-pmu.h
      
      Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
      Cc: Leo Yan <leo.yan@linaro.org>
      Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
      Cc: Mike Leach <mike.leach@linaro.org>
      Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      6c0afc57
    • Arnaldo Carvalho de Melo's avatar
      tools headers: Update syscall.tbl files to support mount_setattr · 743108e1
      Arnaldo Carvalho de Melo authored
      To pick the changes from:
      
        9caccd41 ("fs: introduce MOUNT_ATTR_IDMAP")
      
      This adds this new syscall to the tables used by tools such as 'perf
      trace', so that one can specify it by name and have it filtered, etc.
      
      Addressing these perf build warnings:
      
        Warning: Kernel ABI header at 'tools/perf/arch/x86/entry/syscalls/syscall_64.tbl' differs from latest version at 'arch/x86/entry/syscalls/syscall_64.tbl'
        diff -u tools/perf/arch/x86/entry/syscalls/syscall_64.tbl arch/x86/entry/syscalls/syscall_64.tbl
        Warning: Kernel ABI header at 'tools/perf/arch/powerpc/entry/syscalls/syscall.tbl' differs from latest version at 'arch/powerpc/kernel/syscalls/syscall.tbl'
        diff -u tools/perf/arch/powerpc/entry/syscalls/syscall.tbl arch/powerpc/kernel/syscalls/syscall.tbl
        Warning: Kernel ABI header at 'tools/perf/arch/s390/entry/syscalls/syscall.tbl' differs from latest version at 'arch/s390/kernel/syscalls/syscall.tbl'
        diff -u tools/perf/arch/s390/entry/syscalls/syscall.tbl arch/s390/kernel/syscalls/syscall.tbl
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Christian Brauner <christian.brauner@ubuntu.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Link: http://lore.kernel.org/lkml/YD6Wsxr9ByUbab/a@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      743108e1
    • Namhyung Kim's avatar
      perf test: Fix cpu and thread map leaks in perf_time_to_tsc test · 846580c2
      Namhyung Kim authored
      It should release the maps at the end.
      
        $ perf test -v 71
        71: Convert perf time to TSC                   :
        --- start ---
        test child forked, pid 178744
        mmap size 528384B
        1st event perf time 59207256505278 tsc 13187166645142
        rdtsc          time 59207256542151 tsc 13187166723020
        2nd event perf time 59207256543749 tsc 13187166726393
      
        =================================================================
        ==178744==ERROR: LeakSanitizer: detected memory leaks
      
        Direct leak of 40 byte(s) in 1 object(s) allocated from:
          #0 0x7faf601f9e8f in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
          #1 0x55b620cfc00a in cpu_map__trim_new /home/namhyung/project/linux/tools/lib/perf/cpumap.c:79
          #2 0x55b620cfca2f in perf_cpu_map__read /home/namhyung/project/linux/tools/lib/perf/cpumap.c:149
          #3 0x55b620cfd1ef in cpu_map__read_all_cpu_map /home/namhyung/project/linux/tools/lib/perf/cpumap.c:166
          #4 0x55b620cfd1ef in perf_cpu_map__new /home/namhyung/project/linux/tools/lib/perf/cpumap.c:181
          #5 0x55b6209ef1b2 in test__perf_time_to_tsc tests/perf-time-to-tsc.c:73
          #6 0x55b6209828fb in run_test tests/builtin-test.c:428
          #7 0x55b6209828fb in test_and_print tests/builtin-test.c:458
          #8 0x55b620984a53 in __cmd_test tests/builtin-test.c:679
          #9 0x55b620984a53 in cmd_test tests/builtin-test.c:825
          #10 0x55b6209f0cd4 in run_builtin /home/namhyung/project/linux/tools/perf/perf.c:313
          #11 0x55b62087aa88 in handle_internal_command /home/namhyung/project/linux/tools/perf/perf.c:365
          #12 0x55b62087aa88 in run_argv /home/namhyung/project/linux/tools/perf/perf.c:409
          #13 0x55b62087aa88 in main /home/namhyung/project/linux/tools/perf/perf.c:539
          #14 0x7faf5fd2fd09 in __libc_start_main ../csu/libc-start.c:308
      
        SUMMARY: AddressSanitizer: 72 byte(s) leaked in 2 allocation(s).
        test child finished with 1
        ---- end ----
        Convert perf time to TSC: FAILED!
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Andi Kleen <ak@linux.intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Leo Yan <leo.yan@linaro.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: https://lore.kernel.org/r/20210301140409.184570-12-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      846580c2
    • Namhyung Kim's avatar
      perf test: Fix cpu map leaks in cpu_map_print test · 690d91f5
      Namhyung Kim authored
      It should be released after printing the map.
      
        $ perf test -v 52
        52: Print cpu map                              :
        --- start ---
        test child forked, pid 172233
      
        =================================================================
        ==172233==ERROR: LeakSanitizer: detected memory leaks
      
        Direct leak of 156 byte(s) in 1 object(s) allocated from:
          #0 0x7fc472518e8f in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
          #1 0x55e63b378f7a in cpu_map__trim_new /home/namhyung/project/linux/tools/lib/perf/cpumap.c:79
          #2 0x55e63b37a05c in perf_cpu_map__new /home/namhyung/project/linux/tools/lib/perf/cpumap.c:237
          #3 0x55e63b056d16 in cpu_map_print tests/cpumap.c:102
          #4 0x55e63b056d16 in test__cpu_map_print tests/cpumap.c:120
          #5 0x55e63afff8fb in run_test tests/builtin-test.c:428
          #6 0x55e63afff8fb in test_and_print tests/builtin-test.c:458
          #7 0x55e63b001a53 in __cmd_test tests/builtin-test.c:679
          #8 0x55e63b001a53 in cmd_test tests/builtin-test.c:825
          #9 0x55e63b06dc44 in run_builtin /home/namhyung/project/linux/tools/perf/perf.c:313
          #10 0x55e63aef7a88 in handle_internal_command /home/namhyung/project/linux/tools/perf/perf.c:365
          #11 0x55e63aef7a88 in run_argv /home/namhyung/project/linux/tools/perf/perf.c:409
          #12 0x55e63aef7a88 in main /home/namhyung/project/linux/tools/perf/perf.c:539
          #13 0x7fc47204ed09 in __libc_start_main ../csu/libc-start.c:308
        ...
      
        SUMMARY: AddressSanitizer: 448 byte(s) leaked in 7 allocation(s).
        test child finished with 1
        ---- end ----
        Print cpu map: FAILED!
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Andi Kleen <ak@linux.intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Leo Yan <leo.yan@linaro.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: https://lore.kernel.org/r/20210301140409.184570-11-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      690d91f5
    • Namhyung Kim's avatar
      perf test: Fix a memory leak in thread_map_remove test · 641b6250
      Namhyung Kim authored
      The str should be freed after creating a thread map.  Also change the
      open-coded thread map deletion to a call to perf_thread_map__put().
      
        $ perf test -v 44
        44: Remove thread map                          :
        --- start ---
        test child forked, pid 165536
        2 threads: 165535, 165536
        1 thread: 165536
        0 thread:
      
        =================================================================
        ==165536==ERROR: LeakSanitizer: detected memory leaks
      
        Direct leak of 14 byte(s) in 1 object(s) allocated from:
          #0 0x7f54453ffe8f in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
          #1 0x7f5444f8c6a7 in __vasprintf_internal libio/vasprintf.c:71
      
        SUMMARY: AddressSanitizer: 14 byte(s) leaked in 1 allocation(s).
        test child finished with 1
        ---- end ----
        Remove thread map: FAILED!
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Andi Kleen <ak@linux.intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Leo Yan <leo.yan@linaro.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: https://lore.kernel.org/r/20210301140409.184570-10-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      641b6250
    • Namhyung Kim's avatar
      perf test: Fix a thread map leak in thread_map_synthesize test · 4be42882
      Namhyung Kim authored
      It missed to call perf_thread_map__put() after using the map.
      
        $ perf test -v 43
        43: Synthesize thread map                      :
        --- start ---
        test child forked, pid 162640
      
        =================================================================
        ==162640==ERROR: LeakSanitizer: detected memory leaks
      
        Direct leak of 32 byte(s) in 1 object(s) allocated from:
          #0 0x7fd48cdaa1f8 in __interceptor_realloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:164
          #1 0x563e6d5f8d0e in perf_thread_map__realloc /home/namhyung/project/linux/tools/lib/perf/threadmap.c:23
          #2 0x563e6d3ef69a in thread_map__new_by_pid util/thread_map.c:46
          #3 0x563e6d2cec90 in test__thread_map_synthesize tests/thread-map.c:97
          #4 0x563e6d27d8fb in run_test tests/builtin-test.c:428
          #5 0x563e6d27d8fb in test_and_print tests/builtin-test.c:458
          #6 0x563e6d27fa53 in __cmd_test tests/builtin-test.c:679
          #7 0x563e6d27fa53 in cmd_test tests/builtin-test.c:825
          #8 0x563e6d2ebce4 in run_builtin /home/namhyung/project/linux/tools/perf/perf.c:313
          #9 0x563e6d175a88 in handle_internal_command /home/namhyung/project/linux/tools/perf/perf.c:365
          #10 0x563e6d175a88 in run_argv /home/namhyung/project/linux/tools/perf/perf.c:409
          #11 0x563e6d175a88 in main /home/namhyung/project/linux/tools/perf/perf.c:539
          #12 0x7fd48c8dfd09 in __libc_start_main ../csu/libc-start.c:308
      
        SUMMARY: AddressSanitizer: 8224 byte(s) leaked in 2 allocation(s).
        test child finished with 1
        ---- end ----
        Synthesize thread map: FAILED!
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Andi Kleen <ak@linux.intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Leo Yan <leo.yan@linaro.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: https://lore.kernel.org/r/20210301140409.184570-9-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      4be42882
    • Namhyung Kim's avatar
      perf test: Fix cpu and thread map leaks in switch_tracking test · 953e7b59
      Namhyung Kim authored
      The evlist and cpu/thread maps should be released together.
      Otherwise the following error was reported by Asan.
      
        $ perf test -v 35
        35: Track with sched_switch                    :
        --- start ---
        test child forked, pid 159287
        Using CPUID GenuineIntel-6-8E-C
        mmap size 528384B
        1295 events recorded
      
        =================================================================
        ==159287==ERROR: LeakSanitizer: detected memory leaks
      
        Direct leak of 40 byte(s) in 1 object(s) allocated from:
          #0 0x7fa28d9a2e8f in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
          #1 0x5652f5a5affa in cpu_map__trim_new /home/namhyung/project/linux/tools/lib/perf/cpumap.c:79
          #2 0x5652f5a5ba1f in perf_cpu_map__read /home/namhyung/project/linux/tools/lib/perf/cpumap.c:149
          #3 0x5652f5a5c1df in cpu_map__read_all_cpu_map /home/namhyung/project/linux/tools/lib/perf/cpumap.c:166
          #4 0x5652f5a5c1df in perf_cpu_map__new /home/namhyung/project/linux/tools/lib/perf/cpumap.c:181
          #5 0x5652f5723bbf in test__switch_tracking tests/switch-tracking.c:350
          #6 0x5652f56e18fb in run_test tests/builtin-test.c:428
          #7 0x5652f56e18fb in test_and_print tests/builtin-test.c:458
          #8 0x5652f56e3a53 in __cmd_test tests/builtin-test.c:679
          #9 0x5652f56e3a53 in cmd_test tests/builtin-test.c:825
          #10 0x5652f574fcc4 in run_builtin /home/namhyung/project/linux/tools/perf/perf.c:313
          #11 0x5652f55d9a88 in handle_internal_command /home/namhyung/project/linux/tools/perf/perf.c:365
          #12 0x5652f55d9a88 in run_argv /home/namhyung/project/linux/tools/perf/perf.c:409
          #13 0x5652f55d9a88 in main /home/namhyung/project/linux/tools/perf/perf.c:539
          #14 0x7fa28d4d8d09 in __libc_start_main ../csu/libc-start.c:308
      
        SUMMARY: AddressSanitizer: 72 byte(s) leaked in 2 allocation(s).
        test child finished with 1
        ---- end ----
        Track with sched_switch: FAILED!
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Andi Kleen <ak@linux.intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Leo Yan <leo.yan@linaro.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: https://lore.kernel.org/r/20210301140409.184570-8-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      953e7b59
    • Namhyung Kim's avatar
      perf test: Fix cpu and thread map leaks in keep_tracking test · f2c3202b
      Namhyung Kim authored
      The evlist and the cpu/thread maps should be released together.
      Otherwise following error was reported by Asan.
      
        $ perf test -v 28
        28: Use a dummy software event to keep tracking:
        --- start ---
        test child forked, pid 156810
        mmap size 528384B
      
        =================================================================
        ==156810==ERROR: LeakSanitizer: detected memory leaks
      
        Direct leak of 40 byte(s) in 1 object(s) allocated from:
          #0 0x7f637d2bce8f in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
          #1 0x55cc6295cffa in cpu_map__trim_new /home/namhyung/project/linux/tools/lib/perf/cpumap.c:79
          #2 0x55cc6295da1f in perf_cpu_map__read /home/namhyung/project/linux/tools/lib/perf/cpumap.c:149
          #3 0x55cc6295e1df in cpu_map__read_all_cpu_map /home/namhyung/project/linux/tools/lib/perf/cpumap.c:166
          #4 0x55cc6295e1df in perf_cpu_map__new /home/namhyung/project/linux/tools/lib/perf/cpumap.c:181
          #5 0x55cc626287cf in test__keep_tracking tests/keep-tracking.c:84
          #6 0x55cc625e38fb in run_test tests/builtin-test.c:428
          #7 0x55cc625e38fb in test_and_print tests/builtin-test.c:458
          #8 0x55cc625e5a53 in __cmd_test tests/builtin-test.c:679
          #9 0x55cc625e5a53 in cmd_test tests/builtin-test.c:825
          #10 0x55cc62651cc4 in run_builtin /home/namhyung/project/linux/tools/perf/perf.c:313
          #11 0x55cc624dba88 in handle_internal_command /home/namhyung/project/linux/tools/perf/perf.c:365
          #12 0x55cc624dba88 in run_argv /home/namhyung/project/linux/tools/perf/perf.c:409
          #13 0x55cc624dba88 in main /home/namhyung/project/linux/tools/perf/perf.c:539
          #14 0x7f637cdf2d09 in __libc_start_main ../csu/libc-start.c:308
      
        SUMMARY: AddressSanitizer: 72 byte(s) leaked in 2 allocation(s).
        test child finished with 1
        ---- end ----
        Use a dummy software event to keep tracking: FAILED!
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Andi Kleen <ak@linux.intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Leo Yan <leo.yan@linaro.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: https://lore.kernel.org/r/20210301140409.184570-7-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      f2c3202b
    • Namhyung Kim's avatar
      perf test: Fix cpu and thread map leaks in code_reading test · e06c3ca4
      Namhyung Kim authored
      The evlist and the cpu/thread maps should be released together.
      Otherwise following error was reported by Asan.
      
      Note that this test still has memory leaks in DSOs so it still fails
      even after this change.  I'll take a look at that too.
      
        # perf test -v 26
        26: Object code reading                        :
        --- start ---
        test child forked, pid 154184
        Looking at the vmlinux_path (8 entries long)
        symsrc__init: build id mismatch for vmlinux.
        symsrc__init: cannot get elf header.
        Using /proc/kcore for kernel data
        Using /proc/kallsyms for symbols
        Parsing event 'cycles'
        mmap size 528384B
        ...
        =================================================================
        ==154184==ERROR: LeakSanitizer: detected memory leaks
      
        Direct leak of 439 byte(s) in 1 object(s) allocated from:
          #0 0x7fcb66e77037 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:154
          #1 0x55ad9b7e821e in dso__new_id util/dso.c:1256
          #2 0x55ad9b8cfd4a in __machine__addnew_vdso util/vdso.c:132
          #3 0x55ad9b8cfd4a in machine__findnew_vdso util/vdso.c:347
          #4 0x55ad9b845b7e in map__new util/map.c:176
          #5 0x55ad9b8415a2 in machine__process_mmap2_event util/machine.c:1787
          #6 0x55ad9b8fab16 in perf_tool__process_synth_event util/synthetic-events.c:64
          #7 0x55ad9b8fab16 in perf_event__synthesize_mmap_events util/synthetic-events.c:499
          #8 0x55ad9b8fbfdf in __event__synthesize_thread util/synthetic-events.c:741
          #9 0x55ad9b8ff3e3 in perf_event__synthesize_thread_map util/synthetic-events.c:833
          #10 0x55ad9b738585 in do_test_code_reading tests/code-reading.c:608
          #11 0x55ad9b73b25d in test__code_reading tests/code-reading.c:722
          #12 0x55ad9b6f28fb in run_test tests/builtin-test.c:428
          #13 0x55ad9b6f28fb in test_and_print tests/builtin-test.c:458
          #14 0x55ad9b6f4a53 in __cmd_test tests/builtin-test.c:679
          #15 0x55ad9b6f4a53 in cmd_test tests/builtin-test.c:825
          #16 0x55ad9b760cc4 in run_builtin /home/namhyung/project/linux/tools/perf/perf.c:313
          #17 0x55ad9b5eaa88 in handle_internal_command /home/namhyung/project/linux/tools/perf/perf.c:365
          #18 0x55ad9b5eaa88 in run_argv /home/namhyung/project/linux/tools/perf/perf.c:409
          #19 0x55ad9b5eaa88 in main /home/namhyung/project/linux/tools/perf/perf.c:539
          #20 0x7fcb669acd09 in __libc_start_main ../csu/libc-start.c:308
      
          ...
        SUMMARY: AddressSanitizer: 471 byte(s) leaked in 2 allocation(s).
        test child finished with 1
        ---- end ----
        Object code reading: FAILED!
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Andi Kleen <ak@linux.intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Leo Yan <leo.yan@linaro.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: https://lore.kernel.org/r/20210301140409.184570-6-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      e06c3ca4
    • Namhyung Kim's avatar
      perf test: Fix cpu and thread map leaks in sw_clock_freq test · 97ab7c52
      Namhyung Kim authored
      The evlist has the maps with its own refcounts so we don't need to set
      the pointers to NULL.  Otherwise following error was reported by Asan.
      
      Also change the goto label since it doesn't need to have two.
      
        # perf test -v 25
        25: Software clock events period values        :
        --- start ---
        test child forked, pid 149154
        mmap size 528384B
        mmap size 528384B
      
        =================================================================
        ==149154==ERROR: LeakSanitizer: detected memory leaks
      
        Direct leak of 32 byte(s) in 1 object(s) allocated from:
          #0 0x7fef5cd071f8 in __interceptor_realloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:164
          #1 0x56260d5e8b8e in perf_thread_map__realloc /home/namhyung/project/linux/tools/lib/perf/threadmap.c:23
          #2 0x56260d3df7a9 in thread_map__new_by_tid util/thread_map.c:63
          #3 0x56260d2ac6b2 in __test__sw_clock_freq tests/sw-clock.c:65
          #4 0x56260d26d8fb in run_test tests/builtin-test.c:428
          #5 0x56260d26d8fb in test_and_print tests/builtin-test.c:458
          #6 0x56260d26fa53 in __cmd_test tests/builtin-test.c:679
          #7 0x56260d26fa53 in cmd_test tests/builtin-test.c:825
          #8 0x56260d2dbb64 in run_builtin /home/namhyung/project/linux/tools/perf/perf.c:313
          #9 0x56260d165a88 in handle_internal_command /home/namhyung/project/linux/tools/perf/perf.c:365
          #10 0x56260d165a88 in run_argv /home/namhyung/project/linux/tools/perf/perf.c:409
          #11 0x56260d165a88 in main /home/namhyung/project/linux/tools/perf/perf.c:539
          #12 0x7fef5c83cd09 in __libc_start_main ../csu/libc-start.c:308
      
          ...
        test child finished with 1
        ---- end ----
        Software clock events period values      : FAILED!
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Andi Kleen <ak@linux.intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Leo Yan <leo.yan@linaro.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: https://lore.kernel.org/r/20210301140409.184570-5-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      97ab7c52
    • Namhyung Kim's avatar
      perf test: Fix cpu and thread map leaks in task_exit test · 83d25ccd
      Namhyung Kim authored
      The evlist has the maps with its own refcounts so we don't need to set
      the pointers to NULL.  Otherwise following error was reported by Asan.
      
      Also change the goto label since it doesn't need to have two.
      
        # perf test -v 24
        24: Number of exit events of a simple workload :
        --- start ---
        test child forked, pid 145915
        mmap size 528384B
      
        =================================================================
        ==145915==ERROR: LeakSanitizer: detected memory leaks
      
        Direct leak of 32 byte(s) in 1 object(s) allocated from:
          #0 0x7fc44e50d1f8 in __interceptor_realloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:164
          #1 0x561cf50f4d2e in perf_thread_map__realloc /home/namhyung/project/linux/tools/lib/perf/threadmap.c:23
          #2 0x561cf4eeb949 in thread_map__new_by_tid util/thread_map.c:63
          #3 0x561cf4db7fd2 in test__task_exit tests/task-exit.c:74
          #4 0x561cf4d798fb in run_test tests/builtin-test.c:428
          #5 0x561cf4d798fb in test_and_print tests/builtin-test.c:458
          #6 0x561cf4d7ba53 in __cmd_test tests/builtin-test.c:679
          #7 0x561cf4d7ba53 in cmd_test tests/builtin-test.c:825
          #8 0x561cf4de7d04 in run_builtin /home/namhyung/project/linux/tools/perf/perf.c:313
          #9 0x561cf4c71a88 in handle_internal_command /home/namhyung/project/linux/tools/perf/perf.c:365
          #10 0x561cf4c71a88 in run_argv /home/namhyung/project/linux/tools/perf/perf.c:409
          #11 0x561cf4c71a88 in main /home/namhyung/project/linux/tools/perf/perf.c:539
          #12 0x7fc44e042d09 in __libc_start_main ../csu/libc-start.c:308
      
          ...
        test child finished with 1
        ---- end ----
        Number of exit events of a simple workload: FAILED!
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Andi Kleen <ak@linux.intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Leo Yan <leo.yan@linaro.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: https://lore.kernel.org/r/20210301140409.184570-4-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      83d25ccd
    • Namhyung Kim's avatar
      perf test: Fix a memory leak in attr test · 09a61c8f
      Namhyung Kim authored
      The get_argv_exec_path() returns a dynamic memory so it should be
      freed after use.
      
        $ perf test -v 17
        ...
        ==141682==ERROR: LeakSanitizer: detected memory leaks
      
        Direct leak of 33 byte(s) in 1 object(s) allocated from:
          #0 0x7f09107d2e8f in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
          #1 0x7f091035f6a7 in __vasprintf_internal libio/vasprintf.c:71
      
        SUMMARY: AddressSanitizer: 33 byte(s) leaked in 1 allocation(s).
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Andi Kleen <ak@linux.intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Leo Yan <leo.yan@linaro.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: https://lore.kernel.org/r/20210301140409.184570-3-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      09a61c8f
    • Namhyung Kim's avatar
      perf test: Fix cpu and thread map leaks in basic mmap test · b0faef92
      Namhyung Kim authored
      The evlist has the maps with its own refcounts so we don't need to set
      the pointers to NULL.  Otherwise following error was reported by Asan.
      
        # perf test -v 4
         4: Read samples using the mmap interface      :
        --- start ---
        test child forked, pid 139782
        mmap size 528384B
      
        =================================================================
        ==139782==ERROR: LeakSanitizer: detected memory leaks
      
        Direct leak of 40 byte(s) in 1 object(s) allocated from:
          #0 0x7f1f76daee8f in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
          #1 0x564ba21a0fea in cpu_map__trim_new /home/namhyung/project/linux/tools/lib/perf/cpumap.c:79
          #2 0x564ba21a1a0f in perf_cpu_map__read /home/namhyung/project/linux/tools/lib/perf/cpumap.c:149
          #3 0x564ba21a21cf in cpu_map__read_all_cpu_map /home/namhyung/project/linux/tools/lib/perf/cpumap.c:166
          #4 0x564ba21a21cf in perf_cpu_map__new /home/namhyung/project/linux/tools/lib/perf/cpumap.c:181
          #5 0x564ba1e48298 in test__basic_mmap tests/mmap-basic.c:55
          #6 0x564ba1e278fb in run_test tests/builtin-test.c:428
          #7 0x564ba1e278fb in test_and_print tests/builtin-test.c:458
          #8 0x564ba1e29a53 in __cmd_test tests/builtin-test.c:679
          #9 0x564ba1e29a53 in cmd_test tests/builtin-test.c:825
          #10 0x564ba1e95cb4 in run_builtin /home/namhyung/project/linux/tools/perf/perf.c:313
          #11 0x564ba1d1fa88 in handle_internal_command /home/namhyung/project/linux/tools/perf/perf.c:365
          #12 0x564ba1d1fa88 in run_argv /home/namhyung/project/linux/tools/perf/perf.c:409
          #13 0x564ba1d1fa88 in main /home/namhyung/project/linux/tools/perf/perf.c:539
          #14 0x7f1f768e4d09 in __libc_start_main ../csu/libc-start.c:308
      
          ...
        test child finished with 1
        ---- end ----
        Read samples using the mmap interface: FAILED!
        failed to open shell test directory: /home/namhyung/libexec/perf-core/tests/shell
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Stephane Eranian <eranian@google.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Leo Yan <leo.yan@linaro.org>
      Cc: Andi Kleen <ak@linux.intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Link: https://lore.kernel.org/r/20210301140409.184570-2-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      b0faef92
    • Jiri Olsa's avatar
      perf tools: Fix event's PMU name parsing · 84ea6036
      Jiri Olsa authored
      Jin Yao reported parser error for software event:
      
        # perf stat -e software/r1a/ -a -- sleep 1
        event syntax error: 'software/r1a/'
                             \___ parser error
      
      This happens after commit 8c3b1ba0 ("drm/i915/gt: Track the
      overall awake/busy time"), where new software-gt-awake-time event's
      non-pmu-event-style makes event parser conflict with software PMU.
      
      If we allow PE_PMU_EVENT_PRE to be parsed as PMU name, we fix the
      conflict and the following character '/' for PMU or '-' for
      non-pmu-event-style event allows parser to decide what even is
      specified.
      
      Fixes: 8c3b1ba0 ("drm/i915/gt: Track the overall awake/busy time")
      Reported-by: default avatarJin Yao <yao.jin@linux.intel.com>
      Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Chris Wilson <chris@chris-wilson.co.uk>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Michael Petlan <mpetlan@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: http://lore.kernel.org/lkml/20210301122315.63471-1-jolsa@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      84ea6036
    • Jiri Olsa's avatar
      perf daemon: Fix running test for non root user · 36bc511f
      Jiri Olsa authored
      John reported that the daemon test is not working for non root user.
      Changing the tests configurations so it's allowed to run under normal
      user.
      
      Fixes: 2291bb91 ("perf tests: Add daemon 'list' command test")
      Reported-by: default avatarJohn Garry <john.garry@huawei.com>
      Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
      Tested-by: default avatarJohn Garry <john.garry@huawei.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Michael Petlan <mpetlan@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: http://lore.kernel.org/lkml/20210301122510.64402-2-jolsa@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      36bc511f
    • Jiri Olsa's avatar
      perf daemon: Fix control fifo permissions · 31bf4e7c
      Jiri Olsa authored
      Add proper mode for mkfifo calls to get read and write permissions for
      user. We can't use O_RDWR in here, changing to standard permission
      value.
      
      Fixes: 6a6d1804 ("perf daemon: Set control fifo for session")
      Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: John Garry <john.garry@huawei.com>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Michael Petlan <mpetlan@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: http://lore.kernel.org/lkml/20210301122510.64402-1-jolsa@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      31bf4e7c
    • Antonio Terceiro's avatar
      perf build: Fix ccache usage in $(CC) when generating arch errno table · dacfc08d
      Antonio Terceiro authored
      This was introduced by commit e4ffd066 ("perf: Normalize gcc
      parameter when generating arch errno table").
      
      Assuming the first word of $(CC) is the actual compiler breaks usage
      like CC="ccache gcc": the script ends up calling ccache directly with
      gcc arguments, what fails. Instead of getting the first word, just
      remove from $(CC) any word that starts with a "-". This maintains the
      spirit of the original patch, while not breaking ccache users.
      
      Fixes: e4ffd066 ("perf: Normalize gcc parameter when generating arch errno table")
      Signed-off-by: default avatarAntonio Terceiro <antonio.terceiro@linaro.org>
      Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: He Zhe <zhe.he@windriver.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: stable@vger.kernel.org
      Link: http://lore.kernel.org/lkml/20210224130046.346977-1-antonio.terceiro@linaro.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      dacfc08d
    • Ian Rogers's avatar
      perf tools: Fix documentation of verbose options · b55ff1d1
      Ian Rogers authored
      Option doesn't take a value, make sure the man pages agree. For example:
      
        $ perf evlist --verbose=1
         Error: option `verbose' takes no value
      Signed-off-by: default avatarIan Rogers <irogers@google.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lore.kernel.org/lkml/20210226183145.1878782-1-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      b55ff1d1
    • Ian Rogers's avatar
      perf traceevent: Ensure read cmdlines are null terminated. · 137a5258
      Ian Rogers authored
      Issue detected by address sanitizer.
      
      Fixes: cd4ceb63 ("perf util: Save pid-cmdline mapping into tracing header")
      Signed-off-by: default avatarIan Rogers <irogers@google.com>
      Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lore.kernel.org/lkml/20210226221431.1985458-1-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      137a5258
    • Athira Rajeev's avatar
      perf bench numa: Fix the condition checks for max number of NUMA nodes · 394e4306
      Athira Rajeev authored
      In systems having higher node numbers available like node
      255, perf numa bench will fail with SIGABORT.
      
        <<>>
        perf: bench/numa.c:1416: init: Assertion `!(g->p.nr_nodes > 64 || g->p.nr_nodes < 0)' failed.
        Aborted (core dumped)
        <<>>
      
      Snippet from 'numactl -H' below on a powerpc system where the highest
      node number available is 255:
      
        available: 6 nodes (0,8,252-255)
        node 0 cpus: <cpu-list>
        node 0 size: 519587 MB
        node 0 free: 516659 MB
        node 8 cpus: <cpu-list>
        node 8 size: 523607 MB
        node 8 free: 486757 MB
        node 252 cpus:
        node 252 size: 0 MB
        node 252 free: 0 MB
        node 253 cpus:
        node 253 size: 0 MB
        node 253 free: 0 MB
        node 254 cpus:
        node 254 size: 0 MB
        node 254 free: 0 MB
        node 255 cpus:
        node 255 size: 0 MB
        node 255 free: 0 MB
        node distances:
        node   0   8  252  253  254  255
      
      Note: <cpu-list> expands to actual cpu list in the original output.
      These nodes 252-255 are to represent the memory on GPUs and are valid
      nodes.
      
      The perf numa bench init code has a condition check to see if the number
      of NUMA nodes (nr_nodes) exceeds MAX_NR_NODES. The value of MAX_NR_NODES
      defined in perf code is 64. And the 'nr_nodes' is the value from
      numa_max_node() which represents the highest node number available in the
      system. In some systems where we could have NUMA node 255, this condition
      check fails and results in SIGABORT.
      
      The numa benchmark uses static value of MAX_NR_NODES in the code to
      represent size of two NUMA node arrays and node bitmask used for setting
      memory policy. Patch adds a fix to dynamically allocate size for the
      two arrays and bitmask value based on the node numbers available in the
      system. With the fix, perf numa benchmark will work with node configuration
      on any system and thus removes the static MAX_NR_NODES value.
      Signed-off-by: default avatarAthira Jajeev <atrajeev@linux.vnet.ibm.com>
      Reviewed-by: default avatarSrikar Dronamraju <srikar@linux.vnet.ibm.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Kajol Jain <kjain@linux.ibm.com>
      Cc: Kan Liang <kan.liang@linux.intel.com>
      Cc: Madhavan Srinivasan <maddy@linux.ibm.com>
      Cc: Michael Ellerman <mpe@ellerman.id.au>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
      Cc: linuxppc-dev@lists.ozlabs.org
      Link: http://lore.kernel.org/lkml/1614271802-1503-1-git-send-email-atrajeev@linux.vnet.ibm.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      394e4306
    • Dmitry Safonov's avatar
      perf diff: Don't crash on freeing errno-session on the error path · ffc52b7a
      Dmitry Safonov authored
      __cmd_diff() sets result of perf_session__new() to d->session.
      
      In case of failure, it's errno and perf-diff may crash with:
      
        failed to open perf.data: Permission denied
        Failed to open perf.data
        Segmentation fault (core dumped)
      
      From the coredump:
      
      0  0x00005569a62b5955 in auxtrace__free (session=0xffffffffffffffff)
          at util/auxtrace.c:2681
      1  0x00005569a626b37d in perf_session__delete (session=0xffffffffffffffff)
          at util/session.c:295
      2  perf_session__delete (session=0xffffffffffffffff) at util/session.c:291
      3  0x00005569a618008a in __cmd_diff () at builtin-diff.c:1239
      4  cmd_diff (argc=<optimized out>, argv=<optimized out>) at builtin-diff.c:2011
      [..]
      
      Funny enough, it won't always crash. For me it crashes only if failed
      file is second in cmd-line: the reason is that cmd_diff() check files for
      branch-stacks [in check_file_brstack()] and if the first file doesn't
      have brstacks, it doesn't proceed to try open other files from cmd-line.
      
      Check d->session before calling perf_session__delete().
      
      Another solution would be assigning to temporary variable, checking it,
      but I find it easier to follow with IS_ERR() check in the same function.
      After some time it's still obvious why the check is needed, and with
      temp variable it's possible to make the same mistake.
      
      Committer testing:
      
        $ perf record sleep 1
        [ perf record: Woken up 1 times to write data ]
        [ perf record: Captured and wrote 0.001 MB perf.data (8 samples) ]
        $ perf diff
        failed to open perf.data.old: No such file or directory
        Failed to open perf.data.old
        $ perf record sleep 1
        [ perf record: Woken up 1 times to write data ]
        [ perf record: Captured and wrote 0.001 MB perf.data (8 samples) ]
        $ perf diff
        # Event 'cycles:u'
        #
        # Baseline  Delta Abs  Shared Object     Symbol
        # ........  .........  ................  ..........................
        #
             0.92%    +87.66%  [unknown]         [k] 0xffffffff8825de16
            11.39%     +0.04%  ld-2.32.so        [.] __GI___tunables_init
            87.70%             ld-2.32.so        [.] _dl_check_map_versions
        $ sudo chown root:root perf.data
        [sudo] password for acme:
        $ perf diff
        failed to open perf.data: Permission denied
        Failed to open perf.data
        Segmentation fault (core dumped)
        $
      
      After the patch:
      
        $ perf diff
        failed to open perf.data: Permission denied
        Failed to open perf.data
        $
      Signed-off-by: default avatarDmitry Safonov <dima@arista.com>
      Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Dmitry Safonov <0x7f454c46@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: dmitry safonov <dima@arista.com>
      Link: http://lore.kernel.org/lkml/20210302023533.1572231-1-dima@arista.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      ffc52b7a
    • Andreas Wendleder's avatar
      perf tools: Clean 'generated' directory used for creating the syscall table on x86 · 2b1919ec
      Andreas Wendleder authored
      Remove generated directory tools/perf/arch/x86/include/generated.
      Signed-off-by: default avatarAndreas Wendleder <andreas.wendleder@gmail.com>
      Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: http://lore.kernel.org/lkml/20210301185642.163396-1-gonsolo@gmail.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      2b1919ec
    • Jiri Olsa's avatar
      perf build: Move feature cleanup under tools/build · 762323eb
      Jiri Olsa authored
      Arnaldo reported issue for following build command:
      
        $ rm -rf /tmp/krava; mkdir /tmp/krava; make O=/tmp/krava clean
          CLEAN    config
        /bin/sh: line 0: cd: /tmp/krava/feature/: No such file or directory
        ../../scripts/Makefile.include:17: *** output directory "/tmp/krava/feature/" does not exist.  Stop.
        make[1]: *** [Makefile.perf:1010: config-clean] Error 2
        make: *** [Makefile:90: clean] Error 2
      
      The problem is that now that we include scripts/Makefile.include
      in feature's Makefile (which is fine and needed), we need to ensure
      the OUTPUT directory exists, before executing (out of tree) clean
      command.
      
      Removing the feature's cleanup from perf Makefile and fixing
      feature's cleanup under build Makefile, so it now checks that
      there's existing OUTPUT directory before calling the clean.
      
      Fixes: 211a741c ("tools: Factor Clang, LLC and LLVM utils definitions")
      Reported-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
      Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM/Clang v13-git
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Michael Petlan <mpetlan@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: http://lore.kernel.org/lkml/20210224150831.409639-1-jolsa@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      762323eb
    • Pierre Gondois's avatar
      perf tools: Cast (struct timeval).tv_sec when printing · ded2e511
      Pierre Gondois authored
      The musl-libc [1] defines (struct timeval).tv_sec as a 'long long' for
      arm and other architectures. The default build having a '-Wformat' flag,
      not casting the field when printing prevents from building perf.
      
      This patch casts the (struct timeval).tv_sec fields to the expected
      format.
      
      [1] git://git.musl-libc.org/muslSigned-off-by: default avatarPierre Gondois <Pierre.Gondois@arm.com>
      Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Douglas.raillard@arm.com
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: http://lore.kernel.org/lkml/20210224182410.5366-1-Pierre.Gondois@arm.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      ded2e511
    • Arnaldo Carvalho de Melo's avatar
      tools headers UAPI: Sync kvm.h headers with the kernel sources · 21b7e35b
      Arnaldo Carvalho de Melo authored
      To pick the changes in:
      
        d9a47eda ("KVM: PPC: Book3S HV: Introduce new capability for 2nd DAWR")
        8d4e7e80 ("KVM: x86: declare Xen HVM shared info capability and add test case")
        40da8ccd ("KVM: x86/xen: Add event channel interrupt vector upcall")
      
      These new IOCTLs are now supported on 'perf trace':
      
        $ tools/perf/trace/beauty/kvm_ioctl.sh > before
        $ cp include/uapi/linux/kvm.h tools/include/uapi/linux/kvm.h
        $ tools/perf/trace/beauty/kvm_ioctl.sh > after
        $ diff -u before after
        --- before	2021-02-23 09:55:46.229058308 -0300
        +++ after	2021-02-23 09:55:57.509308058 -0300
        @@ -91,6 +91,10 @@
         	[0xc1] = "GET_SUPPORTED_HV_CPUID",
         	[0xc6] = "X86_SET_MSR_FILTER",
         	[0xc7] = "RESET_DIRTY_RINGS",
        +	[0xc8] = "XEN_HVM_GET_ATTR",
        +	[0xc9] = "XEN_HVM_SET_ATTR",
        +	[0xca] = "XEN_VCPU_GET_ATTR",
        +	[0xcb] = "XEN_VCPU_SET_ATTR",
         	[0xe0] = "CREATE_DEVICE",
         	[0xe1] = "SET_DEVICE_ATTR",
         	[0xe2] = "GET_DEVICE_ATTR",
        $
      
      Addressing this perf build warning:
        Warning: Kernel ABI header at 'tools/include/uapi/linux/kvm.h' differs from latest version at 'include/uapi/linux/kvm.h'
        diff -u tools/include/uapi/linux/kvm.h include/uapi/linux/kvm.h
      
      Cc: David Woodhouse <dwmw@amazon.co.uk>
      Cc: Paul Mackerras <paulus@ozlabs.org>
      Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      21b7e35b
    • Arnaldo Carvalho de Melo's avatar
      tools headers UAPI s390: Sync ptrace.h kernel headers · 303550a4
      Arnaldo Carvalho de Melo authored
      To pick up the changes from:
      
        56e62a73 ("s390: convert to generic entry")
      
      That only adds two new defines, so shouldn't cause problems when
      building the BPF selftests.
      
      Silencing this perf build warning:
      
        Warning: Kernel ABI header at 'tools/arch/s390/include/uapi/asm/ptrace.h' differs from latest version at 'arch/s390/include/uapi/asm/ptrace.h'
        diff -u tools/arch/s390/include/uapi/asm/ptrace.h arch/s390/include/uapi/asm/ptrace.h
      
      Cc: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
      Cc: Sven Schnelle <svens@linux.ibm.com>
      Cc: Vasily Gorbik <gor@linux.ibm.com>
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      303550a4
    • Arnaldo Carvalho de Melo's avatar
      perf arch powerpc: Sync powerpc syscall.tbl with the kernel sources · add76c01
      Arnaldo Carvalho de Melo authored
      To get the changes in:
      
        fbcee2eb ("powerpc/32: Always save non volatile GPRs at syscall entry")
      
      That shouldn't cause any change in tooling, just silences the following
      tools/perf/ build warning:
      
        Warning: Kernel ABI header at 'tools/perf/arch/powerpc/entry/syscalls/syscall.tbl' differs from latest version at 'arch/powerpc/kernel/syscalls/syscall.tbl'
      
      Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
      Cc: Michael Ellerman <mpe@ellerman.id.au>
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      add76c01
    • Arnaldo Carvalho de Melo's avatar
      tools headers UAPI: Sync openat2.h with the kernel sources · 1e61463c
      Arnaldo Carvalho de Melo authored
      To pick the changes in:
      
        99668f61 ("fs: expose LOOKUP_CACHED through openat2() RESOLVE_CACHED")
      
      That don't result in any change in tooling, only silences this perf
      build warning:
      
        Warning: Kernel ABI header at 'tools/include/uapi/linux/openat2.h' differs from latest version at 'include/uapi/linux/openat2.h'
        diff -u tools/include/uapi/linux/openat2.h include/uapi/linux/openat2.h
      
      Cc: Al Viro <viro@zeniv.linux.org.uk>
      Cc: Jens Axboe <axboe@kernel.dk>
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      1e61463c