- 02 May, 2019 40 commits
-
-
Leo Yan authored
Since CoreSight hardware topology can use a 'hidden' funnel in the trace data path, this kind funnel doesn't have register for accessing and is used by default from hardware design perspective. Below is an example for related hardware topology: +------+ +------+ | cpu0 |->| ETM |-\ +------+ +------+ \-> +--------+ +-----+ ...... | Funnel |->| ETF |-\ Hidden funnel +------+ +------+ /-> +--------+ +-----+ \ | | cpu3 |->| ETM |-/ \ V +------+ +------+ \-> +--------+ | Funnel |-> ... +------+ +------+ /-> +--------+ | cpu4 |->| ETM |-\ / +------+ +------+ \-> +--------+ +-----+ / ...... | Funnel |->| ETF |-/ +------+ +------+ /-> +--------+ +-----+ | cpu7 |->| ETM |-/ +------+ +------+ The CoreSight funnel driver only supports dynamic funnel with registration register resource, thus it cannot support for the static funnel case and it's impossible to create trace data path for this case. This patch is to extend CoreSight funnel driver to support both for static funnel and dynamic funnel. For the dynamic funnel it reuses the code existed in the driver, for static funnel the driver will support device probe if without providing register resource and the driver skips registers accessing when detect the register base is NULL. Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Suzuki K Poulose <suzuki.poulose@arm.com> Cc: Wanglai Shi <shiwanglai@hisilicon.com> Suggested-by:Suzuki K Poulose <suzuki.poulose@arm.com> Signed-off-by:
Leo Yan <leo.yan@linaro.org> Reviewed-by:
Mathieu Poirier <mathieu.poirier@linaro.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Leo Yan authored
Following the same fashion with replicator DT binding, this patch is to unify the DT binding for funnel to support static and dynamic modes; finally we get the funnel DT binding as below: Before patch: Static funnel, aka. non-configurable funnel: Not supported; Dynamic funnel, aka. configurable funnel: "arm,coresight-funnel", "arm,primecell"; After patch: Static funnel: "arm,coresight-static-funnel"; Dynamic funnel: "arm,coresight-dynamic-funnel", "arm,primecell"; "arm,coresight-funnel", "arm,primecell"; (obsolete) At the end of this patch, it gives an example for static funnel DT binding, and updates the dynamic funnel example. Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Suzuki K Poulose <suzuki.poulose@arm.com> Cc: Wanglai Shi <shiwanglai@hisilicon.com> Signed-off-by:Rob Herring <robh@kernel.org> Signed-off-by:
-
Leo Yan authored
This patch adds a device id for the new static replicator compatible string; it changes the driver name from "coresight-replicator" to "coresight-static-replicator" as well. This patch also gives warning when use the replicator obsolete DT binding. Signed-off-by:
-
Leo Yan authored
CoreSight uses below bindings for replicator: Dynamic replicator, aka. configurable replicator: "arm,coresight-dynamic-replicator", "arm,primecell"; Static replicator, aka. non-configurable replicator: "arm,coresight-replicator"; The compatible string "arm,coresight-replicator" is not an explicit naming to express the replicator is 'static'. To unify the naming convention, this patch introduces a new compatible string "arm,coresight-static-replicator" for the static replicator; the compatible string "arm,coresight-replicator" is kept for backward compatibility, but tag it as obsolete and suggest to use the new compatible string. As result CoreSight replicator have below bindings: Dynamic replicator: "arm,coresight-dynamic-replicator", "arm,primecell"; Static replicator: "arm,coresight-static-replicator"; "arm,coresight-replicator"; (obsolete) Signed-off-by: -
Vinod Koul authored
Multi-blank lines do not help readability so remove them Checkpatch complains: CHECK: Please don't use multiple blank lines Signed-off-by:
Vinod Koul <vkoul@kernel.org> Signed-off-by:
-
Vinod Koul authored
For improving code readability it helps to have a blank line between function so add when missing. Checkpatch complains: CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by:
-
Vinod Koul authored
macro argument should be inside a parenthesis to avoid precedence issues checkpatch complains: CHECK: Macro argument 'n' may be better as '(n)' to avoid precedence issues Signed-off-by:
-
Vinod Koul authored
Found few more typos in the code, fix them CHECK: 'and and' may be misspelled - perhaps 'and'? CHECK: 'smaple' may be misspelled - perhaps 'sample'? Signed-off-by:
-
Vinod Koul authored
Modify the code to avoid multiple assignments by assigning to variable after error checks in soundwire bus. CHECK: multiple assignments should be avoided Signed-off-by:
-
Vinod Koul authored
Found few more issues reported checkpatch on code alignment so fix those as well in the intel module. Signed-off-by:
-
Vinod Koul authored
Found few more issues reported checkpatch on code alignment so fix those as well in the soundwire core. Signed-off-by:
-
Vinod Koul authored
Checkpatch warns that function definition of __sdw_register_driver misses argument, so add it WARNING: function definition argument 'struct module *' should also have an identifier name Signed-off-by:
-
Vinod Koul authored
Linux code style doesn't expect empty lines after braces and gives warning: CHECK: Blank lines aren't necessary after an open brace '{' Remove the empty line in intel module Signed-off-by: -
Vinod Koul authored
Linux code style doesn't expect empty lines after braces and gives warning: CHECK: Blank lines aren't necessary after an open brace '{' Remove the empty line in cadence lib Signed-off-by: -
Vinod Koul authored
Linux code style doesn't expect empty lines before or after braces and gives warning: CHECK: Blank lines aren't necessary after an open brace '{' CHECK: Blank lines aren't necessary before a close brace '}' Fix these instances in soundwire core Signed-off-by: -
Vinod Koul authored
Some more headers had C++ style SDPX line, fix that and change copyright so that it is consistent with rest of the code in subsystem Signed-off-by:
-
Vinod Koul authored
Move to help format instead of --help-- as that is not recommended and this makes file consistent with other instance Signed-off-by:
-
Pierre-Louis Bossart authored
For some reason the newlines are not used everywhere. Fix as needed. Reported-by:
Joe Perches <joe@perches.com> Reviewed-by:
Takashi Iwai <tiwai@suse.de> Signed-off-by:
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by:
-
Pierre-Louis Bossart authored
Extra newline does not improve readability. Reviewed-by:
-
Pierre-Louis Bossart authored
No need for explicit test against true Reviewed-by:
-
Pierre-Louis Bossart authored
While not strictly necessary, balanced parentheses help with code readability. Reviewed-by:
-
Pierre-Louis Bossart authored
Use Linux style Reviewed-by:
-
Pierre-Louis Bossart authored
No need for explicit test against true Reviewed-by:
-
Pierre-Louis Bossart authored
Extra parentheses required here Reviewed-by:
-
Pierre-Louis Bossart authored
Use Linux style Reviewed-by:
-
Pierre-Louis Bossart authored
Use Linux style Reviewed-by:
-
Pierre-Louis Bossart authored
Use Linux style Reviewed-by:
-
Pierre-Louis Bossart authored
Use Linux style Reviewed-by:
-
Pierre-Louis Bossart authored
No need for explicit test against true Reviewed-by:
-
Pierre-Louis Bossart authored
Use Linux style. In some cases parenthesis alignment is modified to keep the code readable. Reviewed-by:
-
Pierre-Louis Bossart authored
Use Linux style Reviewed-by:
-
Pierre-Louis Bossart authored
tools complain here and the location of the newline does not improve readability. Reviewed-by:
-
Pierre-Louis Bossart authored
no need for an explicit test against false reported by Coccinelle Reviewed-by:
-
Pierre-Louis Bossart authored
and make the code more readable Reviewed-by:
-
Pierre-Louis Bossart authored
spelling mistakes Reviewed-by:
-
Pierre-Louis Bossart authored
Use Linux style Reviewed-by:
-
Pierre-Louis Bossart authored
use Linux style Reviewed-by:
-
Vinod Koul authored
Some more headers had C++ style SDPX line, fix that and change copyright so that it is consistent with rest of the code in subsystem Signed-off-by:
-
Pierre-Louis Bossart authored
No C++ comments in .h files Reviewed-by:
-
Pierre-Louis Bossart authored
Move to the regular help format, --help-- is no longer recommended. Reviewed-by:
-
