- 27 Jul, 2018 8 commits
-
-
Jia-Ju Bai authored
atp_open(), atp_recover() and atp_resume() are never called in atomic context. They call usb_submit_urb() with GFP_ATOMIC, which is not necessary. GFP_ATOMIC can be replaced with GFP_KERNEL. This is found by a static analysis tool named DCNS written by myself. Signed-off-by:
Jia-Ju Bai <baijiaju1990@gmail.com> Signed-off-by:
Dmitry Torokhov <dmitry.torokhov@gmail.com>
-
Jia-Ju Bai authored
usb_probe() is never called in atomic context. It calls usb_alloc_coherent() with GFP_ATOMIC, which is not necessary. GFP_ATOMIC can be replaced with GFP_KERNEL. This is found by a static analysis tool named DCNS written by myself. Signed-off-by:
-
Jia-Ju Bai authored
powermate_alloc_buffers() is never called in atomic context. It calls usb_alloc_coherent() with GFP_ATOMIC, which is not necessary. GFP_ATOMIC can be replaced with GFP_KERNEL. This is found by a static analysis tool named DCNS written by myself. Signed-off-by:
-
Jia-Ju Bai authored
keyspan_probe() is never called in atomic context. It calls usb_alloc_coherent() with GFP_ATOMIC, which is not necessary. GFP_ATOMIC can be replaced with GFP_KERNEL. This is found by a static analysis tool named DCNS written by myself. Signed-off-by:
-
Jia-Ju Bai authored
wdt87xx_resume() is never called in atomic context. It calls mdelay() to busily wait, which is not necessary. mdelay() can be replaced with msleep(). This is found by a static analysis tool named DCNS written by myself. Signed-off-by:
-
Tim Schumacher authored
Move BTN_DEAD into the arrays with the specific button sets instead of assigning it for every iforce device. BTN_DEAD represents an optical sensor which detects if the user is interacting with the device. On devices without that optical sensor BTN_DEAD is repeatedly causing false inputs on every status update of the joystick. Signed-off-by:
Tim Schumacher <timschumi@gmx.de> Signed-off-by:
-
Tim Schumacher authored
Previously, packets that have been dumped are shown in the kernel log like this: drivers/input/joystick/iforce/iforce-packets.c: info cmd = ff04, data = 56 02 04 00 Use dev_dbg to dump the packages only when requested and to list the parent device as well. Use printf logic to generate the hexdump instead of looping through every char that needs to be printed (which in turn fixes the unnecessary newlines and looks more clean in general). The resulting package dump output does now look like this: usb 2-8: iforce_dump_packet info cmd = ff04, data = 56 02 04 00 Signed-off-by:
-
Dmitry Torokhov authored
I do not think Vojtech wants snail mail these days (and he mentioned that nobody has ever sent him snail mail), and the address is not even valid anymore, so let's remove snail-mail instructions from the sources. Acked-by:
Vojtech Pavlik <vojtech@suse.cz> Signed-off-by:
-
- 25 Jul, 2018 5 commits
-
-
Dmitry Torokhov authored
Instead of splitting probe code into separate USB and input setup, flatten it. This allows for easier inspection of order of set up steps, since the probe code is reasonably small. Move input-related initialization (phys) from USB block to input block. Reviewed-by:
Marcus Folkesson <marcus.folkesson@gmail.com> Tested-by:
-
Dmitry Torokhov authored
There is no need to store data buffer size, pointer to the buffer, or endpoint address in pxrc structure, as they are either only needed during setup, or are available from elsewhere. Reviewed-by:
-
Dmitry Torokhov authored
There is no need to have the device table first in the file. Reviewed-by:
-
Dmitry Torokhov authored
URB is the only resource that is not managed, and thus is destroyed too early, before we unregister input device and stop URB in pxrc_close(). To fix it let's install custom devm handler to free the URB at the right time in devm unwind sequence. Reviewed-by:
-
Marcus Folkesson authored
The USB device is only needed during setup, so put it back after initialization and do not store it in our private struct. Also, the USB device is a parent of USB interface so our driver model rules ensure that USB device should not disappear while interface device is still there; there is no need to take reference to the USB device. Reported-by:
Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by:
-
- 18 Jul, 2018 2 commits
-
-
Matti Vaittinen authored
gpio_keys.h uses 'bool' - type which is defined in linux/types.h. Include this header. Signed-off-by:
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> Signed-off-by:
-
Fabio Estevam authored
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by:
Fabio Estevam <fabio.estevam@nxp.com> Signed-off-by:
-
- 04 Jul, 2018 7 commits
-
-
Sebastian Andrzej Siewior authored
iforce_get_id_packet() invokes wait_event_interruptible_timeout() which means it has to be in non-atomic context at that point, thus we can use GFP_KERNEL instead of GFP_ATOMIC. Signed-off-by:
Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by:
-
Chen Zhong authored
This patch adds the device tree binding documentation for common keyboard. Acked-by:
Rob Herring <robh@kernel.org> Signed-off-by:
Chen Zhong <chen.zhong@mediatek.com> Signed-off-by:
-
Colin Ian King authored
Variable num_cols is being assigned but is never used hence it is redundant and can be removed. Cleans up clang warning: warning: variable ‘num_cols’ set but not used [-Wunused-but-set-variable] Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Daniel Mack authored
Keep the documentation link up-to-date in case anybody need to dive into it again, and update email address while at it. Signed-off-by:
Daniel Mack <daniel@zonque.org> Signed-off-by:
-
Daniel Mack authored
The only user of this driver in mainline does not make use of the module parameters, so let's remove them. All properties for this driver should be set through DT or pdata. Use touchscreen_parse_properties() to automatically set some of the common touchscreen properties and derive the axis inversion through that. And finally, use touchscreen_report_pos() to handle the DT properties automatically instead of doing the inversion ourselves. Signed-off-by:
-
Daniel Mack authored
Provide a match table so that the driver can be used in devicetree setups. More properties are added in a later patch. Signed-off-by:
-
Daniel Mack authored
Describe the bindings for EETI touchscreen controllers. Signed-off-by:
-
- 24 Jun, 2018 1 commit
-
-
Zhu Yi authored
Add Rohm BU21029 resistive touch panel controller support with I2C interface. Signed-off-by:
Zhu Yi <yi.zhu5@cn.bosch.com> Signed-off-by:
Mark Jonas <mark.jonas@de.bosch.com> Reviewed-by:
Heiko Schocher <hs@denx.de> Reviewed-by:
-
- 22 Jun, 2018 4 commits
-
-
Fabio Estevam authored
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by:
-
Fabio Estevam authored
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by:
-
Fabio Estevam authored
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by:
-
Fabio Estevam authored
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by:
-
- 12 Jun, 2018 8 commits
-
-
Dmitry Torokhov authored
Bring in xen-kbdfront changes.
-
Ravi Chandra Sadineni authored
Call pm_wakeup_event on every interrupt. This should help us in identifying if keyboard was a potential wake reason for the last resume. Signed-off-by:
Ravi Chandra Sadineni <ravisadineni@chromium.org> Signed-off-by:
-
Ravi Chandra Sadineni authored
Remove the unnecessary check before calling pm_wakeup_event. If the device is not wake enabled, this call is no-op anyway. Signed-off-by:
-
Enric Balletbo i Serra authored
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by:
Enric Balletbo i Serra <enric.balletbo@collabora.com> Signed-off-by:
-
Enric Balletbo i Serra authored
The license text is specifying "GPLv2" but the MODULE_LICENSE is set to GPL which means GNU Public License v2 or later. When MODULE_LICENSE and boiler plate does not match, go for boiler plate license. Signed-off-by:
-
Oleksandr Andrushchenko authored
It is now only possible to control if multi-touch virtual device is created or not (via the corresponding XenStore entries), but keyboard and pointer devices are always created. In some cases this is not desirable. For example, if virtual keyboard device is exposed to Android then the latter won't automatically show on-screen keyboard as it expects that a physical keyboard device can be used for typing. Utilize keyboard and pointer device XenStore feature fields to configure which virtual devices are created: - set "feature-disable-keyboard" to 1 if no keyboard device needs to be created - set "feature-disable-pointer" to 1 if no pointer device needs to be created Keep old behavior by default. Signed-off-by:
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> Suggested-by:
Andrii Chepurnyi <andrii_chepurnyi@epam.com> Tested-by:
Juergen Gross <jgross@suse.com> Signed-off-by:
-
Oleksandr Andrushchenko authored
kbdif protocol describes multi-touch device parameters as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by reading the parameters as defined by the protocol. Fixes: 49aac820 ("Input: xen-kbdfront - add multi-touch support") Signed-off-by:
-
Oleksandr Andrushchenko authored
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen. Changes to kbdif: 1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file. 2. Add new XenStore feature fields, so it is possible to individually control set of exposed virtual devices for each guest OS: - set feature-disable-keyboard to 1 if no keyboard device needs to be created - set feature-disable-pointer to 1 if no pointer device needs to be created 3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by moving the parameters to the proper section. Unique-id field: 1. Add unique-id XenBus entry for virtual input and display. 2. Change type of unique-id field to string for sndif to align with display and input protocols. Signed-off-by:
-
- 11 Jun, 2018 4 commits
-
-
Dmitry Torokhov authored
We allow changing tool type (from MT_TOOL_FINGER to MT_TOOL_PALM) so we should not be forcing new tracking ID for the slot. Acked-by:
Benjamin Tissoires <benjamin.tissoires@redhat.com> Reviewed-by:
Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by:
-
Dmitry Torokhov authored
Let's make input_report_slot_state() return boolean representing whether the contact is active or not. This will allow writing code like: if (input_mt_report_slot_state(input, obj->mt_tool, obj->type != RMI_2D_OBJECT_NONE) { input_event(sensor->input, EV_ABS, ABS_MT_POSITION_X, obj->x); input_event(sensor->input, EV_ABS, ABS_MT_POSITION_Y, obj->y); ... } instead of: input_mt_report_slot_state(input, obj->mt_tool, obj->type != RMI_2D_OBJECT_NONE); if (obj->type != RMI_2D_OBJECT_NONE) { input_event(sensor->input, EV_ABS, ABS_MT_POSITION_X, obj->x); input_event(sensor->input, EV_ABS, ABS_MT_POSITION_Y, obj->y); ... } Reviewed-by:Henrik Rydberg <rydberg@bitmath.org> Acked-by:
Benjamin Tissoires <benjamin.tissoires@redaht.com> Signed-off-by:
-
Lucas Stach authored
The documentation for the touchscreen-swapped-x-y property states that swapping is done after inverting if both are used. RMI4 did it the other way around, leading to inconsistent behavior with regard to other touchscreens. Signed-off-by:
Lucas Stach <l.stach@pengutronix.de> Tested-by:
Nick Dyer <nick@shmanahar.org> Signed-off-by:
-
Wei Yongjun authored
The error return code PTR_ERR(data->irqdomain) is always 0 since data->irqdomain is equal to NULL in this error handling case. Fixes: 24d28e4f ("Input: synaptics-rmi4 - convert irq distribution to irq_domain") Signed-off-by:
Wei Yongjun <weiyongjun1@huawei.com> Reviewed-by:
Lyude Paul <lyude@redhat.com> Reviewed-by:
Nick Desaulniers <ndesaulniers@google.com> Signed-off-by:
-
- 05 Jun, 2018 1 commit
-
-
Nick Dyer authored
Convert the RMI driver to use the standard mechanism for distributing IRQs to the various functions. Tested on: * S7300 (F11, F34, F54) * S7817 (F12, F34, F54) Signed-off-by:
Christopher Heiny <cheiny@synaptics.com> Signed-off-by:
-
