- 20 Jun, 2014 20 commits
-
-
Paul Bolle authored
Two Kconfig entries default to (uppercase) "N". It was clearly intended to use "default n". But since (lowercase) "n" is the default anyway, these lines might as well be removed. Reported-by:
Martin Walch <walch.martin@web.de> Signed-off-by:
Paul Bolle <pebolle@tiscali.nl> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Benedict Boerger authored
Fix checkpatch.pl warnings: Missing blank line after Declarations Signed-off-by:
Benedict Boerger <benedict.boerger@cs.tu-dortmund.de> Signed-off-by:
-
Adithya Krishnamurthy authored
Fixed checkpatch "WARNING: Missing a blank line after declarations" Signed-off-by:
Adithya Krishnamurthy <linux.challenge1@gmail.com> Signed-off-by:
-
Wolfgang Ocker authored
Sparse spit out these warnings: drivers/staging/cxt1e1/musycc.c:68:1: warning: context imbalance in 'musycc_dump_rxbuffer_ring' - different lock contexts for basic block drivers/staging/cxt1e1/musycc.c:136:1: warning: context imbalance in 'musycc_dump_txbuffer_ring' - different lock contexts for basic block The new functions musycc_dump_[rt]xbuffer_ring_locked() assume that the lock is held. musycc_dump_[rt]xbuffer_ring() take the lock. Signed-off-by:
Wolfgang Ocker <weo@weo1.de> Signed-off-by:
-
Rickard Strandqvist authored
Unsigned variable can't be negative so it is unnecessary to test it. Signed-off-by:
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by:
-
A Raghavendra Rao authored
Replaced 'printk' with 'netdev_' function Signed-off-by:
A Raghavendra Rao <arrao@cdac.in> Signed-off-by:
-
Kees Cook authored
This makes sure a format string cannot leak into the work queue name nor the printk buffer. Signed-off-by:
Kees Cook <keescook@chromium.org> Signed-off-by:
-
Masanari Iida authored
This patch removed trailing semicolon from macro in guestlinuxdebug.h Signed-off-by:
Masanari Iida <standby24x7@gmail.com> Signed-off-by:
-
Robin Schroer authored
speakup_key() used manual comparison of jiffies to determine the time since the last keypress, replaced it with time_after() Signed-off-by:
Robin Schroer <sulamiification@gmail.com> Signed-off-by:
-
Alexey Khoroshilov authored
There is a strange "return 0" in line6_probe() before any initialization of the module is done. It can lead to NULL pointer dereference in other functions. The patch proposes to return -ENODEV in this case. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by:
Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by:
-
Vincent Heuken authored
This is a patch to the dgnc_driver.c file that fixes the following error: ERROR: open brace '{' following function declarations go on the next line Signed-off-by:Vincent Heuken <me@vincentheuken.com> Signed-off-by:
-
Arnd Bergmann authored
Using an 'if()' inside of an 'extern inline' function causes a gcc warning when CONFIG_PROFILE_ALL_BRANCHES is set every time the function is called, which gets very noisy: In file included from /git/arm-soc/drivers/staging/wlags49_h2/wl_wext.c:73:0: drivers/staging/wlags49_h2/wl_internal.h:1035:216: warning: '______f' is static but declared in inline function 'wl_act_int_off' which is not static [enabled by default] if(lp->is_handling_int == WL_HANDLING_INT) { Fortunately there is a trivial workaround, so we can avoid the problem by making the functions in question 'static inline' rather than 'extern inline'. Signed-off-by:Arnd Bergmann <arnd@arndb.de> Cc: Henk de Groot <pe1dnn@amsat.org> Signed-off-by:
-
Arnd Bergmann authored
The LIRC support for sa1100 appears to have never worked because it relies on header files that have never been present in git history. Actually trying to build the driver on an ARM sa1100 kernel fails, so let's just remove the broken support. Signed-off-by:
-
Arnd Bergmann authored
If the USB code is a loadable module, this driver cannot be built-in. This adds an explicit dependency on CONFIG_USB so that Kconfig can force sn9c102 to be a module in this case. Signed-off-by:
-
Robin Schroer authored
Signed-off-by:
-
Robin Schroer authored
Signed-off-by:
-
Robin Schroer authored
Signed-off-by:
-
Masanari Iida authored
This patch remove unnecessary parentheses in PHSModule.c Signed-off-by:
-
Rickard Strandqvist authored
Array 'SigBuff' is filled incompletely. Someone forget to multiply for the sizeof type. This was partly found using a static code analysis program called cppcheck. Signed-off-by:
-
Chuong Ngo authored
Signed-off-by:
Chuong Ngo <cngo.linux@gmail.com> Signed-off-by:
-
- 19 Jun, 2014 20 commits
-
-
James A Shackleford authored
This patch fixes the following sparse warnings: skein_iv.h:23:11: warning: symbol 'SKEIN_256_IV_128' was not declared. Should it be static? skein_iv.h:31:11: warning: symbol 'SKEIN_256_IV_160' was not declared. Should it be static? skein_iv.h:39:11: warning: symbol 'SKEIN_256_IV_224' was not declared. Should it be static? skein_iv.h:47:11: warning: symbol 'SKEIN_256_IV_256' was not declared. Should it be static? skein_iv.h:55:11: warning: symbol 'SKEIN_512_IV_128' was not declared. Should it be static? skein_iv.h:67:11: warning: symbol 'SKEIN_512_IV_160' was not declared. Should it be static? skein_iv.h:79:11: warning: symbol 'SKEIN_512_IV_224' was not declared. Should it be static? skein_iv.h:91:11: warning: symbol 'SKEIN_512_IV_256' was not declared. Should it be static? skein_iv.h:103:11: warning: symbol 'SKEIN_512_IV_384' was not declared. Should it be static? skein_iv.h:115:11: warning: symbol 'SKEIN_512_IV_512' was not declared. Should it be static? skein_iv.h:127:11: warning: symbol 'SKEIN_1024_IV_384' was not declared. Should it be static? skein_iv.h:147:11: warning: symbol 'SKEIN_1024_IV_512' was not declared. Should it be static? skein_iv.h:167:11: warning: symbol 'SKEIN_1024_IV_1024' was not declared. Should it be static? by declaring the initialization vectors in question as static. The header skein_iv.h is only included by skein.c Signed-off-by:
James A Shackleford <shack@linux.com> Acked-by:
Jason Cooper <jason@lakedaemon.net> Signed-off-by:
-
Marcus Farkas authored
This commit fixes the following sparse warnings in ps.c: - 702: warning: symbol 'rtl_p2p_noa_ie' was not declared. Should it be static? - 802: warning: symbol 'rtl_p2p_action_ie' was not declared. Should it be static? Signed-off-by:
Marcus Farkas <marcus.farkas@finitebox.com> Signed-off-by:
-
Vitaly Osipov authored
As suggested by Andy Shevchenko on driverdev-devel, replace v = ... sizeof(struct type_of_v) -> sizeof(*v) Based on a cocci patch along the lines of @@ type T; expression E; identifier V; @@ T *V; ... - V = kmalloc(sizeof(T), E); + V = kmalloc(sizeof(*V), E); @@ type T; expression E; identifier V; @@ T *V; ... - V = kzalloc(sizeof(T), E); + V = kzalloc(sizeof(*V), E); Signed-off-by:
Vitaly Osipov <vitaly.osipov@gmail.com> Signed-off-by:
-
Rickard Strandqvist authored
The same code regardless of the outcome of the if statement. And clean up another duplicate line of code. Signed-off-by:
-
Arnd Bergmann authored
The rtl8712 driver has an 'extern inline' function that contains an 'if', which causes lots of warnings with CONFIG_PROFILE_ALL_BRANCHES overriding the definition of 'if': drivers/staging/rtl8712/ieee80211.h:759:229: warning: '______f' is static but declared in inline function 'ieee80211_get_hdrlen' which is not static [enabled by default] This changes the driver to use 'static inline' instead, which happens to be the correct annotation anyway. Signed-off-by:
-
Thomas Vegas authored
The net device only exists when firmware is loaded successfully. Firmware presence variable is only used through r871xu_dev_remove() and this function already checks for net device existence. Signed-off-by:
Thomas Vegas <thomas@grouk.net> Signed-off-by:
-
Thomas Vegas authored
When firmware is not available, net device is not created. Upon disconnect, we must check for net device existence before trying to release net device private data. Signed-off-by:
-
Merlin Chlosta authored
fix coding style: use C89 comments, not C99 Signed-off-by:
Merlin Chlosta <eudyptula@merlin.geekmail.org> Signed-off-by:
-
Martin Kepplinger authored
Remove a totally unnecessary typedef and rename it to lowercase. This is more readable now. Signed-off-by:
Martin Kepplinger <martink@posteo.de> Signed-off-by:
-
James A Shackleford authored
Signed-off-by:
-
James A Shackleford authored
This patch fixes the following sparse warnings: iwctl.c:76:22: warning: symbol 'iwctl_get_wireless_stats' was not declared. Should it be static? iwctl.c:118:5: warning: symbol 'iwctl_giwname' was not declared. Should it be static? iwctl.c:131:5: warning: symbol 'iwctl_siwscan' was not declared. Should it be static? iwctl.c:192:5: warning: symbol 'iwctl_giwscan' was not declared. Should it be static? iwctl.c:344:5: warning: symbol 'iwctl_siwfreq' was not declared. Should it be static? iwctl.c:390:5: warning: symbol 'iwctl_giwfreq' was not declared. Should it be static? iwctl.c:420:5: warning: symbol 'iwctl_siwmode' was not declared. Should it be static? iwctl.c:486:5: warning: symbol 'iwctl_giwmode' was not declared. Should it be static? iwctl.c:520:5: warning: symbol 'iwctl_giwrange' was not declared. Should it be static? iwctl.c:626:5: warning: symbol 'iwctl_siwap' was not declared. Should it be static? iwctl.c:684:5: warning: symbol 'iwctl_giwap' was not declared. Should it be static? iwctl.c:711:5: warning: symbol 'iwctl_giwaplist' was not declared. Should it be static? iwctl.c:784:5: warning: symbol 'iwctl_siwessid' was not declared. Should it be static? iwctl.c:893:5: warning: symbol 'iwctl_giwessid' was not declared. Should it be static? iwctl.c:923:5: warning: symbol 'iwctl_siwrate' was not declared. Should it be static? iwctl.c:1004:5: warning: symbol 'iwctl_giwrate' was not declared. Should it be static? iwctl.c:1049:5: warning: symbol 'iwctl_siwrts' was not declared. Should it be static? iwctl.c:1077:5: warning: symbol 'iwctl_giwrts' was not declared. Should it be static? iwctl.c:1096:5: warning: symbol 'iwctl_siwfrag' was not declared. Should it be static? iwctl.c:1123:5: warning: symbol 'iwctl_giwfrag' was not declared. Should it be static? iwctl.c:1141:5: warning: symbol 'iwctl_siwretry' was not declared. Should it be static? iwctl.c:1176:5: warning: symbol 'iwctl_giwretry' was not declared. Should it be static? iwctl.c:1205:5: warning: symbol 'iwctl_siwencode' was not declared. Should it be static? iwctl.c:1336:5: warning: symbol 'iwctl_giwencode' was not declared. Should it be static? iwctl.c:1398:5: warning: symbol 'iwctl_siwpower' was not declared. Should it be static? iwctl.c:1448:5: warning: symbol 'iwctl_giwpower' was not declared. Should it be static? iwctl.c:1478:5: warning: symbol 'iwctl_giwsens' was not declared. Should it be static? iwctl.c:1502:5: warning: symbol 'iwctl_siwauth' was not declared. Should it be static? iwctl.c:1603:5: warning: symbol 'iwctl_giwauth' was not declared. Should it be static? iwctl.c:1611:5: warning: symbol 'iwctl_siwgenie' was not declared. Should it be static? iwctl.c:1644:5: warning: symbol 'iwctl_giwgenie' was not declared. Should it be static? iwctl.c:1669:5: warning: symbol 'iwctl_siwencodeext' was not declared. Should it be static? iwctl.c:1783:5: warning: symbol 'iwctl_giwencodeext' was not declared. Should it be static? iwctl.c:1791:5: warning: symbol 'iwctl_siwmlme' was not declared. Should it be static? iwctl.c:1900:21: warning: symbol 'iwctl_private_args' was not declared. Should it be static? iwctl.c:1906:33: warning: symbol 'iwctl_handler_def' was not declared. Should it be static? Signed-off-by:
-
James A Shackleford authored
Update declaration of iwctl_private_args to match definition in iwctl.c Signed-off-by:
-
James A Shackleford authored
The function iwctl_siwscan() is defined in iwctl.c as: int iwctl_siwscan(struct net_device *dev, struct iw_request_info *info, struct iw_point *wrq, char *extra) { ... This patch updates iwctl.h so that the type of the 3rd parameter (*wqr) in the function declaration matches the definition. Signed-off-by: -
James A Shackleford authored
This patch fixes the following sparse warnings: dpc.c:65:21: warning: symbol 'acbyRxRate' was not declared. Should it be static? dpc.c:272:9: warning: symbol 'MngWorkItem' was not declared. Should it be static? dpc.c:288:1: warning: symbol 'device_receive_frame' was not declared. Should it be static? Signed-off-by:
-
James A Shackleford authored
Add missing __user macro to second parameter of ethtool_ioctl(). This removes the need for the offending (void *) cast of the user space pointer rq->ifr_data. Signed-off-by:
-
Scott Weir authored
This patch fixes following checkpatch.pl warning: WARNING: Missing a blank line after declarations in gdm_lte.c Signed-off-by:
Scott Weir <sjw0410@gmail.com> Signed-off-by:
-
Malcolm Priestley authored
Signed-off-by:
Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by:
-
Malcolm Priestley authored
The function returns the phy fields rename to vnt_get_phy_field Signed-off-by:
-
Malcolm Priestley authored
Signed-off-by:
-
Malcolm Priestley authored
Signed-off-by:
-
