1. 31 Oct, 2009 5 commits
  2. 30 Oct, 2009 2 commits
    • Ryota Yamauchi's avatar
      xfs: fix xfs_quota remove error · c7ff91d7
      Ryota Yamauchi authored
      The xfs_quota returns ENOSYS when remove command is executed.
      Reproducable with following steps.
      
          # mount -t xfs -o uquota /dev/sda7 /mnt/mp1
          # xfs_quota -x -c off -c remove
          XFS_QUOTARM: Function not implemented.
      
      The remove command is allowed during quotaoff, but xfs_fs_set_xstate()
      checks whether quota is running, and it leads to ENOSYS.
      
      To solve this problem, add a check for X_QUOTARM.
      Signed-off-by: default avatarRyota Yamauchi <r-yamauchi@vf.jp.nec.com>
      Signed-off-by: default avatarUtako Kusaka <u-kusaka@wm.jp.nec.com>
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      c7ff91d7
    • Eric Sandeen's avatar
      xfs: free temporary cursor in xfs_dialloc · 3b826386
      Eric Sandeen authored
      Commit bd169565 seems
      to have a slight regression where this code path:
      
          if (!--searchdistance) {
              /*
               * Not in range - save last search
               * location and allocate a new inode
               */
              ...
              goto newino;
          }
      
      doesn't free the temporary cursor (tcur) that got dup'd in
      this function.
      
      This leaks an item in the xfs_btree_cur zone, and it's caught
      on module unload:
      
      ===========================================================
      BUG xfs_btree_cur: Objects remaining on kmem_cache_close()
      -----------------------------------------------------------
      
      It seems like maybe a single free at the end of the function might
      be cleaner, but for now put a del_cursor right in this code block
      similar to the handling in the rest of the function.
      Signed-off-by: default avatarEric Sandeen <sandeen@sandeen.net>
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      3b826386
  3. 29 Oct, 2009 33 commits