1. 03 Sep, 2014 40 commits
    • Mauro Carvalho Chehab's avatar
      [media] em28xx: use true/false for boolean vars · 7e6c8c19
      Mauro Carvalho Chehab authored
      Instead of using 0 or 1 for boolean, use the true/false
      defines.
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      7e6c8c19
    • Mauro Carvalho Chehab's avatar
      [media] stv0900_core: don't allocate a temporary var · 49bc8962
      Mauro Carvalho Chehab authored
      The error return code STV0900_NO_ERROR happens only once, at
      the end of the functions. So, just return it directly.
      
      This driver should actually be fixed to return standard
      Linux error codes, instead of its own macros, but this
      should be done on a separate patchset.
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      49bc8962
    • Mauro Carvalho Chehab's avatar
      [media] soc_camera: remove uneeded semicolons · c611c908
      Mauro Carvalho Chehab authored
      We don't use semicolons after curly braces in the middle of the
      code.
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      c611c908
    • Mauro Carvalho Chehab's avatar
      [media] bttv-driver: remove an uneeded semicolon · c3142a61
      Mauro Carvalho Chehab authored
      We don't use semicolons after curly braces in the middle of the
      code.
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      c3142a61
    • Mauro Carvalho Chehab's avatar
      [media] s5k5baf: remove an uneeded semicolon · bc39d69a
      Mauro Carvalho Chehab authored
      We don't use semicolons after curly braces in the middle of the
      code.
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      bc39d69a
    • Mauro Carvalho Chehab's avatar
      [media] vivid-vid-out: use memdup_user() · 02829691
      Mauro Carvalho Chehab authored
      Instead of allocating and coping from __user, do it using
      one atomic call. That makes the code simpler.
      
      Found by coccinelle.
      Acked-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      02829691
    • Mauro Carvalho Chehab's avatar
      [media] soc_camera: use kmemdup() · 93623c87
      Mauro Carvalho Chehab authored
      Instead of calling kzalloc and then copying, use kmemdup(). That
      avoids zeroing the data structure before copying.
      
      Found by coccinelle.
      Acked-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      93623c87
    • Mauro Carvalho Chehab's avatar
      [media] marvel-ccic: don't initialize static vars with 0 · a7459a9d
      Mauro Carvalho Chehab authored
      alloc_bufs_at_read is static. No need to initialize with
      zero, as the Kernel will cleanup the data memory already.
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      a7459a9d
    • Mauro Carvalho Chehab's avatar
      [media] dmxdev: don't use before checking file->private_data · 313ddec4
      Mauro Carvalho Chehab authored
      As reported by smatch:
      	drivers/media/dvb-core/dmxdev.c:1091 dvb_demux_poll() warn: variable dereferenced before check 'dmxdevfilter' (see line 1088)
      
      This was introduced by changeset d102cac8.
      
      We need to test before using it.
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      313ddec4
    • Hans Verkuil's avatar
      [media] mt2063: fix sparse warnings · fe10b84e
      Hans Verkuil authored
      drivers/media/tuners/mt2063.c:1238:56: warning: cast truncates bits from constant value (ffffff0f becomes f)
      drivers/media/tuners/mt2063.c:1313:62: warning: cast truncates bits from constant value (ffffff7f becomes 7f)
      drivers/media/tuners/mt2063.c:1321:62: warning: cast truncates bits from constant value (ffffff7f becomes 7f)
      
      Cast to u8 is unnecessary.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      fe10b84e
    • Hans Verkuil's avatar
      [media] v4l2-compat-ioctl32: fix sparse warnings · 8ae632b1
      Hans Verkuil authored
      A lot of these warnings are caused by the fact that we don't generally use
      __user in videodev2.h. Normally the video_usercopy function will copy anything
      pointed to by pointers into kernel space, so having __user in the struct will only
      cause lots of warnings in the drivers. But the flip side of that is that you
      need to add __force casts here.
      
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:337:26: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:337:30: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:338:31: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:338:49: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:343:21: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:346:21: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:349:35: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:349:46: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:352:35: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:352:54: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:363:26: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:363:32: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:364:31: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:364:51: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:371:35: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:371:56: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:376:35: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:376:48: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:430:30: warning: incorrect type in assignment (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:433:48: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:433:56: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:501:24: warning: incorrect type in assignment (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:507:48: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:507:56: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:565:18: warning: incorrect type in assignment (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:670:22: warning: incorrect type in assignment (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:680:29: warning: incorrect type in assignment (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:692:55: warning: incorrect type in initializer (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:773:18: warning: incorrect type in assignment (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:786:30: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:786:44: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:674:37: warning: dereference of noderef expression
      drivers/media/v4l2-core/v4l2-compat-ioctl32.c:718:37: warning: dereference of noderef expression
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      8ae632b1
    • Hans Verkuil's avatar
      [media] videodev2.h: add __user to v4l2_ext_control pointers · eadf9e26
      Hans Verkuil authored
      These are not copied to kernel space by video_usercopy, so mark them
      as __user.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      eadf9e26
    • Hans Verkuil's avatar
      [media] em28xx: fix sparse warnings · 4a9e512a
      Hans Verkuil authored
      drivers/media/usb/em28xx/em28xx-core.c:297:16: warning: cast to restricted __le16
      drivers/media/usb/em28xx/em28xx-cards.c:2249:20: warning: symbol 'em28xx_bcount' was not declared. Should it be static?
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      4a9e512a
    • Hans Verkuil's avatar
      [media] cx18: fix sparse warnings · 39fd4460
      Hans Verkuil authored
      /home/hans/work/build/media-git/drivers/media/pci/cx18/cx18-firmware.c:169:32: warning: cast to restricted __le32
      /home/hans/work/build/media-git/drivers/media/pci/cx18/cx18-firmware.c:170:32: warning: cast to restricted __le32
      /home/hans/work/build/media-git/drivers/media/pci/cx18/cx18-firmware.c:171:31: warning: cast to restricted __le32
      /home/hans/work/build/media-git/drivers/media/pci/cx18/cx18-firmware.c:172:31: warning: cast to restricted __le32
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      39fd4460
    • Hans Verkuil's avatar
      [media] ivtv: fix sparse warnings · 3efb8ab6
      Hans Verkuil authored
      drivers/media/pci/ivtv/ivtv-irq.c:195:25: warning: incorrect type in argument 1 (different base types)
      drivers/media/pci/ivtv/ivtv-irq.c:199:25: warning: incorrect type in argument 1 (different base types)
      drivers/media/pci/ivtv/ivtv-irq.c:278:35: warning: restricted __le32 degrades to integer
      drivers/media/pci/ivtv/ivtv-irq.c:281:51: warning: restricted __le32 degrades to integer
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      3efb8ab6
    • Hans Verkuil's avatar
      [media] cx23885: fix sparse warning · 711c3119
      Hans Verkuil authored
      drivers/media/pci/cx23885/cx23885-dvb.c:1494:72: warning: Using plain integer as NULL pointer
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      711c3119
    • Hans Verkuil's avatar
      [media] cxusb: fix sparse warning · 41150cb9
      Hans Verkuil authored
      drivers/media/usb/dvb-usb/cxusb.c:178:40: warning: restricted __le16 degrades to integer
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      41150cb9
    • Hans Verkuil's avatar
      [media] dm1105: fix sparse warning · 888bd5dc
      Hans Verkuil authored
      drivers/media/pci/dm1105/dm1105.c:617:9: warning: incorrect type in argument 1 (different base types)
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      888bd5dc
    • Hans Verkuil's avatar
      [media] cx231xx: fix sparse warnings · 3f9280a8
      Hans Verkuil authored
      drivers/media/usb/cx231xx/cx231xx-avcore.c:2226:15: warning: cast to restricted __le32
      drivers/media/usb/cx231xx/cx231xx-avcore.c:2447:15: warning: cast to restricted __le32
      drivers/media/usb/cx231xx/cx231xx-avcore.c:2475:15: warning: cast to restricted __le32
      drivers/media/usb/cx231xx/cx231xx-avcore.c:2500:15: warning: cast to restricted __le32
      drivers/media/usb/cx231xx/cx231xx-avcore.c:2647:18: warning: incorrect type in assignment (different base types)
      drivers/media/usb/cx231xx/cx231xx-avcore.c:2659:21: warning: cast to restricted __le32
      drivers/media/usb/cx231xx/cx231xx-dvb.c:743:57: warning: Using plain integer as NULL pointer
      drivers/media/usb/cx231xx/cx231xx-dvb.c:776:57: warning: Using plain integer as NULL pointer
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      3f9280a8
    • Hans Verkuil's avatar
      [media] cx25821: fix sparse warning · 38b2b879
      Hans Verkuil authored
      drivers/media/pci/cx25821/cx25821-video-upstream.c:334:25: warning: incorrect type in argument 2 (different address spaces)
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      38b2b879
    • Hans Verkuil's avatar
      [media] via-camera: fix sparse warning · a7547af7
      Hans Verkuil authored
      drivers/media/platform/via-camera.c:445:34: warning: incorrect type in assignment (different address spaces)
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      a7547af7
    • Hans Verkuil's avatar
      [media] lirc_dev: fix sparse warnings · 60519af3
      Hans Verkuil authored
      drivers/media/rc/lirc_dev.c:598:26: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/rc/lirc_dev.c:606:26: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/rc/lirc_dev.c:616:26: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/rc/lirc_dev.c:625:26: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/rc/lirc_dev.c:634:26: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/rc/lirc_dev.c:643:26: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/rc/lirc_dev.c:739:45: warning: cast removes address space of expression
      drivers/media/rc/lirc_dev.c:739:58: warning: incorrect type in argument 1 (different address spaces)
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      60519af3
    • Hans Verkuil's avatar
      [media] v4l2-ioctl: fix sparse warnings · 4d1afa51
      Hans Verkuil authored
      drivers/media/v4l2-core/v4l2-ioctl.c:1156:53: warning: incorrect type in initializer (different address spaces)
      drivers/media/v4l2-core/v4l2-ioctl.c:1158:42: warning: incorrect type in initializer (different address spaces)
      drivers/media/v4l2-core/v4l2-ioctl.c:1161:34: warning: incorrect type in assignment (different address spaces)
      drivers/media/v4l2-core/v4l2-ioctl.c:1163:35: warning: incorrect type in assignment (different address spaces)
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      4d1afa51
    • Hans Verkuil's avatar
      [media] imon: fix sparse warnings · d778d258
      Hans Verkuil authored
      drivers/media/rc/imon.c:1343:44: warning: cast to restricted __be32
      drivers/media/rc/imon.c:1343:44: warning: cast to restricted __be32
      drivers/media/rc/imon.c:1343:44: warning: cast to restricted __be32
      drivers/media/rc/imon.c:1343:44: warning: cast to restricted __be32
      drivers/media/rc/imon.c:1343:44: warning: cast to restricted __be32
      drivers/media/rc/imon.c:1343:44: warning: cast to restricted __be32
      drivers/media/rc/imon.c:1407:36: warning: cast to restricted __be32
      drivers/media/rc/imon.c:1407:36: warning: cast to restricted __be32
      drivers/media/rc/imon.c:1407:36: warning: cast to restricted __be32
      drivers/media/rc/imon.c:1407:36: warning: cast to restricted __be32
      drivers/media/rc/imon.c:1407:36: warning: cast to restricted __be32
      drivers/media/rc/imon.c:1407:36: warning: cast to restricted __be32
      drivers/media/rc/imon.c:1512:28: warning: cast to restricted __be64
      drivers/media/rc/imon.c:1512:28: warning: cast to restricted __be64
      drivers/media/rc/imon.c:1512:28: warning: cast to restricted __be64
      drivers/media/rc/imon.c:1512:28: warning: cast to restricted __be64
      drivers/media/rc/imon.c:1512:28: warning: cast to restricted __be64
      drivers/media/rc/imon.c:1512:28: warning: cast to restricted __be64
      drivers/media/rc/imon.c:1512:28: warning: cast to restricted __be64
      drivers/media/rc/imon.c:1512:28: warning: cast to restricted __be64
      drivers/media/rc/imon.c:1512:28: warning: cast to restricted __be64
      drivers/media/rc/imon.c:1512:28: warning: cast to restricted __be64
      drivers/media/rc/imon.c:1516:28: warning: cast to restricted __be32
      drivers/media/rc/imon.c:1516:28: warning: cast to restricted __be32
      drivers/media/rc/imon.c:1516:28: warning: cast to restricted __be32
      drivers/media/rc/imon.c:1516:28: warning: cast to restricted __be32
      drivers/media/rc/imon.c:1516:28: warning: cast to restricted __be32
      drivers/media/rc/imon.c:1516:28: warning: cast to restricted __be32
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      d778d258
    • Hans Verkuil's avatar
      [media] si2165: fix sparse warning · e73c7bfe
      Hans Verkuil authored
      drivers/media/dvb-frontends/si2165.c:329:16: warning: odd constant _Bool cast (ffffffffffffffea becomes 1)
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      e73c7bfe
    • Hans Verkuil's avatar
      [media] stv0367: fix sparse warnings · 817d2fd4
      Hans Verkuil authored
      drivers/media/dvb-frontends/stv0367.c:557:5: warning: symbol 'stv0367cab_RF_LookUp1' was not declared. Should it be static?
      drivers/media/dvb-frontends/stv0367.c:569:5: warning: symbol 'stv0367cab_RF_LookUp2' was not declared. Should it be static?
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      817d2fd4
    • Hans Verkuil's avatar
      [media] pwc: fix sparse warning · 29541925
      Hans Verkuil authored
      drivers/media/usb/pwc/pwc-v4l.c:55:12: warning: symbol 'pwc_auto_whitebal_qmenu' was not declared. Should it be static?
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      29541925
    • Hans Verkuil's avatar
      [media] dvb_usb_core: fix sparse warning · 68126673
      Hans Verkuil authored
      drivers/media/usb/dvb-usb-v2/dvb_usb_core.c:24:5: warning: symbol 'dvb_usbv2_disable_rc_polling' was not declared. Should it be static?
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      68126673
    • Hans Verkuil's avatar
      [media] s2255drv: fix sparse warning · ff3ec57d
      Hans Verkuil authored
      drivers/media/usb/s2255/s2255drv.c:2248:20: warning: cast to restricted __le16
      
      At the USB structs there are two different idProduct:
      	usb_device_id::idProduct - already on CPU endiannes
      	usb_device::descriptor.idProduct - with is LE16
      
      In this specific case, the driver checks for the one at usb_device_id
      struct, with already have CPU endianness. So, no conversion is required.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      ff3ec57d
    • Hans Verkuil's avatar
      [media] bcm3510: fix sparse warnings · fba16a1e
      Hans Verkuil authored
      drivers/media/dvb-frontends/bcm3510.c:646:24: warning: cast to restricted __le16
      drivers/media/dvb-frontends/bcm3510.c:647:24: warning: cast to restricted __le16
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      fba16a1e
    • Hans Verkuil's avatar
      [media] wl128x: fix sparse warnings · 2a8b7e58
      Hans Verkuil authored
      drivers/media/radio/wl128x/fmdrv_common.c:598:32: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:598:32: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:598:32: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:598:32: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:767:38: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:767:38: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:767:38: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:767:38: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:992:21: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:992:21: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:992:21: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:992:21: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:443:41: warning: incorrect type in assignment (different base types)
      drivers/media/radio/wl128x/fmdrv_common.c:1359:17: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1359:17: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1359:17: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1359:17: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1359:39: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1359:39: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1359:39: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1359:39: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1368:25: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1368:25: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1368:25: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1368:25: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1368:47: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1368:47: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1368:47: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1368:47: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:119:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:119:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:119:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:119:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:192:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:192:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:192:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:192:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:288:28: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:288:28: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:288:28: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:288:28: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:534:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:534:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:534:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:534:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:625:17: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:625:17: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:625:17: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:625:17: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_tx.c:377:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_tx.c:377:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_tx.c:377:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_tx.c:377:20: warning: cast to restricted __be16
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      2a8b7e58
    • Hans Verkuil's avatar
      [media] mantis: fix sparse warnings · 967a3783
      Hans Verkuil authored
      drivers/media/pci/mantis/hopper_vp3028.c:37:23: warning: symbol 'hopper_vp3028_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp1033.c:38:4: warning: symbol 'lgtdqcs001f_inittab' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp1033.c:153:23: warning: symbol 'lgtdqcs001f_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp1034.c:39:23: warning: symbol 'vp1034_mb86a16_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp1041.c:266:23: warning: symbol 'vp1041_stb0899_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp1041.c:303:23: warning: symbol 'vp1041_stb6100_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp2033.c:40:24: warning: symbol 'vp2033_tda1002x_cu1216_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp2033.c:45:24: warning: symbol 'vp2033_tda10023_cu1216_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp2040.c:40:24: warning: symbol 'vp2040_tda1002x_cu1216_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp2040.c:45:24: warning: symbol 'vp2040_tda10023_cu1216_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp3030.c:38:23: warning: symbol 'mantis_vp3030_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp3030.c:42:23: warning: symbol 'env57h12d5_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_dma.c:167:33: warning: incorrect type in assignment (different base types)
      drivers/media/pci/mantis/mantis_dma.c:172:33: warning: incorrect type in assignment (different base types)
      drivers/media/pci/mantis/mantis_dma.c:174:25: warning: incorrect type in assignment (different base types)
      drivers/media/pci/mantis/mantis_dma.c:178:9: warning: incorrect type in assignment (different base types)
      drivers/media/pci/mantis/mantis_dma.c:179:9: warning: incorrect type in assignment (different base types)
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      967a3783
    • Hans Verkuil's avatar
      [media] mb86a16/mb86a20s: fix sparse warnings · ce08131c
      Hans Verkuil authored
      drivers/media/dvb-frontends/mb86a16.c:31:14: warning: symbol 'verbose' was not declared. Should it be static?
      drivers/media/dvb-frontends/mb86a20s.c:36:4: warning: symbol 'mb86a20s_subchannel' was not declared. Should it be static?
      drivers/media/dvb-frontends/mb86a20s.c:1333:24: warning: symbol 'cnr_qpsk_table' was not declared. Should it be static?
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      ce08131c
    • Hans Verkuil's avatar
      [media] usbtv: fix sparse warnings · 6fbf4d04
      Hans Verkuil authored
      drivers/media/usb/usbtv/usbtv-video.c:285:14: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:285:14: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:285:14: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:285:14: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:285:14: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:285:14: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:287:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:287:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:287:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:287:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:287:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:287:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:288:15: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:288:15: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:288:15: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:288:15: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:288:15: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:288:15: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:289:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:289:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:289:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:289:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:289:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:289:20: warning: cast to restricted __be32
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      6fbf4d04
    • Hans Verkuil's avatar
      [media] uvc: fix sparse warning · d71b0b34
      Hans Verkuil authored
      drivers/media/usb/uvc/uvc_video.c:1466:38: warning: incorrect type in return expression (different base types)
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Acked-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      d71b0b34
    • Hans Verkuil's avatar
      [media] drxj: fix sparse warnings · 4182438e
      Hans Verkuil authored
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11768:25: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11768:25: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11768:25: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11768:25: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11770:25: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11770:25: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11770:25: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11770:25: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11794:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11794:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11794:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11794:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11794:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11794:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11796:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11796:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11796:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11796:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11798:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11798:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11798:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11798:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11800:33: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11800:33: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11800:33: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11800:33: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11605:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11605:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11605:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11605:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11632:29: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11632:29: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11632:29: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11632:29: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11650:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11650:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11650:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11650:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11650:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11650:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11652:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11652:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11652:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11652:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11654:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11654:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11654:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11654:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11656:33: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11656:33: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11656:33: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11656:33: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11670:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11670:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11670:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11670:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11678:47: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11678:47: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11678:47: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11678:47: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11678:47: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11678:47: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11680:46: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11680:46: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11680:46: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11680:46: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11680:46: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11680:46: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11682:51: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11682:51: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11682:51: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11682:51: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11682:51: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11682:51: warning: cast to restricted __be32
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      4182438e
    • Hans Verkuil's avatar
      [media] ngene: fix sparse warnings · c463c979
      Hans Verkuil authored
      drivers/media/pci/ngene/ngene-core.c:188:27: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:190:25: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:199:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:260:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:263:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:282:32: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:283:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:284:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:285:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:286:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:287:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:288:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:292:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:293:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:294:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:295:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:296:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:297:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:303:17: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:316:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:368:17: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:372:9: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1160:28: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1199:20: warning: incorrect type in assignment (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1213:30: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1214:30: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1223:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1225:24: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1227:31: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1296:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1297:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1298:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1299:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1300:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1301:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1302:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1363:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1365:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1376:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1391:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1596:18: warning: Using plain integer as NULL pointer
      drivers/media/pci/ngene/ngene-core.c:1615:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-cards.c:699:29: warning: Using plain integer as NULL pointer
      drivers/media/pci/ngene/ngene-cards.c:699:32: warning: Using plain integer as NULL pointer
      drivers/media/pci/ngene/ngene-cards.c:699:35: warning: Using plain integer as NULL pointer
      drivers/media/pci/ngene/ngene-cards.c:699:38: warning: Using plain integer as NULL pointer
      drivers/media/pci/ngene/ngene-dvb.c:84:59: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-dvb.c:93:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
      drivers/media/pci/ngene/ngene-dvb.c:94:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
      drivers/media/pci/ngene/ngene-dvb.c:100:20: warning: Using plain integer as NULL pointer
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      c463c979
    • Hans Verkuil's avatar
      [media] ddbridge: fix sparse warnings · b5c00cc5
      Hans Verkuil authored
      drivers/media/pci/ddbridge/ddbridge-core.c:88:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:93:37: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:95:25: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:99:15: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:117:58: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:119:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:123:68: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:130:17: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:131:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:136:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:138:25: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:152:22: warning: symbol 'ddb_i2c_algo' was not declared. Should it be static?
      drivers/media/pci/ddbridge/ddbridge-core.c:183:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:184:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:246:25: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:247:25: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:255:25: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:256:25: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:269:35: warning: Using plain integer as NULL pointer
      drivers/media/pci/ddbridge/ddbridge-core.c:358:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:359:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:360:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:362:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:366:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:368:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:369:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:370:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:380:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:381:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:393:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:394:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:395:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:396:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:397:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:401:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:403:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:404:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:406:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:416:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:417:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:475:36: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:484:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:494:20: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:501:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:524:36: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:534:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:852:21: warning: Using plain integer as NULL pointer
      drivers/media/pci/ddbridge/ddbridge-core.c:973:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
      drivers/media/pci/ddbridge/ddbridge-core.c:974:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
      drivers/media/pci/ddbridge/ddbridge-core.c:978:20: warning: Using plain integer as NULL pointer
      drivers/media/pci/ddbridge/ddbridge-core.c:982:20: warning: Using plain integer as NULL pointer
      drivers/media/pci/ddbridge/ddbridge-core.c:1003:23: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1006:23: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1009:30: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1015:25: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1017:39: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1035:24: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1041:20: warning: symbol 'cxd_cfg' was not declared. Should it be static?
      drivers/media/pci/ddbridge/ddbridge-core.c:1130:44: warning: Using plain integer as NULL pointer
      drivers/media/pci/ddbridge/ddbridge-core.c:1183:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1188:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1193:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1198:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1213:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1214:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1215:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1216:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1231:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1232:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1233:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1289:17: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1333:23: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1295:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1347:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1353:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1354:24: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1359:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1361:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1373:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1374:16: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1378:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1382:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1385:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1386:24: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1388:24: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1393:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1394:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1395:16: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1398:16: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1399:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1451:42: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1462:45: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1467:37: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1538:28: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1550:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1561:31: warning: Using plain integer as NULL pointer
      drivers/media/pci/ddbridge/ddbridge-core.c:1585:19: warning: incorrect type in assignment (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1591:47: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1591:60: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1607:9: warning: too many warnings
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      b5c00cc5
    • Hans Verkuil's avatar
      [media] kinect: fix sparse warnings · 6cde2904
      Hans Verkuil authored
      drivers/media/usb/gspca/kinect.c:151:19: warning: incorrect type in assignment (different base types)
      drivers/media/usb/gspca/kinect.c:152:19: warning: incorrect type in assignment (different base types)
      drivers/media/usb/gspca/kinect.c:153:19: warning: incorrect type in assignment (different base types)
      drivers/media/usb/gspca/kinect.c:191:13: warning: restricted __le16 degrades to integer
      drivers/media/usb/gspca/kinect.c:217:16: warning: incorrect type in assignment (different base types)
      drivers/media/usb/gspca/kinect.c:218:16: warning: incorrect type in assignment (different base types)
      
      Note that this fixes a real bug where cpu_to_le16 was used instead of the correct
      le16_to_cpu.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Acked-by: default avatarAntonio Ospite <ao2@ao2.it>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      6cde2904
    • Hans Verkuil's avatar
      [media] dib7000p: fix sparse warning · 18ef20da
      Hans Verkuil authored
      drivers/media/dvb-frontends/dib7000p.c:2562:5: warning: symbol 'dib7090_set_diversity_in' was not declared. Should it be static?
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      18ef20da