- 20 Sep, 2010 21 commits
-
-
Sven Eckelmann authored
set_primary_if exchanges the current primary interfaces with a new one. This is a new reference and thus we have to count it and decrease the count of the old primary interface. Signed-off-by:
Sven Eckelmann <sven.eckelmann@gmx.de> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Sven Eckelmann authored
The return of get_batman_if_by_netdev and get_active_batman_if leaks a pointer from the rcu protected list of interfaces. We must protect it to prevent a too early release of the memory. Those functions must increase the reference counter before rcu_read_unlock or it may be to late to prevent a free. hardif_add_interface must also increase the reference count for the returned batman_if to make the behaviour consistent. Reported-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
-
Sven Eckelmann authored
get_batman_if_by_netdev and get_active_batman_if may leak data from the rcu protected list of interfaces. The rcu protected list of all gateway nodes leaks the actual data outside the read-side critical area. This is not valid as we may free the data using a call_rcu created callback after we unlock using rcu_read_unlock. A workaround is to provide a reference count to be sure that the memory isn't freed to early. It is currently only to implement the already existing functionality and doesn't provide the full tracking of all usage cases. Additionally, we must hardif_hold inside the rcu_read_lock()..rcu_read_unlock() before we attach to the structure which "leaks" it. When another function now removed it from its usage context (primary_if, usage on stack, ...) then we must hardif_put it. If it is decremented to zero then we can issue the call_rcu to the freeing function. So "put" is not allowed inside an rcu_read_lock. Signed-off-by:
-
Sven Eckelmann authored
It is recommended [1] to use synchronize_rcu to simplify the code - especially when otherwise extra locking is needed to protect other code from picking stale elements. It also protects us for emitting to many callbacks which may results in OOM conditions. The only reason not to use it, would be in performance critical sections or when we are not allowed to block. [1] Documentation/RCU/checklist.txt Signed-off-by:
-
Sven Eckelmann authored
Regions which do not use rcu functions don't need to protected by rcu_read_lock. If we want to protect data from being freed than it must be covered by the same read-side critical section or otherwise the grace period may already ended and freed the memory before we called rcu_read_lock again. Signed-off-by:
-
Sven Eckelmann authored
receive_bat_packet is not called with rcu_read_lock so we must ensure by ourself that we protect list_for_each_entry_rcu using the correct RCU locks. Signed-off-by:
-
Sven Eckelmann authored
The update critical sections of if_list must be protected by a locking primitive other than RCU. The iterator must also be protected by the chosen locking mechanism. The rtnl_lock in hardif_remove_interfaces must also be moved outside the iterator primitive to ensure that we don't deadlock the kernel due to differently nested locks in hardif_remove_interfaces and hard_if_event. Signed-off-by:
-
Sven Eckelmann authored
synchronize_rcu respective synchronize_net only waits for the rcu grace period to elapse and we may fail to finish the calls which were made to call_rcu in that time. In result the module could be unloaded during the execution of the RCU callbacks. rcu_barrier[1] will now wait for all outstanding RCU callbacks to finish before continuing. [1] Documentation/RCU/rcubarrier.txt Signed-off-by:
-
Sven Eckelmann authored
We don't allow to seek in the debugfs socket and log files. Thus we should mark the file descriptor as nonseekable. Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Sven Eckelmann authored
The official mailing list is run on lists.open-mesh.org and it should be avoided to sent them to lists.open-mesh.net to reduce the number of receipents and double posts. Signed-off-by:
-
Sven Eckelmann authored
checkpatch now detects the start of a comment and warns about usage of multiple spaces at the beginning of a line. We have to replace the ' ' in multiple lines comments by ' * ' to fix it. Checkpatch also wants a comment after a definition of a spinlock_t which describes what it protects. It is currently not possible to add it before the actual struct which includes the spinlock. Signed-off-by:
-
Haiyang Zhang authored
Remove camel cases of vmbus packet buffer structures Remove camel cases of: struct VMBUS_CHANNEL_PACKET_PAGE_BUFFER struct VMBUS_CHANNEL_PACKET_MULITPAGE_BUFFER Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
Hank Janssen <hjanssen@microsoft.com> Signed-off-by:
-
Andy Shevchenko authored
Signed-off-by:
Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by:
-
Andy Shevchenko authored
Signed-off-by:
-
Andy Shevchenko authored
Signed-off-by:
-
Andy Shevchenko authored
Signed-off-by:
-
Andy Shevchenko authored
Signed-off-by:
-
Andy Shevchenko authored
Signed-off-by:
-
Andy Shevchenko authored
Signed-off-by:
-
Andy Shevchenko authored
Signed-off-by:
-
Andy Shevchenko authored
Signed-off-by:
-
- 16 Sep, 2010 19 commits
-
-
Joe Perches authored
Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Charles Clément authored
Signed-off-by:
Charles Clément <caratorn@gmail.com> Signed-off-by:
-
Pavan Savoy authored
Platform devices tend to have id as -1 when only 1 device exist and a value >=0 when multiple devices exist, since we plan to store all these platform devices if multiple exist, there was a requirement to have id to be >=0. The patch fixes this problem. Signed-off-by:
Pavan Savoy <pavan_savoy@ti.com> Signed-off-by:
-
Andy Shevchenko authored
Signed-off-by:
-
Andy Shevchenko authored
Signed-off-by:
-
Agustin March authored
Removed a space in a comments lines at #459 Signed-off-by:
Agustin March <agustin.march@gmail.com> Signed-off-by:
-
Joe Perches authored
Signed-off-by:
-
Al Cho authored
keucr lost the disconnect, so keucr crash when plug-in and then plug-out SD-card quickly. unmark the part of usb disconnect Signed-off-by:
Al Cho <acho@novell.com> Signed-off-by:
-
Clelia V. Korol authored
Fixed the last 5 lines, indented with spaces, replacing spaces with tabs. Signed-off-by:
Clelia V. Korol <cvkorol@gmail.com> Signed-off-by:
-
Ema Cuevas authored
As reported by checkpatch. Signed-off-by:
Ema Cuevas <emacupk@gmail.com> Signed-off-by:
-
matias authored
I remove parenthesis for a return variable, and also delete a space and tab the code line Signed-off-by:
matias <munozmatiasn@gmail.com> Signed-off-by:
-
Emanuel Mariano Ravera authored
Added an space after the definition of the variable MSG_LEVEL_INFO on line 43 Signed-off-by:
Emanuel Mariano Ravera <ravera.emanuel@gmail.com> Signed-off-by:
-
Diego H. Iglesias authored
Removed not required parentheses in return statements. Signed-off-by:
Diego H. Iglesias <diegohi@gmail.com> Signed-off-by:
-
Vasiliy Kulikov authored
ai_count and ao_counter are unsigned, check for < 0 doesn't make sense. Cast them to int. Signed-off-by:
Vasiliy Kulikov <segooon@gmail.com> Signed-off-by:
-
Vasiliy Kulikov authored
chd_dec_major is unsigned, so check chd_dec_major < 0 doesn't make sense. Since it is used as signed, declare it as int. Signed-off-by:
-
Vasiliy Kulikov authored
video_nr is unsigned, so check video_nr >= 0 doesn't make sense. The only "negative" value may be -1, so explicitly check for it. Signed-off-by:
-
Randy Dunlap authored
Fix kconfig unmet dependency warning: warning: (ST_BT && STAGING && !STAGING_EXCLUDE_BUILD && BT) selects TI_ST which has unmet direct dependencies (RFKILL) Signed-off-by:
Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by:
-
Randy Dunlap authored
Handle build case of CONFIG_PM not being enabled. drivers/staging/bcm/InterfaceInit.c:280: error: 'struct usb_device' has no member named 'autosuspend_delay' Signed-off-by:
-
Randy Dunlap authored
Fix lots of printk format warnings in bcm. Here is a sample of them: drivers/staging/bcm/CmHost.c:1955: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'long unsigned int' drivers/staging/bcm/CmHost.c:1955: warning: format '%x' expects type 'unsigned int', but argument 2 has type 'long unsigned int' drivers/staging/bcm/CmHost.c:1955: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'long unsigned int' drivers/staging/bcm/LeakyBucket.c:85: warning: format '%d' expects type 'int', but argument 4 has type 'long int' drivers/staging/bcm/LeakyBucket.c:85: warning: format '%d' expects type 'int', but argument 3 has type 'long int' drivers/staging/bcm/LeakyBucket.c:85: warning: format '%d' expects type 'int', but argument 4 has type 'long int' Signed-off-by:
-
