- 04 Feb, 2022 10 commits
-
-
Michael Straube authored
UsbRxAggPageCount and UsbRxAggPageTimeout in struct hal_data_8188e are set and never changed. Define these constants and remove the variables from the hal_data_8188e structure. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20220201084259.7497-10-straube.linux@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Michael Straube authored
UsbRxAggBlockCount and UsbRxAggBlockTimeout in struct hal_data_8188e are set but not used. Remove them. Signed-off-by:
-
Michael Straube authored
UsbRxAggMode in struct hal_data_8188e is set to USB_RX_AGG_DMA and never changed. Remove UsbRxAggMode from the hal_data_8188e structure and remove related dead code. Signed-off-by:
-
Michael Straube authored
UsbTxAggMode in struct hal_data_r8188e is only used in a single if statement. Remove UsbTxAggMode from the hal_data_8188e structure and adjust the if statement. Signed-off-by:
-
Michael Straube authored
UsbTxAggDescNum in struct hal_data_8188e is set to 0x6 and never changed. Define this constant and remove UsbTxAggDescNum from the hal_data_8188e structure. Signed-off-by:
-
Michael Straube authored
The varaible BasicRateSet in struct hal_data_8188e is set but never used. Remove it. Signed-off-by:
-
Michael Straube authored
The ReceiveConfig variable in struct hal_data_8188e is only used to store a local value. Use a local variable instead and remove ReceiveConfig from struct hal_data_8188e. Signed-off-by:
-
Michael Straube authored
the variable PGMaxGroup in struct hal_data_8188e is set to 13 and never changed. We can use the already defined constant MAX_PG_GROUP, which is 13, and remove PGMaxGroup from struct hal_data_8188e. Signed-off-by:
-
Michael Straube authored
The variable ExternalPA in struct hal_data_8188e is never set. It stays at the default value 0. Remove it and remove related dead code. Signed-off-by:
-
Gustavo A. R. Silva authored
Silence the following out-of-bounds warning (caught with -Warray-bounds=2): drivers/staging/r8188eu/core/rtw_wlan_util.c: In function ‘HT_caps_handler’: drivers/staging/r8188eu/core/rtw_wlan_util.c:719:54: error: array subscript 2 is above array bounds of ‘u8[1]’ {aka ‘unsigned char[1]’} [-Werror=array-bounds] 719 | pIE->data[i] & 0x3); | ~~~~~~~~~^~~ ./include/linux/minmax.h:32:39: note: in definition of macro ‘__cmp_once’ 32 | typeof(y) unique_y = (y); \ | ^ ./include/linux/minmax.h:45:25: note: in expansion of macro ‘__careful_cmp’ 45 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ drivers/staging/r8188eu/core/rtw_wlan_util.c:718:41: note: in expansion of macro ‘min’ 718 | max_AMPDU_len = min(pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x3, | ^~~ In file included from drivers/staging/r8188eu/core/../include/drv_types.h:16, from drivers/staging/r8188eu/core/rtw_wlan_util.c:7: drivers/staging/r8188eu/core/../include/wlan_bssdef.h:64:13: note: while referencing ‘data’ 64 | u8 data[1]; | ^~~~ by transforming one-element array into a flexible-array member in struct ndis_802_11_var_ie This is part of the ongoing efforts to globally enable -Warray-bounds. Reviewed-by:Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Gustavo A. R. Silva <gustavoars@kernel.org> Link: https://lore.kernel.org/r/20220202070906.GA274379@embeddedorSigned-off-by:
-
- 31 Jan, 2022 30 commits
-
-
Michael Straube authored
The HW_VAR_CAM_EMPTY_ENTRY case in SetHwReg8188EU() is not used. Remove it. Signed-off-by:
-
Michael Straube authored
The HW_VAR_CHECK_BSSID case in SetHwReg8188EU() is not used. Remove it. Signed-off-by:
-
Michael Straube authored
The HW_VAR_BCN_FUNC case in SetHwReg8188EU() just calls hw_var_set_bcn_func(). Remove HW_VAR_BCN_FUNC from SetHwReg8188EU(), remove hw_var_set_bcn_func() and call rtw_write8() directly. Since hw_var_set_bcn_func() was always called with value 0, we only need to keep the else arm of the if statement that checks the value. Signed-off-by:
-
Michael Straube authored
Remove HW_VAR_CAM_WRITE from SetHwReg8188EU() and call rtw_write32() directly. Signed-off-by:
-
Michael Straube authored
Set_MSR() just calls Set_NETYPE0_MSR(). Merge the two functions. Keep Set_MSR() and remove Set_NETYPE0_MSR(). Signed-off-by:
-
Michael Straube authored
Remove HW_VAR_MEDIA_STATUS from SetHwReg8188EU() and call rtw_read8() and rtw_write8() directly. Signed-off-by:
-
Michael Straube authored
Remove HW_VAR_AC_PARAM_BK from SetHwReg8188EU() and call rtw_write32() directly. Signed-off-by:
-
Michael Straube authored
Remove HW_VAR_AC_PARAM_VI from SetHwReg8188EU() and call rtw_write32() directly. Signed-off-by:
-
Michael Straube authored
Remove HW_VAR_AC_PARAM_VO from SetHwReg8188EU() and call rtw_write32() directly. Signed-off-by:
-
Michael Straube authored
Remove HW_VAR_CAM_INVALID_ALL from SetHwReg8188EU() and call rtw_write32() directly. Signed-off-by:
-
Michael Straube authored
Remove HW_VAR_SEC_CFG from SetHwReg8188EU() and call rtw_write8() directly. Signed-off-by:
-
Michael Straube authored
Remove HW_VAR_BEACON_INTERVAL from SetHwReg8188EU() and call rtw_write16() directly. Signed-off-by:
-
Abdun Nihaal authored
rtw_p2p_got_wpsinfo always returns 0 and it's return value is not used. Convert it to return void. Suggested-by:
Abdun Nihaal <abdun.nihaal@gmail.com> Link: https://lore.kernel.org/r/f63e236e3a338789265172990fea049216115105.1643466748.git.abdun.nihaal@gmail.comSigned-off-by:
-
Abdun Nihaal authored
rtw_p2p_prov_disc always returns 0 and it's return value is not used. Convert it to return void. Suggested-by:
-
Abdun Nihaal authored
rtw_p2p_set_persistent always returns 0 and it's return value is not used. Convert it to return void. Suggested-by:
-
Abdun Nihaal authored
rtw_p2p_invite_req always returns 0 and it's return value is not used. Convert it to return void. Suggested-by:
-
Abdun Nihaal authored
rtw_p2p_get_op_ch always returns 0 and it's return value is not used. Convert it to return void. Suggested-by:
-
Abdun Nihaal authored
rtw_p2p_get_groupid always returns 0 and it's return value is not used. Convert it to return void. Suggested-by:
-
Abdun Nihaal authored
rtw_p2p_get_peer_devaddr_by_invitation always returns 0 and it's return value is not used. Convert it to return void. Suggested-by:
-
Abdun Nihaal authored
rtw_p2p_get_peer_devaddr always returns 0 and it's return value is not used. Convert it to return void. Suggested-by:
-
Abdun Nihaal authored
rtw_p2p_get_peer_ifaddr always returns 0 and it's return value is not used. Convert it to return void. Suggested-by:
-
Abdun Nihaal authored
rtw_p2p_get_role always returns 0 and it's return value is not used. Convert it to return void. Suggested-by:
-
Abdun Nihaal authored
rtw_p2p_get_req_cm always returns 0 and it's return value is not used. Convert it to return void. Suggested-by:
-
Abdun Nihaal authored
rtw_p2p_get_status always returns 0 and it's return value is not used. Convert it to return void. Suggested-by:
-
Abdun Nihaal authored
rtw_p2p_setDN always returns 0 and it's return value is not used. Convert it to return void. Suggested-by:
-
Abdun Nihaal authored
rtw_p2p_set_go_nego_ssid always returns 0 and it's return value is not used. Convert it to return void. Suggested-by:
-
Abdun Nihaal authored
rtw_p2p_get2 calls functions that can fail with -EFAULT. Return the error code from the called functions. Signed-off-by:
-
Abdun Nihaal authored
Remove unneeded return variable that is initialized to 0 and not assigned after. Found using Coccinelle Signed-off-by:
-
Abdun Nihaal authored
Remove unneeded return variable that is initialized to 0 and not assigned after. Found using Coccinelle Signed-off-by:
-
Abdun Nihaal authored
Remove unneeded return variable that is initialized to 0 and not assigned after. Found using Coccinelle Signed-off-by:
-
