- 17 Sep, 2020 3 commits
-
-
Evan Quan authored
That's where the uclk dpm get enabled and then the uclk cdr workaround can be applied. Signed-off-by:
Evan Quan <evan.quan@amd.com> Reviewed-by:
Alex Deucher <alexander.deucher@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Evan Quan authored
This is needed for Navi1X only. And it may help for display missing or hang issue seen on some high resolution monitors. V2: no UCLK DPM enablement for Navi10 A0 secure SKU Signed-off-by:
Evan Quan <evan.quan@amd.com> Reviewed-by:
Alex Deucher <alexander.deucher@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Evan Quan authored
So that ASIC specific actions can be added. V2: better namings Signed-off-by:
Evan Quan <evan.quan@amd.com> Reviewed-by:
Alex Deucher <alexander.deucher@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
- 15 Sep, 2020 37 commits
-
-
Michel Dänzer authored
Don't check drm_crtc_state::active for this either, per its documentation in include/drm/drm_crtc.h: * Hence drivers must not consult @active in their various * &drm_mode_config_funcs.atomic_check callback to reject an atomic * commit. atomic_remove_fb disables the CRTC as needed for disabling the primary plane. This prevents at least the following problems if the primary plane gets disabled (e.g. due to destroying the FB assigned to the primary plane, as happens e.g. with mutter in Wayland mode): * The legacy cursor ioctl returned EINVAL for a non-0 cursor FB ID (which enables the cursor plane). * If the cursor plane was enabled, changing the legacy DPMS property value from off to on returned EINVAL. v2: * Minor changes to code comment and commit log, per review feedback. GitLab: https://gitlab.gnome.org/GNOME/mutter/-/issues/1108 GitLab: https://gitlab.gnome.org/GNOME/mutter/-/issues/1165 GitLab: https://gitlab.gnome.org/GNOME/mutter/-/issues/1344Suggested-by:
Daniel Vetter <daniel.vetter@ffwll.ch> Acked-by:
Daniel Vetter <daniel.vetter@ffwll.ch> Reviewed-by:
Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Signed-off-by:
Michel Dänzer <mdaenzer@redhat.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Alex Deucher authored
Copy paste typo. Reported-by:
kernel test robot <lkp@intel.com> Reviewed-by:
Felix Kuehling <Felix.Kuehling@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Alex Deucher authored
Due to hardware bugs, scatter/gather display on raven requires a 1:1 IOMMU mapping, however, SME (System Memory Encryption) requires an indirect IOMMU mapping because the encryption bit is beyond the DMA mask of the chip. As such, the two are incompatible. Acked-by:
Joerg Roedel <jroedel@suse.de> Reviewed-by:
Christian König <christian.koenig@amd.com> Acked-by:
Felix Kuehling <Felix.Kuehling@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
YueHaibing authored
Add trigger_hotplug debugfs entry. Fixes: 6f77b2ac ("drm/amd/display: Add connector HPD trigger debugfs entry") Reviewed-by:
Harry Wentland <harry.wentland@amd.com> Signed-off-by:
YueHaibing <yuehaibing@huawei.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
YueHaibing authored
If parse_write_buffer_into_params() fails, we should free wr_buf before return. Fixes: 6f77b2ac ("drm/amd/display: Add connector HPD trigger debugfs entry") Reviewed-by:
Harry Wentland <harry.wentland@amd.com> Signed-off-by:
YueHaibing <yuehaibing@huawei.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Bernard Zhao authored
In fnction is_cr_done & is_ch_eq_done, when done = false happened once, no need to circle left ln_count. This change is to make the code run a bit fast. Signed-off-by:
Bernard Zhao <bernard@vivo.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Zheng Bin authored
Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:1003:4-9: WARNING: Comparison to bool drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:1083:5-11: WARNING: Comparison to bool Acked-by:
Christian König <christian.koenig@amd.com> Signed-off-by:
Zheng Bin <zhengbin13@huawei.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Zheng Bin authored
Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c:619:15-49: WARNING: Comparison to bool drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c:629:15-49: WARNING: Comparison to bool Acked-by:
Christian König <christian.koenig@amd.com> Signed-off-by:
Zheng Bin <zhengbin13@huawei.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Zheng Bin authored
Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c:1243:14-25: WARNING: Comparison to bool Acked-by:
Christian König <christian.koenig@amd.com> Signed-off-by:
Zheng Bin <zhengbin13@huawei.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Zheng Bin authored
Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/si.c:1342:5-10: WARNING: Comparison to bool Acked-by:
Christian König <christian.koenig@amd.com> Signed-off-by:
Zheng Bin <zhengbin13@huawei.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Zheng Bin authored
Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:562:5-11: WARNING: Comparison to bool Acked-by:
Christian König <christian.koenig@amd.com> Signed-off-by:
Zheng Bin <zhengbin13@huawei.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Zheng Bin authored
Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:619:5-11: WARNING: Comparison to bool Acked-by:
Christian König <christian.koenig@amd.com> Signed-off-by:
Zheng Bin <zhengbin13@huawei.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Zheng Bin authored
Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:3563:5-31: WARNING: Comparison to bool Acked-by:
Christian König <christian.koenig@amd.com> Signed-off-by:
Zheng Bin <zhengbin13@huawei.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Zheng Bin authored
Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:2805:5-11: WARNING: Comparison to bool Acked-by:
Christian König <christian.koenig@amd.com> Signed-off-by:
Zheng Bin <zhengbin13@huawei.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Sandeep Raghuraman authored
This patch adds support for reporting sclk values for Radeon GPUs, where supported. Signed-off-by:
Sandeep Raghuraman <sandy.8925@gmail.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Tian Tao authored
Fix kernel-doc warnings. drivers/gpu/drm/scheduler/sched_fence.c:110: warning: Function parameter or member 'f' not described in 'drm_sched_fence_release_scheduled' drivers/gpu/drm/scheduler/sched_fence.c:110: warning: Excess function parameter 'fence' description in 'drm_sched_fence_release_scheduled' Reviewed-by:
Christian König <christian.koenig@amd.com> Signed-off-by:
Tian Tao <tiantao6@hisilicon.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Randy Dunlap authored
Fix spellos of "function" in drivers/gpu/drm/amd/display/. Signed-off-by:
Randy Dunlap <rdunlap@infradead.org> Cc: Harry Wentland <harry.wentland@amd.com> Cc: Leo Li <sunpeng.li@amd.com> Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Chen Zhou authored
Remove duplicate header which is included twice. Signed-off-by:
Chen Zhou <chenzhou10@huawei.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Jonathan Kim authored
Disabling perf events does not specify reset in ABI so stop doing it in hardware. Signed-off-by:
Jonathan Kim <Jonathan.Kim@amd.com> Reviewed-by:
Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Christian König authored
Turns out this breaks a lot of different hardware. This reverts commit fc8c7052. Signed-off-by:
Christian König <christian.koenig@amd.com> Acked-by:
Nirmoy Das <nirmoy.das@amd.com> Reviewed-by:
Alex Deucher <alexander.deucher@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Oak Zeng authored
Add more accurate description of the pe parameter of function amdgpu_vm_sdma_udpate and amdgpu_vm_cpu_update Signed-off-by:
Oak Zeng <Oak.Zeng@amd.com> Reviewed-by:
Christian Konig <christian.koenig@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Oak Zeng authored
Add comments to refect what function does Signed-off-by:
Oak Zeng <Oak.Zeng@amd.com> Reviewed-by:
Christian Konig <christian.koenig@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Andrey Grodzovsky authored
Create sysfs interface also for sienna_cichlid. Reviewed-by:
Alex Deucher <alexander.deucher@amd.com> Signed-off-by:
Andrey Grodzovsky <andrey.grodzovsky@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Lewis Huang authored
[Why] Seamless boot skip porgram clock when set path mode. It cause driverprogram clock after unblank stream. [How] update clock when non-seamless boot stream exist Signed-off-by:
Lewis Huang <Lewis.Huang@amd.com> Acked-by:
Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Dmytro Laktyushkin authored
Signed-off-by:
Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com> Acked-by:
Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Jun Lei authored
[why] Some SOC BB paramters may vary per SKU, and it does not make sense for driver to hardcode these values [how] Parse the values from VBIOS if available, and use them if valid Signed-off-by:
Jun Lei <Jun.Lei@amd.com> Acked-by:
Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Fangzhi Zuo authored
[Why] psr doesn't get fully disabled before hitting hubbub1_wm_change_req_wa. [How] Pass TRUE to "wait" parameter to get psr fully disabled. Follow-Up fix to: dc: PSR eDP p-state warning occurs intermittently after unplug DP Signed-off-by:
Fangzhi Zuo <Jerry.Zuo@amd.com> Acked-by:
Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Jun Lei authored
[why] Recent characterization shows increased stutter latencies on some SKUs, leading to underflow. [how] Update SOC params to account for this worst case latency. Signed-off-by:
Jun Lei <jun.lei@amd.com> Acked-by:
Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Roman Li authored
[Why] gcc version 5.4.0 fails compilation with: ‘PixelPTEReqHeightPTEs’ may be used uninitialized in this function [-Werror=maybe-uninitialized] [How] Initialized variable explicitly with 0 Signed-off-by:
Roman Li <roman.li@amd.com> Acked-by:
Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Josip Pavic authored
[Why] The ctx field of dc_transfer_func is not always populated and therefore isn't reliable. [How] Remove dc context from dc_transfer_func Signed-off-by:
Josip Pavic <Josip.Pavic@amd.com> Acked-by:
Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Eryk Brol authored
[why] We want to trigger atomic check on connector, which DSC debugfs properties have changed. [how] Add a helper function that iterates through all active connectors and add them to the state if DSC debugfs parameters have changed. Signed-off-by:
Eryk Brol <eryk.brol@amd.com> Signed-off-by:
Mikita Lipski <mikita.lipski@amd.com> Acked-by:
Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Eryk Brol authored
[why] When comparing current DSC timing settings with enforced through debugfs we have to calculate number of both vertical and horisontal slices. So instead of doing that every time we should just use number of slices rather than setting its dimensions. [how] In connector's dsc preferred settings structure change slice height and slice width parameters to number of slices vertical and horisontal. Also calculate number of slices in debugfs rather in create_stream_for_sink. Signed-off-by:
Eryk Brol <eryk.brol@amd.com> Signed-off-by:
Mikita Lipski <mikita.lipski@amd.com> Acked-by:
Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Eryk Brol authored
[why & how] Previously we were returning the number of bytes allocated for a write buffer from debugfs and when manually used it wouldn't rise any errors, but it wouldn't match the size of the parameters passed from userspace. In successful case return the size passed by usermode otherwise the error code is returned. That simplifies the parser helper and removes a potential error of returning mismatched input size. Signed-off-by:
Eryk Brol <eryk.brol@amd.com> Signed-off-by:
Mikita Lipski <mikita.lipski@amd.com> Acked-by:
Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Joshua Aberback authored
[How] - use dc interface instead of hwss interface in cursor functions, to keep dc->idle_optimizations_allowed updated - add dc interface to check if idle optimizations might apply to a plane Signed-off-by:
Joshua Aberback <joshua.aberback@amd.com> Acked-by:
Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Eric Yang authored
[Why] Send stream active state info to DMUB [How] Implement GPINT to notify stream mask Signed-off-by:
Eric Yang <Eric.Yang2@amd.com> Acked-by:
Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Aric Cyr authored
Signed-off-by:
Aric Cyr <aric.cyr@amd.com> Acked-by:
Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Anthony Koo authored
| [Header Changes] | - Add debug flag to log line numbers for PSR debug Signed-off-by:
Anthony Koo <Anthony.Koo@amd.com> Acked-by:
Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-