- 28 Jan, 2008 40 commits
-
-
Al Viro authored
Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk> Signed-off-by:
Jeff Garzik <jeff@garzik.org>
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
* misannotation: struct register_test members are actually host-endian * bug: cpu_to_le64(n) >> 32 instead of cpu_to_le32(n >> 32) in setting ->bufhigh and similar for ->buflow (take low bits, _then_ convert to little-endian, not the other way round). * bug: setup_hw_rings() should not convert to little-endian at all (we feed the result to writel(), not store in shared data structure), let alone try to play with shifting and masking little-endian values. Introduced when setup_hw_rings() went in, screwed both 64bit case and the old code for 32bit rings it had replaced. Signed-off-by:
-
Al Viro authored
Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
Signed-off-by:
-
Al Viro authored
This one is interesting - SBUS and PCI variants have opposite endianness in descriptors (SBUS is sparc-only, so there host-endian == big-endian). Solution: declare a bitwise type (hme32) and in accessor helpers do typechecking and force-casts (once we know that the type is right). Signed-off-by:
-
Al Viro authored
* missing braces in !readl(...) & ... * trivial endianness annotations * in olympic_arb_cmd() the loop collecting fragments of packet is b0rken on big-endian - we have (next_ptr && (buf_ptr=olympic_priv->olympic_lap + ntohs(next_ptr))) as condition and it should have swab16(), not ntohs() - it's host-endian byteswapped, not big-endian. So if we get more than one fragment on big-endian host, we get screwed. This ntohs() got missed back when the rest of those had been switched to swab16() in 2.4.0-test2-pre1 - at a guess, nobody had hit fragmented packets during the testing of PPC fixes. PS: Ken Aaker cc'd on assumption that he is the same guy who'd done the original set of PPC fixes in olympic Signed-off-by:
-
David Woodhouse authored
We get scary warnings on UP if we use spin_trylock() and find, as we hoped, that the lock in question is already locked. Signed-off-by:
David Woodhouse <dwmw2@infradead.org> Signed-off-by:
John W. Linville <linville@tuxdriver.com>
-
David Woodhouse authored
There is weirdness here; the firmware seems to refuse to change channels at will. Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
We'll want to use this for meshfrobbing Signed-off-by:
-
David Woodhouse authored
Also, check that suspend is refused if HOST_SLEEP_CFG hasn't been done. Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
We (ab)use priv->fw_ready to stop the worker thread from sending more commands or data after the response to the HOST_SLEEP_ACTIVATE command comes in. And we set it from the callback function _directly_ to ensure that the worker thread sees it immediately; if we did it in lbs_suspend() after waking up, that might be too late. Signed-off-by:
-
David Woodhouse authored
We want it to send the HOST_SLEEP_ACTIVATE command on the way down... Signed-off-by:
-
David Woodhouse authored
This way, it looks more like a normal function. Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
In particular, we shouldn't be waking the queues in lbs_host_to_card_done() any more. Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
Especially in the light of OLPC trac #5461, in which the firmware starts sending us seemingly random command responses which bear little relation to the command we sent it. Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
Otherwise the device won't let us change channels. Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
sparse was getting on my tits. Signed-off-by:
-
Dan Williams authored
Signed-off-by:
Dan Williams <dcbw@redhat.com> Signed-off-by:
-
Dan Williams authored
Signed-off-by:
-
Dan Williams authored
Signed-off-by:
-
Dan Williams authored
Signed-off-by:
-
David Woodhouse authored
If stupid people like me give it arguments with the wrong type (like a pointer to the structure, for example, instead of the structure itself), then we should probably notice that at compile time. Otherwise, much confusion ensues. Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
Bad dcbw. Always test on big-endian, or at least use sparse. Signed-off-by:
-
