1. 08 Mar, 2016 2 commits
    • Arnd Bergmann's avatar
      wireless: cw1200: use __maybe_unused to hide pm functions_ · 836856e3
      Arnd Bergmann authored
      The cw1200 uses #ifdef to check for CONFIG_PM, but then
      uses SIMPLE_DEV_PM_OPS, which leaves the references out when
      CONFIG_PM_SLEEP is not defined, so we get a warning with
      PM=y && PM_SLEEP=n:
      
      drivers/net/wireless/st/cw1200/cw1200_spi.c:450:12: error: 'cw1200_spi_suspend' defined but not used [-Werror=unused-function]
      
      This removes the incorrect #ifdef and instead uses a __maybe_unused
      annotation to let the compiler know it can silently drop
      the function definition.
      
      For the DEV_PM_OPS definition, we can use an IS_ENABLED() check
      to avoid defining the structure when CONFIG_PM is not set without
      the #ifdef.
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      836856e3
    • Larry Finger's avatar
      rtlwifi: Fix size of wireless mode variable · 73fb2705
      Larry Finger authored
      Smatch reports the following warning:
      
        CHECK   drivers/net/wireless/realtek/rtlwifi/rc.c
      drivers/net/wireless/realtek/rtlwifi/rc.c:144 _rtl_rc_rate_set_series() warn: impossible condition '(wireless_mode == 256) => (0-255 == 256)'
      
      This warning arises because commit acc6907b87a9 ("rtlwifi: Fix warning
      from ieee80211_get_tx_rates() when using 5G") now checks the wireless
      mode for WIRELESS_MODE_AC_ONLY (BIT(8)) in _rtl_rc_rate_set_series().
      As a result, all quantities used to store the wireless mode must be u16.
      
      This patch also reorders struct rtl_sta_info to save a little space.
      
      Fixes: d76d65fd ("rtlwifi: fix broken VHT support")
      Reported-by: default avatarDan Williams <dcbw@redhat.com>
      Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      73fb2705
  2. 07 Mar, 2016 38 commits