- 03 Sep, 2011 12 commits
-
-
Andreas Oberritter authored
Signed-off-by:
Andreas Oberritter <obi@linuxtv.org> Signed-off-by:
Mauro Carvalho Chehab <mchehab@redhat.com>
-
Dan Carpenter authored
The ret = -EIO needs to be before the goto. Signed-off-by:
Dan Carpenter <error27@gmail.com> Signed-off-by:
-
Dan Carpenter authored
The goto needs to be moved after the assignment. Signed-off-by:
-
Mauro Carvalho Chehab authored
Tuners in general convert a high frequency carrier into an Intermediate Frequency (IF). Digital tuners like tda18271, xc3028, etc. generally allow changing the IF frequency, although they generally have recommented settings for the IF. Analog tuners, have a fixed IF frequency, that depends on the physical characteristics of some analog components. For digital tuners, it makes sense to have ways to configure IF, via the tuner's configuration structure, like what's done inside the tda18271-fe maps. The demods need to know what IF is used by the tuner, as it will need to convert internally from IF into baseband. Currently, the bridge driver needs to fill a per-demod configuration struct for it, or pass it via a dvb_attach parameter. The tda18271 datasheet recommends to use different IF's for different delivery system types and for different bandwidths. The DRX-K demod also needs to know the IF frequency in order to work, just like all other demods. However, as it accepts different delivery systems (DVB-C and DVB-T), the IF may change if the standard and/or bandwidth is changed. So, the usual procedure of passing it via a config struct doesn't work. One might try to code it as two separate IF frequencies, or even as a table in function of the delivery system and the bandwidth, but this will be messy. So, it is better and simpler to just add a new callback for it and require the tuners that can be used with MFE frontends like drx-k to implement a new callback to return the used IF. Signed-off-by:
Antti Palosaari <crope@iki.fi>
-
Jarod Wilson authored
Makes it more straight-forward to follow stack traces if the functions don't have generic names. Using this as a crutch while trying to better understand the lockdep warnings I get when loading the em28xx driver. CC: Devin Heitmueller <dheitmueller@kernellabs.com> Signed-off-by:
Jarod Wilson <jarod@redhat.com> Signed-off-by:
-
Jarod Wilson authored
Signed-off-by:
-
Jonathan Corbet authored
The one in-tree videobuf2-dma-sg driver (mmp-camera) has no need for a kernel-space mapping of the buffers; one suspects that most other drivers would not either. The videobuf2-dma-sg module does the right thing if buf->vaddr == NULL - it maps the buffer on demand if somebody needs it. So let's not map the buffer at allocation time; that will save a little CPU time and a lot of address space in the vmalloc range. Signed-off-by:
Jonathan Corbet <corbet@lwn.net> Acked-by:
Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by:
-
Andreas Oberritter authored
- fepriv->parameters_out isn't protected by events->mtx, so move the call to fe->ops.get_frontend out of the locked area. - move the assignment of e->status into the locked area. - use direct assignment instead of memcpy. - use mutex_lock instead of mutex_lock_interruptible, because all code paths protected by this mutex won't block. Signed-off-by: -
Andreas Oberritter authored
the first event after an attempt to tune. Signed-off-by:
-
Andreas Oberritter authored
enqueued before the frontend thread wakes up. Signed-off-by:
-
Andreas Oberritter authored
Modify it to use the data given by the user. Signed-off-by:
-
Julia Lawall authored
Delete nontrivial initialization that is immediately overwritten by the result of an allocation function. The semantic match that makes this change is as follows: // <smpl> @@ type T; identifier i; expression e; @@ ( T i = \(0\|NULL\|ERR_PTR(...)\); | -T i = e; +T i; ) ... when != i i = \(kzalloc\|kcalloc\|kmalloc\)(...); // </smpl> Signed-off-by:
Julia Lawall <julia@diku.dk> Acked-by:
Jean Delvare <khali@linux-fr.org> Signed-off-by:
-
- 01 Sep, 2011 1 commit
-
-
Mauro Carvalho Chehab authored
> [34883.426065] tm6000 #0: registered device video0 > [34883.430591] Trident TVMaster TM5600/TM6000/TM6010 USB2 board (Load status: 0) > [34883.437763] usbcore: registered new interface driver tm6000 > [34884.608372] BUG: unable to handle kernel NULL pointer dereference at 00000002 > [34884.615514] IP: [<f8c4ceea>] tm6000_reset+0xd7/0x11c [tm6000] The dev->int_in USB interfaces is used by some devices for the Remote Controller. Not all devices seem to define this interface, so, tm6000_reset should not try to set the interface to it on such devices. Signed-off-by:
-
- 31 Aug, 2011 17 commits
-
-
Thierry Reding authored
Signed-off-by:
Thierry Reding <thierry.reding@avionic-design.de> Signed-off-by:
-
Thierry Reding authored
Signed-off-by:
-
Thierry Reding authored
When releasing hardware resources, the DMA buffer allocated to the PCM device needs to be freed to prevent a memory leak. Signed-off-by:
-
Thierry Reding authored
If the radio device is opened there is no need to initialize the video buffer queue because it is not used. Signed-off-by:
-
Thierry Reding authored
When the last user closes the device, perform a lightweight reset of the device to bring it into a well-known state. Note that this is not always enough with the TM6010, which sometimes needs a hard reset to get into a working state again. Signed-off-by:
-
Thierry Reding authored
This fixes a memory leak where isochronous buffers would be set up for each video buffer, while it is sufficient to set them up only once per device. Signed-off-by:
-
Thierry Reding authored
When the USB device is disconnected, the device usage bit is not cleared properly. This leads to errors when a device is unplugged and replugged several times until all TM6000_MAXBOARDS bits are used and keeps the driver from binding to the device. Signed-off-by:
-
Thierry Reding authored
This commit introduces the usb_lock mutex to ensure that a USB request always gets the proper response. While this is currently not really necessary it will become important as there are more users. Signed-off-by:
-
Thierry Reding authored
This commit uses sentinel entries to terminate the TV standard register tables instead of hard-coding their size, allowing further entries to be added more easily. It is also more space-efficient if the tables have a varying number of entries. Signed-off-by:
-
Thierry Reding authored
Video data is useless in radio mode, so the corresponding interface can be safely disabled. This should reduce the amount of isochronous traffic noticeably. Signed-off-by:
-
Thierry Reding authored
The register ACTIVE_VIDEO_IF register should be named ACTIVE_IF since it controls more than just the video interface. Signed-off-by:
-
Thierry Reding authored
This brings the IRQ callback implementation more in line with how other drivers do it. Signed-off-by:
-
Thierry Reding authored
Signed-off-by:
-
Thierry Reding authored
In radio mode, the correct input is rinput. The pseudo index 5 is used but cannot be used to index the vinput array because that only has 3 elements. Signed-off-by:
-
Thierry Reding authored
This commit fixes a number of coding style issues as well as some issues reported by checkpatch and sparse. Signed-off-by:
-
Mauro Carvalho Chehab authored
In radio mode, no frequency offset should be used. Instead of taking Thierry's patch that creates a separate function to calculate the digital offset, it seemed better to just keep everything at the same place. Reported-by:
-
Thierry Reding authored
When loading the firmware, complete each chunk by sending an I2C flush command to the frontend. Some devices like the tm6000 seem to require this to properly flush the I2C buffers. The current code in tm6000 executes the flush command once after each I2C transfer, which slows down the firmware loading especially when loading large BASE type images. Signed-off-by:
-
- 29 Aug, 2011 2 commits
-
-
Sakari Ailus authored
The ccdc block in the omap3isp produces events whenever it starts receiving a new frame. A private HS_VS event was used for this previously. Now, the generic V4L2_EVENT_FRAME_SYNC event is being used for the purpose. This patch also provides the frame sequence number to user space. Signed-off-by:
Sakari Ailus <sakari.ailus@iki.fi> Acked-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by:
-
Sakari Ailus authored
Define a frame sync event to tell user space when the reception of a frame starts. Signed-off-by:
-
- 27 Aug, 2011 8 commits
-
-
Jose Alberto Reguero authored
Signed-off-by:
Jose Alberto Reguero <jareguero@telefonica.net> Reviewed-by:
-
istvan_v@mailbox.hu authored
This patch reduces the number of available choices for the notch filter type control so that the standard-specific filter types cannot be selected. It is now limited to being either 0 (4xFsc, the default) or 1 (square pixel optimized). The patch also removes the initialization of this control from cx88_reset(), since that is already done by init_controls(), which is called by cx8800_initdev(). Signed-off-by:
Istvan Varga <istvan_v@mailbox.hu> Signed-off-by:
-
Joe Perches authored
Use the more current logging styles with pr_fmt. Remove now unnecessary private include. Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Joe Perches authored
Deduplicate printk formats to save ~20KB text. $ size drivers/media/common/tuners/tda18271*o.* text data bss dec hex filename 10747 56 1920 12723 31b3 drivers/media/common/tuners/tda18271-common.o.new 18889 56 3112 22057 5629 drivers/media/common/tuners/tda18271-common.o.old 20561 204 4264 25029 61c5 drivers/media/common/tuners/tda18271-fe.o.new 31093 204 6000 37297 91b1 drivers/media/common/tuners/tda18271-fe.o.old 3681 6760 440 10881 2a81 drivers/media/common/tuners/tda18271-maps.o.new 5631 6760 680 13071 330f drivers/media/common/tuners/tda18271-maps.o.old Signed-off-by:
-
Antti Palosaari authored
Style issue. Signed-off-by:
-
Antti Palosaari authored
Thanks to Thomas Gutzler for reporting this. Signed-off-by:
-
Antti Palosaari authored
Signed-off-by:
-
Julia Lawall authored
Convert array index from the loop bound to the loop index. A simplified version of the semantic patch that fixes this problem is as // <smpl> @@ expression e1,e2,ar; @@ for(e1 = 0; e1 < e2; e1++) { <... ar[ - e2 + e1 ] ...> } // </smpl> Signed-off-by:Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
-
