- 27 Dec, 2005 16 commits
-
-
Stefan Richter authored
SCSI: fix transfer direction in scsi_lib and st scsi_prep_fn and st_init_command could issue WRITE requests with zero buffer length. This may lead to kernel panic or oops with some SCSI low-level drivers. Derived from -rc patches from Jens Axboe and James Bottomley. Patch is reassembled for -stable from patches: [SCSI] fix panic when ejecting ieee1394 ipod [SCSI] Consolidate REQ_BLOCK_PC handling path (fix ipod panic) Depends on patch "SCSI: fix transfer direction in sd (kernel panic when ejecting iPod)". Also modifies the already correct sr_init_command to fully match the corresponding -rc patch. Signed-off-by:
Stefan Richter <stefanr@s5r6.in-berlin.de> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Stefan Richter authored
SCSI: fix transfer direction in sd (kernel panic when ejecting iPod) sd_init_command could issue WRITE requests with zero buffer length. This may lead to kernel panic or oops with some SCSI low-level drivers. Seen with the command "eject /dev/sdX" when disconnecting an iPod: http://marc.theaimsgroup.com/?l=linux1394-devel&m=113399994920181 http://marc.theaimsgroup.com/?l=linux1394-user&m=112152701817435 Derived from -rc patches from Jens Axboe and James Bottomley. Patch is reassembled for -stable from patches: [SCSI] fix panic when ejecting ieee1394 ipod [SCSI] Consolidate REQ_BLOCK_PC handling path (fix ipod panic) Signed-off-by:
-
Jason Wessel authored
All the work was done to setup the file and maintain the file handles but the access functions were zeroed out due to the #ifdef. Removing the #ifdef allows full access to all the parameters when CONFIG_MODULES=n. akpm: put it back again, but use CONFIG_SYSFS instead. This patch has already been included in Linus' tree. Signed-off-by:
Jason Wessel <jason.wessel@windriver.com> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Adrian Bunk <bunk@stusta.de> Signed-off-by:
-
Dmitry Torokhov authored
This patch fixes an OOPS in HID driver when connecting simulation devices generating unknown simulation events. Signed-off-by:
Dmitry Torokhov <dtor@mail.ru> Acked-by:
Vojtech Pavlik <vojtech@suse.cz> Signed-off-by:
Chris Wright <chrisw@redhat.com> Signed-off-by:
-
David S. Miller authored
When we insert a new xfrm_state which potentially subsumes an existing one, make sure all cached bundles are flushed so that the new SA is used immediately. Signed-off-by:
David S. Miller <davem@davemloft.net> Signed-off-by:
-
YOSHIFUJI Hideaki authored
The route expiration time is stored in rt6i_expires in jiffies. The argument of rt6_route_add() for adding a route is not the expiration time in jiffies nor in clock_t, but the lifetime (or time left before expiration) in clock_t. Because of the confusion, we sometimes saw several strange errors (FAILs) in TAHI IPv6 Ready Logo Phase-2 Self Test. The symptoms were analyzed by Mitsuru Chinen <CHINEN@jp.ibm.com>. Signed-off-by:
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Signed-off-by:
-
Bart De Schuymer authored
A typo caused some bridged IPv6 packets to get dropped randomly, as reported by Sebastien Chaumontet. The patch below fixes this (using skb->nh.raw instead of raw) and also makes the jumbo packet length checking up-to-date with the code in net/ipv6/exthdrs.c::ipv6_hop_jumbo. Signed-off-by:
Bart De Schuymer <bdschuym@pandora.be> Signed-off-by:
-
Kristian Slavov authored
I reported a problem and gave hints to the solution, but nobody seemed to react. So I prepared a patch against 2.6.14.4. Tested on 2.6.14.4 with "ip monitor addr" and with the program attached, while adding and removing IPv6 address. Both programs didn't receive any messages. Tested 2.6.14.4 + this patch, and both programs received add and remove messages. Signed-off-by:
Kristian Slavov <kristian.slavov@nomadiclab.com> Acked-by:
Jamal Hadi salim <hadi@cyberus.ca> ACKed-by:
Patrick McHardy <kaber@trash.net> Signed-off-by:
-
Patrick McHardy authored
IP6_NF_TARGET_NFQUEUE depends on IP6_NF_IPTABLES, not IP_NF_IPTABLES. Signed-off-by:
-
Patrick McHardy authored
As noticed by Phil Oester, the GRE NAT protocol helper is initialized before the NAT core, which makes registration fail. Change the linking order to make NAT be initialized first. Signed-off-by:
-
Stephen Hemminger authored
Receiving VLAN packets over a device (without VLAN assist) that is doing hardware checksumming (CHECKSUM_HW), causes errors because the VLAN code forgets to adjust the hardware checksum. Signed-off-by:
Stephen Hemminger <shemminger@osdl.org> Signed-off-by:
-
Herbert Xu authored
The skb_postpull_rcsum introduced a bug to the checksum modification. Although the length pulled is offset bytes, the origin of the pulling is the GRE header, not the IP header. Signed-off-by:
Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by:
-
Salyzyn, Mark authored
Miquel van Smoorenburg <miquels@cistron.nl> forwarded me this fix to resolve a deadlock condition that occurs due to the API change in 2.6.13+ kernels dropping the host locking when entering the error handling. They all end up calling adpt_i2o_post_wait(), which if you call it unlocked, might return with host_lock locked anyway and that causes a deadlock. Signed-off-by:
Mark Salyzyn <aacraid@adaptec.com> Cc: James Bottomley <James.Bottomley@steeleye.com> Cc: <stable@kernel.org> Signed-off-by:
-
Yu Luming authored
Fix Null pointer deref in video/lcd/brightness http://bugzilla.kernel.org/show_bug.cgi?id=5571Signed-off-by:
Yu Luming <luming.yu@gmail.com> Cc: "Brown, Len" <len.brown@intel.com> Signed-off-by:
Thomas Renninger <trenn@suse.de> Signed-off-by:
Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by:
-
Patrick McHardy authored
NFA_NEST calls NFA_PUT which jumps to nfattr_failure if the skb has no room left. We call read_unlock_bh at nfattr_failure for the NFA_PUT inside the locked section, so move NFA_NEST inside the locked section too. Signed-off-by:
Krzysztof Piotr Oledzki <ole@ans.pl> Signed-off-by:
-
Krzysztof Oledzki authored
CTA_PROTO_NUM is a u_int8_t. Based on oryginal patch by Patrick McHardy <kaber@trash.net> Signed-off-by:
-
- 14 Dec, 2005 24 commits
-
-
Greg Kroah-Hartman authored
-
Pierre Ossman authored
kauditd was causing suspends to fail because it refused to freeze. Adding a try_to_freeze() to its sleep loop solves the issue. Signed-off-by:
Pierre Ossman <drzeus@drzeus.cx> Acked-by:
Pavel Machek <pavel@suse.cz> Cc: David Woodhouse <dwmw2@infradead.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org> Signed-off-by:
-
Jens Axboe authored
Applications using CCISS_BIG_PASSTHRU complained that the data written was zeros. The problem is that the buffer is being cleared after the user copy, unless the user copy has failed... Correct that logic. Signed-off-by:
Mike Miller <mike.miller@hp.com> Signed-off-by:
Jens Axboe <axboe@suse.de> Signed-off-by:
-
Linux Kernel Mailing List authored
From Mike Miller <mikem@beardog.cca.cpqcorp.net> This patch fixes a bug that breaks hpacucli, a command line interface for the HP Array Config Utility. Without this fix the utility will not detect any controllers in the system. I thought I had already fixed this, but I guess not. Thanks to all who reported the issue. Please consider this this inclusion. Signed-off-by:
Mike Miller <mikem@beardog.cca.cpqcorp.net> Signed-off-by:
-
Ondrej Zary authored
The problem (eject not working on ATAPI LS-120 drive) is caused by idefloppy_ioctl() function which *first* tries generic_ide_ioctl() and *only* if it fails with -EINVAL, proceeds with the specific ioctls. The generic eject command fails with something other than -EINVAL and the specific one is never executed. This patch fixes it by first going through the internal ioctls and only trying generic_ide_ioctl() if none of them matches. Signed-off-by:
Ondrej Zary <linux@rainbow-software.org> Signed-off-by:
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Signed-off-by:
-
Dmitry Torokhov authored
Make /proc/i8k display '?' when service tag is blank in BIOS. This fixes segfault in i8k gkrellm plugin. Signed-off-by:
-
Jeff Garzik authored
[libata] locking rewrite (== fix) A lot of power packed into a little patch. This change eliminates the sharing between our controller-wide spinlock and the SCSI core's Scsi_Host lock. As the locking in libata was already highly compartmentalized, always referencing our own lock, and never scsi_host::host_lock. As a side effect, this change eliminates a deadlock from calling scsi_finish_command() while inside our spinlock. Signed-off-by: -
Olaf Rempel authored
[BRIDGE]: recompute features when adding a new device We must recompute bridge features everytime the list of underlying devices changes, or we might end up with features that are not supported by all devices (eg. NETIF_F_TSO) This patch adds the missing recompute when adding a device to the bridge. Signed-off-by:
Olaf Rempel <razzor@kopf-tisch.de> Signed-off-by:
-
Jay Vosburgh authored
This should resolve http://bugzilla.kernel.org/show_bug.cgi?id=5519 The current feature computation loses bits that it doesn't know about, resulting in an inability to add VLANs and possibly other havoc. Rewrote function to preserve bits it doesn't know about, remove an unneeded state variable, and simplify the code. Signed-off-by:
Jay Vosburgh <fubar@us.ibm.com> Signed-off-by:
John W. Linville <linville@tuxdriver.com> Signed-off-by:
-
Dave Jones authored
[AGPGART] Fix serverworks TLB flush. Go back to what 2.4 kernels used to do here, as if this hits, the kernel just hangs indefinitly. Actually an improvement over 2.4 - we now break; out of the loop instead of just printing messages on timeouts. Signed-off-by:
Dave Jones <davej@redhat.com> Signed-off-by:
-
Igor Popik authored
The i82365 driver does not release all the resources when the device is not found. This can cause an oops when reading /proc/ioports after module unload (e.g. bug #5657). Signed-off-by:
Igor Popik <igor.popik@gmail.com> Signed-off-by:
Dominik Brodowski <linux@dominikbrodowski.net> Signed-off-by:
-
John W. Linville authored
Modules: NM256 driver The current snd-nm256 driver can cause Dell Latitude CSx laptops to lock-up during module (un)load. I have isolated this to the writes to the control port register at offset 0x6cc which were not already protected by the existing reset_workaround. I tried grouping these writes with the existing reset_workaround clause, but that caused the driver to have (un)load problems on the Dell Latitude LS laptops. So, I have implemented a reset_workaround_2 clause (please feel free to suggest a better name!) to cover this situation and added a quirk entry for the CSx laptops. Signed-off-by:
Takashi Iwai <tiwai@suse.de> Signed-off-by:
-
Michael Krufky authored
- Enable tda9887 on the following cx88 boards: pcHDTV 3000 FusionHDTV3 Gold-T - This ensures that analog NTSC video will function properly, without this patch, the tuner may appear to be broken. Signed-off-by:
Michael Krufky <mkrufky@m1k.net> Signed-off-by:
Mauro Carvalho Chehab <mchehab@brturbo.com.br> Signed-off-by:
-
Ricardo Cerqueira authored
- The Pinnacle PCTV Stereo needs tda9887 port2 set to 1 - Without this patch, mt20xx tuner is not detected and the board doesn't tune. Signed-off-by:
Ricardo Cerqueira <v4l@cerqueira.org> Signed-off-by:
-
Oleg Drokin authored
Fix a 32 bit integer overflow in invalidate_inode_pages2_range. Signed-off-by:
-
Thomas Renninger authored
[ACPI] fix HP nx8220 boot hang regression This patch reverts the acpi_bus_find_driver() return value check that came in via the PCI tree via 3fb02738 [PATCH] acpi bridge hotadd: Allow ACPI .add and .start operations to be done independently This particular change broke booting of some HP/Compaq laptops unless acpi=noirq is used. http://bugzilla.kernel.org/show_bug.cgi?id=5221 https://bugzilla.novell.com/show_bug.cgi?id=116763Signed-off-by:
Len Brown <len.brown@intel.com> Signed-off-by:
-
Carlos Silva authored
BUDGET_CI card depends on STV0297 demodulator. This patch solves a DVB driver compile error introduced in 2.6.14 Signed-off-by:
Johannes Stezenbach <js@linuxtv.org> Signed-off-by:
-
Daniel Drake authored
Commit f549d6c1 introduced a generic fallback for security xattrs, but appears to include a subtle bug. Gentoo users with kernels with selinux compiled in, and coreutils compiled with acl support, noticed that they could not copy files on tmpfs using 'cp'. cp (compiled with acl support) copies the file, lists the extended attributes on the old file, copies them all to the new file, and then exits. However the listxattr() calls were failing with this odd behaviour: llistxattr("a.out", (nil), 0) = 17 llistxattr("a.out", 0x7fffff8c6cb0, 17) = -1 ERANGE (Numerical result out of range) I believe this is a simple problem in the logic used to check the buffer sizes; if the user sends a buffer the exact size of the data, then its ok :) This change solves the problem. More info can be found at http://bugs.gentoo.org/113138Signed-off-by:
Daniel Drake <dsd@gentoo.org> Acked-by:
James Morris <jmorris@namei.org> Acked-by:
Stephen Smalley <sds@tycho.nsa.gov> Signed-off-by:
-
Thomas Graf authored
The receive path for fib_lookup netlink messages is lacking sanity checks for header and payload and is thus vulnerable to malformed netlink messages causing illegal memory references. Signed-off-by:
Thomas Graf <tgraf@suug.ch> Signed-off-by:
-
Daniel Drake authored
This patch combines commit 0b360adb (make setkeys root-only) and commit e3f17f0f (only disallow setting by users) Because people can play games reprogramming keys and leaving traps for the next user of the console. Signed-off-by:
-
Oliver Neukum authored
the scsi layer now uses very short sg lists. This breaks the microtek driver. Here is a patch fixes this and some other issues. Signed-off-by:
Oliver Neukum <oliver@neukum.name> Signed-off-by:
-
David Gibson authored
set_page_dirty() will not cope with being handed a page * which is part of a compound page, but not the master page in that compound page. This case can occur via access_process_vm() if you attemp to write to another process's hugepage memory area using ptrace() (causing an oops or hang). This patch fixes the bug by only calling set_page_dirty() from access_process_vm() if the page is not a compound page. We already use a similar fix in bio_set_pages_dirty() for the case of direct io to hugepages. Signed-off-by:
David Gibson <david@gibson.dropbear.id.au> Acked-by:
William Irwin <wli@holomorphy.com> Signed-off-by:
Chris Wright <chrisw@osdl.org> Signed-off-by:
-
Adrian Bunk authored
The Coverity checker spotted this obvious use-after-free caused by a wrong order of the cleanups. Signed-off-by:
Roland Dreier <rolandd@cisco.com> Signed-off-by:
-
Adrian Bunk authored
The Coverity checker spotted this obvious use-after-free Signed-off-by:
Markus Lidel <Markus.Lidel@shadowconnect.com> Signed-off-by:
-
