- 13 Apr, 2020 40 commits
-
-
Colin Ian King authored
The pointer 'w' is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by:Colin Ian King <colin.king@canonical.com> Link: https://lore.kernel.org/r/20200405130619.377043-1-colin.king@canonical.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Briana Oursler authored
Replace camel case variable names with snake case in baseband.h and its dependencies. Signed-off-by:
Briana Oursler <briana.oursler@gmail.com> Reviewed-by:
Stefano Brivio <sbrivio@redhat.com> Link: https://lore.kernel.org/r/20200403171805.466600-1-briana.oursler@gmail.comSigned-off-by:
-
Stefan Wahren authored
We can reduce the indentation in the loop by using continue in case the effect doesn't match. Reviewed-by:
Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Signed-off-by:
Stefan Wahren <stefan.wahren@i2se.com> Link: https://lore.kernel.org/r/1585485901-10172-10-git-send-email-stefan.wahren@i2se.comSigned-off-by:
-
Stefan Wahren authored
There are a lot of multiline statements which can be reduced. Reviewed-by:
-
Stefan Wahren authored
We can reduce the indentation in mmal_setup_components further by returning early in error case. Reviewed-by:
-
Stefan Wahren authored
The function mmal_setup_components has to many indention levels. So move the setup code for video component in its own function. Reviewed-by:
-
Stefan Wahren authored
The function mmal_setup_components has to many indention levels. So move the setup code for encode component in its own function. Reviewed-by:
-
Stefan Wahren authored
This simplifies set_framerate_params and avoids the multiple assignment in one line by moving the fps_high handling out of the if statement. Reviewed-by:
-
Stefan Wahren authored
The indentation of struct members wasn't consistent over the whole driver. Reviewed-by:
-
Stefan Wahren authored
I don't see any reason to keep this TODO, so activate the V4L2_EXPOSURE_METERING_MATRIX handling. Reviewed-by:
-
Stefan Wahren authored
This define is used only once. So drop the define and init the layer directly. Reviewed-by:
-
John B. Wyatt IV authored
Fix 2 parenthesis alignment issues. Reported by checkpatch. Signed-off-by:
John B. Wyatt IV <jbwyatt4@gmail.com> Link: https://lore.kernel.org/r/20200402023310.816245-1-jbwyatt4@gmail.comSigned-off-by:
-
John B. Wyatt IV authored
Fix 2 parenthesis alignment issues. Reported by checkpatch. Signed-off-by:
-
Aiman Najjar authored
This patch fixes remaining checkpatch warnings in rtl871x_xmit.c: WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->PrivacyKeyIndex' 636: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:636: + (u8)psecuritypriv-> + PrivacyKeyIndex); WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->XGrpKeyid' 643: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:643: + (u8)psecuritypriv-> + XGrpKeyid); WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->XGrpKeyid' 652: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:652: + (u8)psecuritypriv-> + XGrpKeyid); Signed-off-by:
Aiman Najjar <aiman.najjar@hurranet.com> Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/98805a72b92e9bbf933e05b827d27944663b7bc1.1585508171.git.aiman.najjar@hurranet.comSigned-off-by:
-
Aiman Najjar authored
1. Refactor make_wlanhdr to improve code style. 2. Use ether_addr_copy instead of memcpy to copy addresses. Suggested-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Aiman Najjar authored
This patch fixes multiline dereference warnings in rtl871x_xmit.c: WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->XGrptxmickey' 379: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:379: + psecuritypriv-> + XGrptxmickey[psecuritypriv-> WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->XGrpKeyid' 380: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:380: + XGrptxmickey[psecuritypriv-> + XGrpKeyid].skey); Signed-off-by:
-
Aiman Najjar authored
This patch fixes the following warning in rtl871x_xmit.c: WARNING: line over 80 characters 130: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:130: + pxmitbuf->pallocated_buf = kmalloc(MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ, Signed-off-by:
-
Aiman Najjar authored
This patch fixes these two long-line checkpatch warnings in rtl871x_xmit.c: WARNING: line over 80 characters \#74: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:74: + * Please allocate memory with the sz = (struct xmit_frame) * NR_XMITFRAME, WARNING: line over 80 characters \#79: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:79: + kmalloc(NR_XMITFRAME * sizeof(struct xmit_frame) + 4, GFP_ATOMIC); Signed-off-by:
-
Gokce Kuler authored
Convert a single line comment to a multiline comment to respect the 80 character rule.Problem found using checkpatch. Signed-off-by:
Gokce Kuler <gokcekuler@gmail.com> Reviewed-by:
-
John B. Wyatt IV authored
Fix style issue with declaration by adopting the same style as the function defintion in drivers/staging/comedi/comedi_buf.c. Issue reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Refactor while loop in Efuse_GetCurrentSize() to reduce indentation level and clear line over 80 characters checkpatch warnings. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Reviewed-by:
-
Michael Straube authored
Remove all remaining unnecessary parentheses reported by checkpatch. Signed-off-by:
-
John B. Wyatt IV authored
Align two different lines of arguments with the parenthesis of their respected function definitions. Fix style warnings of matching alignment. Reported by checkpatch. Signed-off-by:
-
Malcolm Priestley authored
mac80211 rate control decides which cck rates to use so all of them should be set enabled at the appropriate bit rate. This means vnt_get_cck_rate is no longer required. Signed-off-by:
Malcolm Priestley <tvboxspy@gmail.com> Link: https://lore.kernel.org/r/dec847da-5bad-1920-f275-741f7f704fb3@gmail.comSigned-off-by:
-
Malcolm Priestley authored
mac80211 rate control decides which odfm rates to use so all of them should be set enabled at the appropriate bit rate. This means vnt_get_ofdm_rate is no longer required. Signed-off-by:
-
Malcolm Priestley authored
The power table can replaced with calculation 0x0404090 | (power << 12) removing array and length macro. variable power never goes beyond the maximum setting. Signed-off-by:
-
Oscar Carter authored
Define the EnCFG_BBType_MASK bit as an OR operation between two previous defines instead of using the OR between two new BIT macros. Thus, the code is more clear. Signed-off-by:
Oscar Carter <oscar.carter@gmx.com> Reviewed-by:
Quentin Deslandes <quentin.deslandes@itdev.co.uk> Link: https://lore.kernel.org/r/20200402170103.22520-1-oscar.carter@gmx.comSigned-off-by:
-
John B. Wyatt IV authored
Add error code handling to unused 'ret' variable that was never used. Return an error code from functions called within vnt_radio_power_on. Issue reported by coccinelle (coccicheck). Suggested-by:
-
Oscar Carter authored
Create three arrays with the threshold data use in the switch statement of the vnt_update_pre_ed_threshold function. These three arrays contains elements of struct vnt_threshold new type. Create a for loop in the vnt_update_pre_ed_threshold function to do exactly the same that the if-elseif-else statements in the switch statement. Also, remove the if check against the !cr_201 && !cr_206 due to now it is replace by the NULL check against the threshold pointer. When this pointer is NULL means that the cr_201 and cr_206 variables have not been assigned, that is the same that the old comparison against cr_201 and cr_206 due to these variables were initialized with 0. The statistics of the old baseband object file are: section size addr .text 3415 0 .data 576 0 .bss 0 0 .rodata 120 0 .comment 45 0 .note.GNU-stack 0 0 .note.gnu.property 28 0 Total 4184 The statistics of the new baseband object file are: section size addr .text 2209 0 .data 576 0 .bss 0 0 .rodata 344 0 .comment 45 0 .note.GNU-stack 0 0 .note.gnu.property 28 0 Total 3202 With this refactoring it increase a little the readonly data but it decrease much more the .text section. This refactoring decrease the footprint and makes the code more clear. Signed-off-by:
-
Oscar Carter authored
Use the PREAMBLE_SHORT and PREAMBLE_LONG defines present in the file "baseband.h" to assign values to preamble_type variables. Also, use the same defines to make comparisons against these variables. In this way, avoid the use of numerical literals or boolean values and make the code more clear. Signed-off-by:
-
Briana Oursler authored
Remove function BBvExitDeepSleep that is never called. Signed-off-by:
-
Briana Oursler authored
Remove function CARDbRadioPowerOn that is never called, along with comments related to it. Signed-off-by:
-
Briana Oursler authored
Remove function CARDvSetLoopbackMode that is never called, along with comments related to it. Signed-off-by:
-
Briana Oursler authored
Remove function CARDbSoftwareReset that is never called, along with comments related to it. Signed-off-by:
-
Briana Oursler authored
Add whitespace around '-' operator and wrap long lines. Issue found by checkpatch.pl. Signed-off-by:
-
Briana Oursler authored
Eliminate nested if else statement, reduce code duplication, and shorten long lines by creating a new variable, len, to determine function input needed for s_uGetTxRsvTime. Signed-off-by:
-
Briana Oursler authored
Factor rate setting logic out of nested if-else statement to prevent code duplication. Signed-off-by:
-
Briana Oursler authored
Limit return statements within context of switch case to improve readability. Signed-off-by:
-
Briana Oursler authored
Remove comment that refers to function that no longer exists. Signed-off-by:
-
Briana Oursler authored
Remove multiple assignments at initialization and in computations to better match Linux style. Issue found by checkpatch.pl. Signed-off-by:
-
