1. 15 Jan, 2021 12 commits
  2. 12 Jan, 2021 8 commits
  3. 08 Jan, 2021 1 commit
    • Bernard Metzler's avatar
      RDMA/siw: Fix handling of zero-sized Read and Receive Queues. · 661f3859
      Bernard Metzler authored
      During connection setup, the application may choose to zero-size inbound
      and outbound READ queues, as well as the Receive queue.  This patch fixes
      handling of zero-sized queues, but not prevents it.
      
      Kamal Heib says in an initial error report:
      
       When running the blktests over siw the following shift-out-of-bounds is
       reported, this is happening because the passed IRD or ORD from the ulp
       could be zero which will lead to unexpected behavior when calling
       roundup_pow_of_two(), fix that by blocking zero values of ORD or IRD.
      
         UBSAN: shift-out-of-bounds in ./include/linux/log2.h:57:13
         shift exponent 64 is too large for 64-bit type 'long unsigned int'
         CPU: 20 PID: 3957 Comm: kworker/u64:13 Tainted: G S     5.10.0-rc6 #2
         Hardware name: Dell Inc. PowerEdge R630/02C2CP, BIOS 2.1.5 04/11/2016
         Workqueue: iw_cm_wq cm_work_handler [iw_cm]
         Call Trace:
          dump_stack+0x99/0xcb
          ubsan_epilogue+0x5/0x40
          __ubsan_handle_shift_out_of_bounds.cold.11+0xb4/0xf3
          ? down_write+0x183/0x3d0
          siw_qp_modify.cold.8+0x2d/0x32 [siw]
          ? __local_bh_enable_ip+0xa5/0xf0
          siw_accept+0x906/0x1b60 [siw]
          ? xa_load+0x147/0x1f0
          ? siw_connect+0x17a0/0x17a0 [siw]
          ? lock_downgrade+0x700/0x700
          ? siw_get_base_qp+0x1c2/0x340 [siw]
          ? _raw_spin_unlock_irqrestore+0x39/0x40
          iw_cm_accept+0x1f4/0x430 [iw_cm]
          rdma_accept+0x3fa/0xb10 [rdma_cm]
          ? check_flush_dependency+0x410/0x410
          ? cma_rep_recv+0x570/0x570 [rdma_cm]
          nvmet_rdma_queue_connect+0x1a62/0x2680 [nvmet_rdma]
          ? nvmet_rdma_alloc_cmds+0xce0/0xce0 [nvmet_rdma]
          ? lock_release+0x56e/0xcc0
          ? lock_downgrade+0x700/0x700
          ? lock_downgrade+0x700/0x700
          ? __xa_alloc_cyclic+0xef/0x350
          ? __xa_alloc+0x2d0/0x2d0
          ? rdma_restrack_add+0xbe/0x2c0 [ib_core]
          ? __ww_mutex_die+0x190/0x190
          cma_cm_event_handler+0xf2/0x500 [rdma_cm]
          iw_conn_req_handler+0x910/0xcb0 [rdma_cm]
          ? _raw_spin_unlock_irqrestore+0x39/0x40
          ? trace_hardirqs_on+0x1c/0x150
          ? cma_ib_handler+0x8a0/0x8a0 [rdma_cm]
          ? __kasan_kmalloc.constprop.7+0xc1/0xd0
          cm_work_handler+0x121c/0x17a0 [iw_cm]
          ? iw_cm_reject+0x190/0x190 [iw_cm]
          ? trace_hardirqs_on+0x1c/0x150
          process_one_work+0x8fb/0x16c0
          ? pwq_dec_nr_in_flight+0x320/0x320
          worker_thread+0x87/0xb40
          ? __kthread_parkme+0xd1/0x1a0
          ? process_one_work+0x16c0/0x16c0
          kthread+0x35f/0x430
          ? kthread_mod_delayed_work+0x180/0x180
          ret_from_fork+0x22/0x30
      
      Fixes: a5319752 ("rdma/siw: main include file")
      Fixes: f29dd55b ("rdma/siw: queue pair methods")
      Fixes: 8b6a361b ("rdma/siw: receive path")
      Fixes: b9be6f18 ("rdma/siw: transmit path")
      Fixes: 303ae1cd ("rdma/siw: application interface")
      Link: https://lore.kernel.org/r/20210108125845.1803-1-bmt@zurich.ibm.comReported-by: default avatarKamal Heib <kamalheib1@gmail.com>
      Reported-by: default avatarYi Zhang <yi.zhang@redhat.com>
      Reported-by: default avatarkernel test robot <lkp@intel.com>
      Signed-off-by: default avatarBernard Metzler <bmt@zurich.ibm.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
      661f3859
  4. 07 Jan, 2021 5 commits
  5. 03 Jan, 2021 1 commit
  6. 02 Jan, 2021 3 commits
    • Linus Torvalds's avatar
      Merge tag 's390-5.11-3' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux · 3516bd72
      Linus Torvalds authored
      Pull s390 cleanups from Vasily Gorbik:
       "Update defconfigs and sort config select list"
      
      * tag 's390-5.11-3' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux:
        s390/Kconfig: sort config S390 select list once again
        s390: update defconfigs
      3516bd72
    • Linus Torvalds's avatar
      Merge tag 'pm-5.11-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm · d9296a7b
      Linus Torvalds authored
      Pull power management fixes from Rafael Wysocki:
       "These fix a crash in intel_pstate during resume from suspend-to-RAM
        that may occur after recent changes and two resource leaks in error
        paths in the operating performance points (OPP) framework, add a new
        C-states table to intel_idle and update the cpuidle MAINTAINERS entry
        to cover the governors too.
      
        Specifics:
      
         - Fix recently introduced crash in the intel_pstate driver that
           occurs if scale-invariance is disabled during resume from
           suspend-to-RAM due to inconsistent changes of APERF or MPERF MSR
           values made by the platform firmware (Rafael Wysocki).
      
         - Fix a memory leak and add a missing clk_put() in error paths in the
           OPP framework (Quanyang Wang, Viresh Kumar).
      
         - Add new C-states table for SnowRidge processors to the intel_idle
           driver (Artem Bityutskiy).
      
         - Update the MAINTAINERS entry for cpuidle to make it clear that the
           governors are covered by it too (Lukas Bulwahn)"
      
      * tag 'pm-5.11-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
        intel_idle: add SnowRidge C-state table
        cpufreq: intel_pstate: Fix fast-switch fallback path
        opp: Call the missing clk_put() on error
        opp: fix memory leak in _allocate_opp_table
        MAINTAINERS: include governors into CPU IDLE TIME MANAGEMENT FRAMEWORK
      d9296a7b
    • Rafael J. Wysocki's avatar
      Merge branches 'pm-cpufreq' and 'pm-cpuidle' · 89ecf09e
      Rafael J. Wysocki authored
      * pm-cpufreq:
        cpufreq: intel_pstate: Fix fast-switch fallback path
      
      * pm-cpuidle:
        intel_idle: add SnowRidge C-state table
        MAINTAINERS: include governors into CPU IDLE TIME MANAGEMENT FRAMEWORK
      89ecf09e
  7. 01 Jan, 2021 4 commits
    • Linus Torvalds's avatar
      Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi · eda809ae
      Linus Torvalds authored
      Pull SCSI fixes from James Bottomley:
       "This is a load of driver fixes (12 ufs, 1 mpt3sas, 1 cxgbi).
      
        The big core two fixes are for power management ("block: Do not accept
        any requests while suspended" and "block: Fix a race in the runtime
        power management code") which finally sorts out the resume problems
        we've occasionally been having.
      
        To make the resume fix, there are seven necessary precursors which
        effectively renames REQ_PREEMPT to REQ_PM, so every "special" request
        in block is automatically a power management exempt one.
      
        All of the non-PM preempt cases are removed except for the one in the
        SCSI Parallel Interface (spi) domain validation which is a genuine
        case where we have to run requests at high priority to validate the
        bus so this becomes an autopm get/put protected request"
      
      * tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi: (22 commits)
        scsi: cxgb4i: Fix TLS dependency
        scsi: ufs: Un-inline ufshcd_vops_device_reset function
        scsi: ufs: Re-enable WriteBooster after device reset
        scsi: ufs-mediatek: Use correct path to fix compile error
        scsi: mpt3sas: Signedness bug in _base_get_diag_triggers()
        scsi: block: Do not accept any requests while suspended
        scsi: block: Remove RQF_PREEMPT and BLK_MQ_REQ_PREEMPT
        scsi: core: Only process PM requests if rpm_status != RPM_ACTIVE
        scsi: scsi_transport_spi: Set RQF_PM for domain validation commands
        scsi: ide: Mark power management requests with RQF_PM instead of RQF_PREEMPT
        scsi: ide: Do not set the RQF_PREEMPT flag for sense requests
        scsi: block: Introduce BLK_MQ_REQ_PM
        scsi: block: Fix a race in the runtime power management code
        scsi: ufs-pci: Enable UFSHCD_CAP_RPM_AUTOSUSPEND for Intel controllers
        scsi: ufs-pci: Fix recovery from hibernate exit errors for Intel controllers
        scsi: ufs-pci: Ensure UFS device is in PowerDown mode for suspend-to-disk ->poweroff()
        scsi: ufs-pci: Fix restore from S4 for Intel controllers
        scsi: ufs-mediatek: Keep VCC always-on for specific devices
        scsi: ufs: Allow regulators being always-on
        scsi: ufs: Clear UAC for RPMB after ufshcd resets
        ...
      eda809ae
    • Linus Torvalds's avatar
      Merge tag 'block-5.11-2021-01-01' of git://git.kernel.dk/linux-block · 8b4805c6
      Linus Torvalds authored
      Pull block fixes from Jens Axboe:
       "Two minor block fixes from this last week that should go into 5.11:
      
         - Add missing NOWAIT debugfs definition (Andres)
      
         - Fix kerneldoc warning introduced this merge window (Randy)"
      
      * tag 'block-5.11-2021-01-01' of git://git.kernel.dk/linux-block:
        block: add debugfs stanza for QUEUE_FLAG_NOWAIT
        fs: block_dev.c: fix kernel-doc warnings from struct block_device changes
      8b4805c6
    • Linus Torvalds's avatar
      Merge tag 'io_uring-5.11-2021-01-01' of git://git.kernel.dk/linux-block · dc3e24b2
      Linus Torvalds authored
      Pull io_uring fixes from Jens Axboe:
       "A few fixes that should go into 5.11, all marked for stable as well:
      
         - Fix issue around identity COW'ing and users that share a ring
           across processes
      
         - Fix a hang associated with unregistering fixed files (Pavel)
      
         - Move the 'process is exiting' cancelation a bit earlier, so
           task_works aren't affected by it (Pavel)"
      
      * tag 'io_uring-5.11-2021-01-01' of git://git.kernel.dk/linux-block:
        kernel/io_uring: cancel io_uring before task works
        io_uring: fix io_sqe_files_unregister() hangs
        io_uring: add a helper for setting a ref node
        io_uring: don't assume mm is constant across submits
      dc3e24b2
    • Linus Torvalds's avatar
      depmod: handle the case of /sbin/depmod without /sbin in PATH · cedd1862
      Linus Torvalds authored
      Commit 436e980e ("kbuild: don't hardcode depmod path") stopped
      hard-coding the path of depmod, but in the process caused trouble for
      distributions that had that /sbin location, but didn't have it in the
      PATH (generally because /sbin is limited to the super-user path).
      
      Work around it for now by just adding /sbin to the end of PATH in the
      depmod.sh script.
      Reported-and-tested-by: default avatarSedat Dilek <sedat.dilek@gmail.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      cedd1862
  8. 31 Dec, 2020 3 commits
  9. 30 Dec, 2020 3 commits
    • Linus Torvalds's avatar
      Merge tag 'ceph-for-5.11-rc2' of git://github.com/ceph/ceph-client · f6e1ea19
      Linus Torvalds authored
      Pull ceph fixes from Ilya Dryomov:
       "A fix for an edge case in MClientRequest encoding and a couple of
        trivial fixups for the new msgr2 support"
      
      * tag 'ceph-for-5.11-rc2' of git://github.com/ceph/ceph-client:
        libceph: add __maybe_unused to DEFINE_MSGR2_FEATURE
        libceph: align session_key and con_secret to 16 bytes
        libceph: fix auth_signature buffer allocation in secure mode
        ceph: reencode gid_list when reconnecting
      f6e1ea19
    • Artem Bityutskiy's avatar
      intel_idle: add SnowRidge C-state table · 9cf93f05
      Artem Bityutskiy authored
      Add C-state table for the SnowRidge SoC which is found on Intel Jacobsville
      platforms.
      
      The following has been changed.
      
       1. C1E latency changed from 10us to 15us. It was measured using the
          open source "wult" tool (the "nic" method, 15us is the 99.99th
          percentile).
      
       2. C1E power break even changed from 20us to 25us, which may result
          in less C1E residency in some workloads.
      
       3. C6 latency changed from 50us to 130us. Measured the same way as C1E.
      
      The C6 C-state is supported only by some SnowRidge revisions, so add a C-state
      table commentary about this.
      
      On SnowRidge, C6 support is enumerated via the usual mechanism: "mwait" leaf of
      the "cpuid" instruction. The 'intel_idle' driver does check this leaf, so even
      though C6 is present in the table, the driver will only use it if the CPU does
      support it.
      Signed-off-by: default avatarArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
      Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
      9cf93f05
    • Rafael J. Wysocki's avatar
      cpufreq: intel_pstate: Fix fast-switch fallback path · be128345
      Rafael J. Wysocki authored
      When sugov_update_single_perf() falls back to the "frequency"
      path due to the missing scale-invariance, it will call
      cpufreq_driver_fast_switch() via sugov_fast_switch()
      and the driver's ->fast_switch() callback will be invoked,
      so it must not be NULL.
      
      However, after commit a365ab6b ("cpufreq: intel_pstate: Implement
      the ->adjust_perf() callback") intel_pstate sets ->fast_switch() to
      NULL when it is going to use intel_cpufreq_adjust_perf(), which is a
      mistake, because on x86 the scale-invariance may be turned off
      dynamically, so modify it to retain the original ->adjust_perf()
      callback pointer.
      
      Fixes: a365ab6b ("cpufreq: intel_pstate: Implement the ->adjust_perf() callback")
      Reported-by: default avatarKenneth R. Crudup <kenny@panix.com>
      Tested-by: default avatarKenneth R. Crudup <kenny@panix.com>
      Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
      be128345