1. 12 Oct, 2018 4 commits
    • David Ahern's avatar
      net: Evict neighbor entries on carrier down · 859bd2ef
      David Ahern authored
      When a link's carrier goes down it could be a sign of the port changing
      networks. If the new network has overlapping addresses with the old one,
      then the kernel will continue trying to use neighbor entries established
      based on the old network until the entries finally age out - meaning a
      potentially long delay with communications not working.
      
      This patch evicts neighbor entries on carrier down with the exception of
      those marked permanent. Permanent entries are managed by userspace (either
      an admin or a routing daemon such as FRR).
      Signed-off-by: default avatarDavid Ahern <dsahern@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      859bd2ef
    • David Ahern's avatar
      net/ipv6: Add knob to skip DELROUTE message on device down · 7c6bb7d2
      David Ahern authored
      Another difference between IPv4 and IPv6 is the generation of RTM_DELROUTE
      notifications when a device is taken down (admin down) or deleted. IPv4
      does not generate a message for routes evicted by the down or delete;
      IPv6 does. A NOS at scale really needs to avoid these messages and have
      IPv4 and IPv6 behave similarly, relying on userspace to handle link
      notifications and evict the routes.
      
      At this point existing user behavior needs to be preserved. Since
      notifications are a global action (not per app) the only way to preserve
      existing behavior and allow the messages to be skipped is to add a new
      sysctl (net/ipv6/route/skip_notify_on_dev_down) which can be set to
      disable the notificatioons.
      
      IPv6 route code already supports the option to skip the message (it is
      used for multipath routes for example). Besides the new sysctl we need
      to pass the skip_notify setting through the generic fib6_clean and
      fib6_walk functions to fib6_clean_node and to set skip_notify on calls
      to __ip_del_rt for the addrconf_ifdown path.
      Signed-off-by: default avatarDavid Ahern <dsahern@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7c6bb7d2
    • YueHaibing's avatar
      net: fddi: skfp: Remove unused macros 'PNMI_GET_ID' and 'PNMI_SET_ID' · 7cc2d504
      YueHaibing authored
      The two PNMI macros are never used
      Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7cc2d504
    • YueHaibing's avatar
      net: cdc_ncm: remove set but not used variable 'ctx' · 1b8530bf
      YueHaibing authored
      Fixes gcc '-Wunused-but-set-variable' warning:
      
      drivers/net/usb/cdc_ncm.c: In function 'cdc_ncm_status':
      drivers/net/usb/cdc_ncm.c:1603:22: warning:
       variable 'ctx' set but not used [-Wunused-but-set-variable]
        struct cdc_ncm_ctx *ctx;
      
      It not used any more after
      commit fa83dbee ("net: cdc_ncm: remove redundant "disconnected" flag")
      Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1b8530bf
  2. 11 Oct, 2018 36 commits