1. 09 Feb, 2023 1 commit
    • Lucas De Marchi's avatar
      drm/i915: Fix GEN8_MISCCPCTL · 869bace7
      Lucas De Marchi authored
      Register 0x9424 is not replicated on any platform, so it shouldn't be
      declared with REG_MCR(). Declaring it with _MMIO() is basically
      duplicate of the GEN7 version, so just remove the GEN8 and change all
      the callers to use the right functions.
      
      Old versions of the gen8 bspec page used to contain a table with MCR
      registers, apparently implying 0x9400 - 0x94ff registers were
      replicated. However that table went away and there is no information
      related to the ranges for gen8 anymore. Moreover the current behavior of
      the driver wouldn't do anything special for 0x9424 since there is no
      equivalent table in intel_gt_mcr.c: the driver would just fallback to
      intel_uncore_{read,write}(). Therefore, do not care about the possible
      special case for gen8 and just use the register as non-MCR for all the
      platforms.
      
      One place doing read + write is also converted to intel_uncore_rmw().
      
      v2: Reword commit message adding the justification wrt gen8
      
      Fixes: a9e69428 ("drm/i915: Define MCR registers explicitly")
      Cc: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
      Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
      Cc: Gustavo Sousa <gustavo.sousa@intel.com>
      Cc: Matt Atwood <matthew.s.atwood@intel.com>
      Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
      Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
      Reviewed-by: default avatarMatt Roper <matthew.d.roper@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20230206165410.3056073-1-lucas.demarchi@intel.com
      869bace7
  2. 08 Feb, 2023 4 commits
  3. 07 Feb, 2023 2 commits
  4. 06 Feb, 2023 3 commits
  5. 03 Feb, 2023 1 commit
  6. 02 Feb, 2023 2 commits
  7. 01 Feb, 2023 1 commit
  8. 31 Jan, 2023 9 commits
  9. 30 Jan, 2023 1 commit
  10. 27 Jan, 2023 9 commits
  11. 26 Jan, 2023 4 commits
  12. 24 Jan, 2023 3 commits
    • Tvrtko Ursulin's avatar
      Merge drm/drm-next into drm-intel-gt-next · 9635adf8
      Tvrtko Ursulin authored
      Lets eradicate a silent conflict between drm-intel-next and
      drm-intel-gt-next which added a duplicate function (try_firmware_load).
      Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
      9635adf8
    • Daniel Vetter's avatar
      Merge tag 'drm-intel-gt-next-2023-01-18' of... · 045e8d10
      Daniel Vetter authored
      Merge tag 'drm-intel-gt-next-2023-01-18' of git://anongit.freedesktop.org/drm/drm-intel into drm-next
      
      Driver Changes:
      
      Fixes/improvements/new stuff:
      
      - Fix workarounds on Gen2-3 (Tvrtko Ursulin)
      - Fix HuC delayed load memory leaks (Daniele Ceraolo Spurio)
      - Fix a BUG caused by impendance mismatch in dma_fence_wait_timeout and GuC (Janusz Krzysztofik)
      - Add DG2 workarounds Wa_18018764978 and Wa_18019271663 (Matt Atwood)
      - Apply recommended L3 hashing mask tuning parameters (Gen12+) (Matt Roper)
      - Improve suspend / resume times with VT-d scanout workaround active (Andi Shyti, Chris Wilson)
      - Silence misleading "mailbox access failed" warning in snb_pcode_read (Ashutosh Dixit)
      - Fix null pointer dereference on HSW perf/OA (Umesh Nerlige Ramappa)
      - Avoid trampling the ring during buffer migration (and selftests) (Chris Wilson, Matthew Auld)
      - Fix DG2 visual corruption on small BAR systems by not forgetting to copy CCS aux state (Matthew Auld)
      - More fixing of DG2 visual corruption by not forgetting to copy CCS aux state of backup objects (Matthew Auld)
      - Fix TLB invalidation for Gen12.50 video and compute engines (Andrzej Hajda)
      - Limit Wa_22012654132 to just specific steppings (Matt Roper)
      - Fix userspace crashes due eviction not working under lock contention after the object locking conversion (Matthew Auld)
      - Avoid double free is user deploys a corrupt GuC firmware (John Harrison)
      - Fix 32-bit builds by using "%zu" to format size_t (Nirmoy Das)
      - Fix a possible BUG in TTM async unbind due not reserving enough fence slots (Nirmoy Das)
      - Fix potential use after free by not exposing the GEM context id to userspace too early (Rob Clark)
      - Show clamped PL1 limit to the user (hwmon) (Ashutosh Dixit)
      - Workaround unreliable reset on Jasperlake (Chris Wilson)
      - Cover rest of SVG unit MCR registers (Gustavo Sousa)
      - Avoid PXP log spam on platforms which do not support the feature (Alan Previn)
      - Re-disable RC6p on Sandy Bridge to avoid GPU hangs and visual glitches (Sasa Dragic)
      
      Future platform enablement:
      
      - Manage uncore->lock while waiting on MCR register (Matt Roper)
      - Enable Idle Messaging for GSC CS (Vinay Belgaumkar)
      - Only initialize GSC in tile 0 (José Roberto de Souza)
      - Media GT and Render GT share common GGTT (Aravind Iddamsetty)
      - Add dedicated MCR lock (Matt Roper)
      - Implement recommended caching policy (PVC) (Wayne Boyer)
      - Add hardware-level lock for steering (Matt Roper)
      - Check full IP version when applying hw steering semaphore (Matt Roper)
      - Enable GuC GGTT invalidation from the start (Daniele Ceraolo Spurio)
      - MTL GSC firmware support (Daniele Ceraolo Spurio, Jonathan Cavitt)
      - MTL OA support (Umesh Nerlige Ramappa)
      - MTL initial gt workarounds (Matt Roper)
      
      Driver refactors:
      
      - Hold forcewake and MCR lock over PPAT setup (Matt Roper)
      - Acquire fw before loop in intel_uncore_read64_2x32 (Umesh Nerlige Ramappa)
      - GuC filename cleanups and use submission API version number (John Harrison)
      - Promote pxp subsystem to top-level of i915 (Alan Previn)
      - Finish proofing the code agains object size overflows (Chris Wilson, Gwan-gyeong Mun)
      - Start adding module oriented dmesg output (John Harrison)
      
      Miscellaneous:
      
      - Correct kerneldoc for intel_gt_mcr_wait_for_reg() (Matt Roper)
      - Bump up sample period for busy stats selftest (Umesh Nerlige Ramappa)
      - Make GuC default_lists const data (Jani Nikula)
      - Fix table order verification to check all FW types (John Harrison)
      - Remove some limited use register access wrappers (Jani Nikula)
      - Remove struct_member macro (Andrzej Hajda)
      - Remove hardcoded value with a macro (Nirmoy Das)
      - Use helper func to find out map type (Nirmoy Das)
      - Fix a static analysis warning (John Harrison)
      - Consolidate VMA active tracking helpers (Andrzej Hajda)
      - Do not cover all future platforms in TLB invalidation (Tvrtko Ursulin)
      - Replace zero-length arrays with flexible-array members (Gustavo A. R. Silva)
      - Unwind hugepages to drop wakeref on error (Chris Wilson)
      - Remove a couple of superfluous i915_drm.h includes (Jani Nikula)
      
      Merges:
      
      - Merge drm/drm-next into drm-intel-gt-next (Rodrigo Vivi)
      
      danvet: Fix up merge conflict in intel_uc_fw.c, we ended up with 2
      copies of try_firmware_load() somehow.
      Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
      From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/Y8fW2Ny1B1hZ5ZmF@tursulin-desk
      045e8d10
    • Tvrtko Ursulin's avatar
      drm/i915: Use uabi engines for the default engine map · 1ec23ed7
      Tvrtko Ursulin authored
      Default engine map is exactly about uabi engines so no excuse not to use
      the appropriate iterator to populate it.
      Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
      Signed-off-by: default avatarJonathan Cavitt <jonathan.cavitt@intel.com>
      Reviewed-by: default avatarJonathan Cavitt <jonathan.cavitt@intel.com>
      [tursulin: Fixed up r-b tag spelling.]
      Link: https://patchwork.freedesktop.org/patch/msgid/20230123185629.1593320-1-jonathan.cavitt@intel.com
      1ec23ed7