- 23 Feb, 2011 40 commits
-
-
Christopher Brannon authored
The cur_item variable from keyhelp.c is an index into a table of messages. The following condition should always hold: MSG_FUNCNAMES_START + cur_item <= MSG_FUNCNAMES_END. The check in keyhelp.c was wrong. It allowed cur_item to be incremented to an out-of-bounds value. Signed-off-by:
Christopher Brannon <chris@the-brannons.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Marcin Slusarz authored
Commit 1bd751c1 ("Staging: et131x: Clean up rxdma_csr") changed csr from bitfield to u32, but failed to convert 2 uses of halt_status bit. It did: - if (csr.bits.halt_status != 1) + if ((csr & 0x00020000) != 1) which is wrong, because second version is always true. Fix it. This bug was found by coccinelle (http://coccinelle.lip6.fr/). Signed-off-by:
Marcin Slusarz <marcin.slusarz@gmail.com> Acked-by:
Alan Cox <alan@linux.intel.com> Signed-off-by:
-
Aaro Koskinen authored
pSR and pCR fields can be deleted with no changes in the functionality. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
-
Aaro Koskinen authored
Delete dead code for skipping the video memory sizing. Signed-off-by:
-
Javier Martinez Canillas authored
Due a cleanup in earlier patches, the function fbcon_XGI_sync now does nothing so it has to be removed. This patches removes the unused function. Signed-off-by:
Javier Martinez Canillas <martinez.javier@gmail.com> Acked-by:
Dan Carpenter <error27@gmail.com> Signed-off-by:
-
Javier Martinez Canillas authored
xgifb framebuffer driver had an option to use an accelerator engine that never got used (XGIfb_accel was always 0). An earlier patchset removed the code relevant to the accelerator. Since this spinlock was used only for that code, it can be deleted as well. Signed-off-by:
-
Javier Martinez Canillas authored
xgifb framebuffer driver has an option to use an accelerator engine that never get used (XGIfb_accel is always 0). An earlier patchset remove the code that depends on the accelerator being activated. This patch removes all the references to XGIfb_accel. Signed-off-by:
-
Javier Martinez Canillas authored
xgifb staging driver for XG20, XG21, XG40, XG42 frame buffer device has a accelerator engine that never get used (XGIfb_accel is always 0). Also the driver has a set of defines that hides the synchronization mechanism used to access critical sections and a way to disable spinlocks use at compile time. In a earlier patch all the code that depends on the accelerator being active was deleted because it was dead code. Since the only usage of this synchronization defines were in that dead code, this patch removes all the now unused spinlock conditional compilation logic. Signed-off-by:
-
Javier Martinez Canillas authored
Earlier patch removed code that never got executed because it depended on XGIfb_accel variable value to de distinct than 0. But this variable is always 0 in current driver. That dead code used a set of functions that not remains unused. This patch removes these unused functions. Signed-off-by:
-
Javier Martinez Canillas authored
xgifb staging driver has code that dependens on XGIfb_accel != 0. But as Dan Carpenter noticed, XGIfb_accel value is always 0 in current driver. So there is code that never gets executed. This patch removes this dead code. Signed-off-by:
-
Tomas Winkler authored
use USB_SUBCLASS_AUDIOSTREAMING constant from usb/audio.h instead of 0x02 Cc: Mike Thomas <rmthomas@sciolus.org> Cc: Dan Carpenter <error27@gmail.com> Signed-off-by:
Tomas Winkler <tomas.winkler@intel.com> Signed-off-by:
-
Tomas Winkler authored
Cc: Mike Thomas <rmthomas@sciolus.org> Signed-off-by:
-
Tomas Winkler authored
make inputset population to be more compact and readable Cc: Mike Thomas <rmthomas@sciolus.org> Signed-off-by:
-
Tomas Winkler authored
fix some code styles and drop too verbose printouts and non relevant code Cc: Mike Thomas <rmthomas@sciolus.org> Signed-off-by:
-
Greg Kroah-Hartman authored
This reverts commit f2f17948. It should not be putting code into the include/input/ directory, and lots of other people have complained about it. Cc: Tony SIM <chinyeow.sim.xt@renesas.com> Cc: Andrew Chew <achew@nvidia.com> Cc: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by:
-
Mike McCormack authored
Signed-off-by:
Mike McCormack <mikem@ring3k.org> Signed-off-by:
-
Mike McCormack authored
Signed-off-by:
-
Mike McCormack authored
Signed-off-by:
-
Mike McCormack authored
Signed-off-by:
-
Mike McCormack authored
Signed-off-by:
-
Mike McCormack authored
Signed-off-by:
-
Mike McCormack authored
Signed-off-by:
-
Roland Vossen authored
Increasing robustness of the code, although no problem has been reported in the field. Several code paths were unshielded for multi thread access. Several lock acquisitions have been added to wl_mac80211.c Signed-off-by:
Roland Vossen <rvossen@broadcom.com> Reviewed-by:
Arend van Spriel <arend@broadcom.com> Reviewed-by:
Brett Rudley <brudley@broadcom.com> Signed-off-by:
-
Roland Vossen authored
A spinlock was acquired prior to calling the Mac80211 functions ieee80211_wake_queues() and ieee80211_stop_queues() and Cfg80211 functions wiphy_rfkill_set_hw_state() and wiphy_rfkill_start_polling(). This is not required and could even lead to instability. Therefore the locks were removed. Signed-off-by:
-
Roland Vossen authored
Code cleanup. Added lock related comments to wl_mac80211.c. Also removed a redundant function definition. Signed-off-by:
-
Arend van Spriel authored
In the struct wlc_bsscfg a couple of attribute were held under a preprocessor definition, but these are not needed in the mac80211 driver context. Signed-off-by:
-
Arend van Spriel authored
When associated on 5G the driver receives a probe request for 2G with a 2G rate specified. The driver asserts as the operating band is still 5G when the probe request packet is given. Root cause was that ioctl function did fail upon setting the channel as requested by mac80211 when we are associated. Signed-off-by:
-
Stanislav Fomichev authored
- move ltoh16_buf/htol16_buf util/bcmsrom.c - replace ltoh16_buf in brcmsmac/wlc_mac80211.c with several le16_to_cpu's Signed-off-by:
Stanislav Fomichev <kernel@fomichev.me> Signed-off-by:
-
Stanislav Fomichev authored
htod32 -> cpu_to_le32 htod16 -> cpu_to_le16 dtoh32 -> le32_to_cpu dtoh16 -> le16_to_cpu For brcmfmac/dhd_common.c just removed defines. Signed-off-by:
-
Stanislav Fomichev authored
- BCMSWAP32 - bcmswap32 - BCMSWAP32BY16 - bcmswap32by16 Signed-off-by:
-
Stanislav Fomichev authored
htol16_ua_store -> put_unaligned_le16 htol32_ua_store -> put_unaligned_le32 hton16_ua_store -> put_unaligned_be16 hton32_ua_store -> put_unaligned_be32 ltoh16_ua -> get_unaligned_le16 ltoh32_ua -> get_unaligned_le32 ntoh16_ua -> get_unaligned_be16 ntoh32_ua -> get_unaligned_be32 removed unused: - load32_ua - load16_ua - store32_ua - store16_ua - ltoh_ua - ntoh_au Signed-off-by:
-
Stanislav Fomichev authored
HTON16/hton16 -> cpu_to_be16 (htons for networking code) HTON32/hton32 -> cpu_to_be32 (htonl for networking code) NTOH16/ntoh32 -> be16_to_cpu (ntohs for networking code) NTOH32/ntoh32 -> be32_to_cpu (ntohl for networking code) LTOH16/ltoh16 -> le16_to_cpu LTOH32/ltoh32 -> le32_to_cpu HTOL16/htol16 -> cpu_to_le16 HTOL32/htol32 -> cpu_to_le32 Signed-off-by:
-
Roland Vossen authored
With heavy transmit traffic, once in a while (range 15mins-1hr) a tx packet was added to a full transmit queue. Under certain conditions an other packet in the queue gets bumped to make room for the new packet. This is not considered an error condition, but normal operation. Despite that, there was an ASSERT(0) that caused the driver to oops. The ASSERT(0) has been removed. Driver was tested afterwards. Signed-off-by:
-
Nitin Gupta authored
Both zram and zcache use xvmalloc allocator. If xvmalloc is compiled separately for both of them, we will get linker error if they are both selected as "built-in". We can also get linker error regarding missing xvmalloc symbols if zram is not built. So, we now compile xvmalloc separately and export its symbols which are then used by both of zram and zcache. Signed-off-by:
Nitin Gupta <ngupta@vflare.org> Acked-by:
Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by:
-
Vipin Mehta authored
Cancel the pending scan operation once the interface is going down to avoid warnings from the cfg80211 module. Once the interface is down, cfg80211 checks for any pending scan requests and dumps a warning if it finds one. It expects the driver to abort any ongoing scan operation once the driver detects that the interface is going down. Signed-off-by:
Vipin Mehta <vmehta@atheros.com> Signed-off-by:
-
Dan Carpenter authored
We should check that optTxFrmCmd.optIEDataLen isn't too large before we copy it into the data buffer. Signed-off-by:
Vipin Mehta <vipin.mehta@atheros.com> Signed-off-by:
-
Dan Carpenter authored
The original code was written in a funny way where every statement was part of else if blocks. I broke them up into separate statements by adding breaks on failure conditions. Signed-off-by:
-
Luis R. Rodriguez authored
This updates the TODO file to reflect new changes on development. Cc: Joe Perches <joe@perches.com> Cc: Naveen Singh <nsingh@atheros.com> Signed-off-by:
Luis R. Rodriguez <lrodriguez@atheros.com> Signed-off-by:
-
Greg Kroah-Hartman authored
Lots of little ones all through the driver, mostly all in a cut-and-paste header comment. Cc: Alan Cox <alan@linux.intel.com> Signed-off-by: -
Greg Kroah-Hartman authored
The mod.c file should not be part of the repo. Cc: Alan Cox <alan@linux.intel.com> Signed-off-by:
-
