1. 18 Jan, 2024 22 commits
  2. 14 Jan, 2024 2 commits
  3. 12 Jan, 2024 14 commits
  4. 10 Jan, 2024 2 commits
    • Rahul Rameshbabu's avatar
      wifi: b43: Disable QoS for bcm4331 · 09795bde
      Rahul Rameshbabu authored
      bcm4331 seems to not function correctly with QoS support. This may be due
      to issues with currently available firmware or potentially a device
      specific issue.
      
      When queues that are not of the default "best effort" priority are
      selected, traffic appears to not transmit out of the hardware while no
      errors are returned. This behavior is present among all the other priority
      queues: video, voice, and background. While this can be worked around by
      setting a kernel parameter, the default behavior is problematic for most
      users and may be difficult to debug. This patch offers a working out-of-box
      experience for bcm4331 users.
      
      Log of the issue (using ssh low-priority traffic as an example):
          ssh -T -vvvv git@github.com
          OpenSSH_9.6p1, OpenSSL 3.0.12 24 Oct 2023
          debug1: Reading configuration data /etc/ssh/ssh_config
          debug2: checking match for 'host * exec "/nix/store/q1c2flcykgr4wwg5a6h450hxbk4ch589-bash-5.2-p15/bin/bash -c '/nix/store/c015armnkhr6v18za0rypm7sh1i8js8w-gnupg-2.4.1/bin/gpg-connect-agent --quiet updatestartuptty /bye >/dev/null 2>&1'"' host github.com originally github.com
          debug3: /etc/ssh/ssh_config line 5: matched 'host "github.com"'
          debug1: Executing command: '/nix/store/q1c2flcykgr4wwg5a6h450hxbk4ch589-bash-5.2-p15/bin/bash -c '/nix/store/c015armnkhr6v18za0rypm7sh1i8js8w-gnupg-2.4.1/bin/gpg-connect-agent --quiet updatestartuptty /bye >/dev/null 2>&1''
          debug3: command returned status 0
          debug3: /etc/ssh/ssh_config line 5: matched 'exec "/nix/store/q1c2flcykgr4wwg5a6h450hxbk4ch589-bash-5.2-p15/bin/bash -c '/nix/store/c015armnkhr6v18za0r"'
          debug2: match found
          debug1: /etc/ssh/ssh_config line 9: Applying options for *
          debug3: expanded UserKnownHostsFile '~/.ssh/known_hosts' -> '/home/binary-eater/.ssh/known_hosts'
          debug3: expanded UserKnownHostsFile '~/.ssh/known_hosts2' -> '/home/binary-eater/.ssh/known_hosts2'
          debug2: resolving "github.com" port 22
          debug3: resolve_host: lookup github.com:22
          debug3: channel_clear_timeouts: clearing
          debug3: ssh_connect_direct: entering
          debug1: Connecting to github.com [192.30.255.113] port 22.
          debug3: set_sock_tos: set socket 3 IP_TOS 0x48
      
      Fixes: e6f5b934 ("b43: Add QOS support")
      Signed-off-by: default avatarRahul Rameshbabu <sergeantsagara@protonmail.com>
      Reviewed-by: default avatarJulian Calaby <julian.calaby@gmail.com>
      Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
      Link: https://msgid.link/20231231050300.122806-5-sergeantsagara@protonmail.com
      09795bde
    • Rahul Rameshbabu's avatar
      wifi: b43: Stop correct queue in DMA worker when QoS is disabled · 581c8967
      Rahul Rameshbabu authored
      When QoS is disabled, the queue priority value will not map to the correct
      ieee80211 queue since there is only one queue. Stop queue 0 when QoS is
      disabled to prevent trying to stop a non-existent queue and failing to stop
      the actual queue instantiated.
      
      Fixes: bad69194 ("b43: avoid packet losses in the dma worker code.")
      Signed-off-by: default avatarRahul Rameshbabu <sergeantsagara@protonmail.com>
      Reviewed-by: default avatarJulian Calaby <julian.calaby@gmail.com>
      Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
      Link: https://msgid.link/20231231050300.122806-4-sergeantsagara@protonmail.com
      581c8967