1. 16 Apr, 2021 1 commit
    • Mihai Moldovan's avatar
      kconfig: nconf: stop endless search loops · 8c94b430
      Mihai Moldovan authored
      If the user selects the very first entry in a page and performs a
      search-up operation, or selects the very last entry in a page and
      performs a search-down operation that will not succeed (e.g., via
      [/]asdfzzz[Up Arrow]), nconf will never terminate searching the page.
      
      The reason is that in this case, the starting point will be set to -1
      or n, which is then translated into (n - 1) (i.e., the last entry of
      the page) or 0 (i.e., the first entry of the page) and finally the
      search begins. This continues to work fine until the index reaches 0 or
      (n - 1), at which point it will be decremented to -1 or incremented to
      n, but not checked against the starting point right away. Instead, it's
      wrapped around to the bottom or top again, after which the starting
      point check occurs... and naturally fails.
      
      My original implementation added another check for -1 before wrapping
      the running index variable around, but Masahiro Yamada pointed out that
      the actual issue is that the comparison point (starting point) exceeds
      bounds (i.e., the [0,n-1] interval) in the first place and that,
      instead, the starting point should be fixed.
      
      This has the welcome side-effect of also fixing the case where the
      starting point was n while searching down, which also lead to an
      infinite loop.
      
      OTOH, this code is now essentially all his work.
      
      Amazingly, nobody seems to have been hit by this for 11 years - or at
      the very least nobody bothered to debug and fix this.
      Signed-off-by: default avatarMihai Moldovan <ionic@ionic.de>
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      8c94b430
  2. 14 Apr, 2021 22 commits
  3. 25 Mar, 2021 6 commits
  4. 14 Mar, 2021 11 commits