1. 17 Apr, 2020 24 commits
    • Linus Torvalds's avatar
      Merge tag 'devicetree-fixes-for-5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux · 8fce9058
      Linus Torvalds authored
      Pull devicetree fixes from Rob Herring:
      
       - Fix warnings from enabling more dtc warnings which landed in the
         merge window and didn't get fixed in time.
      
       - Fix some document references from DT schema conversions
      
       - Fix kmemleak errors in DT unittests
      
      * tag 'devicetree-fixes-for-5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux: (23 commits)
        kbuild: check libyaml installation for 'make dt_binding_check'
        of: unittest: kmemleak in duplicate property update
        of: overlay: kmemleak in dup_and_fixup_symbol_prop()
        of: unittest: kmemleak in of_unittest_overlay_high_level()
        of: unittest: kmemleak in of_unittest_platform_populate()
        of: unittest: kmemleak on changeset destroy
        MAINTAINERS: dt: fix pointers for ARM Integrator, Versatile and RealView
        MAINTAINERS: dt: update display/allwinner file entry
        dt-bindings: iio: dac: AD5570R fix bindings errors
        dt-bindings: Fix misspellings of "Analog Devices"
        dt-bindings: pwm: Fix cros-ec-pwm example dtc 'reg' warning
        docs: dt: rockchip,dwc3.txt: fix a pointer to a renamed file
        docs: dt: fix a broken reference for a file converted to json
        docs: dt: qcom,dwc3.txt: fix cross-reference for a converted file
        docs: dt: fix broken reference to phy-cadence-torrent.yaml
        dt-bindings: interrupt-controller: Fix loongson,parent_int_map property schema
        dt-bindings: hwmon: Fix incorrect $id paths
        dt-bindings: Fix dtc warnings on reg and ranges in examples
        dt-bindings: BD718x7 - add missing I2C bus properties
        dt-bindings: clock: syscon-icst: Remove unneeded unit name
        ...
      8fce9058
    • Linus Torvalds's avatar
      Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux · 95988fbc
      Linus Torvalds authored
      Pull arm64 fixes from Catalin Marinas:
      
       - Remove vdso code trying to free unallocated pages.
      
       - Delete the space separator in the __emit_inst macro as it breaks the
         clang integrated assembler.
      
      * tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux:
        arm64: Delete the space separator in __emit_inst
        arm64: vdso: don't free unallocated pages
      95988fbc
    • Linus Torvalds's avatar
      Merge tag 'for-linus-5.7-rc2-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip · d0a4ebe7
      Linus Torvalds authored
      Pull xen update from Juergen Gross:
      
       - a small cleanup patch
      
       - a security fix for a bug in the Xen hypervisor to avoid enabling Xen
         guests to crash dom0 on an unfixed hypervisor.
      
      * tag 'for-linus-5.7-rc2-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip:
        arm/xen: make _xen_start_info static
        xen/xenbus: ensure xenbus_map_ring_valloc() returns proper grant status
      d0a4ebe7
    • Linus Torvalds's avatar
      Merge tag 'io_uring-5.7-2020-04-17' of git://git.kernel.dk/linux-block · a2286a44
      Linus Torvalds authored
      Pull io_uring fixes from Jens Axboe:
      
       - wrap up the init/setup cleanup (Pavel)
      
       - fix some issues around deferral sequences (Pavel)
      
       - fix splice punt check using the wrong struct file member
      
       - apply poll re-arm logic for pollable retry too
      
       - pollable retry should honor cancelation
      
       - fix setup time error handling syzbot reported crash
      
       - restore work state when poll is canceled
      
      * tag 'io_uring-5.7-2020-04-17' of git://git.kernel.dk/linux-block:
        io_uring: don't count rqs failed after current one
        io_uring: kill already cached timeout.seq_offset
        io_uring: fix cached_sq_head in io_timeout()
        io_uring: only post events in io_poll_remove_all() if we completed some
        io_uring: io_async_task_func() should check and honor cancelation
        io_uring: check for need to re-wait in polled async handling
        io_uring: correct O_NONBLOCK check for splice punt
        io_uring: restore req->work when canceling poll request
        io_uring: move all request init code in one place
        io_uring: keep all sqe->flags in req->flags
        io_uring: early submission req fail code
        io_uring: track mm through current->mm
        io_uring: remove obsolete @mm_fault
      a2286a44
    • Linus Torvalds's avatar
      Merge tag 'block-5.7-2020-04-17' of git://git.kernel.dk/linux-block · bf9196d5
      Linus Torvalds authored
      Pull block fixes from Jens Axboe:
      
       - Fix for a driver tag leak in error handling (John)
      
       - Remove now defunct Kconfig selection from dasd (Stefan)
      
       - blk-wbt trace fiexs (Tommi)
      
      * tag 'block-5.7-2020-04-17' of git://git.kernel.dk/linux-block:
        blk-wbt: Drop needless newlines from tracepoint format strings
        blk-wbt: Use tracepoint_string() for wbt_step tracepoint string literals
        s390/dasd: remove IOSCHED_DEADLINE from DASD Kconfig
        blk-mq: Put driver tag in blk_mq_dispatch_rq_list() when no budget
      bf9196d5
    • Linus Torvalds's avatar
      Merge tag 'libata-5.7-2020-04-17' of git://git.kernel.dk/linux-block · 2acbb9e6
      Linus Torvalds authored
      Pull libata fixlet from Jens Axboe:
       "Add yet another Comet Lake PCI ID for ahci"
      
      * tag 'libata-5.7-2020-04-17' of git://git.kernel.dk/linux-block:
        ahci: Add Intel Comet Lake PCH-U PCI ID
      2acbb9e6
    • Linus Torvalds's avatar
      Merge tag 'for-5.7-rc1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux · c5304dd5
      Linus Torvalds authored
      Pull btrfs fix from David Sterba:
       "A regression fix for a warning caused by running balance and snapshot
        creation in parallel"
      
      * tag 'for-5.7-rc1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux:
        btrfs: fix setting last_trans for reloc roots
      c5304dd5
    • Linus Torvalds's avatar
      Merge tag 'pm-5.7-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm · 5a32fe48
      Linus Torvalds authored
      Pull power management update from Rafael Wysocki:
       "Allow the operating performance points (OPP) core to be used in the
        case when the same driver is used on different platforms, some of
        which have an OPP table and some of which have a clock node (Rajendra
        Nayak)"
      
      * tag 'pm-5.7-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
        opp: Manage empty OPP tables with clk handle
      5a32fe48
    • Linus Torvalds's avatar
      Merge tag 'sound-5.7-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound · c8a6552f
      Linus Torvalds authored
      Pull sound fixes from Takashi Iwai:
       "One significant regression fix is for HD-audio buffer preallocation.
        In 5.6 it was set to non-prompt for x86 and forced to 0, but this
        turned out to be problematic for some applications, hence it gets
        reverted. Distros would need to restore CONFIG_SND_HDA_PREALLOC_SIZE
        value to the earlier values they've used in the past.
      
        Other than that, we've received quite a few small fixes for HD-audio
        and USB-audio. Most of them are for dealing with the broken TRX40
        mobos and the runtime PM without HD-audio codecs"
      
      * tag 'sound-5.7-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound:
        ALSA: hda: call runtime_allow() for all hda controllers
        ALSA: hda: Allow setting preallocation again for x86
        ALSA: hda: Explicitly permit using autosuspend if runtime PM is supported
        ALSA: hda: Skip controller resume if not needed
        ALSA: hda: Keep the controller initialization even if no codecs found
        ALSA: hda: Release resources at error in delayed probe
        ALSA: hda: Honor PM disablement in PM freeze and thaw_noirq ops
        ALSA: hda: Don't release card at firmware loading error
        ALSA: usb-audio: Check mapping at creating connector controls, too
        ALSA: usb-audio: Don't create jack controls for PCM terminals
        ALSA: usb-audio: Don't override ignore_ctl_error value from the map
        ALSA: usb-audio: Filter error from connector kctl ops, too
        ALSA: hda/realtek - Enable the headset mic on Asus FX505DT
        ALSA: ctxfi: Remove unnecessary cast in kfree
      c8a6552f
    • Masahiro Yamada's avatar
      kbuild: check libyaml installation for 'make dt_binding_check' · 0903060f
      Masahiro Yamada authored
      If you run 'make dtbs_check' without installing the libyaml package,
      the error message "dtc needs libyaml ..." is shown.
      
      This should be checked also for 'make dt_binding_check' because dtc
      needs to validate *.example.dts extracted from *.yaml files.
      
      It is missing since commit 4f0e3a57 ("kbuild: Add support for DT
      binding schema checks"), but this fix-up is applicable only after commit
      e10c4321 ("kbuild: allow to run dt_binding_check and dtbs_check
      in a single command").
      
      I gave the Fixes tag to the latter in case somebody is interested in
      back-porting this.
      
      Fixes: e10c4321 ("kbuild: allow to run dt_binding_check and dtbs_check in a single command")
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      0903060f
    • Tommi Rantala's avatar
      blk-wbt: Drop needless newlines from tracepoint format strings · 3f22037d
      Tommi Rantala authored
      Drop needless newlines from tracepoint format strings, they only add
      empty lines to perf tracing output.
      Signed-off-by: default avatarTommi Rantala <tommi.t.rantala@nokia.com>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      3f22037d
    • Tommi Rantala's avatar
      blk-wbt: Use tracepoint_string() for wbt_step tracepoint string literals · 3a89c25d
      Tommi Rantala authored
      Use tracepoint_string() for string literals that are used in the
      wbt_step tracepoint, so that userspace tools can display the string
      content.
      Signed-off-by: default avatarTommi Rantala <tommi.t.rantala@nokia.com>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      3a89c25d
    • Stefan Haberland's avatar
      s390/dasd: remove IOSCHED_DEADLINE from DASD Kconfig · 3dceecfa
      Stefan Haberland authored
      CONFIG_IOSCHED_DEADLINE was removed with
      commit f382fb0b ("block: remove legacy IO schedulers")
      
      and setting of the scheduler was removed with
      commit a5fd8ddc ("s390/dasd: remove setting of scheduler from driver").
      
      So get rid of the select.
      Reported-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
      Signed-off-by: default avatarStefan Haberland <sth@linux.ibm.com>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      3dceecfa
    • Frank Rowand's avatar
      of: unittest: kmemleak in duplicate property update · 29acfb65
      Frank Rowand authored
      kmemleak reports several memory leaks from devicetree unittest.
      This is the fix for problem 5 of 5.
      
      When overlay 'overlay_bad_add_dup_prop' is applied, the apply code
      properly detects that a memory leak will occur if the overlay is removed
      since the duplicate property is located in a base devicetree node and
      reports via printk():
      
        OF: overlay: WARNING: memory leak will occur if overlay removed, property: /testcase-data-2/substation@100/motor-1/rpm_avail
        OF: overlay: WARNING: memory leak will occur if overlay removed, property: /testcase-data-2/substation@100/motor-1/rpm_avail
      
      The overlay is removed when the apply code detects multiple changesets
      modifying the same property.  This is reported via printk():
      
        OF: overlay: ERROR: multiple fragments add, update, and/or delete property /testcase-data-2/substation@100/motor-1/rpm_avail
      
      As a result of this error, the overlay is removed resulting in the
      expected memory leak.
      
      Add another device node level to the overlay so that the duplicate
      property is located in a node added by the overlay, thus no memory
      leak will occur when the overlay is removed.
      
      Thus users of kmemleak will not have to debug this leak in the future.
      
      Fixes: 2fe0e876 ("of: overlay: check prevents multiple fragments touching same property")
      Reported-by: default avatarErhard F. <erhard_f@mailbox.org>
      Signed-off-by: default avatarFrank Rowand <frank.rowand@sony.com>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      29acfb65
    • Frank Rowand's avatar
      of: overlay: kmemleak in dup_and_fixup_symbol_prop() · 478ff649
      Frank Rowand authored
      kmemleak reports several memory leaks from devicetree unittest.
      This is the fix for problem 4 of 5.
      
      target_path was not freed in the non-error path.
      
      Fixes: e0a58f3e ("of: overlay: remove a dependency on device node full_name")
      Reported-by: default avatarErhard F. <erhard_f@mailbox.org>
      Signed-off-by: default avatarFrank Rowand <frank.rowand@sony.com>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      478ff649
    • Frank Rowand's avatar
      of: unittest: kmemleak in of_unittest_overlay_high_level() · 145fc138
      Frank Rowand authored
      kmemleak reports several memory leaks from devicetree unittest.
      This is the fix for problem 3 of 5.
      
      of_unittest_overlay_high_level() failed to kfree the newly created
      property when the property named 'name' is skipped.
      
      Fixes: 39a751a4 ("of: change overlay apply input data from unflattened to FDT")
      Reported-by: default avatarErhard F. <erhard_f@mailbox.org>
      Signed-off-by: default avatarFrank Rowand <frank.rowand@sony.com>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      145fc138
    • Frank Rowand's avatar
      of: unittest: kmemleak in of_unittest_platform_populate() · 216830d2
      Frank Rowand authored
      kmemleak reports several memory leaks from devicetree unittest.
      This is the fix for problem 2 of 5.
      
      of_unittest_platform_populate() left an elevated reference count for
      grandchild nodes (which are platform devices).  Fix the platform
      device reference counts so that the memory will be freed.
      
      Fixes: fb2caa50 ("of/selftest: add testcase for nodes with same name and address")
      Reported-by: default avatarErhard F. <erhard_f@mailbox.org>
      Signed-off-by: default avatarFrank Rowand <frank.rowand@sony.com>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      216830d2
    • Frank Rowand's avatar
      of: unittest: kmemleak on changeset destroy · b3fb36ed
      Frank Rowand authored
      kmemleak reports several memory leaks from devicetree unittest.
      This is the fix for problem 1 of 5.
      
      of_unittest_changeset() reaches deeply into the dynamic devicetree
      functions.  Several nodes were left with an elevated reference
      count and thus were not properly cleaned up.  Fix the reference
      counts so that the memory will be freed.
      
      Fixes: 201c910b ("of: Transactional DT support.")
      Reported-by: default avatarErhard F. <erhard_f@mailbox.org>
      Signed-off-by: default avatarFrank Rowand <frank.rowand@sony.com>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      b3fb36ed
    • Mauro Carvalho Chehab's avatar
      MAINTAINERS: dt: fix pointers for ARM Integrator, Versatile and RealView · 21a431e6
      Mauro Carvalho Chehab authored
      There's a conversion from a plain text binding file into 4 yaml ones.
      The old file got removed, causing this new warning:
      
      	Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/arm/arm-boards
      
      Address it by replacing the old reference by the new ones
      
      Fixes: 4b900070 ("dt-bindings: arm: Add Versatile YAML schema")
      Fixes: 2d483550 ("dt-bindings: arm: Drop the non-YAML bindings")
      Fixes: 7db625b9 ("dt-bindings: arm: Add RealView YAML schema")
      Fixes: 4fb00d90 ("dt-bindings: arm: Add Versatile Express and Juno YAML schema")
      Fixes: 33fbfb3e ("dt-bindings: arm: Add Integrator YAML schema")
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
      Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      21a431e6
    • Mauro Carvalho Chehab's avatar
      MAINTAINERS: dt: update display/allwinner file entry · f4d859b7
      Mauro Carvalho Chehab authored
      Changeset f5a98bfe ("dt-bindings: display: Convert Allwinner display pipeline to schemas")
      split Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
      into several files. Yet, it kept the old place at MAINTAINERS.
      
      Update it to point to the new place.
      
      Fixes: f5a98bfe ("dt-bindings: display: Convert Allwinner display pipeline to schemas")
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      f4d859b7
    • Alexandru Tachici's avatar
      dt-bindings: iio: dac: AD5570R fix bindings errors · 2cf3818f
      Alexandru Tachici authored
      Replaced num property with reg property, fixed errors
      reported by dt-binding-check.
      
      Fixes: ea52c212 ("dt-bindings: iio: dac: Add docs for AD5770R DAC")
      Signed-off-by: default avatarAlexandru Tachici <alexandru.tachici@analog.com>
      [robh: Fix required property list, fix Fixes tag]
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      2cf3818f
    • Josef Bacik's avatar
      btrfs: fix setting last_trans for reloc roots · aec7db3b
      Josef Bacik authored
      I made a mistake with my previous fix, I assumed that we didn't need to
      mess with the reloc roots once we were out of the part of relocation where
      we are actually moving the extents.
      
      The subtle thing that I missed is that btrfs_init_reloc_root() also
      updates the last_trans for the reloc root when we do
      btrfs_record_root_in_trans() for the corresponding fs_root.  I've added a
      comment to make sure future me doesn't make this mistake again.
      
      This showed up as a WARN_ON() in btrfs_copy_root() because our
      last_trans didn't == the current transid.  This could happen if we
      snapshotted a fs root with a reloc root after we set
      rc->create_reloc_tree = 0, but before we actually merge the reloc root.
      
      Worth mentioning that the regression produced the following warning
      when running snapshot creation and balance in parallel:
      
        BTRFS info (device sdc): relocating block group 30408704 flags metadata|dup
        ------------[ cut here ]------------
        WARNING: CPU: 0 PID: 12823 at fs/btrfs/ctree.c:191 btrfs_copy_root+0x26f/0x430 [btrfs]
        CPU: 0 PID: 12823 Comm: btrfs Tainted: G        W 5.6.0-rc7-btrfs-next-58 #1
        Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.0-59-gc9ba5276e321-prebuilt.qemu.org 04/01/2014
        RIP: 0010:btrfs_copy_root+0x26f/0x430 [btrfs]
        RSP: 0018:ffffb96e044279b8 EFLAGS: 00010202
        RAX: 0000000000000009 RBX: ffff9da70bf61000 RCX: ffffb96e04427a48
        RDX: ffff9da733a770c8 RSI: ffff9da70bf61000 RDI: ffff9da694163818
        RBP: ffff9da733a770c8 R08: fffffffffffffff8 R09: 0000000000000002
        R10: ffffb96e044279a0 R11: 0000000000000000 R12: ffff9da694163818
        R13: fffffffffffffff8 R14: ffff9da6d2512000 R15: ffff9da714cdac00
        FS:  00007fdeacf328c0(0000) GS:ffff9da735e00000(0000) knlGS:0000000000000000
        CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
        CR2: 000055a2a5b8a118 CR3: 00000001eed78002 CR4: 00000000003606f0
        DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
        DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
        Call Trace:
         ? create_reloc_root+0x49/0x2b0 [btrfs]
         ? kmem_cache_alloc_trace+0xe5/0x200
         create_reloc_root+0x8b/0x2b0 [btrfs]
         btrfs_reloc_post_snapshot+0x96/0x5b0 [btrfs]
         create_pending_snapshot+0x610/0x1010 [btrfs]
         create_pending_snapshots+0xa8/0xd0 [btrfs]
         btrfs_commit_transaction+0x4c7/0xc50 [btrfs]
         ? btrfs_mksubvol+0x3cd/0x560 [btrfs]
         btrfs_mksubvol+0x455/0x560 [btrfs]
         __btrfs_ioctl_snap_create+0x15f/0x190 [btrfs]
         btrfs_ioctl_snap_create_v2+0xa4/0xf0 [btrfs]
         ? mem_cgroup_commit_charge+0x6e/0x540
         btrfs_ioctl+0x12d8/0x3760 [btrfs]
         ? do_raw_spin_unlock+0x49/0xc0
         ? _raw_spin_unlock+0x29/0x40
         ? __handle_mm_fault+0x11b3/0x14b0
         ? ksys_ioctl+0x92/0xb0
         ksys_ioctl+0x92/0xb0
         ? trace_hardirqs_off_thunk+0x1a/0x1c
         __x64_sys_ioctl+0x16/0x20
         do_syscall_64+0x5c/0x280
         entry_SYSCALL_64_after_hwframe+0x49/0xbe
        RIP: 0033:0x7fdeabd3bdd7
      
      Fixes: 2abc726a ("btrfs: do not init a reloc root if we aren't relocating")
      Reviewed-by: default avatarFilipe Manana <fdmanana@suse.com>
      Signed-off-by: default avatarJosef Bacik <josef@toxicpanda.com>
      Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
      aec7db3b
    • Jason Yan's avatar
      arm/xen: make _xen_start_info static · 74f4c438
      Jason Yan authored
      Fix the following sparse warning:
      
      arch/arm64/xen/../../arm/xen/enlighten.c:39:19: warning: symbol
      '_xen_start_info' was not declared. Should it be static?
      Reported-by: default avatarHulk Robot <hulkci@huawei.com>
      Signed-off-by: default avatarJason Yan <yanaijie@huawei.com>
      Reviewed-by: default avatarStefano Stabellini <sstabellini@kernel.org>
      Link: https://lore.kernel.org/r/20200415084853.5808-1-yanaijie@huawei.comSigned-off-by: default avatarJuergen Gross <jgross@suse.com>
      74f4c438
    • Linus Torvalds's avatar
      Merge tag 'nfs-for-5.7-3' of git://git.linux-nfs.org/projects/trondmy/linux-nfs · 7a56db02
      Linus Torvalds authored
      Pull NFS client bugfix from Trond Myklebust:
       "Fix an ABBA spinlock issue in pnfs_update_layout()"
      
      * tag 'nfs-for-5.7-3' of git://git.linux-nfs.org/projects/trondmy/linux-nfs:
        NFS: Fix an ABBA spinlock issue in pnfs_update_layout()
      7a56db02
  2. 16 Apr, 2020 14 commits
  3. 15 Apr, 2020 2 commits
    • Tuong Lien's avatar
      tipc: fix incorrect increasing of link window · edadedf1
      Tuong Lien authored
      In commit 16ad3f40 ("tipc: introduce variable window congestion
      control"), we allow link window to change with the congestion avoidance
      algorithm. However, there is a bug that during the slow-start if packet
      retransmission occurs, the link will enter the fast-recovery phase, set
      its window to the 'ssthresh' which is never less than 300, so the link
      window suddenly increases to that limit instead of decreasing.
      
      Consequently, two issues have been observed:
      
      - For broadcast-link: it can leave a gap between the link queues that a
      new packet will be inserted and sent before the previous ones, i.e. not
      in-order.
      
      - For unicast: the algorithm does not work as expected, the link window
      jumps to the slow-start threshold whereas packet retransmission occurs.
      
      This commit fixes the issues by avoiding such the link window increase,
      but still decreasing if the 'ssthresh' is lowered.
      
      Fixes: 16ad3f40 ("tipc: introduce variable window congestion control")
      Acked-by: default avatarJon Maloy <jmaloy@redhat.com>
      Signed-off-by: default avatarTuong Lien <tuong.t.lien@dektech.com.au>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      edadedf1
    • Cambda Zhu's avatar
      Documentation: Fix tcp_challenge_ack_limit default value · 5309960e
      Cambda Zhu authored
      The default value of tcp_challenge_ack_limit has been changed from
      100 to 1000 and this patch fixes its documentation.
      Signed-off-by: default avatarCambda Zhu <cambda@linux.alibaba.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5309960e