- 14 Dec, 2017 40 commits
-
-
Yongqiang Sun authored
It may take over 200ms for wait hpd ready. To optimize the resume time, we can power on eDP in init_hw, wait for hpd ready when doing link training. also create separate eDP enable function to make sure eDP is powered up before doing and DPCD access, as HPD low will result in DPDC transaction failure. After optimization, setpowerstate 145ms -> 9.8ms, DPMS 387ms -> 18.9ms Signed-off-by:
Yongqiang Sun <yongqiang.sun@amd.com> Signed-off-by:
Tony Cheng <tony.cheng@amd.com> Reviewed-by:
Harry Wentland <harry.wentland@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Eric Yang authored
Signed-off-by:
Eric Yang <Eric.Yang2@amd.com> Reviewed-by:
Andrew Jiang <Andrew.Jiang@amd.com> Acked-by:
-
Eric Bernstein authored
Move OPP initialization of mpc tree parameters to hw_init function. Signed-off-by:
Eric Bernstein <eric.bernstein@amd.com> Reviewed-by:
-
Eric Bernstein authored
Use REG_UPDATE instead of REG_SET for programming MPC out mux. Signed-off-by:
-
Vitaly Prosyak authored
When convert from fixed31_32 to other fixed point format use math operation round instead of floor. Signed-off-by:
Vitaly Prosyak <vitaly.prosyak@amd.com> Reviewed-by:
Roman Li <Roman.Li@amd.com> Reviewed-by:
Krunoslav Kovac <Krunoslav.Kovac@amd.com> Acked-by:
-
Yue Hin Lau authored
Signed-off-by:
Yue Hin Lau <Yuehin.Lau@amd.com> Reviewed-by:
-
Vitaly Prosyak authored
Also handle fixpoint y values for CM curves Signed-off-by:
-
Yue Hin Lau authored
Signed-off-by:
-
Dmytro Laktyushkin authored
This reverts commit 978482d0de86 Revert noisy assert messages Signed-off-by:
Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com> Reviewed-by:
-
Dmytro Laktyushkin authored
Signed-off-by:
-
Dmytro Laktyushkin authored
Signed-off-by:
-
Harry Wentland authored
This has proven helpful on other OSes to give a quick state of the DC driver when a bug is reported. Signed-off-by:
-
Tony Cheng authored
REG_UPDATE_2 return the reg value it write out through MMIO we need to do a REG_READ to confirm the value is written out Signed-off-by:
-
Harry Wentland authored
This code can sometimes look troubling but we trust it as it comes from HW teams with a guarantee of correctness. Add a note to these files to explain this. v2: thing -> things Signed-off-by:
-
Harry Wentland authored
In code provided by HW teams we do a NaN check on floats by comparing the number against itself. This confuses most people including myself. Macro it out to make it self-explanatory. Don't do a NaN check for int. v2: parantheses around 'number' expression Signed-off-by:
-
Tony Cheng authored
Signed-off-by:
-
Tony Cheng authored
This prevents an issue where the MPCC will not go to idle due to us not waiting for it to become idle during disable plane. Signed-off-by:
-
Andrew Jiang authored
- Only update DPP clock if it's a full update. - Program viewport on position change. This caused SLS regressions. Signed-off-by:
-
Yongqiang Sun authored
When programming cursor position after front end programmed, if position is already set previously, it doesn't make sense to program position with all 0. Cache position and use the parameter after front end programming. Signed-off-by:
-
Yongqiang Sun authored
Cursor is abnormal after pipe_ctx is changed in context. Cause: cursor attributes is programmed right after front end programming, but it use old pipe_ctx to program which is not updated yet. Solution: Program cursor regs after context swapped. Signed-off-by:
-
Yongqiang Sun authored
Fixed fliped landscape and fliped portrait hard hang. Signed-off-by:
-
Eric Murphy-Zaremba authored
Signed-off-by:
Eric Murphy-Zaremba <Eric.Murphy-zaremba@amd.com> Reviewed-by:
Aric Cyr <Aric.Cyr@amd.com> Acked-by:
-
Eric Bernstein authored
Create opp_set_test_pattern function with similar interface and implementation as timing generator test pattern. Signed-off-by:
-
Vitaly Prosyak authored
Add color module to diagnostic compilation Signed-off-by:
Charlene Liu <Charlene.Liu@amd.com> Acked-by:
-
Eric Bernstein authored
During HW initialization, instead of assuming or detecting the existing MPCC mux configuration and then removing existing planes, reset all the MPCC muxes. Signed-off-by:
-
Yue Hin Lau authored
Signed-off-by:
-
Yongqiang Sun authored
HDR display playing video underflow is observed when switching to full screen due to program a lower watermark right after unlock otg. Instead of disable plane in next flip coming, if there is a plane disconnected, after otg unlock wait for mpcc idle and disable the plane, then program watermark. So there is enough warter mark to make sure current frame data pass through. Signed-off-by:
-
Tony Cheng authored
Signed-off-by:
-
Harry Wentland authored
Signed-off-by:
-
Harry Wentland authored
Found by smatch: drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:357 convert_to_custom_float() error: buffer overflow 'arr_points' 2 <= 2 drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:358 convert_to_custom_float() warn: buffer overflow 'arr_points' 2 <= 2 Regression: drm/amd/display: Remove extra arr_points element Signed-off-by:
-
Tony Cheng authored
Signed-off-by:
-
Andrew Jiang authored
Program the DCC registers when dcc_change is true. Signed-off-by:
-
Yongqiang Sun authored
Work around for a hw bug causing optc underflow if blank data double buffer disable and remove mpcc. Checking optc status after otg unlock, after wait mpcc idle check status again, if optc underflow just happens after wait mpcc idle, clear underflow status and enable blank data double buffer. Signed-off-by:
-
Andrew Jiang authored
Rather than setting it every time there's a full update with surface count > 0, set it when we need to do plane_atomic_disconnect. Also make sure that we unset the flag in plane_atomic_disable, so that in the event we run through a sequence where we do disconnect followed by an immediate disable, we do not do unnecessarily request a passive flip to do the optimization. Signed-off-by:
-
Harry Wentland authored
Signed-off-by:
Leo (Sunpeng) Li <sunpeng.li@amd.com> Signed-off-by:
-
Yongqiang Sun authored
There is already wait mpcc idle function. It is better to use the same function for all wait mpcc idle. Signed-off-by:
-
Eric Bernstein authored
Fix update_mpcc logic to only call assert_mpcc_idle_before_connect if mpcc is not already being used (and required removal). Update set_out_rate_control to include optional flow control parameter. In init_mpcc_from_hw check for case where bot_sel is same as mpcc_id. Signed-off-by:
-
Yongqiang Sun authored
Signed-off-by:
-
Harry Wentland authored
Found by smatch: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:506 construct() warn: possible memory leak of 'dc_ctx' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:506 construct() warn: possible memory leak of 'dc_vbios' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:506 construct() warn: possible memory leak of 'dcn_ip' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:506 construct() warn: possible memory leak of 'dcn_soc' Signed-off-by:
-
Harry Wentland authored
pipe_ctx->stream and pipe_ctx->plane_state are never NULL Found by smatch: drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2111 set_default_colors() error: we previously assumed 'pipe_ctx->stream' could be null (see line 2101) Signed-off-by:
-
