- 13 Apr, 2020 40 commits
-
-
Jérôme Pouiller authored
link_id was expected to contain identifier of a station. It was also used to mark frames that has to sent after dtim. We do not use the further purpose. For the last purpose, we can directly check the flag value in tx_info. Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Jérôme Pouiller <jerome.pouiller@silabs.com> Link: https://lore.kernel.org/r/20200401110405.80282-17-Jerome.Pouiller@silabs.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Jérôme Pouiller authored
Driver does not use link_map_cache anymore. So we can drop it. In add, we do not have to keep this counter in sync with skb_queue item, so we can drop explicit spin_locks. Reviewed-by:
-
Jérôme Pouiller authored
Since we do not track power save status of the stations anymore, link_map_cache is now only used to track "Content After (DTIM) Beacon". We prefer to rely on flags from tx_info. So we will be able to drop link_map_cache. Reviewed-by:
-
Jérôme Pouiller authored
Following the remove of asleep_mask, the tx_allowed_mask argument passed to various functions is now always the same. Drop this argument and simplify the code. Reviewed-by:
-
Jérôme Pouiller authored
Currently, the driver tracks power save state of the stations with the variable sta_asleep_mask. Then, it takes care to not sent data to asleep stations. However, this work is already done by mac80211. Normally, there are no frames for asleep stations in our queues. So, driver do not have to filter frames in its queues (apart the frames marked "AFTER_DTIM"). Notice that there is a risk of race between state of the station and data send to the firmware. However, this risk is limited since the number of frame in queues are small. In add, this race also exists with the current code. Anyway, the firmware is able to detect the problem and driver will receive a 'REQUEUE' status (translated in TX_STAT_TX_FILTERED for mac80211). Reviewed-by:
-
Jérôme Pouiller authored
It is far simpler to return a pointer instead of an error. Thus, it is no more necessary to pass a pointer reference as argument. Reviewed-by:
-
Jérôme Pouiller authored
The argument "total" is not used anymore since commit a3c529a8 ("staging: wfx: simplify handling of IEEE80211_TX_CTL_SEND_AFTER_DTIM"). Fixes: a3c529a8 ("staging: wfx: simplify handling of IEEE80211_TX_CTL_SEND_AFTER_DTIM") Reviewed-by:
-
Jérôme Pouiller authored
Thanks to skb_queue_empty_lockless(), it is not necessary to acquire the spin_lock before to check if the queue is empty. Reviewed-by:
-
Jérôme Pouiller authored
The last argument of hif_handle_tx_data() was now unused. In add, hif_handle_tx_data() has nothing to do with HIF layer and should be renamed. Finally, it not convenient to pass a wfx_vif as parameter. It is easier to let hif_handle_tx_data() find the interface itself. Reviewed-by:
-
Jérôme Pouiller authored
__wfx_flush() wait for all queues to be empty. In current code, wait_link_id_empty is wake up each time there is no more data for a station. We can simplify the processing and avoid some wake-up by raising this event only when the queue is empty. Reviewed-by:
-
Jérôme Pouiller authored
The field queue_id is no more used. Reviewed-by:
-
Jérôme Pouiller authored
tx_info->hw_queue contains "vif.hw_queue[skb_get_queue_mapping(skb)]". For now, it is equivalent of "skb_get_queue_mapping(skb)". However, it is not the same semantic. In wfx_tx_inner(), we want to get the mac80211 queue index, not the hardware queue index. Reviewed-by:
-
Jérôme Pouiller authored
In the old days, the driver tried to reorder frames in order to send frames from the same queue grouped to the firmware. However, the firmware is able to do the job internally for a long time. There is no reasons to keep this mechanism. Reviewed-by:
-
Jérôme Pouiller authored
Instead of maintaining stop status for each queue, we can just maintain a global status for all queues. In add, wfx_tx_queues_{lock/unlock} are only used when no more tx_policies are available. Therefore, the counter of recursive locks ("tx_locked_cnt") is useless. So, wfx_tx_queues_{lock/unlock} can be replaced by ieee80211_{stop/start}_queues. Reviewed-by: -
Jérôme Pouiller authored
When a new tx_policy has to be uploaded, it is necessary to avoid any race between the frame and the policy. So, the driver stops the tx queue during tx_policy upload. However, it is not necessary to stop mac80211 queuing. Reviewed-by:
-
Jérôme Pouiller authored
Add a few check on start of hif_join(). Reviewed-by:
-
Soumyajit Deb authored
Break various lines into multiple lines to respect 80 character width limit. Reported by checkpatch.pl Signed-off-by:
Soumyajit Deb <debsoumyajit100@gmail.com> Link: https://lore.kernel.org/r/20200406111706.25957-4-debsoumyajit100@gmail.comSigned-off-by:
-
Soumyajit Deb authored
Remove unnecessary extra parentheses to improve code readability. Signed-off-by:
-
Soumyajit Deb authored
Add "*" at the start of each line of the multiline comment to improve code readability and to adhere to the uniform Kernel coding style. Reported by checkpatch.pl Signed-off-by:
-
Michael Straube authored
The variable 'bStopBlinking' is used in if tests immediately after its value is set. Use the conditions for setting 'bStopBlinking' diretly in the subsequent if tests and remove the variable. Slightly reduces object file size by 16 bytes (gcc 9.2.1 x86_64). Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20200405112230.31975-2-straube.linux@gmail.comSigned-off-by:
-
Michael Straube authored
Remove unnecessary asignment in SwLedBlink1(). The code path with the asignment 'pLed->BlinkTimes = 0' is only executed when 'pLed->BlinkTimes' is already zero and the value is not changed between the test 'if (pLed->BlinkTimes == 0)' and the asignment. Signed-off-by:
-
R Veera Kumar authored
Correct a typo in comment. Misspelling found using checkpatch.pl. Signed-off-by:
R Veera Kumar <vkor@vkten.in> Link: https://lore.kernel.org/r/20200405175722.8188-1-vkor@vkten.inSigned-off-by:
-
R Veera Kumar authored
Correct misspelt variable name. Misspelling found using checkpatch.pl. Signed-off-by:
-
Colin Ian King authored
The pointer 'w' is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by:Colin Ian King <colin.king@canonical.com> Link: https://lore.kernel.org/r/20200405130619.377043-1-colin.king@canonical.comSigned-off-by:
-
Briana Oursler authored
Replace camel case variable names with snake case in baseband.h and its dependencies. Signed-off-by:
Briana Oursler <briana.oursler@gmail.com> Reviewed-by:
Stefano Brivio <sbrivio@redhat.com> Link: https://lore.kernel.org/r/20200403171805.466600-1-briana.oursler@gmail.comSigned-off-by:
-
Stefan Wahren authored
We can reduce the indentation in the loop by using continue in case the effect doesn't match. Reviewed-by:
Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Signed-off-by:
Stefan Wahren <stefan.wahren@i2se.com> Link: https://lore.kernel.org/r/1585485901-10172-10-git-send-email-stefan.wahren@i2se.comSigned-off-by:
-
Stefan Wahren authored
There are a lot of multiline statements which can be reduced. Reviewed-by:
-
Stefan Wahren authored
We can reduce the indentation in mmal_setup_components further by returning early in error case. Reviewed-by:
-
Stefan Wahren authored
The function mmal_setup_components has to many indention levels. So move the setup code for video component in its own function. Reviewed-by:
-
Stefan Wahren authored
The function mmal_setup_components has to many indention levels. So move the setup code for encode component in its own function. Reviewed-by:
-
Stefan Wahren authored
This simplifies set_framerate_params and avoids the multiple assignment in one line by moving the fps_high handling out of the if statement. Reviewed-by:
-
Stefan Wahren authored
The indentation of struct members wasn't consistent over the whole driver. Reviewed-by:
-
Stefan Wahren authored
I don't see any reason to keep this TODO, so activate the V4L2_EXPOSURE_METERING_MATRIX handling. Reviewed-by:
-
Stefan Wahren authored
This define is used only once. So drop the define and init the layer directly. Reviewed-by:
-
John B. Wyatt IV authored
Fix 2 parenthesis alignment issues. Reported by checkpatch. Signed-off-by:
John B. Wyatt IV <jbwyatt4@gmail.com> Link: https://lore.kernel.org/r/20200402023310.816245-1-jbwyatt4@gmail.comSigned-off-by:
-
John B. Wyatt IV authored
Fix 2 parenthesis alignment issues. Reported by checkpatch. Signed-off-by:
-
Aiman Najjar authored
This patch fixes remaining checkpatch warnings in rtl871x_xmit.c: WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->PrivacyKeyIndex' 636: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:636: + (u8)psecuritypriv-> + PrivacyKeyIndex); WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->XGrpKeyid' 643: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:643: + (u8)psecuritypriv-> + XGrpKeyid); WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->XGrpKeyid' 652: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:652: + (u8)psecuritypriv-> + XGrpKeyid); Signed-off-by:
Aiman Najjar <aiman.najjar@hurranet.com> Reviewed-by:
-
Aiman Najjar authored
1. Refactor make_wlanhdr to improve code style. 2. Use ether_addr_copy instead of memcpy to copy addresses. Suggested-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Aiman Najjar authored
This patch fixes multiline dereference warnings in rtl871x_xmit.c: WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->XGrptxmickey' 379: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:379: + psecuritypriv-> + XGrptxmickey[psecuritypriv-> WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->XGrpKeyid' 380: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:380: + XGrptxmickey[psecuritypriv-> + XGrpKeyid].skey); Signed-off-by:
-
Aiman Najjar authored
This patch fixes the following warning in rtl871x_xmit.c: WARNING: line over 80 characters 130: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:130: + pxmitbuf->pallocated_buf = kmalloc(MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ, Signed-off-by:
-
