1. 31 Oct, 2013 17 commits
  2. 21 Sep, 2013 16 commits
  3. 17 Sep, 2013 2 commits
    • Russell King's avatar
      DMA-API: net: brocade/bna/bnad.c: fix 32-bit DMA mask handling · 3e548079
      Russell King authored
      The fallback to 32-bit DMA mask is rather odd:
      	if (!dma_set_mask(&pdev->dev, DMA_BIT_MASK(64)) &&
      	    !dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64))) {
      		*using_dac = true;
      	} else {
      		err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
      		if (err) {
      			err = dma_set_coherent_mask(&pdev->dev,
      						    DMA_BIT_MASK(32));
      			if (err)
      				goto release_regions;
      		}
      
      This means we only try and set the coherent DMA mask if we failed to
      set a 32-bit DMA mask, and only if both fail do we fail the driver.
      Adjust this so that if either setting fails, we fail the driver - and
      thereby end up properly setting both the DMA mask and the coherent
      DMA mask in the fallback case.
      Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
      3e548079
    • Russell King's avatar
      DMA-API: provide a helper to set both DMA and coherent DMA masks · 4aa806b7
      Russell King authored
      Provide a helper to set both the DMA and coherent DMA masks to the
      same value - this avoids duplicated code in a number of drivers,
      sometimes with buggy error handling, and also allows us identify
      which drivers do things differently.
      Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
      4aa806b7
  4. 16 Sep, 2013 5 commits