1. 08 May, 2020 2 commits
    • Vladimir Oltean's avatar
      net: dsa: sja1105: add static tables for virtual links · 94f94d4a
      Vladimir Oltean authored
      This patch adds the register definitions for the:
      - VL Lookup Table
      - VL Policing Table
      - VL Forwarding Table
      - VL Forwarding Parameters Table
      
      These are needed in order to perform TTEthernet operations: QoS
      classification, flow-based policing and/or frame redirecting with the
      switch.
      Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      94f94d4a
    • Vladimir Oltean's avatar
      net: dsa: introduce a dsa_port_from_netdev public helper · e1eea811
      Vladimir Oltean authored
      As its implementation shows, this is synonimous with calling
      dsa_slave_dev_check followed by dsa_slave_to_port, so it is quite simple
      already and provides functionality which is already there.
      
      However there is now a need for these functions outside dsa_priv.h, for
      example in drivers that perform mirroring and redirection through
      tc-flower offloads (they are given raw access to the flow_cls_offload
      structure), where they need to call this function on act->dev.
      
      But simply exporting dsa_slave_to_port would make it non-inline and
      would result in an extra function call in the hotpath, as can be seen
      for example in sja1105:
      
      Before:
      
      000006dc <sja1105_xmit>:
      {
       6dc:	e92d4ff0 	push	{r4, r5, r6, r7, r8, r9, sl, fp, lr}
       6e0:	e1a04000 	mov	r4, r0
       6e4:	e591958c 	ldr	r9, [r1, #1420]	; 0x58c <- Inline dsa_slave_to_port
       6e8:	e1a05001 	mov	r5, r1
       6ec:	e24dd004 	sub	sp, sp, #4
      	u16 tx_vid = dsa_8021q_tx_vid(dp->ds, dp->index);
       6f0:	e1c901d8 	ldrd	r0, [r9, #24]
       6f4:	ebfffffe 	bl	0 <dsa_8021q_tx_vid>
      			6f4: R_ARM_CALL	dsa_8021q_tx_vid
      	u8 pcp = netdev_txq_to_tc(netdev, queue_mapping);
       6f8:	e1d416b0 	ldrh	r1, [r4, #96]	; 0x60
      	u16 tx_vid = dsa_8021q_tx_vid(dp->ds, dp->index);
       6fc:	e1a08000 	mov	r8, r0
      
      After:
      
      000006e4 <sja1105_xmit>:
      {
       6e4:	e92d4ff0 	push	{r4, r5, r6, r7, r8, r9, sl, fp, lr}
       6e8:	e1a04000 	mov	r4, r0
       6ec:	e24dd004 	sub	sp, sp, #4
      	struct dsa_port *dp = dsa_slave_to_port(netdev);
       6f0:	e1a00001 	mov	r0, r1
      {
       6f4:	e1a05001 	mov	r5, r1
      	struct dsa_port *dp = dsa_slave_to_port(netdev);
       6f8:	ebfffffe 	bl	0 <dsa_slave_to_port>
      			6f8: R_ARM_CALL	dsa_slave_to_port
       6fc:	e1a09000 	mov	r9, r0
      	u16 tx_vid = dsa_8021q_tx_vid(dp->ds, dp->index);
       700:	e1c001d8 	ldrd	r0, [r0, #24]
       704:	ebfffffe 	bl	0 <dsa_8021q_tx_vid>
      			704: R_ARM_CALL	dsa_8021q_tx_vid
      
      Because we want to avoid possible performance regressions, introduce
      this new function which is designed to be public.
      Suggested-by: default avatarVivien Didelot <vivien.didelot@gmail.com>
      Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
      Reviewed-by: default avatarVivien Didelot <vivien.didelot@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e1eea811
  2. 07 May, 2020 38 commits
    • Chen Zhou's avatar
      cxgb4: remove duplicate headers · bb206a08
      Chen Zhou authored
      Remove duplicate headers which are included twice.
      Signed-off-by: default avatarChen Zhou <chenzhou10@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      bb206a08
    • David S. Miller's avatar
      Merge tag 'wireless-drivers-next-2020-05-07' of... · 5d9e4722
      David S. Miller authored
      Merge tag 'wireless-drivers-next-2020-05-07' of git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next
      
      Kalle Valo says:
      
      ====================
      wireless-drivers-next patches for v5.8
      
      First set of patches for v5.8. Changes all over, ath10k apparently
      seeing most new features this time. rtw88 also had lots of changes due
      to preparation for new hardware support.
      
      In this pull request there's also a new macro to include/linux/iopoll:
      read_poll_timeout_atomic(). This is needed by rtw88 for atomic
      polling.
      
      Major changes:
      
      ath11k
      
      * add debugfs file for testing ADDBA and DELBA
      
      * add 802.11 encapsulation offload on hardware support
      
      * add htt_peer_stats_reset debugfs file
      
      ath10k
      
      * enable VHT160 and VHT80+80 modes
      
      * enable radar detection in secondary segment
      
      * sdio: disable TX complete indication to improve throughput
      
      * sdio: decrease power consumption
      
      * sdio: add HTT TX bundle support to increase throughput
      
      * sdio: add rx bitrate reporting
      
      ath9k
      
      * improvements to AR9002 calibration logic
      
      carl9170
      
      * remove buggy P2P_GO support
      
      p54usb
      
      * add support for AirVasT USB stick
      
      rtw88
      
      * add support for antenna configuration
      
      ti wlcore
      
      * add support for AES_CMAC cipher
      
      iwlwifi
      
      * support for a few new FW API versions
      
      * new hw configs
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5d9e4722
    • David S. Miller's avatar
      Merge branch 'Add-QRTR-MHI-client-driver' · 3031a86e
      David S. Miller authored
      Manivannan Sadhasivam says:
      
      ====================
      Add QRTR MHI client driver
      
      Here is the series adding MHI client driver support to Qualcomm IPC router
      protocol. MHI is a newly added bus to kernel which is used to communicate to
      external modems over a physical interface like PCI-E. This driver is used to
      transfer the QMI messages between the host processor and external modems over
      the "IPCR" channel.
      
      For QRTR, this driver is just another driver acting as a transport layer like
      SMD.
      
      Currently this driver is needed to control the QCA6390 WLAN device from ath11k.
      The ath11k MHI controller driver will take care of booting up QCA6390 and
      bringing it to operating state. Later, this driver will be used to transfer QMI
      messages over the MHI-IPCR channel.
      
      The second patch of this series removes the ARCH_QCOM dependency for QRTR. This
      is needed because the QRTR driver will be used with x86 machines as well to talk
      to devices like QCA6390.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      3031a86e
    • Manivannan Sadhasivam's avatar
      net: qrtr: Do not depend on ARCH_QCOM · e4267108
      Manivannan Sadhasivam authored
      IPC Router protocol is also used by external modems for exchanging the QMI
      messages. Hence, it doesn't always depend on Qualcomm platforms. One such
      instance is the QCA6390 WLAN device connected to x86 machine.
      Reviewed-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
      Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e4267108
    • Manivannan Sadhasivam's avatar
      net: qrtr: Add MHI transport layer · 6e728f32
      Manivannan Sadhasivam authored
      MHI is the transport layer used for communicating to the external modems.
      Hence, this commit adds MHI transport layer support to QRTR for
      transferring the QMI messages over IPC Router.
      Reviewed-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
      Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6e728f32
    • Geert Uytterhoeven's avatar
      via-rhine: Add platform dependencies · 0932969e
      Geert Uytterhoeven authored
      The VIA Rhine Ethernet interface is only present on PCI devices or
      VIA/WonderMedia VT8500/WM85xx SoCs.  Add platform dependencies to the
      VIA_RHINE config symbol, to avoid asking the user about it when
      configuring a kernel without PCI or VT8500/WM85xx support.
      Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
      Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0932969e
    • Po Liu's avatar
      net:enetc: bug fix for qos sfi operate space after freed · 571cf296
      Po Liu authored
      'Dan Carpenter' reported:
      This code frees "sfi" and then dereferences it on the next line:
      >                 kfree(sfi);
      >                 clear_bit(sfi->index, epsfp.psfp_sfi_bitmap);
      
      This "sfi->index" should be "index".
      Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarPo Liu <Po.Liu@nxp.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      571cf296
    • Jason Yan's avatar
      net: encx24j600: make encx24j600_hw_init() return void · 7f960633
      Jason Yan authored
      This function always return 0 now, we can make it return void to
      simplify the code. This fixes the following coccicheck warning:
      
      drivers/net/ethernet/microchip/encx24j600.c:609:5-8: Unneeded variable:
      "ret". Return "0" on line 653
      Signed-off-by: default avatarJason Yan <yanaijie@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7f960633
    • Jason Yan's avatar
      net: mlx4: remove unneeded variable "err" in mlx4_en_ethtool_add_mac_rule() · 5a7c4509
      Jason Yan authored
      Fix the following coccicheck warning:
      
      drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:1396:5-8: Unneeded
      variable: "err". Return "0" on line 1411
      Signed-off-by: default avatarJason Yan <yanaijie@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5a7c4509
    • Jason Yan's avatar
      net: tulip: de4x5: make PCI_signature() return void · 27ad2cd2
      Jason Yan authored
      This function always return 0 now, we can make it return void to
      simplify the code. This fixes the following coccicheck warning:
      
      drivers/net/ethernet/dec/tulip/de4x5.c:3908:11-17: Unneeded variable:
      "status". Return "0" on line 3912
      Signed-off-by: default avatarJason Yan <yanaijie@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      27ad2cd2
    • Jason Yan's avatar
      net: atheros: remove dead code in atl1c_resume() · f9a98f90
      Jason Yan authored
      This code has been marked dead for nearly 10 years. Remove it.
      Signed-off-by: default avatarJason Yan <yanaijie@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f9a98f90
    • Jason Yan's avatar
      b43: remove dead function b43_rssinoise_postprocess() · 49d4c392
      Jason Yan authored
      This function is dead for more than 10 years. Remove it.
      Signed-off-by: default avatarJason Yan <yanaijie@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      49d4c392
    • Zheng Zengkai's avatar
      net: phy: Make iproc_mdio_resume static · 31e2d067
      Zheng Zengkai authored
      Fix sparse warnings:
      
      drivers/net/phy/mdio-bcm-iproc.c:182:5: warning:
       symbol 'iproc_mdio_resume' was not declared. Should it be static?
      Reported-by: default avatarHulk Robot <hulkci@huawei.com>
      Signed-off-by: default avatarZheng Zengkai <zhengzengkai@huawei.com>
      Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      31e2d067
    • David S. Miller's avatar
      Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net · 3793faad
      David S. Miller authored
      Conflicts were all overlapping changes.
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      3793faad
    • Linus Torvalds's avatar
      Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net · a811c1fa
      Linus Torvalds authored
      Pull networking fixes from David Miller:
      
       1) Fix reference count leaks in various parts of batman-adv, from Xiyu
          Yang.
      
       2) Update NAT checksum even when it is zero, from Guillaume Nault.
      
       3) sk_psock reference count leak in tls code, also from Xiyu Yang.
      
       4) Sanity check TCA_FQ_CODEL_DROP_BATCH_SIZE netlink attribute in
          fq_codel, from Eric Dumazet.
      
       5) Fix panic in choke_reset(), also from Eric Dumazet.
      
       6) Fix VLAN accel handling in bnxt_fix_features(), from Michael Chan.
      
       7) Disallow out of range quantum values in sch_sfq, from Eric Dumazet.
      
       8) Fix crash in x25_disconnect(), from Yue Haibing.
      
       9) Don't pass pointer to local variable back to the caller in
          nf_osf_hdr_ctx_init(), from Arnd Bergmann.
      
      10) Wireguard should use the ECN decap helper functions, from Toke
          Høiland-Jørgensen.
      
      11) Fix command entry leak in mlx5 driver, from Moshe Shemesh.
      
      12) Fix uninitialized variable access in mptcp's
          subflow_syn_recv_sock(), from Paolo Abeni.
      
      13) Fix unnecessary out-of-order ingress frame ordering in macsec, from
          Scott Dial.
      
      14) IPv6 needs to use a global serial number for dst validation just
          like ipv4, from David Ahern.
      
      15) Fix up PTP_1588_CLOCK deps, from Clay McClure.
      
      16) Missing NLM_F_MULTI flag in gtp driver netlink messages, from
          Yoshiyuki Kurauchi.
      
      17) Fix a regression in that dsa user port errors should not be fatal,
          from Florian Fainelli.
      
      18) Fix iomap leak in enetc driver, from Dejin Zheng.
      
      19) Fix use after free in lec_arp_clear_vccs(), from Cong Wang.
      
      20) Initialize protocol value earlier in neigh code paths when
          generating events, from Roman Mashak.
      
      21) netdev_update_features() must be called with RTNL mutex in macsec
          driver, from Antoine Tenart.
      
      22) Validate untrusted GSO packets even more strictly, from Willem de
          Bruijn.
      
      23) Wireguard decrypt worker needs a cond_resched(), from Jason
          Donenfeld.
      
      * git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net: (111 commits)
        net: flow_offload: skip hw stats check for FLOW_ACTION_HW_STATS_DONT_CARE
        MAINTAINERS: put DYNAMIC INTERRUPT MODERATION in proper order
        wireguard: send/receive: use explicit unlikely branch instead of implicit coalescing
        wireguard: selftests: initalize ipv6 members to NULL to squelch clang warning
        wireguard: send/receive: cond_resched() when processing worker ringbuffers
        wireguard: socket: remove errant restriction on looping to self
        wireguard: selftests: use normal kernel stack size on ppc64
        net: ethernet: ti: am65-cpsw-nuss: fix irqs type
        ionic: Use debugfs_create_bool() to export bool
        net: dsa: Do not leave DSA master with NULL netdev_ops
        net: dsa: remove duplicate assignment in dsa_slave_add_cls_matchall_mirred
        net: stricter validation of untrusted gso packets
        seg6: fix SRH processing to comply with RFC8754
        net: mscc: ocelot: ANA_AUTOAGE_AGE_PERIOD holds a value in seconds, not ms
        net: dsa: ocelot: the MAC table on Felix is twice as large
        net: dsa: sja1105: the PTP_CLK extts input reacts on both edges
        selftests: net: tcp_mmap: fix SO_RCVLOWAT setting
        net: hsr: fix incorrect type usage for protocol variable
        net: macsec: fix rtnl locking issue
        net: mvpp2: cls: Prevent buffer overflow in mvpp2_ethtool_cls_rule_del()
        ...
      a811c1fa
    • Pablo Neira Ayuso's avatar
      net: flow_offload: skip hw stats check for FLOW_ACTION_HW_STATS_DONT_CARE · 16f80360
      Pablo Neira Ayuso authored
      This patch adds FLOW_ACTION_HW_STATS_DONT_CARE which tells the driver
      that the frontend does not need counters, this hw stats type request
      never fails. The FLOW_ACTION_HW_STATS_DISABLED type explicitly requests
      the driver to disable the stats, however, if the driver cannot disable
      counters, it bails out.
      
      TCA_ACT_HW_STATS_* maintains the 1:1 mapping with FLOW_ACTION_HW_STATS_*
      except by disabled which is mapped to FLOW_ACTION_HW_STATS_DISABLED
      (this is 0 in tc). Add tc_act_hw_stats() to perform the mapping between
      TCA_ACT_HW_STATS_* and FLOW_ACTION_HW_STATS_*.
      
      Fixes: 319a1d19 ("flow_offload: check for basic action hw stats type")
      Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      16f80360
    • Lukas Bulwahn's avatar
      MAINTAINERS: put DYNAMIC INTERRUPT MODERATION in proper order · b0956956
      Lukas Bulwahn authored
      Commit 9b038086 ("docs: networking: convert DIM to RST") added a new
      file entry to DYNAMIC INTERRUPT MODERATION to the end, and not following
      alphabetical order.
      
      So, ./scripts/checkpatch.pl -f MAINTAINERS complains:
      
        WARNING: Misordered MAINTAINERS entry - list file patterns in alphabetic
        order
        #5966: FILE: MAINTAINERS:5966:
        +F:      lib/dim/
        +F:      Documentation/networking/net_dim.rst
      
      Reorder the file entries to keep MAINTAINERS nicely ordered.
      Signed-off-by: default avatarLukas Bulwahn <lukas.bulwahn@gmail.com>
      Acked-by: default avatarJakub Kicinski <kuba@kernel.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b0956956
    • David S. Miller's avatar
      Merge branch 'wireguard-fixes' · d3f3e6ac
      David S. Miller authored
      Jason A. Donenfeld says:
      
      ====================
      wireguard fixes for 5.7-rc5
      
      With Ubuntu and Debian having backported this into their kernels, we're
      finally seeing testing from places we hadn't seen prior, which is nice.
      With that comes more fixes:
      
      1) The CI for PPC64 was running with extremely small stacks for 64-bit,
         causing spurious crashes in surprising places.
      
      2) There's was an old leftover routing loop restriction, which no longer
         makes sense given the queueing architecture, and was causing problems
         for people who really did want nested routing.
      
      3) Not yielding our kthread on CONFIG_PREEMPT_VOLUNTARY systems caused
         RCU stalls and other issues, reported by Wang Jian, with the fix
         suggested by Sultan Alsawaf.
      
      4) Clang spewed warnings in a selftest for CONFIG_IPV6=n, reported by
         Arnd Bergmann.
      
      5) A complicated if statement was simplified to an assignment while also
         making the likely/unlikely hinting more correct and simple, and
         increasing readability, suggested by Sultan.
      
      Patches (2) and (3) have Fixes: lines and are probably good candidates
      for stable.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d3f3e6ac
    • Jason A. Donenfeld's avatar
      wireguard: send/receive: use explicit unlikely branch instead of implicit coalescing · 243f2148
      Jason A. Donenfeld authored
      It's very unlikely that send will become true. It's nearly always false
      between 0 and 120 seconds of a session, and in most cases becomes true
      only between 120 and 121 seconds before becoming false again. So,
      unlikely(send) is clearly the right option here.
      
      What happened before was that we had this complex boolean expression
      with multiple likely and unlikely clauses nested. Since this is
      evaluated left-to-right anyway, the whole thing got converted to
      unlikely. So, we can clean this up to better represent what's going on.
      
      The generated code is the same.
      Suggested-by: default avatarSultan Alsawaf <sultan@kerneltoast.com>
      Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      243f2148
    • Jason A. Donenfeld's avatar
      wireguard: selftests: initalize ipv6 members to NULL to squelch clang warning · 4fed818e
      Jason A. Donenfeld authored
      Without setting these to NULL, clang complains in certain
      configurations that have CONFIG_IPV6=n:
      
      In file included from drivers/net/wireguard/ratelimiter.c:223:
      drivers/net/wireguard/selftest/ratelimiter.c:173:34: error: variable 'skb6' is uninitialized when used here [-Werror,-Wuninitialized]
                      ret = timings_test(skb4, hdr4, skb6, hdr6, &test_count);
                                                     ^~~~
      drivers/net/wireguard/selftest/ratelimiter.c:123:29: note: initialize the variable 'skb6' to silence this warning
              struct sk_buff *skb4, *skb6;
                                         ^
                                          = NULL
      drivers/net/wireguard/selftest/ratelimiter.c:173:40: error: variable 'hdr6' is uninitialized when used here [-Werror,-Wuninitialized]
                      ret = timings_test(skb4, hdr4, skb6, hdr6, &test_count);
                                                           ^~~~
      drivers/net/wireguard/selftest/ratelimiter.c:125:22: note: initialize the variable 'hdr6' to silence this warning
              struct ipv6hdr *hdr6;
                                  ^
      
      We silence this warning by setting the variables to NULL as the warning
      suggests.
      Reported-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      4fed818e
    • Jason A. Donenfeld's avatar
      wireguard: send/receive: cond_resched() when processing worker ringbuffers · 4005f5c3
      Jason A. Donenfeld authored
      Users with pathological hardware reported CPU stalls on CONFIG_
      PREEMPT_VOLUNTARY=y, because the ringbuffers would stay full, meaning
      these workers would never terminate. That turned out not to be okay on
      systems without forced preemption, which Sultan observed. This commit
      adds a cond_resched() to the bottom of each loop iteration, so that
      these workers don't hog the core. Note that we don't need this on the
      napi poll worker, since that terminates after its budget is expended.
      Suggested-by: default avatarSultan Alsawaf <sultan@kerneltoast.com>
      Reported-by: default avatarWang Jian <larkwang@gmail.com>
      Fixes: e7096c13 ("net: WireGuard secure network tunnel")
      Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      4005f5c3
    • Jason A. Donenfeld's avatar
      wireguard: socket: remove errant restriction on looping to self · b673e24a
      Jason A. Donenfeld authored
      It's already possible to create two different interfaces and loop
      packets between them. This has always been possible with tunnels in the
      kernel, and isn't specific to wireguard. Therefore, the networking stack
      already needs to deal with that. At the very least, the packet winds up
      exceeding the MTU and is discarded at that point. So, since this is
      already something that happens, there's no need to forbid the not very
      exceptional case of routing a packet back to the same interface; this
      loop is no different than others, and we shouldn't special case it, but
      rather rely on generic handling of loops in general. This also makes it
      easier to do interesting things with wireguard such as onion routing.
      
      At the same time, we add a selftest for this, ensuring that both onion
      routing works and infinite routing loops do not crash the kernel. We
      also add a test case for wireguard interfaces nesting packets and
      sending traffic between each other, as well as the loop in this case
      too. We make sure to send some throughput-heavy traffic for this use
      case, to stress out any possible recursion issues with the locks around
      workqueues.
      
      Fixes: e7096c13 ("net: WireGuard secure network tunnel")
      Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b673e24a
    • Jason A. Donenfeld's avatar
      wireguard: selftests: use normal kernel stack size on ppc64 · a0fd7cc8
      Jason A. Donenfeld authored
      While at some point it might have made sense to be running these tests
      on ppc64 with 4k stacks, the kernel hasn't actually used 4k stacks on
      64-bit powerpc in a long time, and more interesting things that we test
      don't really work when we deviate from the default (16k). So, we stop
      pushing our luck in this commit, and return to the default instead of
      the minimum.
      Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a0fd7cc8
    • Grygorii Strashko's avatar
      net: ethernet: ti: am65-cpsw-nuss: fix irqs type · 6f5c27f9
      Grygorii Strashko authored
      The K3 INTA driver, which is source TX/RX IRQs for CPSW NUSS, defines IRQs
      triggering type as EDGE by default, but triggering type for CPSW NUSS TX/RX
      IRQs has to be LEVEL as the EDGE triggering type may cause unnecessary IRQs
      triggering and NAPI scheduling for empty queues. It was discovered with
      RT-kernel.
      
      Fix it by explicitly specifying CPSW NUSS TX/RX IRQ type as
      IRQF_TRIGGER_HIGH.
      
      Fixes: 93a76530 ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver")
      Signed-off-by: default avatarGrygorii Strashko <grygorii.strashko@ti.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6f5c27f9
    • Arnd Bergmann's avatar
      dsa: sja1105: dynamically allocate stats structure · ae1804de
      Arnd Bergmann authored
      The addition of sja1105_port_status_ether structure into the
      statistics causes the frame size to go over the warning limit:
      
      drivers/net/dsa/sja1105/sja1105_ethtool.c:421:6: error: stack frame size of 1104 bytes in function 'sja1105_get_ethtool_stats' [-Werror,-Wframe-larger-than=]
      
      Use dynamic allocation to avoid this.
      
      Fixes: 336aa67b ("net: dsa: sja1105: show more ethtool statistics counters for P/Q/R/S")
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ae1804de
    • Geert Uytterhoeven's avatar
      ionic: Use debugfs_create_bool() to export bool · 0735ccc9
      Geert Uytterhoeven authored
      Currently bool ionic_cq.done_color is exported using
      debugfs_create_u8(), which requires a cast, preventing further compiler
      checks.
      
      Fix this by switching to debugfs_create_bool(), and dropping the cast.
      Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
      Acked-by: default avatarShannon Nelson <snelson@pensando.io>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0735ccc9
    • David S. Miller's avatar
      Merge branch 'ethtool-master-slave' · 9e330bf4
      David S. Miller authored
      Oleksij Rempel says:
      
      ====================
      provide support for PHY master/slave configuration
      
      changes v6:
      - use NL_SET_ERR_MSG_ATTR in ethnl_update_linkmodes
      - add sanity checks in the ioctl interface
      - use bool for ethnl_validate_master_slave_cfg()
      
      changes v5:
      - set MASTER_SLAVE_CFG_UNSUPPORTED as default value
      - send a netlink error message on validation error
      - more code fixes
      
      changes v4:
      - rename port_mode to master_slave
      - move validation code to net/ethtool/linkmodes.c
      - add UNSUPPORTED state and avoid sending unsupported fields
      - more formatting and naming fixes
      - tja11xx: support only force mode
      - tja11xx: mark state as unsupported
      
      changes v3:
      - provide separate field for config and state.
      - make state rejected on set
      - add validation
      
      changes v2:
      - change names. Use MASTER_PREFERRED instead of MULTIPORT
      - configure master/slave only on request. Default configuration can be
        provided by PHY or eeprom
      - status and configuration to the user space.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9e330bf4
    • Oleksij Rempel's avatar
      net: phy: tja11xx: add support for master-slave configuration · b883e47b
      Oleksij Rempel authored
      The TJA11xx PHYs have a vendor specific Master/Slave configuration bit,
      which is not compatible with IEEE 803.2-2018 spec for 100Base-T1
      devices. So, provide a custom config_ange call back to solve this
      problem.
      Signed-off-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
      Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b883e47b
    • Oleksij Rempel's avatar
      ethtool: provide UAPI for PHY master/slave configuration. · bdbdac76
      Oleksij Rempel authored
      This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of
      auto-negotiation support, we needed to be able to configure the
      MASTER-SLAVE role of the port manually or from an application in user
      space.
      
      The same UAPI can be used for 1000BASE-T or MultiGBASE-T devices to
      force MASTER or SLAVE role. See IEEE 802.3-2018:
      22.2.4.3.7 MASTER-SLAVE control register (Register 9)
      22.2.4.3.8 MASTER-SLAVE status register (Register 10)
      40.5.2 MASTER-SLAVE configuration resolution
      45.2.1.185.1 MASTER-SLAVE config value (1.2100.14)
      45.2.7.10 MultiGBASE-T AN control 1 register (Register 7.32)
      
      The MASTER-SLAVE role affects the clock configuration:
      
      -------------------------------------------------------------------------------
      When the  PHY is configured as MASTER, the PMA Transmit function shall
      source TX_TCLK from a local clock source. When configured as SLAVE, the
      PMA Transmit function shall source TX_TCLK from the clock recovered from
      data stream provided by MASTER.
      
      iMX6Q                     KSZ9031                XXX
      ------\                /-----------\        /------------\
            |                |           |        |            |
       MAC  |<----RGMII----->| PHY Slave |<------>| PHY Master |
            |<--- 125 MHz ---+-<------/  |        | \          |
      ------/                \-----------/        \------------/
                                                     ^
                                                      \-TX_TCLK
      
      -------------------------------------------------------------------------------
      
      Since some clock or link related issues are only reproducible in a
      specific MASTER-SLAVE-role, MAC and PHY configuration, it is beneficial
      to provide generic (not 100BASE-T1 specific) interface to the user space
      for configuration flexibility and trouble shooting.
      Signed-off-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
      Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      bdbdac76
    • David S. Miller's avatar
      Merge branch 'chcr-next' · 3d59a583
      David S. Miller authored
      Devulapally Shiva Krishna says:
      
      ====================
      Crypto/chcr: Fix issues regarding algorithm implementation in driver
      
      The following series of patches fixes the issues which came during
      self-tests with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS enabled.
      
      Patch 1: Fixes gcm(aes) hang issue and rfc4106-gcm encryption issue.
      Patch 2: Fixes ctr, cbc, xts and rfc3686-ctr extra test failures.
      Patch 3: Fixes ccm(aes) extra test failures.
      Patch 4: Added support for 48 byte-key_len in aes_xts.
      Patch 5: fix for hmac(sha) extra test failure.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      3d59a583
    • Devulapally Shiva Krishna's avatar
      Crypto/chcr: fix for hmac(sha) test fails · 02f58e5b
      Devulapally Shiva Krishna authored
      The hmac(sha) test fails for a zero length source text data.
      For hmac(sha) minimum length of the data must be of block-size.
      So fix this by including the data_len for the last block.
      Signed-off-by: default avatarAyush Sawal <ayush.sawal@chelsio.com>
      Signed-off-by: default avatarDevulapally Shiva Krishna <shiva@chelsio.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      02f58e5b
    • Devulapally Shiva Krishna's avatar
      Crypto/chcr: support for 48 byte key_len in aes-xts · ee91ac1b
      Devulapally Shiva Krishna authored
      Added support for 48 byte key length for aes-xts.
      Signed-off-by: default avatarAyush Sawal <ayush.sawal@chelsio.com>
      Signed-off-by: default avatarDevulapally Shiva Krishna <shiva@chelsio.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ee91ac1b
    • Devulapally Shiva Krishna's avatar
      Crypto/chcr: fix for ccm(aes) failed test · 10b0c75d
      Devulapally Shiva Krishna authored
      The ccm(aes) test fails when req->assoclen > ~240bytes.
      
      The problem is the value assigned to auth_offset is wrong.
      As auth_offset is unsigned char, it can take max value as 255.
      So fix it by making it unsigned int.
      Signed-off-by: default avatarAyush Sawal <ayush.sawal@chelsio.com>
      Signed-off-by: default avatarDevulapally Shiva Krishna <shiva@chelsio.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      10b0c75d
    • Devulapally Shiva Krishna's avatar
      Crypto/chcr: fix ctr, cbc, xts and rfc3686-ctr failed tests · 6b363a28
      Devulapally Shiva Krishna authored
      This solves the following issues observed during self test when
      CONFIG_CRYPTO_MANAGER_EXTRA_TESTS is enabled.
      
      1. Added fallback for cbc, ctr and rfc3686 if req->nbytes is zero
      and for xts added a fallback case if req->nbytes is not multiple of 16.
      
      2. In case of cbc-aes, solved wrong iv update. When
      chcr_cipher_fallback() is called, used req->info pointer instead of
      reqctx->iv.
      
      3. In cbc-aes decryption there was a wrong result. This occurs when
      chcr_cipher_fallback() is called from chcr_handle_cipher_resp().
      In the fallback function iv(req->info) used is wrongly updated.
      So use the initial iv for this case.
      
      4)In case of ctr-aes encryption observed wrong result. In adjust_ctr_overflow()
      there is condition which checks if ((bytes / AES_BLOCK_SIZE) > c),
      where c is the number of blocks which can be processed without iv overflow,
      but for the above bytes (req->nbytes < 32 , not a multiple of 16) this
      condition fails and the 2nd block is corrupted as it requires the rollover iv.
      So added a '=' condition in this to take care of this.
      
      5)In rfc3686-ctr there was wrong result observed. This occurs when
      chcr_cipher_fallback() is called from chcr_handle_cipher_resp().
      Here also copying initial_iv in init_iv pointer for handling the fallback
      case correctly.
      Signed-off-by: default avatarAyush Sawal <ayush.sawal@chelsio.com>
      Signed-off-by: default avatarDevulapally Shiva Krishna <shiva@chelsio.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6b363a28
    • Devulapally Shiva Krishna's avatar
      Crypto/chcr: fix gcm-aes and rfc4106-gcm failed tests · d91a3159
      Devulapally Shiva Krishna authored
      This patch fixes two issues observed during self tests with
      CONFIG_CRYPTO_MANAGER_EXTRA_TESTS enabled.
      
      1. gcm(aes) hang issue , that happens during decryption.
      2. rfc4106-gcm-aes-chcr encryption unexpectedly succeeded.
      
      For gcm-aes decryption , authtag is not mapped due to
      sg_nents_for_len(upto size: assoclen+ cryptlen - authsize).
      So fix it by dma_mapping authtag.
      Also replaced sg_nents() to sg_nents_for_len() in case of aead_dma_unmap().
      
      For rfc4106-gcm-aes-chcr, used crypto_ipsec_check_assoclen() for checking
      the validity of assoclen.
      Signed-off-by: default avatarAyush Sawal <ayush.sawal@chelsio.com>
      Signed-off-by: default avatarDevulapally Shiva Krishna <shiva@chelsio.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d91a3159
    • David S. Miller's avatar
      Merge branch 'net-ipa-kill-endpoint-stop-workaround' · 33395f4a
      David S. Miller authored
      Alex Elder says:
      
      ====================
      net: ipa: kill endpoint stop workaround
      
      It turns out that a workaround that performs a small DMA operation
      between retried attempts to stop a GSI channel is not needed for any
      supported hardware.  The hardware quirk that required the extra DMA
      operation was fixed after IPA v3.1.  So this series gets rid of that
      workaround code, along with some other code that was only present to
      support it.
      
      NOTE:  This series depends on (and includes/duplicates) another patch
             that has already been committed in the net tree:
               713b6ebb net: ipa: fix a bug in ipa_endpoint_stop()
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      33395f4a
    • Alex Elder's avatar
      net: ipa: kill ipa_cmd_dma_task_32b_addr_add() · da1a782a
      Alex Elder authored
      A recent commit removed the only use of ipa_cmd_dma_task_32b_addr_add().
      This function (and the IPA immediate command it implements) is no
      longer needed, so get rid of it, along with all of the definitions
      associated with it.  Isolate its removal in a commit so it can be
      easily added back again if needed.
      Signed-off-by: default avatarAlex Elder <elder@linaro.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      da1a782a
    • Alex Elder's avatar
      net: ipa: kill ipa_endpoint_stop() · f30dcb7d
      Alex Elder authored
      The previous commit made ipa_endpoint_stop() be a trivial wrapper
      around gsi_channel_stop().  Since it no longer does anything
      special, just open-code it in the three places it's used.
      Signed-off-by: default avatarAlex Elder <elder@linaro.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f30dcb7d