1. 08 Mar, 2016 3 commits
    • Jean Delvare's avatar
      PCI/AER: Log actual error causes in aer_inject · 96b45ea5
      Jean Delvare authored
      The aer_inject driver is very quiet.  In most cases, it merely returns an
      error code to user-space, leaving the user with little clue about the
      actual reason for the failure.
      
      So, log error messages for 4 of the most frequent causes of failure:
      * Can't find the root port of the specified device.
      * Device doesn't support AER.
      * Root port doesn't support AER.
      * AER device not found.
      
      This gives the user a chance to understand why aer-inject failed.
      
      Based on a preliminary patch by Thomas Renninger.
      Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
      Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
      CC: Borislav Petkov <bp@suse.de>
      CC: Thomas Renninger <trenn@suse.de>
      96b45ea5
    • Jean Delvare's avatar
      PCI/AER: Use dev_warn() in aer_inject · 3bc11851
      Jean Delvare authored
      dev_warn() is better than printk(LOG_WARNING...) as it records which device
      the message relates to.  Also add a prefix "aer_inject:" to help
      differentiate real errors from injected errors.
      Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
      Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
      CC: Borislav Petkov <bp@suse.de>
      3bc11851
    • Jean Delvare's avatar
      PCI/AER: Fix aer_inject error codes · 20ac75e5
      Jean Delvare authored
      EPERM means "Operation not permitted", which doesn't reflect the lack of
      support for AER.  EPROTONOSUPPORT (Protocol not supported) is a better
      choice of error code if the device or its root port lack support for AER.
      
      Likewise, EINVAL means "Invalid argument", which is not suitable for cases
      where the AER error device is missing or unusable.  ENODEV and
      EPROTONOSUPPORT, respectively, fit better.
      Suggested-by: default avatarBorislav Petkov <bp@suse.de>
      Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
      Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
      CC: Borislav Petkov <bp@suse.de>
      CC: Prarit Bhargava <prarit@redhat.com>
      20ac75e5
  2. 04 Feb, 2016 3 commits
  3. 24 Jan, 2016 34 commits